Re: [PATCH] drm/amdgpu: move task_info to amdgpu_fpriv

2023-10-16 Thread Christian König
Am 17.10.23 um 00:15 schrieb Felix Kuehling: On 2023-10-16 13:08, Shashank Sharma wrote: This patch does the following: - moves vm->task_info struct to fpriv->task_info. - makes task_info allocation dynamic. - adds reference counting support for task_info structure. - adds some new helper functi

RE: [PATCH 4/5] drm/amdgpu: bypass RAS error reset in some conditions

2023-10-16 Thread Yang, Stanley
[AMD Official Use Only - General] The in_gpu_reset is set after reset error count and reset error status function call, so we can't use amdgpu_in_reset(), please check ras->in_recovery flag. Regards, Stanley From: Zhou1, Tao Sent: Friday, October 13, 2023 5:06 PM To: Zhang, Hawking ; amd-gfx@l

Re: [PATCH 1/2] drm/amdgpu : Add hive ras recovery check

2023-10-16 Thread Lazar, Lijo
On 10/17/2023 9:58 AM, Asad Kamal wrote: Add hive ras recovery check and propagate fatal error to aids of all sockets in the hive May be reword it as 'If one of the devices in the hive detects a fatal error, need to send ras recovery reset message to PMFW of all devices in the hive. For th

[PATCH 1/2] drm/amdgpu : Add hive ras recovery check

2023-10-16 Thread Asad Kamal
Add hive ras recovery check and propagate fatal error to aids of all sockets in the hive Signed-off-by: Asad Kamal Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 9 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.h | 1 + drivers/gpu/drm/amd

[PATCH 2/2] drm/amdgpu: update retry times for psp BL wait

2023-10-16 Thread Asad Kamal
Increase retry time for PSP BL wait, to compensate for longer time to set c2pmsg 35 ready bit during mode1 with RAS Signed-off-by: Asad Kamal Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/psp_v13_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 2/2] gpu/drm: Eliminate DRM_SCHED_PRIORITY_UNSET

2023-10-16 Thread Luben Tuikov
Eliminate DRM_SCHED_PRIORITY_UNSET, value of -2, whose only user was amdgpu. Furthermore, eliminate an index bug, in that when amdgpu boots, it calls drm_sched_entity_init() with DRM_SCHED_PRIORITY_UNSET, which uses it to index sched->sched_rq[]. Cc: Alex Deucher Cc: Christian König Signed-off-b

[PATCH 1/2] drm/amdgpu: Unset context priority is now invalid

2023-10-16 Thread Luben Tuikov
A context priority value of AMD_CTX_PRIORITY_UNSET is now invalid--instead of carrying it around and passing it to the Direct Rendering Manager--and it becomes AMD_CTX_PRIORITY_NORMAL in amdgpu_ctx_ioctl(), the gateway to context creation. Cc: Alex Deucher Cc: Christian König Signed-off-by: Lube

[PATCH v12 9/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7

2023-10-16 Thread Ma Jun
From: Evan Quan Fulfill the SMU13.0.7 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello Signed-off-by: Ma Jun -- v10->v11: - downgrade the prompt level on message failure(Lijo) --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 59 +++

[PATCH v12 8/9] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-10-16 Thread Ma Jun
From: Evan Quan Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello Signed-off-by: Ma Jun -- v10->v11: - downgrade the prompt level on message failure(Lijo) --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 + drivers/

[PATCH v12 7/9] drm/amd/pm: add flood detection for wbrf events

2023-10-16 Thread Ma Jun
From: Evan Quan To protect PMFW from being overloaded. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 31 +++ drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 7 + 2 files changed, 32 inser

[PATCH v12 6/9] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-10-16 Thread Ma Jun
From: Evan Quan With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7). Signed-off-by: Evan Quan R

[PATCH v12 5/9] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature

2023-10-16 Thread Ma Jun
From: Evan Quan Add those data structures to support Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello Signed-off-by: Ma Jun --- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 14 +- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h | 14

[PATCH v12 4/9] wifi: mac80211: Add support for WBRF features

2023-10-16 Thread Ma Jun
From: Evan Quan To support the WBRF mechanism, Wifi adapters utilized in the system must register the frequencies in use(or unregister those frequencies no longer used) via the dedicated calls. So that, other drivers responding to the frequencies can take proper actions to mitigate possible inter

[PATCH v12 3/9] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

2023-10-16 Thread Ma Jun
From: Evan Quan The newly added WBRF feature needs this interface for channel width calculation. Signed-off-by: Ma Jun Signed-off-by: Evan Quan -- v8->v9: - correct typo(Mhz -> MHz) (Johnson) --- include/net/cfg80211.h | 8 net/wireless/chan.c| 3 ++- 2 files changed, 10 inser

[PATCH v12 2/9] platform/x86/amd: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-10-16 Thread Ma Jun
Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate this, AMD has introduced a mechanism that devices can

[PATCH v12 1/9] Documentation/driver-api: Add document about WBRF mechanism

2023-10-16 Thread Ma Jun
Add documentation about AMD's Wifi band RFI mitigation (WBRF) mechanism explaining the theory and how it is used. Signed-off-by: Ma Jun --- Documentation/driver-api/wbrf.rst | 73 +++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/driver-api/wbrf.r

[PATCH v12 0/9] Enable Wifi RFI interference mitigation feature support

2023-10-16 Thread Ma Jun
Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate possible RFI interference we introuduced WBRF(Wifi Ban

[linux-next:master] BUILD REGRESSION 4d0515b235dec789578d135a5db586b25c5870cb

2023-10-16 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 4d0515b235dec789578d135a5db586b25c5870cb Add linux-next specific files for 20231016 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202309212121.cul1ptra-...@intel.com https

Re: [PATCH v4 4/4] drm/amd/amdgpu/vcn: Add RB decouple feature under SRIOV - P4

2023-10-16 Thread Leo Liu
The set looks good to me. The series is: Reviewed-by: Leo Liu On 2023-10-16 12:54, Bokun Zhang wrote: - In VCN 4 SRIOV code path, add code to enable RB decouple feature Signed-off-by: Bokun Zhang --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 71 +-- 1 file changed, 5

Re: [PATCH V2 2/2] drm/amdgpu: Permit PCIe transfer over links with XGMI

2023-10-16 Thread Felix Kuehling
On 2023-10-16 10:49, David Francis wrote: When the CPU is XGMI connected, the PCIe links should not be enumerated for topology purposes. However, PCIe transfer should still be a valid option for remote doorbells and MMIO mappings. Move the XGMI connection check out of the shared helper functio

Re: [PATCH V2 1/2] drm/amdgpu: Acquire ttm locks for dmaunmap

2023-10-16 Thread Felix Kuehling
On 2023-10-16 10:49, David Francis wrote: dmaunmap can call ttm_bo_validate, which expects the ttm dma_resv to be held. Acquire the locks in amdgpu_amdkfd_gpuvm_dmaunmap_mem. Because the dmaunmap step can now fail, the unmap ioctl UAPI needs two new arguments. n_dmaunmap_success tracks the nu

Re: [PATCH] drm/amdgpu: move task_info to amdgpu_fpriv

2023-10-16 Thread Felix Kuehling
On 2023-10-16 13:08, Shashank Sharma wrote: This patch does the following: - moves vm->task_info struct to fpriv->task_info. - makes task_info allocation dynamic. - adds reference counting support for task_info structure. - adds some new helper functions to find and put task_info. - adds respecti

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread Simon Ser
On Monday, October 16th, 2023 at 17:10, Ville Syrjälä wrote: > On Mon, Oct 16, 2023 at 05:52:22PM +0300, Pekka Paalanen wrote: > > > On Mon, 16 Oct 2023 15:42:16 +0200 > > André Almeida andrealm...@igalia.com wrote: > > > > > Hi Pekka, > > > > > > On 10/16/23 14:18, Pekka Paalanen wrote: > >

Re: [PATCH v4 1/4] drm/amd/amdgpu/vcn: Add RB decouple feature under SRIOV - P1

2023-10-16 Thread Zhang, Bokun
[AMD Official Use Only - General] Hey Chris, Yes, we use bitfield as flags to control certain features. From: Christian König Sent: Monday, October 16, 2023 1:58 PM To: Zhang, Bokun ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v4 1/4] drm/amd/amdgpu/v

[PATCH] drm/amdgpu: update to the latest GC 11.5 headers

2023-10-16 Thread Alex Deucher
Add some additional bitfields. Signed-off-by: Alex Deucher --- .../include/asic_reg/gc/gc_11_5_0_sh_mask.h | 48 +++ 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/drm/amd/include/asic_reg/gc/gc_11_5_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/gc/gc_11_5_0_s

Re: [PATCH v4 1/4] drm/amd/amdgpu/vcn: Add RB decouple feature under SRIOV - P1

2023-10-16 Thread Christian König
Am 16.10.23 um 18:52 schrieb Bokun Zhang: - Update SRIOV header with RB decouple flag Signed-off-by: Bokun Zhang --- drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h b/drivers/gpu

Re: [PATCH 2/2] drm/amd/display: Fix stack size issue on DML2

2023-10-16 Thread Alex Deucher
On Mon, Oct 16, 2023 at 10:27 AM Rodrigo Siqueira wrote: > > This commit is the last part of the fix that reduces the stack size in > the DML2 code. > > Cc: Stephen Rothwell > Cc: Alex Deucher > Cc: Roman Li > Cc: Chaitanya Dhere > Fixes: a2815ada8616 ("drm/amd/display: Introduce DML2") > Sign

[PATCH] drm/amdgpu: move task_info to amdgpu_fpriv

2023-10-16 Thread Shashank Sharma
This patch does the following: - moves vm->task_info struct to fpriv->task_info. - makes task_info allocation dynamic. - adds reference counting support for task_info structure. - adds some new helper functions to find and put task_info. - adds respective supporting changes for existing get_task_in

[PATCH v4 4/4] drm/amd/amdgpu/vcn: Add RB decouple feature under SRIOV - P4

2023-10-16 Thread Bokun Zhang
- In VCN 4 SRIOV code path, add code to enable RB decouple feature Signed-off-by: Bokun Zhang --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 71 +-- 1 file changed, 55 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/a

[PATCH v4 3/4] drm/amd/amdgpu/vcn: Add RB decouple feature under SRIOV - P3

2023-10-16 Thread Bokun Zhang
- Update VCN header for RB decouple feature - Add metadata struct, metadata will be placed after each RB Signed-off-by: Bokun Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 50 + 1 file changed, 43 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgp

[PATCH v4 2/4] drm/amd/amdgpu/vcn: Add RB decouple feature under SRIOV - P2

2023-10-16 Thread Bokun Zhang
- Add function to check if RB decouple is enabled under SRIOV Signed-off-by: Bokun Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.h index fabb83e9d9ae..8

[PATCH v4 1/4] drm/amd/amdgpu/vcn: Add RB decouple feature under SRIOV - P1

2023-10-16 Thread Bokun Zhang
- Update SRIOV header with RB decouple flag Signed-off-by: Bokun Zhang --- drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h index 104a5ad

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread Ville Syrjälä
On Mon, Oct 16, 2023 at 05:52:22PM +0300, Pekka Paalanen wrote: > On Mon, 16 Oct 2023 15:42:16 +0200 > André Almeida wrote: > > > Hi Pekka, > > > > On 10/16/23 14:18, Pekka Paalanen wrote: > > > On Mon, 16 Oct 2023 12:52:32 +0200 > > > André Almeida wrote: > > > > > >> Hi Michel, > > >> > > >

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread André Almeida
On 10/16/23 16:52, Pekka Paalanen wrote: On Mon, 16 Oct 2023 15:42:16 +0200 André Almeida wrote: Hi Pekka, On 10/16/23 14:18, Pekka Paalanen wrote: On Mon, 16 Oct 2023 12:52:32 +0200 André Almeida wrote: Hi Michel, On 8/17/23 12:37, Michel Dänzer wrote: On 8/15/23 20:57, André Almei

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread Pekka Paalanen
On Mon, 16 Oct 2023 15:42:16 +0200 André Almeida wrote: > Hi Pekka, > > On 10/16/23 14:18, Pekka Paalanen wrote: > > On Mon, 16 Oct 2023 12:52:32 +0200 > > André Almeida wrote: > > > >> Hi Michel, > >> > >> On 8/17/23 12:37, Michel Dänzer wrote: > >>> On 8/15/23 20:57, André Almeida wrote:

[PATCH V2 2/2] drm/amdgpu: Permit PCIe transfer over links with XGMI

2023-10-16 Thread David Francis
When the CPU is XGMI connected, the PCIe links should not be enumerated for topology purposes. However, PCIe transfer should still be a valid option for remote doorbells and MMIO mappings. Move the XGMI connection check out of the shared helper function amdgpu_device_is_peer_accessible and into th

[PATCH V2 1/2] drm/amdgpu: Acquire ttm locks for dmaunmap

2023-10-16 Thread David Francis
dmaunmap can call ttm_bo_validate, which expects the ttm dma_resv to be held. Acquire the locks in amdgpu_amdkfd_gpuvm_dmaunmap_mem. Because the dmaunmap step can now fail, the unmap ioctl UAPI needs two new arguments. n_dmaunmap_success tracks the number of devices that have completed dmaunmap.

[PATCH 2/2] drm/amd/display: Fix stack size issue on DML2

2023-10-16 Thread Rodrigo Siqueira
This commit is the last part of the fix that reduces the stack size in the DML2 code. Cc: Stephen Rothwell Cc: Alex Deucher Cc: Roman Li Cc: Chaitanya Dhere Fixes: a2815ada8616 ("drm/amd/display: Introduce DML2") Signed-off-by: Rodrigo Siqueira --- .../amd/display/dc/dml2/display_mode_core.c

[PATCH 0/2] Reduce stack size for DML2

2023-10-16 Thread Rodrigo Siqueira
Stephen discovers a stack size issue when compiling the latest amdgpu code with allmodconfig. This patchset addresses that issue by splitting a large function into two smaller parts. Thanks Siqueira Rodrigo Siqueira (2): drm/amd/display: Reduce stack size by splitting function drm/amd/display

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread André Almeida
Hi Pekka, On 10/16/23 14:18, Pekka Paalanen wrote: On Mon, 16 Oct 2023 12:52:32 +0200 André Almeida wrote: Hi Michel, On 8/17/23 12:37, Michel Dänzer wrote: On 8/15/23 20:57, André Almeida wrote: From: Pekka Paalanen Specify how the atomic state is maintained between userspace and kernel

RE: [PATCH v3] drm/amd/amdgpu/vcn: Add RB decouple feature under SRIOV

2023-10-16 Thread Liu, Leo
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Bokun Zhang > Sent: Friday, October 13, 2023 1:43 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Bokun > Subject: [PATCH v3] drm/amd/amdgpu/vcn: Add RB decouple feature under > SRIOV > > - Add code

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread Pekka Paalanen
On Mon, 16 Oct 2023 12:52:32 +0200 André Almeida wrote: > Hi Michel, > > On 8/17/23 12:37, Michel Dänzer wrote: > > On 8/15/23 20:57, André Almeida wrote: > >> From: Pekka Paalanen > >> > >> Specify how the atomic state is maintained between userspace and > >> kernel, plus the special case fo

Re: [PATCH v6 6/6] drm/doc: Define KMS atomic state set

2023-10-16 Thread André Almeida
Hi Michel, On 8/17/23 12:37, Michel Dänzer wrote: On 8/15/23 20:57, André Almeida wrote: From: Pekka Paalanen Specify how the atomic state is maintained between userspace and kernel, plus the special case for async flips. Signed-off-by: Pekka Paalanen Signed-off-by: André Almeida [...]

RE: [PATCH] drm/amdgpu/mes11: remove aggregated doorbell code

2023-10-16 Thread Xiao, Jack
[AMD Official Use Only - General] If aggregated doorbell will not be intended for user queue oversubscription, it's ok to remove it. Reviewed-by: Jack Xiao -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, October 13, 2023 9:53 PM To: Deucher, Alexander Cc: amd