Re: [PATCH v2 2/4] drm: Add drm_get_acpi_edid() helper

Hi Mario, kernel test robot noticed the following build errors: [auto build test ERROR on rafael-pm/linux-next] [also build test ERROR on rafael-pm/acpi-bus linus/master v6.8-rc2 next-20240131] [cannot apply to drm-misc/drm-misc-next rafael-pm/devprop] [If your patch is applied to the wrong git

RE: [PATCH] drm/amdgpu: remove asymmetrical irq disabling in vcn 4.0.5 suspend

[AMD Official Use Only - General] Acked-By: Saleemkhan Jamadar -Original Message- From: Zhang, Yifan Sent: Tuesday, January 30, 2024 6:45 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Gopalakrishnan, Veerabadhran (Veera) ; Jamadar, Saleemkhan ; Zhang, Yifan Subject:

RE: [PATCH] drm/amdgpu/pm: Use inline function for IP version check

[AMD Official Use Only - General] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Ma, Jun Sent: Wednesday, January 31, 2024 1:59 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Deucher, Alexander ; Wang, Yang(Kevin) ; Ma, Jun Subject: [PATCH]

[PATCH] drm/amdgpu/pm: Use inline function for IP version check

Use existing inline function for IP version check. Signed-off-by: Ma Jun --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c

[PATCH] drm/amd/display: Add NULL test for 'timing generator' in 'dcn21_set_pipe()'

In "u32 otg_inst = pipe_ctx->stream_res.tg->inst;" pipe_ctx->stream_res.tg could be NULL, it is relying on the caller to ensure the tg is not NULL. Fixes: 474ac4a875ca ("drm/amd/display: Implement some asic specific abm call backs.") Cc: Yongqiang Sun Cc: Anthony Koo Cc: Rodrigo Siqueira Cc:

[PATCH v2] drm/amd/display: Fix 'panel_cntl' could be null in 'dcn21_set_backlight_level()'

'panel_cntl' structure used to control the display panel could be null, dereferencing it could lead to a null pointer access. Fixes the below: drivers/gpu/drm/amd/amdgpu/../display/dc/hwss/dcn21/dcn21_hwseq.c:269 dcn21_set_backlight_level() error: we previously assumed 'panel_cntl' could be

RE: [PATCH 2/2] use PSP address query command

[AMD Official Use Only - General] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Tuesday, January 30, 2024 19:09 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH 2/2] use PSP address query command

Re: [PATCH v3 1/2] drm/buddy: Implement tracking clear page feature

Hi Matthew, On 12/21/2023 12:51 AM, Matthew Auld wrote: Hi, On 14/12/2023 13:42, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. On the otherhand,    DRM buddy marks

Re: [PATCH v3] drm/amdkfd: reserve the BO before validating it

On 2024-01-30 04:45, Lang Yu wrote: Fixes: 410f08516e0f ("drm/amdkfd: Move dma unmapping after TLB flush") v2: Avoid unmapping attachment twice when ERESTARTSYS. v3: Lock the BO before accessing ttm->sg to avoid race conditions.(Felix) [ 41.708711] WARNING: CPU: 0 PID: 1463 at

[PATCH 2/2] drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole (v2)

The TBA and TMA, along with an unused IB allocation, reside at low addresses in the VM address space. A stray VM fault which hits these pages must be serviced by making their page table entries invalid. The scheduler depends upon these pages being resident and fails, preventing a debugger from

[PATCH 1/2] drm/amdgpu: Reduce VA_RESERVED_BOTTOM to 64KB

The reservation is there to catch NULL pointer dereferences from the GPU. Reduce the size to 64KB to make sure that shared virtual address programming models can map all CPU-accessible virtual addresses for GPU access. This is also the default for CPU virtual address mappings as seen in

[PATCH v5 3/3] drm/buddy: Add defragmentation support

Add a function to support defragmentation. v5: Defragment the freelist order array beginning from min_order. Signed-off-by: Arunpravin Paneer Selvam Suggested-by: Matthew Auld --- drivers/gpu/drm/drm_buddy.c | 70 ++--- 1 file changed, 58 insertions(+), 12

[PATCH v5 2/3] drm/amdgpu: Enable clear page functionality

Add clear page support in vram memory region. v1:(Christian) - Dont handle clear page as TTM flag since when moving the BO back in from GTT again we don't need that. - Make a specialized version of amdgpu_fill_buffer() which only clears the VRAM areas which are not already cleared -

[PATCH v5 1/3] drm/buddy: Implement tracking clear page feature

- Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages size - If driver requests cleared memory we prefer cleared

[PATCH v2 3/4] drm/amd: Fetch the EDID from _DDC if available for eDP

Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Attempt to fetch this EDID if it exists and prefer it over the EDID that is provided by the panel. Signed-off-by: Mario Limonciello --- v2: * Use drm helper which will run more

[PATCH v2 4/4] drm/nouveau: Use drm_get_acpi_edid() helper

Rather than inventing a wrapper to acpi_video_get_edid() use the one provided by drm. This fixes two problems: 1. A memory leak that the memory provided by the ACPI call was never freed. 2. Validation of the BIOS provided blob. Signed-off-by: Mario Limonciello --- v1->v2: * New patch ---

[PATCH v2 2/4] drm: Add drm_get_acpi_edid() helper

Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Drivers can call this helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method. Signed-off-by: Mario Limonciello --- v1->v2: * Split code from previous amdgpu specific

[PATCH v2 1/4] ACPI: video: Handle fetching EDID that is longer than 256 bytes

The ACPI specification allows for an EDID to be up to 512 bytes but the _DDC EDID fetching code will only try up to 256 bytes. Modify the code to instead start at 512 bytes and work it's way down instead. As _DDC is now called up to 4 times on a machine debugging messages are noisier than

[PATCH v2 0/4] Add support for fetching EDID from ACPI _DDC

Some laptops ship an EDID in the BIOS encoded in the _DDC method that differs than the EDID directly on the laptop panel for $REASONS. This is the EDID that is used by the AMD Windows driver, and so sometimes different results are found in different operating systems. This series adds a new DRM

RE: [PATCH] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

[Public] > -Original Message- > From: amd-gfx On Behalf Of Qiang > Ma > Sent: Tuesday, January 30, 2024 4:35 AM > To: lexander.deuc...@amd.com; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; sunran...@208suo.com; > SHANMUGAM, SRINIVASAN > Cc: Qiang Ma ;

Re: [PATCH] drm/amdgpu: remove golden setting for gfx 11.5.0

[AMD Official Use Only - General] Acked-by: Alex Deucher From: Zhang, Yifan Sent: Monday, January 29, 2024 4:06 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Huang, Tim ; Yu, Lang ; Zhang, Yifan Subject: [PATCH]

Re: [PATCH 5/6] drm/i915: Update shared stats to use the new gem helper

On 30/01/2024 16:12, Alex Deucher wrote: Switch to using the new gem shared memory stats helper rather than hand rolling it. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- drivers/gpu/drm/i915/i915_drm_client.c | 2 +-

Re: [PATCH 2/6] drm: add drm_gem_object_is_shared_for_memory_stats() helper

On 30/01/2024 16:12, Alex Deucher wrote: Add a helper so that drm drivers can consistently report shared status via the fdinfo shared memory stats interface. In addition to handle count, show buffers as shared if they are shared via dma-buf as well (e.g., shared with v4l or some other

Re: [PATCH 3/6] drm: update drm_show_memory_stats() for dma-bufs

On 30/01/2024 16:12, Alex Deucher wrote: Show buffers as shared if they are shared via dma-buf as well (e.g., shared with v4l or some other subsystem). v2: switch to gem helper Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Reviewed-by: Rob Clark (v1)

Re: [PATCH 1/6] Documentation/gpu: Update documentation on drm-shared-*

On 30/01/2024 16:12, Alex Deucher wrote: Clarify the documentaiton in preparation for updated helpers which check the handle count as well as whether a dma-buf has been attached. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher

Re: [PATCH 2/6] drm: add drm_gem_object_is_shared_for_memory_stats() helper

On 1/30/24 11:12, Alex Deucher wrote: Add a helper so that drm drivers can consistently report shared status via the fdinfo shared memory stats interface. In addition to handle count, show buffers as shared if they are shared via dma-buf as well (e.g., shared with v4l or some other subsystem).

[PATCH 5/6] drm/i915: Update shared stats to use the new gem helper

Switch to using the new gem shared memory stats helper rather than hand rolling it. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- drivers/gpu/drm/i915/i915_drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 6/6] drm/xe: Update shared stats to use the new gem helper

Switch to using the new gem shared memory stats helper rather than hand rolling it. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- drivers/gpu/drm/xe/xe_drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 2/6] drm: add drm_gem_object_is_shared_for_memory_stats() helper

Add a helper so that drm drivers can consistently report shared status via the fdinfo shared memory stats interface. In addition to handle count, show buffers as shared if they are shared via dma-buf as well (e.g., shared with v4l or some other subsystem). Link:

[PATCH 1/6] Documentation/gpu: Update documentation on drm-shared-*

Clarify the documentaiton in preparation for updated helpers which check the handle count as well as whether a dma-buf has been attached. Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher --- Documentation/gpu/drm-usage-stats.rst |

[PATCH 3/6] drm: update drm_show_memory_stats() for dma-bufs

Show buffers as shared if they are shared via dma-buf as well (e.g., shared with v4l or some other subsystem). v2: switch to gem helper Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Reviewed-by: Rob Clark (v1) Signed-off-by: Alex Deucher Cc: Rob Clark

[PATCH 4/6] drm/amdgpu: add shared fdinfo stats

Add shared stats. Useful for seeing shared memory. v2: take dma-buf into account as well v3: use the new gem helper Link: https://lore.kernel.org/all/20231207180225.439482-1-alexander.deuc...@amd.com/ Signed-off-by: Alex Deucher Cc: Rob Clark --- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c |

[PATCH 0/6 V3] fdinfo shared stats

We had a request to add shared buffer stats to fdinfo for amdgpu and while implementing that, Christian mentioned that just looking at the GEM handle count doesn't take into account buffers shared with other subsystems like V4L or RDMA. Those subsystems don't use GEM, so it doesn't really matter

Re: [PATCH] drm/amd/display: Add NULL check for kzalloc in 'amdgpu_dm_atomic_commit_tail()'

[AMD Official Use Only - General] Prefer drm_err instead of DRM_ERR: https://elixir.bootlin.com/linux/latest/source/include/drm/drm_print.h#L468 With or without that fixed, patch is Reviewed-by: Aurabindo Pillai -- Regards, Jay From: SHANMUGAM, SRINIVASAN

[PATCH v3 9/9] drm/ci: uprev IGT and update testlist

Uprev IGT and add amd, v3d, vc4 and vgem specific tests to testlist. Have testlist.txt per driver and include a base testlist so that the driver specific tests will run only on those hardware. Signed-off-by: Vignesh Raman --- v3: - New patch in series to uprev IGT and update testlist. ---

[PATCH v3 6/9] drm/ci: rockchip: Rename existing job

For rockchip rk3288 and rk3399, the display driver is rockchip. Currently, in drm-ci for rockchip, only the display driver is tested. So rename the rockchip job to indicate that display driver is tested. Rename the name of xfail files for rockchip (rk3288 and rk3399), to include information about

[PATCH v3 8/9] drm/ci: uprev mesa version

zlib.net is not allowing tarball download anymore and results in below error in kernel+rootfs_arm32 container build, urllib.error.HTTPError: HTTP Error 403: Forbidden urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type Uprev mesa which includes a fix for this issue.

[PATCH v3 7/9] drm/ci: rockchip: Add job to test panfrost GPU driver

For rockchip rk3288 and rk3399, the GPU driver is panfrost. So add support in drm-ci to test panfrost driver for rockchip SOC and update xfails. Skip KMS tests for panfrost driver since it is not a not a KMS driver. Signed-off-by: Vignesh Raman --- v2: - Add panfrost GPU jobs for rockchip SOC

[PATCH v3 2/9] drm/ci: mediatek: Rename exisitng job

For mediatek mt8173 and mt8183, the display driver is mediatek. Currently, in drm-ci for mediatek, only the display driver is tested. So rename the mediatek job to indicate that display driver is tested. Rename the name of xfail files for mediatek (mt8173 and mt8183), to include information about

[PATCH v3 1/9] drm/ci: arm64.config: Enable CONFIG_DRM_ANALOGIX_ANX7625

Enable CONFIG_DRM_ANALOGIX_ANX7625 in the arm64 defconfig to get display driver probed on the mt8183-kukui-jacuzzi-juniper machine. arch/arm64/configs/defconfig has CONFIG_DRM_ANALOGIX_ANX7625=m, but drm-ci don't have initrd with modules, so add CONFIG_DRM_ANALOGIX_ANX7625=y in CI arm64 config.

[PATCH v3 5/9] drm/ci: meson: Add job to test panfrost GPU driver

For amlogic meson SOC the GPU driver is panfrost. So add support in drm-ci to test panfrost driver for amlogic meson SOC and update xfails. Skip KMS tests for panfrost driver since it is not a not a KMS driver. Signed-off-by: Vignesh Raman --- v2: - Add panfrost GPU jobs for amlogic meson SOC

[PATCH v3 4/9] drm/ci: meson: Rename exisitng job

For Amlogic Meson SOC the display driver is meson. Currently, in drm-ci for meson, only the display driver is tested. So rename the meson job to indicate that display driver is tested. Rename the name of xfail files for meson (g12b), to include information about the tested driver and update

[PATCH v3 3/9] drm/ci: mediatek: Add job to test panfrost and powervr GPU driver

For mediatek mt8173, the GPU driver is powervr and for mediatek mt8183, the GPU driver is panfrost. So add support in drm-ci to test panfrost and powervr GPU driver for mediatek SOCs and update xfails. Powervr driver was merged in linux kernel, but there's no mediatek support yet. So disable the

[PATCH v3 0/9] drm/ci: Add support for GPU and display testing

Some ARM SOCs have a separate display controller and GPU, each with different drivers. For mediatek mt8173, the GPU driver is powervr, and the display driver is mediatek. In the case of mediatek mt8183, the GPU driver is panfrost, and the display driver is mediatek. With rockchip rk3288/rk3399,

Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

Am 30.01.24 um 12:16 schrieb Daniel Vetter: On Tue, Jan 30, 2024 at 12:10:31PM +0100, Daniel Vetter wrote: On Mon, Jan 29, 2024 at 06:31:19PM +0800, Julia Zhang wrote: As vram objects don't have backing pages and thus can't implement drm_gem_object_funcs.get_sg_table callback. This removes drm

[PATCH] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

Problem: The computer in the bios initialization process, unplug the HDMI display, wait until the system up, plug in the HDMI display, did not enter the hotplug interrupt function, the display is not bright. Fix: After the above problem occurs, and the hpd ack interrupt bit is 1, the interrupt

[PATCH] drm/amdgpu: Clear the hotplug interrupt ack bit before hpd initialization

Problem: The computer in the bios initialization process, unplug the HDMI display, wait until the system up, plug in the HDMI display, did not enter the hotplug interrupt function, the display is not bright. Fix: After the above problem occurs, and the hpd ack interrupt bit is 1, the interrupt

[PATCH] drm/amdgpu: remove asymmetrical irq disabling in vcn 4.0.5 suspend

There is no irq enabled in vcn 4.0.5 resume, causing wrong amdgpu_irq_src status. Beside, current set function callbacks are empty with no real effect. Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 17 - drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 19

Re: [PATCH v3] drm/amdgpu: Fix missing error code in 'gmc_v6/7/8/9_0_hw_init()'

Am 30.01.24 um 11:19 schrieb Srinivasan Shanmugam: Return 0 for success scenairos in 'gmc_v6/7/8/9_0_hw_init()' Fixes the below: drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:920 gmc_v6_0_hw_init() warn: missing error code? 'r' drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:1104 gmc_v7_0_hw_init() warn:

RE: [PATCH] drm/amdgpu: Need to resume ras during gpu reset for gfx v9_4_3 sriov

[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of YiPeng Chai Sent: Tuesday, January 30, 2024 20:10 To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Zhou1, Tao ; Chai, Thomas ; Yang, Stanley ; Chai,

[PATCH] drm/amdgpu: Need to resume ras during gpu reset for gfx v9_4_3 sriov

Need to resume ras during gpu reset for gfx v9_4_3 sriov Signed-off-by: YiPeng Chai --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index

Flaky tests for amdgpu

Hi Maintainers, There are some flaky tests reported for amdgpu driver testing in drm-ci. # Board Name: hp-11A-G6-EE-grunt # IGT Version: 1.28-gb0cc8160e # Linux Version: 6.7.0-rc3 Pipeline url: https://gitlab.freedesktop.org/vigneshraman/linux/-/jobs/54373774 # Reported by deqp-runner

Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

On Tue, Jan 30, 2024 at 12:10:31PM +0100, Daniel Vetter wrote: > On Mon, Jan 29, 2024 at 06:31:19PM +0800, Julia Zhang wrote: > > As vram objects don't have backing pages and thus can't implement > > drm_gem_object_funcs.get_sg_table callback. This removes drm dma-buf > > callbacks in

Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

On Mon, Jan 29, 2024 at 06:31:19PM +0800, Julia Zhang wrote: > As vram objects don't have backing pages and thus can't implement > drm_gem_object_funcs.get_sg_table callback. This removes drm dma-buf > callbacks in virtgpu_gem_map_dma_buf()/virtgpu_gem_unmap_dma_buf() > and implement virtgpu

[PATCH 2/2] use PSP address query command

Get UMC physical address from PSP in RAS error address coversion. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/umc_v12_0.c | 46 ++ 1 file changed, 39 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v12_0.c

[PATCH 1/2] add PSP RAS address query command

Convert mca address to physical address or vice versa via RAS TA. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 25 + drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 3 +++ drivers/gpu/drm/amd/amdgpu/ta_ras_if.h | 36 + 3 files

Re: [PATCH v3 3/3] drm/amdgpu: Implement check_async_props for planes

> Do we really need this much flexibility, especially for the first driver > adding the first few additional properties? AFAIU we'd like to allow more props as well, e.g. cursor position…

Re: [PATCH v3 3/3] drm/amdgpu: Implement check_async_props for planes

On Sun, Jan 28, 2024 at 06:25:15PM -0300, André Almeida wrote: > AMD GPUs can do async flips with changes on more properties than just > the FB ID, so implement a custom check_async_props for AMD planes. > > Allow amdgpu to do async flips with overlay planes as well. > > Signed-off-by: André

[PATCH v3] drm/amdgpu: Fix missing error code in 'gmc_v6/7/8/9_0_hw_init()'

Return 0 for success scenairos in 'gmc_v6/7/8/9_0_hw_init()' Fixes the below: drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:920 gmc_v6_0_hw_init() warn: missing error code? 'r' drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:1104 gmc_v7_0_hw_init() warn: missing error code? 'r'

Re: [PATCH] drm/amd/display: Fix buffer overflow in 'get_host_router_total_dp_tunnel_bw()'

It looks good to me. Reviewed-by: Tom Chung On 1/30/2024 5:49 PM, SHANMUGAM, SRINIVASAN wrote: [AMD Official Use Only - General] *From:* SHANMUGAM, SRINIVASAN *Sent:* Tuesday, January 30, 2024 3:18 PM *To:* Siqueira, Rodrigo ; Pillai, Aurabindo *Cc:*

RE: [PATCH] drm/amd/display: Fix buffer overflow in 'get_host_router_total_dp_tunnel_bw()'

[AMD Official Use Only - General] From: SHANMUGAM, SRINIVASAN Sent: Tuesday, January 30, 2024 3:18 PM To: Siqueira, Rodrigo ; Pillai, Aurabindo Cc: Cyr, Aric ; amd-gfx@lists.freedesktop.org; Somasundaram, Meenakshikumar ; Huang, PeiChen (Pei-Chen) Subject: Re: [PATCH] drm/amd/display: Fix

Re: [PATCH] drm/amd/display: Fix buffer overflow in 'get_host_router_total_dp_tunnel_bw()'

+ Cc: Tom Chung On 1/29/2024 9:19 PM, Srinivasan Shanmugam wrote: The error message buffer overflow 'dc->links' 12 <= 12 suggests that the code is trying to access an element of the dc->links array that is beyond its bounds. In C, arrays are zero-indexed, so an array with 12 elements has valid

[PATCH v3] drm/amdkfd: reserve the BO before validating it

Fixes: 410f08516e0f ("drm/amdkfd: Move dma unmapping after TLB flush") v2: Avoid unmapping attachment twice when ERESTARTSYS. v3: Lock the BO before accessing ttm->sg to avoid race conditions.(Felix) [ 41.708711] WARNING: CPU: 0 PID: 1463 at drivers/gpu/drm/ttm/ttm_bo.c:846

Re: [PATCH] drm/amd/display: Add NULL check for kzalloc in 'amdgpu_dm_atomic_commit_tail()'

+ Cc: Tom Chung On 1/30/2024 2:11 PM, SHANMUGAM, SRINIVASAN wrote: Add a NULL check for the kzalloc call that allocates memory for dummy_updates in the amdgpu_dm_atomic_commit_tail function. Previously, if kzalloc failed to allocate memory and returned NULL, the code would attempt to use the

Re: [PATCH v2] drm/amdgpu: Fix missing error code in 'gmc_v6/7/8/9_0_hw_init()'

Am 30.01.24 um 09:27 schrieb Srinivasan Shanmugam: Return r for success scenairos in 'gmc_v6/7/8/9_0_hw_init()' Fixes the below: drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:920 gmc_v6_0_hw_init() warn: missing error code? 'r' drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:1104 gmc_v7_0_hw_init() warn:

RE: [PATCH 2/2] drm/amdgpu: reset gpu for pm abort case

[AMD Official Use Only - General] > From: Lazar, Lijo > Sent: Monday, January 29, 2024 2:48 PM > To: Liang, Prike ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Sharma, Deepak > > Subject: Re: [PATCH 2/2] drm/amdgpu: reset gpu for pm abort case > > > > On 1/26/2024 2:30 PM, Liang,

[PATCH] drm/amd/display: Add NULL check for kzalloc in 'amdgpu_dm_atomic_commit_tail()'

Add a NULL check for the kzalloc call that allocates memory for dummy_updates in the amdgpu_dm_atomic_commit_tail function. Previously, if kzalloc failed to allocate memory and returned NULL, the code would attempt to use the NULL pointer. The fix is to check if kzalloc returns NULL, and if so,

Re: Bug#1061449: linux-image-6.7-amd64: a boot message from amdgpu

Hi, [for this reply dropping the Debian bugreport to avoid later followups sending the ack to the mailinglist and adding noise] On Sun, Jan 28, 2024 at 11:44:59AM +0100, Linux regression tracking (Thorsten Leemhuis) wrote: > On 27.01.24 14:14, Salvatore Bonaccorso wrote: > > > > In Debian

[PATCH v2 0/1] drm/amd: Don't init MEC2 firmware when it fails to load

> Sorry to be pedantic; but I realized after I tried to apply this is > missing a S-o-b. Can you please add one? Of course, here you go. I left it off because I wasn't 100% sure about the intention of your previous change. David McFarland (1): drm/amd: Don't init MEC2 firmware when it fails

Re: drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole (v2)

Hi Felix, Thanks for reply. I'll record a backtrace when I'm free. Besides, here is a dmesg log from someone else in the issue discussion about this problem: https://projects.blender.org/attachments/ea7b7db5-ac16-479d-935b-9e1da33cd6f0 Tested using next-20240129 with this patch applied, and setup

Re: drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole (v2)

Hello Felix, I think you are right. This problem has existed for years(just look at the issue creation time in my link), and is thought caused by OpenGL-ROCM interop(that's why I think this patch might help). It is very easy to trigger this problem in blender(method is also mentioned in the

Re: drm/amdkfd: Relocate TBA/TMA to opposite side of VM hole (v2)

Hi, Seems rocm-opengl interop hang problem still exists[1]. Btw have you discovered into this problem? Best regards, Shengyu [1] https://projects.blender.org/blender/blender/issues/100353#issuecomment-599 在 2024/1/27 03:15, Shengyu Qu 写道: Hello Felix, This patch seems working on my

Re: [RFC PATCH 0/2] drm/amd/display: switch amdgpu_dm_connector to

On Fri, 26 Jan 2024, Mario Limonciello wrote: > On 1/26/2024 10:28, Melissa Wen wrote: >> Hi, >> >> I'm debugging a null-pointer dereference when running >> igt@kms_connector_force_edid and the way I found to solve the bug is to >> stop using raw edid handler in amdgpu_connector_funcs_force and

[PATCH v2 1/1] drm/amd: Don't init MEC2 firmware when it fails to load

The same calls are made directly above, but conditional on the firmware loading and validating successfully. Fixes: 9931b67690cf ("drm/amd: Load GFX10 microcode during early_init") Signed-off-by: David McFarland --- v2: signed off drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 -- 1 file changed,

RE: [PATCH] drm/amdgpu: remove imu start dependency on amdgpu_dpm.

[Public] Reviewed-by: Lang Yu >-Original Message- >From: amd-gfx On Behalf Of Yifan Zhang >Sent: Saturday, January 20, 2024 4:32 PM >To: amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Huang, Tim >; Feng, Kenneth ; Ma, Li >; Zhang, Yifan >Subject: [PATCH] drm/amdgpu: remove

RE: [PATCH v2] drm/amdgpu: drm/amdgpu: remove golden setting for gfx 11.5.0

[Public] Reviewed-by: Lang Yu >-Original Message- >From: Zhang, Yifan >Sent: Tuesday, January 30, 2024 1:20 PM >To: amd-gfx@lists.freedesktop.org >Cc: Deucher, Alexander ; Koenig, Christian >; Huang, Tim ; Yu, Lang >; Zhang, Yifan >Subject: [PATCH v2] drm/amdgpu: drm/amdgpu: remove

[PATCH v2] drm/amdgpu: Fix missing error code in 'gmc_v6/7/8/9_0_hw_init()'

Return r for success scenairos in 'gmc_v6/7/8/9_0_hw_init()' Fixes the below: drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:920 gmc_v6_0_hw_init() warn: missing error code? 'r' drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:1104 gmc_v7_0_hw_init() warn: missing error code? 'r'

[PATCH] drm/amdgpu: Fix missing error code in 'gmc_v6/7/8/9_0_hw_init()'

Return r for success scenairos in 'gmc_v6/7/8/9_0_hw_init()' Fixes the below: drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:920 gmc_v6_0_hw_init() warn: missing error code? 'r' drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c:1104 gmc_v7_0_hw_init() warn: missing error code? 'r'