Re: [PATCH] drm/amdgpu: refactoring the runtime pm mode detection code

2024-04-01 Thread Lazar, Lijo
On 3/29/2024 1:58 PM, Ma Jun wrote: > refactor the code of runtime pm mode detection to support > amdgpu_runtime_pm =2 and 1 two cases > > Signed-off-by: Ma Jun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 68 ++

RE: [PATCH] drm/amdgpu: refactoring the runtime pm mode detection code

2024-04-01 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] -Original Message- From: Ma, Jun Sent: Tuesday, April 2, 2024 11:44 AM To: Ma, Jun ; amd-gfx@lists.freedesktop.org Cc: Ma, Jun ; Feng, Kenneth ; Deucher, Alexander ; Wang, Yang(Kevin) ; Lazar, Lijo Subject: Re: [PATCH] drm/amdgpu: refactoring the

Re: [PATCH] drm/amdgpu: refactoring the runtime pm mode detection code

2024-04-01 Thread Ma, Jun
ping... Regards, Ma Jun On 3/29/2024 4:28 PM, Ma Jun wrote: > refactor the code of runtime pm mode detection to support > amdgpu_runtime_pm =2 and 1 two cases > > Signed-off-by: Ma Jun > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 68

Re: [PATCH v1] drm/amd/amdgpu: support MES command SET_HW_RESOURCE1 in sriov

2024-04-01 Thread JingWen Chen
Acked-by: Jingwen Chen On 2024/3/27 11:52, chongli2 wrote: > support MES command SET_HW_RESOURCE1 in sriov > > Signed-off-by: chongli2 > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h | 6 +++ > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 5 +++ >

RE: [PATCH] drm/amdgpu/mes11: print MES opcodes rather than numbers

2024-04-01 Thread Liu, Shaoyun
[AMD Official Use Only - General] Comments inline -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Saturday, March 30, 2024 10:01 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/mes11: print MES opcodes rather than numbers Makes

[PATCH 2/2] amd/amdgpu: improve VF recover time

2024-04-01 Thread Zhigang Luo
1. change AMDGPU_VF2PF_UPDATE_MAX_RETRY_LIMIT from 30 to 5. 2. set fatel error detected flag. Change-Id: If1e0357deffa4549d4e83e925c8d764f7f8c9f42 Signed-off-by: Zhigang Luo --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 1 +

[PATCH 1/2] amd/amdkfd: sync all devices to wait all processes being evicted

2024-04-01 Thread Zhigang Luo
If there are more than one device doing reset in parallel, the first device will call kfd_suspend_all_processes() to evict all processes on all devices, this call takes time to finish. other device will start reset and recover without waiting. if the process has not been evicted before doing

Re: Proposal to add CRIU support to DRM render nodes

2024-04-01 Thread Felix Kuehling
On 2024-04-01 12:56, Tvrtko Ursulin wrote: On 01/04/2024 17:37, Felix Kuehling wrote: On 2024-04-01 11:09, Tvrtko Ursulin wrote: On 28/03/2024 20:42, Felix Kuehling wrote: On 2024-03-28 12:03, Tvrtko Ursulin wrote: Hi Felix, I had one more thought while browsing around the amdgpu CRIU

Re: Proposal to add CRIU support to DRM render nodes

2024-04-01 Thread Tvrtko Ursulin
On 01/04/2024 17:37, Felix Kuehling wrote: On 2024-04-01 11:09, Tvrtko Ursulin wrote: On 28/03/2024 20:42, Felix Kuehling wrote: On 2024-03-28 12:03, Tvrtko Ursulin wrote: Hi Felix, I had one more thought while browsing around the amdgpu CRIU plugin. It appears it relies on the KFD

Re: Proposal to add CRIU support to DRM render nodes

2024-04-01 Thread Felix Kuehling
On 2024-04-01 11:09, Tvrtko Ursulin wrote: On 28/03/2024 20:42, Felix Kuehling wrote: On 2024-03-28 12:03, Tvrtko Ursulin wrote: Hi Felix, I had one more thought while browsing around the amdgpu CRIU plugin. It appears it relies on the KFD support being compiled in and /dev/kfd present,

Re: Proposal to add CRIU support to DRM render nodes

2024-04-01 Thread Tvrtko Ursulin
On 28/03/2024 20:42, Felix Kuehling wrote: On 2024-03-28 12:03, Tvrtko Ursulin wrote: Hi Felix, I had one more thought while browsing around the amdgpu CRIU plugin. It appears it relies on the KFD support being compiled in and /dev/kfd present, correct? AFAICT at least, it relies on that

Re: [PATCH 1/2] drm/amd/display: Introduce overlay cursor mode

2024-04-01 Thread Leo Li
On 2024-03-28 11:52, Harry Wentland wrote: On 2024-03-28 11:48, Robert Mader wrote: Hi, On 15.03.24 18:09, sunpeng...@amd.com wrote: From: Leo Li [Why] DCN is the display hardware for amdgpu. DRM planes are backed by DCN hardware pipes, which carry pixel data from one end (memory), to

Re: [PATCH 30/43] drm/amd/display: Enable cur_rom_en even if cursor degamma is not enabled

2024-04-01 Thread Harry Wentland
On 2024-04-01 09:40, Melissa Wen wrote: > > > On 28/03/2024 16:50, roman...@amd.com wrote: >> From: Rodrigo Siqueira Where is the commit description. Why is this needed? What is this fixing? Like Melissa said, this might cause a regression. Harry >> >> Signed-off-by: Rodrigo Siqueira >>

[PATCH] drm/amd/display: Add missing parameter desc in dc_commit_streams

2024-04-01 Thread Srinivasan Shanmugam
This commit removes the lines that describe the 'streams' and 'stream_count' parameters and adds a line to describe the 'params' parameter, which was missing from the original comment block. Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2138: warning: Function

Re: [PATCH 30/43] drm/amd/display: Enable cur_rom_en even if cursor degamma is not enabled

2024-04-01 Thread Melissa Wen
On 28/03/2024 16:50, roman...@amd.com wrote: From: Rodrigo Siqueira Signed-off-by: Rodrigo Siqueira Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH 38/43] drm/amd/display: Fix MPCC DTN logging

2024-04-01 Thread Melissa Wen
On 28/03/2024 16:50, roman...@amd.com wrote: From: Eric Bernstein [Why] DTN only logs 'pipe_count' instances of MPCC. However in some cases there are different number of MPCC than DPP (pipe_count). [How] Add mpcc_count parameter to resource_pool and set it during pool construction and use

RE: [PATCH 00/43] DC Patches Apr 1, 2024

2024-04-01 Thread Wheeler, Daniel
[Public] Sorry about that, meant to respond to this one. Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on

RE: [PATCH 01/43] drm/amd/display: Fix compiler redefinition warnings for certain configs

2024-04-01 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: *

Re: [PATCH v2] drm/radeon/radeon_display: Decrease the size of allocated memory

2024-04-01 Thread Christian König
Am 30.03.24 um 17:34 schrieb Erick Archer: This is an effort to get rid of all multiplications from allocation functions in order to prevent integer overflows [1] [2]. In this case, the memory allocated to store RADEONFB_CONN_LIMIT pointers to "drm_connector" structures can be avoided. This is

Re: [PATCH] drm/amdgpu: Fix discovery initialization failure during pci rescan

2024-04-01 Thread Christian König
Am 01.04.24 um 12:18 schrieb Ma Jun: Waiting for system ready to fix the discovery initialization failure issue. This failure usually occurs when dGPU is removed and then rescanned via command line. It's caused by following two errors: [1] vram size is 0 [2] wrong binary signature

RE: [PATCH v2 1/4] drm/amdgpu: Set fatal errror detected flag earlier

2024-04-01 Thread Kamal, Asad
[AMD Official Use Only - General] Series is Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Thursday, March 28, 2024 8:06 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Wang, Yang(Kevin)

Re: [PATCH v2 2/4] drm/amd/pm: Add PMFW message and capability flags

2024-04-01 Thread Lazar, Lijo
On 4/1/2024 4:45 PM, Kamal, Asad wrote: > [AMD Official Use Only - General] > > -Original Message- > From: amd-gfx On Behalf Of Lijo Lazar > Sent: Thursday, March 28, 2024 8:06 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Deucher, Alexander > ; Wang, Yang(Kevin) >

[PATCH] drm/amdgpu: Process bif doorbell event

2024-04-01 Thread Hawking Zhang
When BACO exit is triggered by doorbell transaction, firmware will config bif to issue msi interrupt to indicate doorbell transaction. If bif ring is not enabled in such case, driver needs to ack the interrupt by clearing the interrupt status. Signed-off-by: Hawking Zhang ---

RE: [PATCH v2 2/4] drm/amd/pm: Add PMFW message and capability flags

2024-04-01 Thread Kamal, Asad
[AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Thursday, March 28, 2024 8:06 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Wang, Yang(Kevin) Subject: [PATCH v2 2/4] drm/amd/pm: Add PMFW message and

Re: [PATCH v9 1/3] drm/buddy: Implement tracking clear page feature

2024-04-01 Thread Paneer Selvam, Arunpravin
Hi Matthew, On 3/28/2024 10:18 PM, Matthew Auld wrote: On 28/03/2024 16:07, Paneer Selvam, Arunpravin wrote: Hi Matthew, On 3/26/2024 11:39 PM, Matthew Auld wrote: On 18/03/2024 21:40, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the

[PATCH] drm/amdgpu: Fix discovery initialization failure during pci rescan

2024-04-01 Thread Ma Jun
Waiting for system ready to fix the discovery initialization failure issue. This failure usually occurs when dGPU is removed and then rescanned via command line. It's caused by following two errors: [1] vram size is 0 [2] wrong binary signature Signed-off-by: Ma Jun ---

RE: [PATCH] drm/amdgpu: update check condition for XGMI ACA UE

2024-04-01 Thread Wang, Yang(Kevin)
[AMD Official Use Only - General] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Monday, April 1, 2024 3:50 PM To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: update check condition for XGMI ACA UE

[PATCH] drm/amdgpu: update check condition for XGMI ACA UE

2024-04-01 Thread Tao Zhou
Check more possibile ext error codes. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c index f4be524b0dc1..be1f4efa9ef6

RE: [PATCH] drm/amd/pm: update XGMI RAS UE criteria for sum v13.0.6

2024-04-01 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Monday, April 1, 2024 14:24 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amd/pm: update XGMI RAS UE criteria for sum

[PATCH] drm/amd/pm: update XGMI RAS UE criteria for sum v13.0.6

2024-04-01 Thread Tao Zhou
Add more possible ext error code. v2: still use ext error code instead of UC bit. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c