Re: [PATCH] drm/amdgpu/gfx11: properly handle regGRBM_GFX_CNTL in soft reset

2024-04-11 Thread Lazar, Lijo
On 4/8/2024 10:50 PM, Alex Deucher wrote: > Need to take the srbm_mutex and while we are here, use the > helper function soc21_grbm_select(); > > Signed-off-by: Alex Deucher Reviewed-by: Lijo Lazar Thanks, Lijo > --- > drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 15 +-- > 1 file

Re: [PATCH] Revert "drm/amd/display: fix USB-C flag update after enc10 feature init"

2024-04-11 Thread Alex Deucher
ping? On Fri, Mar 29, 2024 at 6:59 PM Alex Deucher wrote: > > This reverts commit b5abd7f983e14054593dc91d6df2aa5f8cc67652. > > This change breaks DSC on 4k monitors at 144Hz over USB-C. > > Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3254 > Signed-off-by: Alex Deucher > Cc:

Re: [PATCH] drm/amdgpu/mes11: print MES opcodes rather than numbers

2024-04-11 Thread Alex Deucher
Ping? On Mon, Apr 8, 2024 at 3:02 PM Alex Deucher wrote: > > Makes it easier to review the logs when there are MES > errors. > > v2: use dbg for emitted, add helpers for fetching strings > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 78

Re: [PATCH] drm/amdgpu/gfx11: properly handle regGRBM_GFX_CNTL in soft reset

2024-04-11 Thread Alex Deucher
ping? On Mon, Apr 8, 2024 at 1:57 PM Alex Deucher wrote: > > Need to take the srbm_mutex and while we are here, use the > helper function soc21_grbm_select(); > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 15 +-- > 1 file changed, 5 insertions(+),

RE: [PATCH] drm/amdgpu: add new aca smu callback func parse_error_code{}

2024-04-11 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Yang > Wang > Sent: Friday, April 12, 2024 10:54 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Wang, Yang(Kevin) > Subject: [PATCH] drm/amdgpu: add

[PATCH] drm/amdgpu: add new aca smu callback func parse_error_code{}

2024-04-11 Thread Yang Wang
add new aca smu callback parse_error_code{} to avoid specific asic check in amdgpu_aca.c file Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 23 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_aca.h | 1 + .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-04-11 Thread Dave Airlie
On Thu, 11 Apr 2024 at 17:32, Arnd Bergmann wrote: > > On Thu, Apr 11, 2024, at 09:15, Ard Biesheuvel wrote: > > On Thu, 11 Apr 2024 at 03:11, Samuel Holland > > wrote: > >> On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: > >> > Samuel Holland writes: > >> > >> >> The short-term fix would

Re: [PATCH] drm/amd/display: Enable ogam_ram for dcn32+dcn35+dcn351

2024-04-11 Thread Joshua Ashton
On 4/11/24 3:26 PM, Melissa Wen wrote: On 04/10, Joshua Ashton wrote: The comment here states "no OGAM in DPP since DCN1", yet that is not true. Testing on an RX 7900XTX (dcn32), it actually does exist in hardware and works fine. My best guess is the comment is confused with OGAM ROM for

Re: [PATCH] Revert "drm/amd/display: Enable cur_rom_en even if cursor degamma is not enabled"

2024-04-11 Thread Melissa Wen
On 04/11, Rodrigo Siqueira wrote: > This reverts commit 5aba567a2988400d4e01d44493c84bed92820d8d. > > The original patch introduces cursor gamma issue to multiple > Linux compositors. For this reason this commit reverts this change. Thanks for checking the issue. Reviewed-by: Melissa Wen > >

[PATCH] Revert "drm/amd/display: Enable cur_rom_en even if cursor degamma is not enabled"

2024-04-11 Thread Rodrigo Siqueira
This reverts commit 5aba567a2988400d4e01d44493c84bed92820d8d. The original patch introduces cursor gamma issue to multiple Linux compositors. For this reason this commit reverts this change. Cc: Melissa Wen Cc: Harry Wentland Signed-off-by: Rodrigo Siqueira ---

Re: [PATCH] drm/amdgpu: increase mes submission timeout

2024-04-11 Thread Deucher, Alexander
[AMD Official Use Only - General] Reviewed-by: Alex Deucher From: Kim, Jonathan Sent: Thursday, April 11, 2024 3:03 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Joshi, Mukul ; Kim, Jonathan ; Kim, Jonathan Subject: [PATCH] drm/amdgpu:

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-11 Thread Leo Li
On 2024-04-04 10:22, Marius Vlad wrote: On Thu, Apr 04, 2024 at 09:59:03AM -0400, Harry Wentland wrote: Hi all, On 2024-04-04 06:24, Pekka Paalanen wrote: On Wed, 3 Apr 2024 17:32:46 -0400 Leo Li wrote: On 2024-03-28 10:33, Pekka Paalanen wrote: On Fri, 15 Mar 2024 13:09:56 -0400

[linux-next:master] BUILD REGRESSION 4118d9533ff3a5d16efb476a0d00afceecd92cf5

2024-04-11 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 4118d9533ff3a5d16efb476a0d00afceecd92cf5 Add linux-next specific files for 20240411 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404120101.daqbazh3-...@intel.com Error

[PATCH] drm/amdgpu: increase mes submission timeout

2024-04-11 Thread Jonathan Kim
MES internally has a timeout allowance of 2 seconds. Increase driver timeout to 3 seconds to be safe. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c

Re: [PATCH] drm/amdgpu: validate the parameters of amdgpu_vm_bo_clear_mappings

2024-04-11 Thread Christian König
Am 11.04.24 um 17:44 schrieb Jann Horn: On Thu, Apr 11, 2024 at 12:25 PM Christian König wrote: Am 11.04.24 um 05:28 schrieb xinhui pan: Ensure there is no address overlapping. Reported-by: Vlad Stolyarov Signed-off-by: xinhui pan --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++

Re: [PATCH] drm/amd/display: Enable ogam_ram for dcn32+dcn35+dcn351

2024-04-11 Thread Melissa Wen
On 04/10, Joshua Ashton wrote: > The comment here states "no OGAM in DPP since DCN1", yet that is not > true. > > Testing on an RX 7900XTX (dcn32), it actually does exist in hardware and > works fine. > My best guess is the comment is confused with OGAM ROM for DPP, rather > than OGAM RAM. > > I

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-04-11 Thread Arnd Bergmann
On Thu, Apr 11, 2024, at 09:15, Ard Biesheuvel wrote: > On Thu, 11 Apr 2024 at 03:11, Samuel Holland > wrote: >> On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: >> > Samuel Holland writes: >> >> >> The short-term fix would be to drop the `select >> >> ARCH_HAS_KERNEL_FPU_SUPPORT` for >> >>

Re: [PATCH Review 1/1] drm/amdgpu: Support setting recover method

2024-04-11 Thread Christian König
Am 11.04.24 um 13:49 schrieb Christian König: Am 11.04.24 um 13:30 schrieb Yang, Stanley: [AMD Official Use Only - General] -Original Message- From: Christian König Sent: Thursday, April 11, 2024 7:17 PM To: Yang, Stanley ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH Review

Re: [PATCH Review 1/1] drm/amdgpu: Support setting recover method

2024-04-11 Thread Christian König
Am 11.04.24 um 13:30 schrieb Yang, Stanley: [AMD Official Use Only - General] -Original Message- From: Christian König Sent: Thursday, April 11, 2024 7:17 PM To: Yang, Stanley ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH Review 1/1] drm/amdgpu: Support setting recover method

RE: [PATCH Review 1/1] drm/amdgpu: Support setting recover method

2024-04-11 Thread Yang, Stanley
[AMD Official Use Only - General] > -Original Message- > From: Christian König > Sent: Thursday, April 11, 2024 7:17 PM > To: Yang, Stanley ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH Review 1/1] drm/amdgpu: Support setting recover method > > Am 11.04.24 um 13:11 schrieb

Re: [PATCH V2] drm/ttm: remove unused paramter

2024-04-11 Thread Christian König
Am 01.04.24 um 05:04 schrieb jesse.zh...@amd.com: From: Jesse Zhang remove the unsed the paramter in the function ttm_bo_bounce_temp_buffer and ttm_bo_add_move_fence. V2:rebase the patch on top of drm-misc-next (Christian) And pushed to drm-misc-next. Thanks, Christian. Signed-off-by:

Re: [PATCH Review 1/1] drm/amdgpu: Support setting recover method

2024-04-11 Thread Christian König
Am 11.04.24 um 13:11 schrieb Stanley.Yang: Don't modify amdgpu gpu recover get operation, add amdgpu gpu recover set operation to select reset method, only support mode1 and mode2 currently. Well I don't think setting this from userspace is valid. The reset method to use is determined by the

[PATCH Review 1/1] drm/amdgpu: Support setting recover method

2024-04-11 Thread Stanley . Yang
Don't modify amdgpu gpu recover get operation, add amdgpu gpu recover set operation to select reset method, only support mode1 and mode2 currently. Signed-off-by: Stanley.Yang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +

Re: [PATCH] drm/amdgpu: validate the parameters of amdgpu_vm_bo_clear_mappings

2024-04-11 Thread Christian König
Am 11.04.24 um 05:28 schrieb xinhui pan: Ensure there is no address overlapping. Reported-by: Vlad Stolyarov Signed-off-by: xinhui pan --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

Re: [PATCH] drm/amdgpu: set vm_update_mode=0 as default for NV32 in SRIOV case

2024-04-11 Thread Christian König
Am 28.03.24 um 00:34 schrieb Danijel Slivka: For asic with VF MMIO access protection avoid using CPU for VM table updates. CPU pagetable updates have issues with HDP flush as VF MMIO access protection blocks write to BIF_BX_DEV0_EPF0_VF0_HDP_MEM_COHERENCY_FLUSH_CNTL register during sriov

Re: [PATCH] drm/amdgpu: validate the parameters of amdgpu_vm_bo_clear_mappings

2024-04-11 Thread Christian König
Am 11.04.24 um 05:28 schrieb xinhui pan: Ensure there is no address overlapping. Reported-by: Vlad Stolyarov Signed-off-by: xinhui pan --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH v2] drm/amdkfd: make sure VM is ready for updating operations

2024-04-11 Thread Lang Yu
When page table BOs were evicted but not validated before updating page tables, VM is still in evicting state, amdgpu_vm_update_range returns -EBUSY and restore_process_worker runs into a dead loop. v2: Split the BO validation and page table update into two separate loops in

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-04-11 Thread Thiago Jung Bauermann
Hello, Samuel Holland writes: > Now that all previously-supported architectures select > ARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol instead > of the existing list of architectures. It can also take advantage of the > common kernel-mode FPU API and method of adjusting

[PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-11 Thread Jani Nikula
Surprisingly many places depend on debugfs.h to be included via drm_print.h. Fix them. Signed-off-by: Jani Nikula --- Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-04-11 Thread Samuel Holland
Hi Thiago, On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: > Samuel Holland writes: >> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: >>> >>> Unfortunately this patch causes build failures on arm with allyesconfig >>> and allmodconfig. Tested with next-20240410. > > > >> In both

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-11 Thread Andrzej Hajda
On 10.04.2024 16:14, Jani Nikula wrote: Surprisingly many places depend on debugfs.h to be included via drm_print.h. Fix them. Signed-off-by: Jani Nikula --- Reviewed-by: Andrzej Hajda Regards Andrzej Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc:

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-04-11 Thread Thiago Jung Bauermann
Hello Samuel, Thank you for the quick reply! Samuel Holland writes: > On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: >> >> Unfortunately this patch causes build failures on arm with allyesconfig >> and allmodconfig. Tested with next-20240410. > In both cases, the issue is that the

Re: [PATCH] drm/amd/display: Enable ogam_ram for dcn32+dcn35+dcn351

2024-04-11 Thread Ethan Lee
On Wed, Apr 10, 2024 at 6:13 PM Joshua Ashton wrote: > > The comment here states "no OGAM in DPP since DCN1", yet that is not > true. > > Testing on an RX 7900XTX (dcn32), it actually does exist in hardware and > works fine. > My best guess is the comment is confused with OGAM ROM for DPP, rather

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-04-11 Thread Samuel Holland
Hi Thiago, On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: > Samuel Holland writes: > >> Now that all previously-supported architectures select >> ARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol instead >> of the existing list of architectures. It can also take advantage of

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-04-11 Thread Thiago Jung Bauermann
Hello Samuel, Samuel Holland writes: > On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: >> Samuel Holland writes: >>> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: Unfortunately this patch causes build failures on arm with allyesconfig and allmodconfig. Tested with

Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT

2024-04-11 Thread Ard Biesheuvel
(cc Arnd) On Thu, 11 Apr 2024 at 03:11, Samuel Holland wrote: > > Hi Thiago, > > On 2024-04-10 8:02 PM, Thiago Jung Bauermann wrote: > > Samuel Holland writes: > >> On 2024-04-10 5:21 PM, Thiago Jung Bauermann wrote: > >>> > >>> Unfortunately this patch causes build failures on arm with