[PATCH] drm/amdgpu: Use driver mode reset for data poison handling

2024-04-15 Thread Hawking Zhang
mode-2 reset is the only reliable method that can get GC/SDMA back when poison is consumed. mmhub requires mode-1 reset. Signed-off-by: Hawking Zhang --- .../gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 22 +++ 1 file changed, 3 insertions(+), 19 deletions(-) diff --git

RE: [PATCH] drm/amdgpu: Use driver mode reset for data poison handling

2024-04-15 Thread Zhang, Hawking
[AMD Official Use Only - General] Please ignore this one, will send out a new one -Original Message- From: Zhou1, Tao Sent: Tuesday, April 16, 2024 01:08 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu: Use driver mode reset for

RE: [PATCH] drm/amdgpu: Use driver mode reset for data poison handling

2024-04-15 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Hawking Zhang > Sent: Tuesday, April 16, 2024 12:34 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao > Cc: Zhang, Hawking > Subject: [PATCH] drm/amdgpu: Use driver mode reset for data poison

[PATCH] drm/amdgpu: Use driver mode reset for data poison handling

2024-04-15 Thread Hawking Zhang
mode-2 reset is the only reliable method that can get GC/SDMA back when poison is consumed. mmhub requires mode-1 reset. Signed-off-by: Hawking Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] rock-dgb_defconfig: Update for Linux 6.7 with UBSAN

2024-04-15 Thread Alex Deucher
Acked-by: Alex Deucher On Mon, Apr 15, 2024 at 4:07 PM Felix Kuehling wrote: > > make rock-dbg_defconfig > make savedefconfig > cp defconfig arch/x86/config/rock-dbg_defconfig > > This also enables UBSAN, which can help catch some types of bugs at > compile time. > > Signed-off-by: Felix

RE: [PATCH] drm/amdgpu: replace tmz flag into buffer flag

2024-04-15 Thread Min, Frank
[AMD Official Use Only - General] Hi Alex, Sure, I will merge the fix and update the kerneldoc above each function. Best Regards, Frank -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Sunday, April 14, 2024 6:42 AM To: Min, Frank Cc: amd-gfx@lists.freedesktop.org;

RE: [PATCH v2] drm/amdkfd: make sure VM is ready for updating operations

2024-04-15 Thread Yu, Lang
[Public] ping >-Original Message- >From: Yu, Lang >Sent: Thursday, April 11, 2024 4:11 PM >To: amd-gfx@lists.freedesktop.org >Cc: Koenig, Christian ; Kuehling, Felix >; Yu, Lang >Subject: [PATCH v2] drm/amdkfd: make sure VM is ready for updating >operations > >When page table BOs were

Re: [PATCH] drm/amdkfd: fix NULL pointer dereference

2024-04-15 Thread Felix Kuehling
This patch does not apply to amd-staging-drm-next. This is against a DKMS branch and should be reviewed on our internal mailing list. However, I suspect that part of the problem is, that the DKMS branch has diverged quite a bit in this area, and is missing at least one patch from me that was

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-15 Thread Leo Li
On 2024-04-15 04:19, Pekka Paalanen wrote: On Fri, 12 Apr 2024 16:14:28 -0400 Leo Li wrote: On 2024-04-12 11:31, Alex Deucher wrote: On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen wrote: On Fri, 12 Apr 2024 10:28:52 -0400 Leo Li wrote: On 2024-04-12 04:03, Pekka Paalanen wrote:

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-15 Thread Philip Yang
On 2024-04-14 10:57, Arunpravin Paneer Selvam wrote: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS flag in the buffer's

Re: [PATCH 2/2] drm/amdgpu: IB test encode test package change for VCN5

2024-04-15 Thread Alex Deucher
On Mon, Apr 15, 2024 at 5:25 PM Sonny Jiang wrote: > > From: Sonny Jiang > > VCN5 session info package interface changed > > Signed-off-by: Sonny Jiang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[PATCH 2/2] drm/amdgpu: IB test encode test package change for VCN5

2024-04-15 Thread Sonny Jiang
From: Sonny Jiang VCN5 session info package interface changed Signed-off-by: Sonny Jiang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c index

[PATCH 1/2] drm/amdgpu: IB size alignment on VCN5

2024-04-15 Thread Sonny Jiang
From: Sonny Jiang VCN5 IB size alignment adjusted. Signed-off-by: Sonny Jiang --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH] rock-dgb_defconfig: Update for Linux 6.7 with UBSAN

2024-04-15 Thread Felix Kuehling
make rock-dbg_defconfig make savedefconfig cp defconfig arch/x86/config/rock-dbg_defconfig This also enables UBSAN, which can help catch some types of bugs at compile time. Signed-off-by: Felix Kuehling --- arch/x86/configs/rock-dbg_defconfig | 46 + 1 file changed,

Re: [PATCH 02/25] drm/amd/display: Add a function for checking tmds mode

2024-04-15 Thread Melissa Wen
On 10/04/2024 18:25, Rodrigo Siqueira wrote: From: Chris Park [Why] DVI is TMDS signal like HDMI but without audio. Current signal check does not correctly reflect DVI clock programming. [How] Define a new signal check for TMDS that includes DVI to HDMI TMDS programming. Reviewed-by:

[PATCH] drm/amdgpu: clear seq64 memory on free

2024-04-15 Thread Arunpravin Paneer Selvam
We should clear the memory on free. Otherwise, there is a chance that we will access the previous application data and this would leads to an abnormal behaviour in the current application. Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 6 +- 1 file

[linux-next:master] BUILD REGRESSION 6bd343537461b57f3efe5dfc5fc193a232dfef1e

2024-04-15 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 6bd343537461b57f3efe5dfc5fc193a232dfef1e Add linux-next specific files for 20240415 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404151720.ha4kzy01-...@intel.com https

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-15 Thread Paneer Selvam, Arunpravin
Hi Christian, On 4/15/2024 7:33 PM, Christian König wrote: Am 14.04.24 um 16:57 schrieb Arunpravin Paneer Selvam: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS

RE: [PATCH] drm/amdgpu: Change AID detection logic

2024-04-15 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Monday, April 15, 2024 00:43 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Kamal, Asad Subject: [PATCH] drm/amdgpu:

RE: [PATCH] drm/amdkfd: Enable SQ watchpoint for gfx10

2024-04-15 Thread Kim, Jonathan
[Public] > -Original Message- > From: Six, Lancelot > Sent: Friday, April 12, 2024 8:54 AM > To: amd-gfx@lists.freedesktop.org > Cc: Kim, Jonathan ; Six, Lancelot > > Subject: [PATCH] drm/amdkfd: Enable SQ watchpoint for gfx10 > > There are new control registers introduced in gfx10 used

Re: [PATCH v11 1/3] drm/buddy: Implement tracking clear page feature

2024-04-15 Thread Paneer Selvam, Arunpravin
Hi Christian, Could you please push these patches into drm branch. Thanks, Arun. On 4/15/2024 2:53 AM, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the

Re: [PATCH] drm/amd/display: Enable ogam_ram for dcn32+dcn35+dcn351

2024-04-15 Thread Harry Wentland
On 2024-04-15 11:27, Melissa Wen wrote: > On 04/12, Harry Wentland wrote: >> >> >> On 2024-04-12 16:22, Harry Wentland wrote: >>> >>> >>> On 2024-04-12 12:26, Melissa Wen wrote: On 04/12, Joshua Ashton wrote: > > > On 4/11/24 3:26 PM, Melissa Wen wrote: >> On 04/10, Joshua

Re: [PATCH] drm/amd/display: Enable ogam_ram for dcn32+dcn35+dcn351

2024-04-15 Thread Melissa Wen
On 04/12, Harry Wentland wrote: > > > On 2024-04-12 16:22, Harry Wentland wrote: > > > > > > On 2024-04-12 12:26, Melissa Wen wrote: > >> On 04/12, Joshua Ashton wrote: > >>> > >>> > >>> On 4/11/24 3:26 PM, Melissa Wen wrote: > On 04/10, Joshua Ashton wrote: > > The comment here

Re: [PATCH] drm/radeon: make -fstrict-flex-arrays=3 happy

2024-04-15 Thread Christian König
Am 15.04.24 um 15:38 schrieb Alex Deucher: The driver parses a union where the layout up through the first array is the same, however, the array has different sizes depending on the elements in the union. Be explicit to fix the UBSAN checker. Closes:

Re: Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-15 Thread Maxime Ripard
On Mon, 15 Apr 2024 16:09:22 +0300, Jani Nikula wrote: > On Wed, 10 Apr 2024, Jani Nikula wrote: > > Surprisingly many places depend on debugfs.h to be included via > > drm_print.h. Fix them. > > While all of this is trivial, merely adding some includes, please > > [ ... ] Acked-by: Maxime

Re: [PATCH] drm/amdgpu: Modify the contiguous flags behaviour

2024-04-15 Thread Christian König
Am 14.04.24 um 16:57 schrieb Arunpravin Paneer Selvam: Now we have two flags for contiguous VRAM buffer allocation. If the application request for AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS, it would set the ttm place TTM_PL_FLAG_CONTIGUOUS flag in the buffer's placement function. This patch will change

2024 X.Org Foundation Election Results

2024-04-15 Thread Ricardo Garcia
The Board of Directors election concluded on 08 April 2024. There were 81 Members of the X.Org Foundation eligible to vote, and 61 Members cast votes. This is a 75.3% turn out. In the election of the Directors to the Board of the X.Org Foundation, the results were that Erik Faye-Lund, Simon Ser,

Re: [PATCH] drm/amdgpu: Add missing space to DRM_WARN() message

2024-04-15 Thread Alex Deucher
On Mon, Apr 15, 2024 at 4:40 AM Thorsten Blum wrote: > > s/,please/, please/ > > Signed-off-by: Thorsten Blum Reviewed-by: Alex Deucher And applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH 0/2] drm/amdgpu/display: Make multi-plane configurations more flexible

2024-04-15 Thread Pekka Paalanen
On Fri, 12 Apr 2024 16:14:28 -0400 Leo Li wrote: > On 2024-04-12 11:31, Alex Deucher wrote: > > On Fri, Apr 12, 2024 at 11:08 AM Pekka Paalanen > > wrote: > >> > >> On Fri, 12 Apr 2024 10:28:52 -0400 > >> Leo Li wrote: > >> > >>> On 2024-04-12 04:03, Pekka Paalanen wrote: > On Thu,

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-15 Thread Jani Nikula
On Wed, 10 Apr 2024, Jani Nikula wrote: > Surprisingly many places depend on debugfs.h to be included via > drm_print.h. Fix them. While all of this is trivial, merely adding some includes, please consider acking the changes to your corner of the kernel. Thanks, Jani. > > Signed-off-by: Jani

[PATCH] drm/radeon: make -fstrict-flex-arrays=3 happy

2024-04-15 Thread Alex Deucher
The driver parses a union where the layout up through the first array is the same, however, the array has different sizes depending on the elements in the union. Be explicit to fix the UBSAN checker. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3323 Fixes: df8fc4e934c1 ("kbuild:

RE: [PATCH 00/25] DC Patches April 10, 2024

2024-04-15 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on the following systems: * Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U * MSI Gaming X Trio RX 6800 * Gigabyte Gaming OC RX 7900 XTX These systems were tested on the following display/connection types: *

Re: [PATCH 1/6] drm/amdgpu: Support contiguous VRAM allocation

2024-04-15 Thread Christian König
Am 12.04.24 um 22:12 schrieb Philip Yang: RDMA device with limited scatter-gather capability requires physical address contiguous VRAM buffer for RDMA peer direct access. Add a new KFD alloc memory flag and store as new GEM bo alloc flag. When pin this buffer object to export for RDMA

Re: [PATCH v2] drm/amdgpu: refactoring the runtime pm mode detection code

2024-04-15 Thread Lazar, Lijo
On 4/3/2024 8:27 AM, Ma Jun wrote: > refactor the code of runtime pm mode detection to support > amdgpu_runtime_pm =2 and 1 two cases > > Signed-off-by: Ma Jun > Reviewed-by: Yang Wang Reviewed-by: Lijo Lazar Thanks, Lijo > --- > v1->v2: > - Fix logic and output info (Lijo) > - Fix code

[PATCH] drm/amdgpu: Add missing space to DRM_WARN() message

2024-04-15 Thread Thorsten Blum
s/,please/, please/ Signed-off-by: Thorsten Blum --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 7753a2e64d41..3cba0e196ca8 100644