RE: [PATCH 2/2] drm/amdgpu: fix documentation errors in gmc v12.0

2024-05-14 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, May 15, 2024 00:44 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/2]

RE: [PATCH] drm/amdgpu: fix compiler 'side-effect' check issue for RAS_EVENT_LOG()

2024-05-14 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Wang, Yang(Kevin) Sent: Tuesday, May 14, 2024 08:03 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Kamal, Asad Subject: [PATCH] drm/amdgpu: fix

[PATCH v3] drm/amdkfd: Remove bo NULL check in gmc_v12_0_get_vm_pte() function

2024-05-14 Thread Sreekant Somasekharan
Remove bo NULL check in amdgpu/gmc_v12_0.c:gmc_v12_0_get_vm_pte() function to fix smatch warning: 'drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c:518 gmc_v12_0_get_vm_pte() warn: variable dereferenced before check 'bo' (see line 500)' Signed-off-by: Sreekant Somasekharan Suggested-by: Dan Carpenter

RE: [PATCH] drm/amdgpu: fix compiler 'side-effect' check issue for RAS_EVENT_LOG()

2024-05-14 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Ping... Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Tuesday, May 14, 2024 8:03 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Kamal, Asad Subject: [PATCH] drm/amdgpu: fix compiler

[PATCH v2] drm/amdkfd: Remove bo NULL check in gmc_v12_0_get_vm_pte() function

2024-05-14 Thread Sreekant Somasekharan
Remove bo NULL check in amdgpu/gmc_v12_0.c:gmc_v12_0_get_vm_pte() function to fix smatch warning: 'drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c:518 gmc_v12_0_get_vm_pte() warn: variable dereferenced before check 'bo' (see line 500)' Signed-off-by: Sreekant Somasekharan Suggested-by: Dan Carpenter

RE: [PATCH] drm/amdgpu: fix Kconfig for ISP v2

2024-05-14 Thread Nirujogi, Pratap
[AMD Official Use Only - AMD Internal Distribution Only] Thanks Alex! -Original Message- From: Deucher, Alexander Sent: Tuesday, May 14, 2024 5:28 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Nirujogi, Pratap Subject: [PATCH] drm/amdgpu: fix Kconfig for ISP v2 Add

Re: [PATCH] drm/amdgpu: fix Kconfig for ISP

2024-05-14 Thread Alex Deucher
Ignore this. Better, functional patch sent out. Alex On Tue, May 14, 2024 at 5:12 PM Alex Deucher wrote: > > Add new config option and set proper dependencies for ISP. > > Signed-off-by: Alex Deucher > Cc: Pratap Nirujogi > --- > drivers/gpu/drm/amd/amdgpu/Kconfig | 1 + >

[PATCH] drm/amdgpu: fix Kconfig for ISP v2

2024-05-14 Thread Alex Deucher
Add new config option and set proper dependencies for ISP. v2: add missed guards, drop separate Kconfig Signed-off-by: Alex Deucher Cc: Pratap Nirujogi --- drivers/gpu/drm/amd/amdgpu/Kconfig| 11 +++ drivers/gpu/drm/amd/amdgpu/Makefile | 2 ++

[PATCH] drm/amdgpu: fix Kconfig for ISP

2024-05-14 Thread Alex Deucher
Add new config option and set proper dependencies for ISP. Signed-off-by: Alex Deucher Cc: Pratap Nirujogi --- drivers/gpu/drm/amd/amdgpu/Kconfig | 1 + drivers/gpu/drm/amd/amdgpu/Makefile | 2 ++ drivers/gpu/drm/amd/isp/Kconfig | 17 + 3 files changed, 20 insertions(+)

RE: [PATCH] drm/amdgpu: Add documentation for AMD_IP_BLOCK_TYPE_ISP

2024-05-14 Thread Nirujogi, Pratap
[Public] Acked, thanks Alex. -Original Message- From: Deucher, Alexander Sent: Tuesday, May 14, 2024 3:23 PM To: amd-gfx@lists.freedesktop.org; Nirujogi, Pratap Cc: Stephen Rothwell Subject: RE: [PATCH] drm/amdgpu: Add documentation for AMD_IP_BLOCK_TYPE_ISP [Public] + Pratap >

RE: [PATCH] drm/amdgpu: Add documentation for AMD_IP_BLOCK_TYPE_ISP

2024-05-14 Thread Deucher, Alexander
[Public] + Pratap > -Original Message- > From: Deucher, Alexander > Sent: Tuesday, May 14, 2024 11:14 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Stephen Rothwell > > Subject: [PATCH] drm/amdgpu: Add documentation for > AMD_IP_BLOCK_TYPE_ISP > > Add missing

[PATCH 2/2] drm/amdgpu: fix documentation errors in gmc v12.0

2024-05-14 Thread Alex Deucher
Fix up parameter descriptions. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c index 34e751b9b7003..c12c96f5bbaae 100644 ---

[PATCH 1/2] drm/amdgpu: fix documentation errors in sdma v7.0

2024-05-14 Thread Alex Deucher
Fix up parameter descriptions. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c index

Re: [RFC 0/5] Discussion around eviction improvements

2024-05-14 Thread Christian König
Am 14.05.24 um 17:14 schrieb Tvrtko Ursulin: On 13/05/2024 14:49, Tvrtko Ursulin wrote: On 09/05/2024 13:40, Tvrtko Ursulin wrote: On 08/05/2024 19:09, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Last few days I was looking at the situation with VRAM over subscription, what happens

[PATCH] drm/amdgpu: Add documentation for AMD_IP_BLOCK_TYPE_ISP

2024-05-14 Thread Alex Deucher
Add missing documentation for the IP block. Fixes: a83048bfa402 ("drm/amd/amdgpu: Add ISP support to amdgpu_discovery") Reported-by: Stephen Rothwell Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/include/amd_shared.h | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [RFC 0/5] Discussion around eviction improvements

2024-05-14 Thread Tvrtko Ursulin
On 13/05/2024 14:49, Tvrtko Ursulin wrote: On 09/05/2024 13:40, Tvrtko Ursulin wrote: On 08/05/2024 19:09, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Last few days I was looking at the situation with VRAM over subscription, what happens versus what perhaps should happen. Browsing

[PATCH v3 1/2] drm/buddy: Fix the range bias clear memory allocation issue

2024-05-14 Thread Arunpravin Paneer Selvam
Problem statement: During the system boot time, an application request for the bulk volume of cleared range bias memory when the clear_avail is zero, we dont fallback into normal allocation method as we had an unnecessary clear_avail check which prevents the fallback method leads to fb allocation

[PATCH v3 2/2] drm/tests: Add a unit test for range bias allocation

2024-05-14 Thread Arunpravin Paneer Selvam
Allocate cleared blocks in the bias range when the DRM buddy's clear avail is zero. This will validate the bias range allocation in scenarios like system boot when no cleared blocks are available and exercise the fallback path too. The resulting blocks should always be dirty. v1:(Matthew) -

Re: [PATCH] drm/amdgpu: Check if NBIO funcs are NULL in amdgpu_device_baco_exit

2024-05-14 Thread Alex Deucher
Applied. Thanks! On Tue, May 14, 2024 at 3:27 AM Christian König wrote: > > Am 14.05.24 um 09:06 schrieb Friedrich Vock: > > The special case for VM passthrough doesn't check adev->nbio.funcs > > before dereferencing it. If GPUs that don't have an NBIO block are > > passed through, this leads

Re: [PATCH] drm/amdgpu/mes: use mc address for wptr in add queue packet

2024-05-14 Thread Alex Deucher
Acked-by: Alex Deucher On Tue, May 14, 2024 at 5:07 AM Min, Frank wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > From: Frank Min > > use mc address for wptr in add queue packet > > Signed-off-by: Frank Min > --- > drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 6 +- >

[PATCH v4 05/10] drm/amd/pm: Add xgmi plpd to SMU v13.0.6 pm_policy

2024-05-14 Thread Lijo Lazar
On SOCs with SMU v13.0.6, allow changing xgmi plpd policy through pm_policy sysfs interface. Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang --- v2, v3: No change v4: Use macro for XGMI policy type name drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 17 ++-

[PATCH v4 09/10] drm/amd/pm: Remove unused interface to set plpd

2024-05-14 Thread Lijo Lazar
Remove unused callback to set PLPD policy and its implementation from arcturus, aldebaran and SMUv13.0.6 SOCs. Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 6 --- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 22 ---

[PATCH v4 08/10] drm/amd/pm: Remove legacy interface for xgmi plpd

2024-05-14 Thread Lijo Lazar
Replace the legacy interface with amdgpu_dpm_set_pm_policy to set XGMI PLPD mode. Also, xgmi_plpd sysfs node is not used by any client. Remove that as well. Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang --- v2: No change v3: Rebase to remove device_attr_id__xgmi_plpd_policy

[PATCH v4 10/10] Documentation/amdgpu: Add PM policy documentation

2024-05-14 Thread Lijo Lazar
Add documentation about the newly added pm_policy node in sysfs. Signed-off-by: Lijo Lazar --- Documentation/gpu/amdgpu/thermal.rst | 6 drivers/gpu/drm/amd/pm/amdgpu_pm.c | 48 2 files changed, 54 insertions(+) diff --git

[PATCH v4 07/10] drm/amd/pm: Add xgmi plpd to arcturus pm_policy

2024-05-14 Thread Lijo Lazar
On arcturus, allow changing xgmi plpd policy through pm_policy sysfs interface. Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 ++-- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 42 +++ 2 files changed, 46

[PATCH v4 06/10] drm/amd/pm: Add xgmi plpd to aldebaran pm_policy

2024-05-14 Thread Lijo Lazar
On aldebaran, allow changing xgmi plpd policy through pm_policy sysfs interface. Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang --- .../drm/amd/pm/swsmu/smu13/aldebaran_ppt.c| 35 +++ 1 file changed, 35 insertions(+) diff --git

[PATCH v4 03/10] drm/amd/pm: Add support to select pstate policy

2024-05-14 Thread Lijo Lazar
Add support to select pstate policy in SOCs with SMUv13.0.6 Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang --- v2,v3: No change v4: Use macro for policy type name .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c| 2 + .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 71 +++

[PATCH v4 04/10] drm/amd/pm: Add xgmi plpd policy to pm_policy

2024-05-14 Thread Lijo Lazar
Add support to set XGMI PLPD policy levels through pm_policy sysfs node. Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang --- v2, v3: No change v4: Use a macro for XGMI PLPD policy type drivers/gpu/drm/amd/include/kgd_pp_interface.h | 1 + drivers/gpu/drm/amd/pm/amdgpu_pm.c |

[PATCH v4 02/10] drm/amd/pm: Update PMFW messages for SMUv13.0.6

2024-05-14 Thread Lijo Lazar
Add PMF message to select a Pstate policy in SOCs with SMU v13.0.6. Signed-off-by: Lijo Lazar Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_ppsmc.h | 3 ++- drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 ++- 2 files changed, 4

[PATCH v4 01/10] drm/amd/pm: Add support for DPM policies

2024-05-14 Thread Lijo Lazar
Add support to set/get information about different DPM policies. The support is only available on SOCs which use swsmu architecture. A DPM policy type may be defined with different levels. For example, a policy may be defined to select Pstate preference and then later a pstate preference may be

[PATCH v4 00/10] Add PM policy interfaces

2024-05-14 Thread Lijo Lazar
This series adds APIs to get the supported PM policies and also set them. A PM policy type is a predefined policy type supported by an SOC and each policy may define two or more levels to choose from. A user can select the appropriate level through amdgpu_dpm_set_pm_policy() or through sysfs node

Re: [PATCH] drm/amd/display: Drop pixel_clock_mhz

2024-05-14 Thread Chung, ChiaHsuan (Tom)
This patch looks good to me. Reviewed-by: Tom Chung On 5/9/2024 9:55 AM, Mario Limonciello wrote: The pixel_clock_mhz property is populated in amdgpu_dm when Freesync is setup, but it is not used anywhere in amdgpu_dm. Remove the dead code. Cc:chiahsuan.ch...@amd.com Signed-off-by: Mario

RE: [PATCH 1/8] drm/amdgpu: support imu for gc 12_0_0

2024-05-14 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Gao, Likun Sent: Tuesday, May 14, 2024 16:51 To: amd-gfx list Subject: [PATCH 1/8] drm/amdgpu: support imu for gc 12_0_0 [AMD

RE: [PATCH 3/3] drm/amdgpu: Use NPS ranges from discovery table

2024-05-14 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Tuesday, May 14, 2024 16:36 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Koenig, Christian ; Ma,

[PATCH] drm/amdgpu: add more device info to the devcoredump

2024-05-14 Thread Sunil Khatri
Adding more device information: a. PCI info b. VRAM and GTT info c. GDC config Also correct the print layout and section information for in devcoredump. Signed-off-by: Sunil Khatri --- .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 21 +-- 1 file changed, 19 insertions(+), 2

[PATCH 2/2] drm/amd/pm: check specific index for aldebaran

2024-05-14 Thread Jesse Zhang
To avoid warning problems, drop index and use PPSMC_MSG_GfxDriverReset instead of index for aldebaran. Signed-off-by: Jesse Zhang Suggested-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

[PATCH 1/2] drm/amd/pm: check specific index for smu13

2024-05-14 Thread Jesse Zhang
To avoid warning problems, drop index and use PPSMC_MSG_GfxDriverReset instead of index. Signed-off-by: Jesse Zhang Suggested-by: Lijo Lazar --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git

Re: [PATCH] drm/amdgpu: Use the slab allocator to reduce job allocation fragmentation

2024-05-14 Thread Christian König
Am 14.05.24 um 10:13 schrieb Liang, Prike: [AMD Official Use Only - AMD Internal Distribution Only] From: Koenig, Christian Sent: Friday, May 10, 2024 5:31 PM To: Liang, Prike ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: Use the slab allocator to

RE: [PATCH 2/2 v2] drm/amd/pm: check specific index for aldebaran

2024-05-14 Thread Zhang, Jesse(Jie)
[AMD Official Use Only - AMD Internal Distribution Only] Hi Lijo -Original Message- From: Lazar, Lijo Sent: Tuesday, May 14, 2024 4:19 PM To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Huang, Tim Subject: Re: [PATCH 2/2 v2]

[PATCH 8/8] drm/amdgpu: switch default mes to uni mes

2024-05-14 Thread Gao, Likun
[AMD Official Use Only - AMD Internal Distribution Only] From: Likun Gao Switch the default mes to uni mes for gfx v12. V2: remove uni_mes set for gfx v11. Signed-off-by: Likun Gao --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 -- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4

[PATCH 6/8] drm/amdgpu: enable gfxoff for gc v12.0.0

2024-05-14 Thread Gao, Likun
[AMD Official Use Only - AMD Internal Distribution Only] From: Likun Gao Enable GFXOFF for GC v12.0.0. Signed-off-by: Likun Gao Reviewed-by: Kenneth Feng --- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c

[PATCH 7/8] drm/amd/pm: add pp_dpm_dcefclk for smu 14.0.2/3

2024-05-14 Thread Gao, Likun
[AMD Official Use Only - AMD Internal Distribution Only] From: Kenneth Feng add pp_dpm_dcefclk for smu 14.0.2/3 Signed-off-by: Kenneth Feng Reviewed-by: Jack Gui --- .../drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 24 +++ 1 file changed, 24 insertions(+) diff --git

[PATCH 5/8] drm/amd/amdgpu: enable mmhub and athub cg on gc 12.0.0

2024-05-14 Thread Gao, Likun
[AMD Official Use Only - AMD Internal Distribution Only] From: Likun Gao Enable mmhub and athub cg on gc 12.0.0 Signed-off-by: Likun Gao Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/soc24.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH] drm/amdgpu/mes: use mc address for wptr in add queue packet

2024-05-14 Thread Min, Frank
[AMD Official Use Only - AMD Internal Distribution Only] From: Frank Min use mc address for wptr in add queue packet Signed-off-by: Frank Min --- drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH 4/8] drm/amdgpu: enable some cg feature for gc 12.0.0

2024-05-14 Thread Gao, Likun
[AMD Official Use Only - AMD Internal Distribution Only] From: Likun Gao Enable 3D cgcg, 3D cgls, sram fgcg, perfcounter mgcg, repeater fgcg for gc v12.0.0. Signed-off-by: Likun Gao Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/soc24.c | 8 +++- 1 file changed, 7

[PATCH 3/8] drm/amdgpu: enable gfx cgcg for gfx v12_0_0

2024-05-14 Thread Gao, Likun
[AMD Official Use Only - AMD Internal Distribution Only] From: Likun Gao Enable GFX CGCG and CGLS for gfx version 12.0.0. Signed-off-by: Likun Gao Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 1 + drivers/gpu/drm/amd/amdgpu/soc24.c | 3 ++- 2 files changed, 3

[PATCH 1/8] drm/amdgpu: support imu for gc 12_0_0

2024-05-14 Thread Gao, Likun
[AMD Official Use Only - AMD Internal Distribution Only] From: Likun Gao Support IMU for ASIC with GC 12.0.0 Drop some unused function. Signed-off-by: Likun Gao --- drivers/gpu/drm/amd/amdgpu/imu_v12_0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

FW: [PATCH 2/8] drm/amdgpu/jpeg5: enable power gating

2024-05-14 Thread Gao, Likun
[AMD Official Use Only - AMD Internal Distribution Only] From: Sonny Jiang Enable PG on JPEG5 Signed-off-by: Sonny Jiang Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/soc24.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc24.c

[PATCH 3/3] drm/amdgpu: Use NPS ranges from discovery table

2024-05-14 Thread Lijo Lazar
Add GMC API to fetch NPS range information from discovery table. Use NPS range information in GMC 9.4.3 SOCs when available, otherwise fallback to software method. Signed-off-by: Lijo Lazar Reviewed-by: Le Ma --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 92 +++

[PATCH 2/3] drm/amdgpu: Add nps info table to IP discovery

2024-05-14 Thread Lijo Lazar
Add support to fetch NPS info table in IP discovery table. Signed-off-by: Lijo Lazar Reviewed-by: Le Ma --- drivers/gpu/drm/amd/include/discovery.h | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include/discovery.h

[PATCH 1/3] drm/amdgpu: Fix memory range calculation

2024-05-14 Thread Lijo Lazar
Consider the 16M reserved region also before range calculation for GMC 9.4.3 SOCs. Signed-off-by: Lijo Lazar Acked-by: Christian König Reviewed-by: Le Ma Fixes: a433f1f59484 ("drm/amdgpu: Initialize memory ranges for GC 9.4.3") --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 1 file

Re: [PATCH 2/2 v2] drm/amd/pm: check specific index for aldebaran

2024-05-14 Thread Lazar, Lijo
On 5/14/2024 12:28 PM, Jesse Zhang wrote: > To avoid warning problems, drop index and > use PPSMC_MSG_GfxDriverReset instead of index for aldebaran. > > Signed-off-by: Jesse Zhang > Suggested-by: Lijo Lazar > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 13 +++-- > 1

RE: [PATCH] drm/amdgpu: add debug flag to enable RAS ACA driver.

2024-05-14 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Wang, Yang(Kevin) Sent: Tuesday, May 14, 2024 16:15 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao Subject: [PATCH] drm/amdgpu: add debug

[PATCH] drm/amdgpu: add debug flag to enable RAS ACA driver.

2024-05-14 Thread Yang Wang
Use debug_mask=0x10 (BIT.4) param to help enable RAS ACA driver. (RAS ACA is disabled by default.) Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 ++ 3 files changed, 9

RE: [PATCH] drm/amdgpu: Use the slab allocator to reduce job allocation fragmentation

2024-05-14 Thread Liang, Prike
[AMD Official Use Only - AMD Internal Distribution Only] > From: Koenig, Christian > Sent: Friday, May 10, 2024 5:31 PM > To: Liang, Prike ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH] drm/amdgpu: Use the slab allocator to reduce job > allocation fragmentation

Re: [PATCH] drm/amdgpu: Check if NBIO funcs are NULL in amdgpu_device_baco_exit

2024-05-14 Thread Christian König
Am 14.05.24 um 09:06 schrieb Friedrich Vock: The special case for VM passthrough doesn't check adev->nbio.funcs before dereferencing it. If GPUs that don't have an NBIO block are passed through, this leads to a NULL pointer dereference on startup. Signed-off-by: Friedrich Vock Acked-by:

Re: [PATCH 2/2] drm/amd/pm: check specific index for aldebaran

2024-05-14 Thread Lazar, Lijo
On 5/14/2024 12:37 PM, Wang, Yang(Kevin) wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > -Original Message- > From: amd-gfx On Behalf Of Lazar, Lijo > Sent: Tuesday, May 14, 2024 2:07 PM > To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org > Cc: Deucher,

RE: [PATCH 2/2] drm/amd/pm: check specific index for aldebaran

2024-05-14 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: amd-gfx On Behalf Of Lazar, Lijo Sent: Tuesday, May 14, 2024 2:07 PM To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Huang, Tim Subject: Re: [PATCH 2/2]

[PATCH] drm/amdgpu: Check if NBIO funcs are NULL in amdgpu_device_baco_exit

2024-05-14 Thread Friedrich Vock
The special case for VM passthrough doesn't check adev->nbio.funcs before dereferencing it. If GPUs that don't have an NBIO block are passed through, this leads to a NULL pointer dereference on startup. Signed-off-by: Friedrich Vock Fixes: 1bece222eab ("drm/amdgpu: Clear doorbell interrupt

[PATCH 2/2 v2] drm/amd/pm: check specific index for aldebaran

2024-05-14 Thread Jesse Zhang
To avoid warning problems, drop index and use PPSMC_MSG_GfxDriverReset instead of index for aldebaran. Signed-off-by: Jesse Zhang Suggested-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] drm/amdgpu/pm: Drop hard-code value of usTMax

2024-05-14 Thread Lazar, Lijo
On 5/14/2024 9:43 AM, Ma Jun wrote: > Drop hard-code value of nsTmax because we read this > value from fantable below. > > Signed-off-by: Ma Jun Reviewed-by: Lijo Lazar Thanks, Lijo > --- > drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c | 2 -- > 1 file changed, 2

Re: [PATCH v2] drm/amdgpu: Fix the null pointer dereference to ras_manager

2024-05-14 Thread Lazar, Lijo
On 5/14/2024 9:42 AM, Ma Jun wrote: > Check ras_manager before using it > > Signed-off-by: Ma Jun Reviewed-by: Lijo Lazar Thanks, Lijo > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git

[no subject]

2024-05-14 Thread Jesse Zhang
>From 3348a4bb465834b165de80dc42d11630ac5c6a83 Mon Sep 17 00:00:00 2001 From: Jesse Zhang Date: Tue, 14 May 2024 13:59:18 +0800 Subject: [PATCH 2/2 v2] drm/amd/pm: check specific index for aldebaran To avoid warning problems, drop index and use PPSMC_MSG_GfxDriverReset instead of index for

[PATCH 1/2 v2] drm/amd/pm: check specific index for smu13

2024-05-14 Thread Jesse Zhang
To avoid warning problems, drop index and use PPSMC_MSG_GfxDriverReset instead of index for smu13. Signed-off-by: Jesse Zhang Suggested-by: Lijo Lazar --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git

RE: [PATCH 2/2] drm/amd/pm: Use gpu_metrics_v1_6 for SMUv13.0.6

2024-05-14 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Kamal, Asad Sent: Tuesday, May 14, 2024 14:23 To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Zhang, Hawking ; Ma, Le ; Zhang, Morris ; Kamal,

[PATCH 2/2] drm/amd/pm: Use gpu_metrics_v1_6 for SMUv13.0.6

2024-05-14 Thread Asad Kamal
Use gpu_metrics_v1_6 for SMUv13.0.6 to fill gpu metric info Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git

[PATCH 1/2] drm/amd/pm: Add gpu_metrics_v1_6

2024-05-14 Thread Asad Kamal
Add new gpu_metrics_v1_6 to acquire accumulated throttler residencies Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../gpu/drm/amd/include/kgd_pp_interface.h| 89 +++ drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c| 3 + 2 files changed, 92 insertions(+) diff

Re: [PATCH 2/2] drm/amd/pm: check specific index for aldebaran

2024-05-14 Thread Lazar, Lijo
On 5/14/2024 11:34 AM, Jesse Zhang wrote: > To avoid warning problems, drop index and > use PPSMC_MSG_GfxDriverReset instead of index for aldebaran. > > Signed-off-by: Jesse Zhang > Suggested-by: Lijo Lazar > --- > drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 13 +++-- > 1

[PATCH 2/2] drm/amd/pm: check specific index for aldebaran

2024-05-14 Thread Jesse Zhang
To avoid warning problems, drop index and use PPSMC_MSG_GfxDriverReset instead of index for aldebaran. Signed-off-by: Jesse Zhang Suggested-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git

[PATCH 1/2] drm/amd/pm: check specific index for smu13

2024-05-14 Thread Jesse Zhang
To avoid warning problems, drop index and use PPSMC_MSG_GfxDriverReset instead of index for smu13. Signed-off-by: Jesse Zhang Suggested-by: Lijo Lazar --- .../gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git