Re: [PATCH v2] drm/amd/display: use correct scale for actual_brightness

Ping. On Tue, 4 Aug 2020, Alexander Monakov wrote: > Documentation for sysfs backlight level interface requires that > values in both 'brightness' and 'actual_brightness' files are > interpreted to be in range from 0 to the value given in the > 'max_brightness' file. >

Re: Non-deterministically boot into dark screen with `amdgpu`

Hi, you should Сс a specialized mailing list and a relevant maintainer, otherwise your email is likely to be ignored as LKML is an incredibly high-volume list. Adding amd-gfx and Alex Deucher. More thoughts below. On Sun, 9 Aug 2020, Ignat Insarov wrote: > Hello! > > This is an issue report. 

Re: [PATCH v2] drm/amd/display: use correct scale for actual_brightness

On Tue, 4 Aug 2020, Alexander Monakov wrote: > Documentation for sysfs backlight level interface requires that > values in both 'brightness' and 'actual_brightness' files are > interpreted to be in range from 0 to the value given in the > 'max_brightness' file. > > With amdg

[PATCH v2] drm/amd/display: use correct scale for actual_brightness

Kazlauskas Signed-off-by: Alexander Monakov --- v2: split convert_brightness to &_from_user and &_to_user (Nicholas) .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 81 +-- 1 file changed, 40 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu

Re: [PATCH] drm/amd/display: use correct scale for actual_brightness

mains 255 with this patch, so as far as userspace is concerned nothing is changed apart from value given by actual_brightness file. Alexander > > Not an expert on existing implementations to point out a specific one though. > > Regards, > Nicholas Kazlauskas > > On 2020-08-0

[PATCH] drm/amd/display: use correct scale for actual_brightness

internal backlight range. Extend the existing 'convert_brightness' function to handle conversion in both directions. Bug: https://bugzilla.kernel.org/show_bug.cgi?id=203905 Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1242 Cc: Alex Deucher Signed-off-by: Alexander Monakov --- .../gpu/drm

Re: [PATCH] Revert "drm/amd/display: disable dcn20 abm feature for bring up"

On Thu, 28 May 2020, Harry Wentland wrote: > On 2020-05-28 9:54 a.m., Alexander Monakov wrote: > > > > > > On Thu, 28 May 2020, Harry Wentland wrote: > > > >> This reverts commit 96cb7cf13d8530099c256c053648ad576588c387. > >> > >>

Re: [PATCH] Revert "drm/amd/display: disable dcn20 abm feature for bring up"

On Thu, 28 May 2020, Harry Wentland wrote: > This reverts commit 96cb7cf13d8530099c256c053648ad576588c387. > > This change was used for DCN2 bringup and is no longer desired. > In fact it breaks backlight on DCN2 systems. Reported-and-tested-by: Alexander Monakov Thanks. >

Re: Flaky brightness on Renoir

: > On Wed, May 27, 2020 at 6:30 PM Alexander Monakov wrote: > > > > Hey, > > > > note that the driver does not call dmcu_load_iram on Renoir, as > > dm_late_init has > > > > /* todo will enable for navi10 */ > > if (adev->asic_type <= CH

RE: Flaky brightness on Renoir

take a look at from dmcu_load_iram. > >>> There's a bugreport on the tracker from a person with the same > >>> laptop model as mine that says that the threshold may vary from boot to > >>> boot. > > > > Thanks, > > Anthony > > > >

Flaky brightness on Renoir

Hello, I have a laptop with the recent Renoir SoC. Screen brightness is controlled via the amdgpu driver. Unfortunately it doesn't work properly: brightness doesn't go below a certain threshold. In one experiment I've found the threshold to be about 95 (of 255), which is quite high. There's a