[PATCH 20/22] drm/amd/display: Query all entries in assignment table during updates.

2021-11-04 Thread Anson Jacob
-by: Anson Jacob Signed-off-by: Jimmy Kizito --- .../gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c index

[PATCH 21/22] drm/amd/display: Initialise encoder assignment when initialising dc_state.

2021-11-04 Thread Anson Jacob
assignments are invalid. [How] Initialise encoder assignment variables when creating new dc_state resource. Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Jimmy Kizito --- drivers/gpu/drm/amd/display/dc/core/dc.c | 5 + drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c

[PATCH 18/22] drm/amd/display: 3.2.161

2021-11-04 Thread Anson Jacob
From: Aric Cyr This version brings along following fixes: - Improvements to INBOX0 HW Lock - Add support for sending TPS3 pattern - Fix Coverity Issues - Fixes for DMUB - Fix RGB MPO underflow with multiple displays - WS fixes and code restructure Acked-by: Anson Jacob Signed-off-by: Aric Cyr

[PATCH 16/22] drm/amd/display: Add hpd pending flag to indicate detection of new hpd.

2021-11-04 Thread Anson Jacob
Acked-by: Anson Jacob Signed-off-by: Meenakshikumar Somasundaram --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +++--- .../drm/amd/display/dc/core/dc_link_dpia.c| 20 +-- drivers/gpu/drm/amd/display/dc/dc_link.h | 1 + 3 files changed, 14 insertions(+), 13 del

[PATCH 22/22] drm/amd/display: Wait for ACK for INBOX0 HW Lock

2021-11-04 Thread Anson Jacob
. Reviewed-by: Nicholas Kazlauskas Acked-by: Anson Jacob Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 37 +++-- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 2 + .../drm/amd/display/dc/dce/dmub_hw_lock_mgr.c | 3 ++ drivers/gpu/drm/amd/display/dmub

[PATCH 14/22] drm/amd/display: Add callbacks for DMUB HPD IRQ notifications

2021-11-04 Thread Anson Jacob
the HPD handler to also handle HPD IRQ (RX) since the logic is the same. Fixes: 00be4268d32c ("drm/amd/display: Support for DMUB HPD interrupt handling") Reviewed-by: Wayne Lin Reviewed-by: Jude Shih Acked-by: Anson Jacob Signed-off-by: Nicholas Kazlauskas --- .../gpu/drm/amd/display

[PATCH 19/22] drm/amd/display: To support sending TPS3 pattern when restoring link

2021-11-04 Thread Anson Jacob
From: Robin Chen [Why] Some panels require to use TPS3 pattern to wake up link in PSR mode. [How] To add TPS3 selection information in PSR settings command and pass to DMUB FW. Reviewed-by: Anthony Koo Acked-by: Anson Jacob Signed-off-by: Robin Chen --- drivers/gpu/drm/amd/display/dc/dce

[PATCH 17/22] drm/amd/display: Adjust code indentation

2021-11-04 Thread Anson Jacob
From: Charlene Liu Reviewed-by: Sung joon Kim Acked-by: Anson Jacob Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc

[PATCH 15/22] drm/amd/display: Fix Coverity Issues

2021-11-04 Thread Anson Jacob
From: Chris Park [Why] Coverity discovers holes in logic that needs to be addressed for improved code integrity. [How] Address issues found by coverity without changing the actual logic. Reviewed-by: Aric Cyr Acked-by: Anson Jacob Signed-off-by: Chris Park --- drivers/gpu/drm/amd/display

[PATCH 12/22] drm/amd/display: retain/release stream pointer in link enc table

2021-11-04 Thread Anson Jacob
it indicates if we want to reference the stream pointer or not. Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Sung Joon Kim --- drivers/gpu/drm/amd/display/dc/core/dc_link_enc_cfg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core

[PATCH 13/22] drm/amd/display: Don't lock connection_mutex for DMUB HPD

2021-11-04 Thread Anson Jacob
ble is static at creation - we don't dynamically add or remove links, just streams. Fixes: 00be4268d32c ("drm/amd/display: Support for DMUB HPD interrupt handling") Reviewed-by: Jude Shih Acked-by: Anson Jacob Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/amdgpu_d

[PATCH 11/22] drm/amd/display: fix stale info in link encoder assignment

2021-11-04 Thread Anson Jacob
if the unassign loop does the work properly, the loop should base on the current state to clean up the assignment. Also, the unassignment should better clean up the values in the assignement slots as well. Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Roy Chan --- .../drm/amd/display

[PATCH 10/22] drm/amd/display: use link_rate_set above DPCD 1.3 (#1527)

2021-11-04 Thread Anson Jacob
From: "Huang, ChiaWen" [Why & How] According to eDP spec, DPCD 1.3 is only for eDP DPCD v1.4 In dpcd_set_link_settings function, the driver is just above v1.3 Reviewed-by: Wenjing Liu Acked-by: Anson Jacob Signed-off-by: ChiawenHuang --- drivers/gpu/drm/amd/display/dc/core/dc

[PATCH 08/22] drm/amd/display: bring dcn31 clk mgr in line with other version style

2021-11-04 Thread Anson Jacob
From: Dmytro Laktyushkin Reviewed-by: Nicholas Kazlauskas Acked-by: Anson Jacob Signed-off-by: Dmytro Laktyushkin --- .../gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c | 8 .../gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.h | 7 +++ 2 files changed, 11 insertions

[PATCH 05/22] drm/amd/display: Fix RGB MPO underflow with multiple displays

2021-11-04 Thread Anson Jacob
idle. Added a two step call to dc_update_planes_and_stream, first time with pipe split disabled and the second time with pipe split enabled, which fixed the underflow issue Change-Id: I2d6fcc146242a30849096f08c52afa13bf4f9225 Reviewed-by: Aric Cyr Acked-by: Anson Jacob Signed-off-by: Angus Wang

[PATCH 07/22] drm/amd/display: Fix detection of aligned DMUB firmware meta info

2021-11-04 Thread Anson Jacob
] To maintain compatibility with already released firmware where this occurs we need to try every meta offset from 0..15 inclusive. Extract out the meta info checker into a helper function that's called for each of these offsets and exit early when we've found it. Reviewed-by: Eric Yang Acked-by: Anson

[PATCH 09/22] drm/amd/display: clean up some formats and log.

2021-11-04 Thread Anson Jacob
From: Charlene Liu [why] reduce az indirect register dump. need add az clock_gating control field used in some project. [how] conditional output indrect register in the log. add clock_gating feild Reviewed-by: Sung joon Kim Acked-by: Anson Jacob Signed-off-by: Charlene Liu --- drivers/gpu

[PATCH 02/22] drm/amd/display: Pass panel inst to a PSR command

2021-11-04 Thread Anson Jacob
-by: Anson Jacob Signed-off-by: Mikita Lipski --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 4 +++- drivers/gpu/drm/amd/display/dc/dce/dmub_psr.h | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 06/22] drm/amd/display: Use link_enc_cfg API for queries.

2021-11-04 Thread Anson Jacob
Acked-by: Anson Jacob Signed-off-by: Jimmy Kizito --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c index

[PATCH 03/22] drm/amd/display: remove dmcub_support cap dependency

2021-11-04 Thread Anson Jacob
From: Charlene Liu [why] matching the dmcub_support with all other dcn version. Reviewed-by: Sung joon Kim Reviewed-by: Martin Leung Acked-by: Anson Jacob Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH 01/22] drm/amd/display: Add helper for blanking all dp displays

2021-11-04 Thread Anson Jacob
Lee Reviewed-by: Wesley Chalmers Reviewed-by: Aric Cyr Acked-by: Anson Jacob Signed-off-by: Leo (Hanghong) Ma --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 51 +++ drivers/gpu/drm/amd/display/dc/dc_link.h | 4 ++ .../display/dc/dce110/dce110_hw_sequ

[PATCH 04/22] drm/amd/display: Add comment where CONFIG_DRM_AMD_DC_DCN macro ends

2021-11-04 Thread Anson Jacob
Trivial patch which adds a comment for macro endif's in amdgpu_dm.c Reviewed-by: Ariel Bernstein Reviewed-by: Harry Wentland Acked-by: Anson Jacob Signed-off-by: Anson Jacob --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH 00/22] DC Patches Nov 4, 2021

2021-11-04 Thread Anson Jacob
/display: Wait for ACK for INBOX0 HW Lock Angus Wang (1): drm/amd/display: Fix RGB MPO underflow with multiple displays Anson Jacob (1): drm/amd/display: Add comment where CONFIG_DRM_AMD_DC_DCN macro ends Aric Cyr (1): drm/amd/display: 3.2.161 Charlene Liu (3): drm/amd/display: remove

[PATCH] drm/amdkfd: Fix dummy kgd2kfd_probe parameters

2021-09-30 Thread Anson Jacob
Commit 4d706ed6825f ("drm/amdkfd: clean up parameters in kgd2kfd_probe") updated paremeters for kgd2kfd_probe. Update the dummy function as well when CONFIG_HSA_AMD is not enabled. Fixes: 4d706ed6825f ("drm/amdkfd: clean up parameters in kgd2kfd_probe") Signed-off-by: Anson

[PATCH 23/24] drm/amd/display: Update VCP X.Y logging to improve usefulness

2021-09-24 Thread Anson Jacob
and format output to be human readable. Reviewed-by: Wenjing Liu Acked-by: Anson Jacob Signed-off-by: George Shen --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 49 ++- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core

[PATCH 24/24] drm/amd/display: Pass PCI deviceid into DC

2021-09-24 Thread Anson Jacob
From: Charlene Liu [why] pci deviceid not passed to dal dc, without proper break, dcn2.x falls into dcn3.x code path [how] pass in pci deviceid, and break once dal_version initialized. Reviewed-by: Zhan Liu Acked-by: Anson Jacob Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display

[PATCH 22/24] drm/amd/display: Handle Y carry-over in VCP X.Y calculation

2021-09-24 Thread Anson Jacob
From: George Shen [Why/How] Theoretically rare corner case where ceil(Y) results in rounding up to an integer. If this happens, the 1 should be carried over to the X value. Reviewed-by: Wenjing Liu Acked-by: Anson Jacob Signed-off-by: George Shen --- drivers/gpu/drm/amd/display/dc/dcn10

[PATCH 21/24] drm/amd/display: make verified link cap not exceeding max link cap

2021-09-24 Thread Anson Jacob
-by: Jimmy Kizito Acked-by: Anson Jacob Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 43 --- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core

[PATCH 20/24] drm/amd/display: initialize backlight_ramping_override to false

2021-09-24 Thread Anson Jacob
From: Josip Pavic [Why] Stack variable params.backlight_ramping_override is uninitialized, so it contains junk data [How] Initialize the variable to false Reviewed-by: Roman Li Acked-by: Anson Jacob Signed-off-by: Josip Pavic --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + 1

[PATCH 18/24] drm/amd/display: Replace referral of dal with dc

2021-09-24 Thread Anson Jacob
From: Qingqing Zhuo [Why] DC should be used in place of DAL in upstream. [How] Replace dal with dc in function names. Reviewed-by: Rodrigo Siqueira Acked-by: Anson Jacob Signed-off-by: Qingqing Zhuo --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 2 +- drivers/gpu/drm

[PATCH 19/24] drm/amd/display: Defer LUT memory powerdown until LUT bypass latches

2021-09-24 Thread Anson Jacob
Vupdate. [HOW] Re-enable mem low power for CM block Force optimization on next flip and disable LUT memory during optimization sequence if LUT select field is then set to bypass Reviewed-by: Eric Yang Acked-by: Anson Jacob Signed-off-by: Michael Strauss --- drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH 17/24] drm/amd/display: 3.2.155

2021-09-24 Thread Anson Jacob
From: Aric Cyr This version brings along following fixes: - Fixes to backlight, LUT, PPS, MST - Use correct vpg for 128b/132b encoding - Improved logging for VCP - Replace referral of dal with dc Acked-by: Anson Jacob Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1

[PATCH 16/24] drm/amd/display: [FW Promotion] Release 0.0.86

2021-09-24 Thread Anson Jacob
From: Anthony Koo Acked-by: Anson Jacob Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 14/24] drm/amd/display: Add PPS immediate update flag for DCN2

2021-09-24 Thread Anson Jacob
Acked-by: Anson Jacob Signed-off-by: Ilya --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_optc.c| 5 + .../gpu/drm/amd/display/dc/dcn20/dcn20_stream_encoder.c | 9 ++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20

[PATCH 15/24] drm/amd/display: Add an extra check for dcn10 OPTC data format

2021-09-24 Thread Anson Jacob
From: Oliver Logush Reviewed-by: Charlene Liu Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Oliver Logush --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_ipp.h | 6 -- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 2 +- drivers/gpu/drm/amd/display/dc/inc/hw/dwb.h

[PATCH 13/24] drm/amd/display: Fix MST link encoder availability check.

2021-09-24 Thread Anson Jacob
with the stream for which the availability check is being conducted. If the link is shared, then the link encoder should be shared too and will be deemed available. Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Jimmy Kizito --- .../drm/amd/display/dc/core/dc_link_enc_cfg.c | 23

[PATCH 12/24] drm/amd/display: Fix for link encoder access for MST.

2021-09-24 Thread Anson Jacob
From: Meenakshikumar Somasundaram [Why] Link encoder in the link could be null for certain links. [How] If link encoder in the link is null then get the link encoder from the stream. Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Meenakshikumar Somasundaram --- drivers/gpu/drm

[PATCH 11/24] drm/amd/display: add two lane settings training options

2021-09-24 Thread Anson Jacob
From: Wenjing Liu [why] option 1: disallow different lanes to have different lane settings option 2: dpcd lane settings will always use the same hw lane settings even if it doesn't match requested lane adjust Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Wenjing Liu --- .../gpu

[PATCH 10/24] drm/amd/display: decouple hw_lane_settings from dpcd_lane_settings

2021-09-24 Thread Anson Jacob
individually. Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 154 +++--- drivers/gpu/drm/amd/display/dc/dc_dp_types.h | 5 - .../amd/display/include/link_service_types.h | 19 ++- 3 files changed, 70 insertions

[PATCH 09/24] drm/amd/display: rename lane_settings to hw_lane_settings

2021-09-24 Thread Anson Jacob
From: Wenjing Liu [why] This is one of the major steps to decouple hw lane settings from dpcd lane settings. Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Wenjing Liu --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 8 ++-- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 38

[PATCH 08/24] drm/amd/display: implement decide lane settings

2021-09-24 Thread Anson Jacob
From: Wenjing Liu [why] Decouple lane settings decision logic all to its own function. The function takes in lane adjust array and link training settings and decide what hw lane setting and dpcd lane setting should be used. Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Wenjing Liu

[PATCH 07/24] drm/amd/display: add function to convert hw to dpcd lane settings

2021-09-24 Thread Anson Jacob
From: Wenjing Liu [why] Unify the code which handles the conversion between hw lane setting and dpcd lane setting. Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 113 ++ .../gpu/drm/amd/display/dc/inc

[PATCH 06/24] drm/amd/display: update cur_lane_setting to an array one for each lane

2021-09-24 Thread Anson Jacob
From: Wenjing Liu [why] To support per lane lane setting adjustment, we need to change cur_lane_setting to an array one for each lane as the first step. Reviewed-by: Jun Lei Acked-by: Anson Jacob Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 8

[PATCH 04/24] drm/amd/display: add vsync notify to dmub for abm pause

2021-09-24 Thread Anson Jacob
-by: Nicholas Kazlauskas Acked-by: Anson Jacob Signed-off-by: Eric Yang --- drivers/gpu/drm/amd/display/dc/core/dc.c | 54 +++ drivers/gpu/drm/amd/display/dc/dc.h | 2 + drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 21 drivers/gpu/drm/amd/display/dc/inc/hw

[PATCH 05/24] drm/amd/display: Add debug support to override the Minimum DRAM Clock

2021-09-24 Thread Anson Jacob
From: David Galiffi [Why] Requested feature to assist with Thermal, Acoustic, Power, and Performance tuning. [How] Add a debug field that will override calculated minimum DRAM clock, if the debug value is larger than the calculate value. Reviewed-by: Alvin Lee Acked-by: Anson Jacob Signed

[PATCH 03/24] drm/amd/display: Don't enable AFMT for DP audio stream

2021-09-24 Thread Anson Jacob
From: Michael Strauss [WHY] AFMT is unused for DP audio, so powering it on for DP is unnecessary. [HOW] APG block should be powered down instead, however HW defaults to shutdown state when not enabled so no further work is required. Reviewed-by: Wenjing Liu Acked-by: Anson Jacob Signed-off

[PATCH 02/24] drm/amd/display: [FW Promotion] Release 0.0.85

2021-09-24 Thread Anson Jacob
From: Anthony Koo Acked-by: Anson Jacob Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 01/24] drm/amd/display: use correct vpg instance for 128b/132b encoding

2021-09-24 Thread Anson Jacob
From: Wenjing Liu [why] 128b/132b uses the vpg instance assigned to hpo dp stream encoder. The current vpg used is assigned to dio stream encoder. This is incorrect and cause display black screen because the actual vpg is powered off. Reviewed-by: Michael Strauss Acked-by: Anson Jacob Signed

[PATCH 00/24] DC Patches Sep 24, 2021

2021-09-24 Thread Anson Jacob
This DC patchset brings improvements in multiple areas. In summary, we have: - Fixes to backlight, LUT, PPS, MST - Use correct vpg for 128b/132b encoding - Improved logging for VCP - Replace referral of dal with dc Anthony Koo (2): drm/amd/display: [FW Promotion] Release 0.0.85

Re: [3/4] drm/amd/display: Fix rest of pass-by-value structs in DML

2021-09-15 Thread Anson Jacob
Hi Harry, This patch fixes the following CID's. Thanks. Addresses-Coverity-ID: 1424031: ("Big parameter passed by value") Addresses-Coverity-ID: 1424055: ("Big parameter passed by value") Addresses-Coverity-ID: 1424072: ("Big parameter passed by value") Addresses-Coverity-ID: 1423779: ("Big

Re: [2/4] drm/amd/display: Pass all structs in display_rq_dlg_helpers by pointer

2021-09-15 Thread Anson Jacob
Hi Harry, This patch fixes the following CID's. Thanks. Addresses-Coverity-ID: 1423868: ("Big parameter passed by value") Addresses-Coverity-ID: 1423870: ("Big parameter passed by value") -- Anson

Re: [1/4] drm/amd/display: Pass display_pipe_params_st as const in DML

2021-09-15 Thread Anson Jacob
Hi Harry, This patch fixes the following CID's. Thanks. Addresses-Coverity-ID: 1424031: ("Big parameter passed by value") Addresses-Coverity-ID: 1423970: ("Big parameter passed by value") Addresses-Coverity-ID: 1423941: ("Big parameter passed by value") Addresses-Coverity-ID: 1451742: ("Big

Re: drm/amd/display: move FPU associated DSC code to DML folder

2021-09-14 Thread Anson Jacob
Tested on nixeus 4k144hz DSC capable display on RX5700XT (NAVI10 0x1002:0x731F 0x1DA2:0xE410 0xC1) on ubuntu 20.04. Display lightsup at 4k144hz with DSC engine on. Tested-by: Anson Jacob On 2021-09-07 10:32 a.m., Qingqing Zhuo wrote: As part of the FPU isolation work documented in https

[PATCH] drm/amdgpu: Remove ununsed variable from amdgpu_ib_pool_init

2021-09-13 Thread Anson Jacob
Remove unused variable 'size'. Signed-off-by: Anson Jacob --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c index 9274f32c3661..bc1297dcdf97 100644 --- a/drivers/gpu/drm

[PATCH] drm/amdkfd: Add dummy function for kgd2kfd_resume_iommu

2021-09-13 Thread Anson Jacob
Add dummy function when CONFIG_HSA_AMD is not enabled. Fixes: 433d2448d57c ("drm/amdkfd: separate kfd_iommu_resume from kfd_resume") Signed-off-by: Anson Jacob --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/

[PATCH] drm/amd/display: dc_assert_fp_enabled assert only if FPU is not enabled

2021-09-09 Thread Anson Jacob
Assert only when FPU is not enabled. Fixes: e549f77c1965 ("drm/amd/display: Add DC_FP helper to check FPU state") Signed-off-by: Anson Jacob Cc: Christian König Cc: Hersen Wu Cc: Harry Wentland Cc: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c | 2 +- 1 file

[PATCH 13/13] drm/amd/display: use GFP_ATOMIC in amdgpu_dm_irq_schedule_work

2021-08-06 Thread Anson Jacob
ohanan Pillai Acked-by: Anson Jacob Signed-off-by: Anson Jacob Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c b/drivers/gpu/drm/amd/d

[PATCH 11/13] drm/amd/display: Clear GPINT after DMCUB has reset

2021-08-06 Thread Anson Jacob
was 1002. [How] Move the GPINT clear outside of the reset loop and do it unconditionally after the DMCUB has been properly reset. Reviewed-by: Roy Chan Reviewed-by: Eric Yang Acked-by: Anson Jacob Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dmub/src/dmub_dcn31.c | 8

[PATCH 12/13] drm/amd/display: Increase timeout threshold for DMCUB reset

2021-08-06 Thread Anson Jacob
From: Nicholas Kazlauskas [Why] If we're backdoor loading the DMCUB performs more work than just the PHY reset so we can end up resetting before the cleanup has fully finished. [How] Increase timeout, add udelay between spins to guarantee a minimum. Acked-by: Anson Jacob Signed-off

[PATCH 09/13] drm/amd/display: [FW Promotion] Release 0.0.78

2021-08-06 Thread Anson Jacob
From: Anthony Koo Acked-by: Anson Jacob Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

[PATCH 07/13] drm/amd/display: Add AUX I2C tracing.

2021-08-06 Thread Anson Jacob
From: Ashley Thomas [Why] Developers can find it useful if the driver can produce AUX traces without special equipment. [How] Add AUX tracing. Reviewed-by: Zhan Liu Acked-by: Anson Jacob Signed-off-by: Ashley Thomas --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 192

[PATCH 04/13] drm/amd/display: refactor the cursor programing codes

2021-08-06 Thread Anson Jacob
From: Roy Chan Acked-by: Anson Jacob Signed-off-by: Roy Chan --- .../gpu/drm/amd/display/dc/core/dc_stream.c | 106 +++--- 1 file changed, 65 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core

[PATCH 10/13] drm/amd/display: 3.2.148

2021-08-06 Thread Anson Jacob
for ODM + MPC case Reviewed-by: Wyatt Wood Acked-by: Anson Jacob Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 62c222d0402f

[PATCH 02/13] drm/amd/display: fix missing writeback disablement if plane is removed

2021-08-06 Thread Anson Jacob
From: Roy Chan [Why] If the plane has been removed, the writeback disablement logic doesn't run [How] fix the logic order Acked-by: Anson Jacob Signed-off-by: Roy Chan --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 14 -- drivers/gpu/drm/amd/display/dc/dcn30

[PATCH 08/13] drm/amd/display: add authentication_complete in hdcp output

2021-08-06 Thread Anson Jacob
From: Wenjing Liu [why] DM needs to be notified when hdcp module has completed authentication attempt. Acked-by: Anson Jacob Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/display/modules/hdcp/hdcp.c | 5 +- .../gpu/drm/amd/display/modules/hdcp/hdcp.h | 8 ++ .../display/modules/hdcp

[PATCH 03/13] drm/amd/display: refactor the codes to centralize the stream/pipe checking logic

2021-08-06 Thread Anson Jacob
From: Roy Chan Acked-by: Anson Jacob Signed-off-by: Roy Chan --- drivers/gpu/drm/amd/display/dc/core/dc.c | 62 1 file changed, 41 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index

[PATCH 05/13] drm/amd/display: fix incorrect CM/TF programming sequence in dwb

2021-08-06 Thread Anson Jacob
From: Roy Chan [How] the programming sequeune was for old asic. the correct programming sequeunce should be similar to the one used in mpc. the fix is copied from the mpc programming sequeunce. Acked-by: Anson Jacob Signed-off-by: Roy Chan --- .../drm/amd/display/dc/dcn30/dcn30_dwb_cm.c

[PATCH 06/13] drm/amd/display: Correct comment style

2021-08-06 Thread Anson Jacob
From: Roy Chan Acked-by: Anson Jacob Signed-off-by: Roy Chan --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h index

[PATCH 01/13] drm/amd/display: Remove invalid assert for ODM + MPC case

2021-08-06 Thread Anson Jacob
From: Eric Bernstein Reviewed-by: Dmytro Laktyushkin Acked-by: Anson Jacob Signed-off-by: Eric Bernstein Cc: sta...@vger.kernel.org --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn30

[PATCH 00/13] DC Patches Aug 6, 2021

2021-08-06 Thread Anson Jacob
- Remove invalid assert for ODM + MPC case Anson Jacob (1): drm/amd/display: use GFP_ATOMIC in amdgpu_dm_irq_schedule_work Anthony Koo (2): drm/amd/display: [FW Promotion] Release 0.0.78 drm/amd/display: 3.2.148 Ashley Thomas (1): drm/amd/display: Add AUX I2C tracing. Eric Bernstein (1

[PATCH] drm/vc4: hdmi: Fix build break caused by merge issue

2021-08-04 Thread Anson Jacob
10524131852.263883-2-max...@cerno.tech Signed-off-by: Anson Jacob --- drivers/gpu/drm/vc4/vc4_hdmi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index df65e0b6449b..aab1b36ceb3c 100644 --- a/drivers/gp

[RFC v2 2/2] drm/amd/display: Use PPC FPU functions

2021-07-21 Thread Anson Jacob
Use kernel_fpu_begin & kernel_fpu_end for PPC Depends on "ppc/fpu: Add generic FPU api similar to x86" v2: - Got rid of macro switch for PPC as header file with same name as x86 is added by previous patch in the series Signed-off-by: Anson Jacob CC: Christoph Hellwig CC: Ro

[RFC v2 1/2] ppc/fpu: Add generic FPU api similar to x86

2021-07-21 Thread Anson Jacob
ated kernel_fpu_enabled as EXPORT_SYMBOL_GPL Signed-off-by: Anson Jacob CC: Christoph Hellwig CC: Rodrigo Siqueira CC: Harry Wentland CC: Christian König --- arch/powerpc/include/asm/fpu/api.h | 18 arch/powerpc/include/asm/switch_to.h | 25 +- arch/powerpc/kernel/process.c|

[RFC v2 0/2] PPC: Add generic FPU api similar to x86

2021-07-21 Thread Anson Jacob
- Updated kernel_fpu_enabled as EXPORT_SYMBOL_GPL - Got rid of macro switch for PPC in dc/os_types.h as header file with same name as x86 is added by previous patch in the series Anson Jacob (2): ppc/fpu: Add generic FPU api similar to x86 drm/amd/display: Use PPC FPU functions arch/powerpc

[PATCH] drm/amd/amdgpu: Add a new line to debugfs phy_settings output

2021-07-20 Thread Anson Jacob
Add new line to phy_settings output Signed-off-by: Anson Jacob --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c b/drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH] drm/amd/amdgpu: Update debugfs link_settings output link_rate field in hex

2021-07-20 Thread Anson Jacob
l/debug/dri/0/DP-1/link_settings cat /sys/kernel/debug/dri/0/DP-1/link_settings Current: 4 0x1e 0 Verified: 4 0x1e 0 Reported: 4 0x1e 16 Preferred: 4 0x1e 0 Signed-off-by: Anson Jacob --- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c| 16 1 file changed, 8 ins

[V2] drm/amdgpu: Fix documentaion for dm_dmub_outbox1_low_irq

2021-07-20 Thread Anson Jacob
Fix make htmldocs complaint: ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:628: warning: Excess function parameter 'interrupt_params' description in 'DMUB_TRACE_MAX_READ' v2: Moved DMUB_TRACE_MAX_READ macro above function documentation Signed-off-by: Anson Jacob CC: Harry Wentland

[RFC 0/2] Add generic FPU api similar to x86

2021-07-19 Thread Anson Jacob
This is an attempt to have generic FPU enable/disable calls similar to x86. So that we can simplify gpu/drm/amd/display/dc/os_types.h Also adds FPU correctness logic seen in x86. Anson Jacob (2): ppc/fpu: Add generic FPU api similar to x86 drm/amd/display: Use PPC FPU functions arch

[RFC 1/2] ppc/fpu: Add generic FPU api similar to x86

2021-07-19 Thread Anson Jacob
- Add kernel_fpu_begin & kernel_fpu_end API as x86 - Add logic similar to x86 to ensure fpu begin/end call correctness - Add kernel_fpu_enabled to know if FPU is enabled Signed-off-by: Anson Jacob --- arch/powerpc/include/asm/switch_to.h | 29 ++ arch/powerpc/kernel/proce

[RFC 2/2] drm/amd/display: Use PPC FPU functions

2021-07-19 Thread Anson Jacob
Use kernel_fpu_begin & kernel_fpu_end for PPC Depends on "ppc/fpu: Add generic FPU api similar to x86" Signed-off-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/os_types.h | 28 ++- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/drive

[PATCH] drm/amdgpu: Fix documentaion for dm_dmub_outbox1_low_irq

2021-07-19 Thread Anson Jacob
Fix make htmldocs complaint: ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:628: warning: Excess function parameter 'interrupt_params' description in 'DMUB_TRACE_MAX_READ' Signed-off-by: Anson Jacob --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2

[PATCH] drm/amdgpu: Fix documentaion for amdgpu_bo_add_to_shadow_list

2021-07-19 Thread Anson Jacob
or member 'vmbo' not described in 'amdgpu_bo_add_to_shadow_list' ./drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:739: warning: Excess function parameter 'bo' description in 'amdgpu_bo_add_to_shadow_list' Signed-off-by: Anson Jacob --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- 1 file changed, 1

[PATCH 18/24] drm/amd/display: Rename constant

2021-06-10 Thread Anson Jacob
From: Wesley Chalmers [WHY] 7 is the minimum number of retries TX must attempt on an AUX DEFER, not the maximum. Signed-off-by: Wesley Chalmers Reviewed-by: Jun Lei Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 22/24] drm/amd/display: Add interface to get Calibrated Avg Level from FIFO

2021-06-10 Thread Anson Jacob
From: Wesley Chalmers [WHY] Hardware has handed down a new sequence requiring the value of this register be read from clk_mgr. Signed-off-by: Wesley Chalmers Reviewed-by: Dmytro Laktyushkin Acked-by: Anson Jacob --- .../display/dc/dcn10/dcn10_stream_encoder.h | 24

[PATCH 14/24] drm/amd/display: Set LTTPR Transparent Mode after read link cap

2021-06-10 Thread Anson Jacob
read. Explicitly setting Transparent mode after LTTPR capability read should cover all cases. Signed-off-by: Wesley Chalmers Reviewed-by: Jun Lei Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 16/24] drm/amd/display: Improve logic for is_lttpr_present

2021-06-10 Thread Anson Jacob
if PHY_REPEATER_CNT is a valid LTTPR count. Signed-off-by: Wesley Chalmers Reviewed-by: Jun Lei Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers

[PATCH 04/24] drm/amd/display: tune backlight ramping profiles

2021-06-10 Thread Anson Jacob
From: Josip Pavic [Why & How] Tune backlight ramping profiles for each Vari-Bright level to suit customer preferences Signed-off-by: Josip Pavic Reviewed-by: Anthony Koo Acked-by: Anson Jacob --- .../amd/display/modules/power/power_helpers.c | 20 +-- 1 file changed

[PATCH 23/24] drm/amd/display: Cover edge-case when changing DISPCLK WDIVIDER

2021-06-10 Thread Anson Jacob
IVIDER = 127 Because of frequency stepping, divider must first be set from any other divider value to 126 before executing sequence b. Signed-off-by: Wesley Chalmers Reviewed-by: Dmytro Laktyushkin Acked-by: Anson Jacob --- .../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c

[PATCH 21/24] drm/amd/display: Partition DPCD address space and break up transactions

2021-06-10 Thread Anson Jacob
spans multiple blocks, break up the request into multiple requests. Signed-off-by: Wesley Chalmers Reviewed-by: Jun Lei Acked-by: Anson Jacob --- .../drm/amd/display/dc/core/dc_link_dpcd.c| 87 ++- include/drm/drm_dp_helper.h | 17 2 files changed, 102

[PATCH 19/24] drm/amd/display: 7 retries + 50 ms timeout on AUX DEFER

2021-06-10 Thread Anson Jacob
7 or more retries have been made, and the 50ms interval has passed. Signed-off-by: Wesley Chalmers Reviewed-by: Jun Lei Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 17/24] drm/amd/display: Enforce DPCD Address ranges

2021-06-10 Thread Anson Jacob
the entire range. After DPCD has been queried, copy the requested bytes into the caller's data buffer, and deallocate all resources used. Signed-off-by: Wesley Chalmers Reviewed-by: Jun Lei Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/Makefile | 2 +- drivers/gpu/drm/amd

[PATCH 24/24] drm/amd/display: Extend AUX timeout for DP initial reads

2021-06-10 Thread Anson Jacob
-by: Wesley Chalmers Reviewed-by: Jun Lei Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c index

[PATCH 11/24] drm/amd/display: Read LTTPR caps first on hotplug

2021-06-10 Thread Anson Jacob
From: Wesley Chalmers [WHY] A new SCR for the DP2.0 spec requires that LTTPR caps be the first thing read from DPCD upon hotplug. Signed-off-by: Wesley Chalmers Reviewed-by: Jun Lei Acked-by: Anson Jacob --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 65 ++- 1 file

[PATCH 03/24] drm/amd/display: add config option for eDP hotplug detection

2021-06-10 Thread Anson Jacob
From: Yi-Ling Chen [Why] Some custom platforms use eDP hotplug events to notify panel capability changes that should be reported [How] Add a DC config option that unblocks eDP hotplug events Signed-off-by: Yi-Ling Chen Reviewed-by: Aric Cyr Acked-by: Anson Jacob --- drivers/gpu/drm/amd

[PATCH 10/24] drm/amd/display: move psr dm interface to separate files

2021-06-10 Thread Anson Jacob
From: Roman Li [Why] Improve the maintain/read abilities of dm code. [How] Create amdgpu_dm_psr.c/h files. Move psr function from amdgpu_dm.c Signed-off-by: Roman Li Reviewed-by: Nicholas Kazlauskas Acked-by: Anson Jacob --- .../gpu/drm/amd/display/amdgpu_dm/Makefile| 2 +- .../gpu

[PATCH 12/24] drm/amd/display: Move LTTPR cap read into its own function

2021-06-10 Thread Anson Jacob
From: Wesley Chalmers [WHY] We want LTTPR capabilities to be readable from more places than just retrieve_link_cap Signed-off-by: Wesley Chalmers Reviewed-by: Jun Lei Acked-by: Anson Jacob --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 75 ++- 1 file changed, 41

[PATCH 01/24] drm/amd/display: Remove unnecessary blank lines

2021-06-10 Thread Anson Jacob
From: Dmytro Laktyushkin cleanup Signed-off-by: Dmytro Laktyushkin Reviewed-by: Aric Cyr Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c b/drivers/gpu

[PATCH 02/24] drm/amd/display: add DMUB registers to crash dump diagnostic data.

2021-06-10 Thread Anson Jacob
Thomas Reviewed-by: Nicholas Kazlauskas Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 100 +- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 4 + drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 29 + .../gpu/drm/amd/display/dmub/src/dmub_dcn20.c

[PATCH 08/24] drm/amd/display: [FW Promotion] Release 0.0.70

2021-06-10 Thread Anson Jacob
From: Anthony Koo Signed-off-by: Anthony Koo Reviewed-by: Anthony Koo Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd

[PATCH 07/24] drm/amd/display: Updated variable name.

2021-06-10 Thread Anson Jacob
From: David Galiffi [Why] Fixed spelling error. [How] Changed "currnet_setting" to "current_setting". Signed-off-by: David Galiffi Reviewed-by: Wesley Chalmers Acked-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 12 ++-- 1 file changed

  1   2   3   >