RE: [PATCH] drm/amdkfd: init drm_client with funcs hook

2024-01-14 Thread Cui, Flora
[AMD Official Use Only - General] Ping? -Original Message- From: Cui, Flora Sent: Friday, January 12, 2024 4:05 PM To: amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH] drm/amdkfd: init drm_client with funcs hook otherwise drm_client_dev_unregister() would try to kfree

RE: [PATCH 07/15] drm/amd/display: remove redundant CONFIG_DRM_AMD_DC_DCN in dc

2022-05-07 Thread Cui, Flora
[AMD Official Use Only - General] What about arm? -Original Message- From: amd-gfx On Behalf Of Rodrigo Siqueira Jordao Sent: 2022年5月7日 1:13 To: Alex Deucher ; Hung, Alex ; Wang, Chao-kai (Stylon) Cc: Li, Sun peng (Leo) ; Lakha, Bhawanpreet ; Zhuo, Qingqing (Lillian) ; Li, Roman ;

RE: [PATCH 1/2] drm/amdgpu: fix vkms hrtimer settings

2021-11-22 Thread Cui, Flora
er, Alexander Sent: 2021年11月23日 0:43 To: Chen, Guchun ; Cui, Flora ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: fix vkms hrtimer settings [Public] Can you explain how the current code is failing? It's not immediately obvious to me. I'm not opposed to this change, it's ju

RE: [PATCH] drm/amd/powerplay: move maximum sustainable clock retrieving to .hw_init

2020-06-08 Thread Cui, Flora
[AMD Public Use] Reported-and-tested-by: Flora Cui From: Deucher, Alexander Sent: Monday, June 8, 2020 11:02 PM To: Quan, Evan ; amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: Re: [PATCH] drm/amd/powerplay: move maximum sustainable clock retrieving to .hw_init [AMD Public Use

Re: [PATCH 2/2] drm/amdgpu: skip reservation of discovery tmr region in pre-Navi

2020-01-16 Thread Cui, Flora
IMHO it's better to handle the size==0 case in amdgpu_bo_create_kernel_at(). 在 1/17/2020 2:57 AM, Hawking Zhang 写道: IP discovery is only supported in Navi series and onwards. There is no need to reserve a portion of vram as discovery tmr region for pre-Navi adapters. Signed-off-by: Hawking

[PATCH libdrm] tests/amdgpu: disable reset test for now

2019-07-22 Thread Cui, Flora
ASIC hang randomly. Signed-off-by: Flora Cui --- tests/amdgpu/amdgpu_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/amdgpu/amdgpu_test.c b/tests/amdgpu/amdgpu_test.c index 6f1e372..a4ce8ce 100644 --- a/tests/amdgpu/amdgpu_test.c +++ b/tests/amdgpu/amdgpu_test.c

RE: [PATCH libdrm 1/1] tests/amdgpu: divide dispatch test into compute and gfx

2019-07-22 Thread Cui, Flora
Patch is Reviewed-by: Flora Cui Could you apply the similar change to draw test? -Original Message- From: amd-gfx On Behalf Of Le Ma Sent: Monday, July 22, 2019 4:01 PM To: amd-gfx@lists.freedesktop.org Cc: Ma, Le ; Cui, Flora Subject: [PATCH libdrm 1/1] tests/amdgpu: divide dispatch

Re: [PATCH libdrm 1/2] tests/amdgpu: fix for dispatch/draw test

2019-07-19 Thread Cui, Flora
I'm not sure. Could you have a try? 在 7/19/2019 3:48 PM, Huang, Ray 写道: > Thanks Flora, can we have these tests, and try on our new APUs as well?  > > Thanks, > Ray > >> -Original Message- >> From: amd-gfx On Behalf Of Cui, >> Flora >> Sent: Thu

Re: [PATCH libdrm 1/2] tests/amdgpu: fix for dispatch/draw test

2019-07-19 Thread Cui, Flora
the Change-Id tags are added automatically. do you know how to get rid of it? 在 7/19/2019 3:40 PM, Michel Dänzer 写道: > On 2019-07-19 8:00 a.m., Cui, Flora wrote: >> Hi Michel, >> >> These 2 commits is pushed to https://gitlab.freedesktop.org/fcui/drm. >> Could yo

Re: [PATCH libdrm 1/2] tests/amdgpu: fix for dispatch/draw test

2019-07-19 Thread Cui, Flora
Hi Michel, These 2 commits is pushed to https://gitlab.freedesktop.org/fcui/drm. Could you help to merge to mesa/drm? BR, Flora 在 7/18/2019 5:31 PM, Christian König 写道: > Am 18.07.19 um 10:10 schrieb Cui, Flora: >> 1. skip test if there's no desired ring >> 2. clear shader buff

[PATCH libdrm 1/2] tests/amdgpu: fix for dispatch/draw test

2019-07-18 Thread Cui, Flora
1. skip test if there's no desired ring 2. clear shader buffer 3. update command buffer for gfx9 Change-Id: I5e4e92842c4fd1088c14dc048bedf4fe84892b36 Signed-off-by: Flora Cui --- tests/amdgpu/basic_tests.c | 36 1 file changed, 28 insertions(+), 8

[PATCH libdrm 2/2] tests/amdgpu: add gpu reset test

2019-07-18 Thread Cui, Flora
1. perform gpu reset 2. perform dispatch test to verify gpu reset to a good state Change-Id: I4bba0d1b829288bba7b6885d7e68c8f69ef8f4b5 Signed-off-by: Flora Cui --- tests/amdgpu/amdgpu_test.c | 5 + tests/amdgpu/basic_tests.c | 38 ++ 2 files changed, 43

RE: [PATCH v4] drm/amdgpu: fix scheduler timeout calc

2019-07-04 Thread Cui, Flora
Ping... Could anyone give me a rb? -Original Message- From: Cui, Flora Sent: Thursday, July 4, 2019 11:09 AM To: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH v4] drm/amdgpu: fix scheduler timeout calc Ping... -Original Message- From: Cui, Flora Sent: Monday, July 1, 2019

RE: [PATCH v4] drm/amdgpu: fix scheduler timeout calc

2019-07-03 Thread Cui, Flora
Ping... -Original Message- From: Cui, Flora Sent: Monday, July 1, 2019 11:37 AM To: amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH v4] drm/amdgpu: fix scheduler timeout calc scheduler timeout is in jiffies v2: move timeout check to amdgpu_device_get_job_timeout_settings

[PATCH v4] drm/amdgpu: fix scheduler timeout calc

2019-06-30 Thread Cui, Flora
scheduler timeout is in jiffies v2: move timeout check to amdgpu_device_get_job_timeout_settings after parsing the value v3: add lockup_timeout param check. 0: keep default value. negative: infinity timeout. v4: refactor codes. Change-Id: I26708c163db943ff8d930dd81bcab4b4b9d84eb2 Signed-off-by:

[PATCH v3] drm/amdgpu: fix scheduler timeout calc

2019-06-28 Thread Cui, Flora
scheduler timeout is in jiffies v2: move timeout check to amdgpu_device_get_job_timeout_settings after parsing the value v3: add lockup_timeout param check. 0: keep default value. negative: infinity timeout. Change-Id: I26708c163db943ff8d930dd81bcab4b4b9d84eb2 Signed-off-by: Flora Cui ---

Re: [PATCH v2] drm/amdgpu: fix scheduler timeout calc

2019-06-27 Thread Cui, Flora
在 6/27/2019 6:17 PM, Christian König 写道: > Am 27.06.19 um 12:03 schrieb Cui, Flora: >> scheduler timeout is in jiffies >> v2: move timeout check to amdgpu_device_get_job_timeout_settings after >> parsing the value >> >> Change-Id: I26708c163db943ff8d930dd81bcab4b

[PATCH v2] drm/amdgpu: fix scheduler timeout calc

2019-06-27 Thread Cui, Flora
scheduler timeout is in jiffies v2: move timeout check to amdgpu_device_get_job_timeout_settings after parsing the value Change-Id: I26708c163db943ff8d930dd81bcab4b4b9d84eb2 Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 7 +-- 1 file changed, 5 insertions(+), 2

Re: [PATCH v2] drm/amdgpu: fix scheduler timeout calc

2019-06-25 Thread Cui, Flora
please ignore this mail. I'll prepare v3 patch to simplify code logic. 获取 Outlook for Android<https://aka.ms/ghei36> From: Cui, Flora Sent: Tuesday, June 25, 2019 5:43:38 PM To: amd-gfx@lists.freedesktop.org Cc: Cui, Flora Subject: [PATCH v2] drm/amdgp

[PATCH v2] drm/amdgpu: fix scheduler timeout calc

2019-06-25 Thread Cui, Flora
scheduler timeout is in jiffies v2: move timeout check to amdgpu_device_get_job_timeout_settings after parsing the value & add negative value check Change-Id: I26708c163db943ff8d930dd81bcab4b4b9d84eb2 Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 6 +- 1 file

Re: [PATCH] drm/amdgpu: fix scheduler timeout calc

2019-06-24 Thread Cui, Flora
OK. will update in v2. 在 6/24/2019 5:36 PM, Christian König 写道: > Am 24.06.19 um 10:50 schrieb Cui, Flora: >> scheduler timeout is in jiffies >> >> Change-Id: I26708c163db943ff8d930dd81bcab4b4b9d84eb2 >> Signed-off-by: Flora Cui > > I actually

[PATCH] drm/amdgpu: fix scheduler timeout calc

2019-06-24 Thread Cui, Flora
scheduler timeout is in jiffies Change-Id: I26708c163db943ff8d930dd81bcab4b4b9d84eb2 Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c

Re: [PATCH v2] dri2: reply to client for WaitMSC request in any case

2019-06-03 Thread Cui, Flora
:26 skrev Cui, Flora : >> ping... >> >> commit 47613e8e8f4a5e3b25830e3c015a4a217fcbe469 >> Author: Flora Cui >> Date: Wed May 29 14:18:50 2019 +0800 >> >> dri2: reply to client for WaitMSC request in any case >> >> otherwi

[PATCH v2] dri2: reply to client for WaitMSC request in any case

2019-06-03 Thread Cui, Flora
(NULL, 0, wait_info); +   else +   DRI2WaitMSCComplete(client, draw, target_msc, 0, 0); +     return TRUE;  } 在 5/29/2019 2:36 PM, Cui, Flora 写道: > otherwise client would wait for reply forever and desktop appears hang. > > Signed-off-by: Flora Cui > --- > sr

[PATCH] dri2: reply to client for WaitMSC request in any case

2019-05-29 Thread Cui, Flora
otherwise client would wait for reply forever and desktop appears hang. Signed-off-by: Flora Cui --- src/amdgpu_dri2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amdgpu_dri2.c b/src/amdgpu_dri2.c index 44316ac..34353a7 100644 --- a/src/amdgpu_dri2.c +++ b/src/amdgpu_dri2.c @@

[PATCH] drm/amdgpu: reserve stollen vram for raven series

2019-05-28 Thread Cui, Flora
to avoid screen corruption during modprobe. Change-Id: I8671de6ed46285585dbe866832c6d2b835ca37f3 Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

Re: [PATCH] drm/amdgpu: add DRIVER_SYNCOBJ_TIMELINE to amdgpu

2019-05-27 Thread Cui, Flora
the patch is Reviewed-by: Flora Cui 在 5/28/2019 10:52 AM, Chunming Zhou 写道: > Change-Id: I2b1af1478fbddbb5084b90b3ff85c2eb964bd217 > Signed-off-by: Chunming Zhou > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

[PATCH] drm/amdgpu: keep stolen memory on picasso

2019-05-16 Thread Cui, Flora
otherwise screen corrupts during modprobe. Change-Id: I73bcf3ab0c666077dfe85436a3457a0379382304 Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

[PATCH libdrm] tests/amdgpu: minor fix for dispatch/draw test

2019-03-19 Thread Cui, Flora
1. clear cmd buffer 2. make amdgpu_memcpy_dispatch_test static 3. tab/space fix Change-Id: Idf55f8881f66458b585092eccb55b6042520e4ad Signed-off-by: Flora Cui --- tests/amdgpu/basic_tests.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

[PATCH libdrm 4/4] tests/amdgpu: add memcpy draw test

2019-03-15 Thread Cui, Flora
add memcpy draw test for gfx9 Change-Id: Ib80e55b1ab7aa556c4b5adfdd39aedf7d58ba628 Signed-off-by: Flora Cui Tested-by: Rui Teng --- tests/amdgpu/basic_tests.c | 264 +++-- 1 file changed, 253 insertions(+), 11 deletions(-) diff --git

[PATCH libdrm 2/4] tests/amdgpu: add memcpy dispatch test

2019-03-15 Thread Cui, Flora
add memcpy dispatch test for gfx9 Change-Id: Ic9b280db2ced21b15e228c1c4c217836ab3f44a8 Signed-off-by: Flora Cui Tested-by: Rui Teng Reviewed-by: Hawking Zhang --- tests/amdgpu/basic_tests.c | 163 - 1 file changed, 161 insertions(+), 2 deletions(-)

[PATCH libdrm 3/4] tests/amdgpu: add memset draw test

2019-03-15 Thread Cui, Flora
add memset draw test for gfx9 Change-Id: I3a1f2460ec0917e29ce1a891200eeaa1a0565fda Signed-off-by: Flora Cui Tested-by: Rui Teng --- tests/amdgpu/amdgpu_test.c | 5 + tests/amdgpu/basic_tests.c | 554 + 2 files changed, 559 insertions(+) diff --git

RE: [PATCH] remove amdgpu_vrr_atom

2019-03-07 Thread Cui, Flora
Drop amd-gfx. Hi Michel, Thanks for your info. Hi Hui, Could you make similar changes in ugl? -Original Message- From: Michel Dänzer Sent: Thursday, March 07, 2019 5:05 PM To: Cui, Flora ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] remove amdgpu_vrr_atom Hi Flora, note

[PATCH] remove amdgpu_vrr_atom

2019-03-06 Thread Cui, Flora
it doesn't work as expected Change-Id: I21c4a5251105f8293686a5d6331b7c23e02854e9 Signed-off-by: Flora Cui --- src/amdgpu_kms.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c index 74d5806..54d7e9e 100644 --- a/src/amdgpu_kms.c +++

[PATCH v2] tests/amdgpu: add deadlock test for sdma

2019-03-05 Thread Cui, Flora
deadlock test for sdma will cause gpu recoverty. disable the test for now until GPU reset recovery could survive at least 1000 times test. v2: add modprobe parameter Change-Id: I9adac63c62db22107345eddb30e7d81a1bda838c Signed-off-by: Flora Cui --- tests/amdgpu/amdgpu_test.c| 4 ++

[PATCH libdrm] tests/amdgpu: add deadlock test for sdma

2019-03-05 Thread Cui, Flora
deadlock test for sdma will cause gpu recoverty. disable the test for now until GPU reset recovery could survive at least 1000 times test. Change-Id: I9adac63c62db22107345eddb30e7d81a1bda838c Signed-off-by: Flora Cui --- tests/amdgpu/amdgpu_test.c| 4 ++ tests/amdgpu/deadlock_tests.c |

[PATCH libdrm 1/2] tests/amdgpu: add memset dispatch test

2019-02-27 Thread Cui, Flora
add memset dispatch test for gfx9 Change-Id: If607fbd9c6e49ca830a662adc24fe6b1e2a25bfb Signed-off-by: Flora Cui Tested-by: Rui Teng --- tests/amdgpu/basic_tests.c | 215 - 1 file changed, 213 insertions(+), 2 deletions(-) diff --git

[PATCH libdrm 2/2] tests/amdgpu: add memcpy dispatch test

2019-02-27 Thread Cui, Flora
add memcpy dispatch test for gfx9 Change-Id: If433434c5378f3b318209d4e28c19d7ce9cff1a2 Signed-off-by: Flora Cui Tested-by: Rui Teng --- tests/amdgpu/basic_tests.c | 129 + 1 file changed, 129 insertions(+) diff --git a/tests/amdgpu/basic_tests.c

RE: [PATCH libdrm] tests/amdgpu: add dispatch test

2019-02-24 Thread Cui, Flora
OK. I'll prepare the patch base on master once the tests are finished. -Original Message- From: Alex Deucher Sent: Saturday, February 23, 2019 4:55 AM To: Zhang, Hawking Cc: Cui, Flora ; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Subject: Re: [PATCH libdrm] tests

[PATCH libdrm] tests/amdgpu: add dispatch test

2019-02-17 Thread Cui, Flora
From: Flora Cui Change-Id: I6f5dfa4379cb21c41c68757fae0105527a03e54f Signed-off-by: Flora Cui --- tests/amdgpu/basic_tests.c | 175 - 1 file changed, 173 insertions(+), 2 deletions(-) diff --git a/tests/amdgpu/basic_tests.c

RE: [PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants

2018-11-23 Thread Cui, Flora
Patch is Reviewed-by: Flora Cui -Original Message- From: amd-gfx On Behalf Of Junwei Zhang Sent: Friday, November 23, 2018 4:32 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry Subject: [PATCH] drm/amdgpu: disable UVD/VCE for some polaris 12 variants Some variants don't support

RE: [PATCH 2/7] drm/amdgpu/gfx6: clean up cu configuration

2017-02-07 Thread Cui, Flora
Just follow the same routine as in gfx7/gfx8. I suppose this could be fixed with another patch. Regards, Flora -Original Message- From: Zhang, Hawking Sent: Wednesday, February 08, 2017 11:47 AM To: Cui, Flora <flora@amd.com>; amd-gfx@lists.freedesktop.org Cc: Cui, Flora

RE: [PATCH 2/2] drm/amdgpu: update pitcairn golden setting

2016-12-14 Thread Cui, Flora
Yes. I'm working on this. Regards, Flora -Original Message- From: Zhang, Jerry Sent: Thursday, December 15, 2016 2:43 PM To: Cui, Flora <flora@amd.com>; amd-gfx@lists.freedesktop.org Cc: Cui, Flora <flora@amd.com> Subject: RE: [PATCH 2/2] drm/amdgpu: update pit