On 1/18/2023 7:27 AM, Christian König wrote:
Am 17.01.23 um 19:12 schrieb Das, Nirmoy:
Hi Alex,
On 1/17/2023 7:06 PM, Alex Deucher wrote:
On Tue, Jan 17, 2023 at 1:05 PM Nirmoy Das
wrote:
There are no current users of DRM_DEBUG_KMS_RATELIMITED()
so remove it.
Cc: Maarten Lankhorst
Cc
Hi Alex,
On 1/17/2023 7:06 PM, Alex Deucher wrote:
On Tue, Jan 17, 2023 at 1:05 PM Nirmoy Das wrote:
There are no current users of DRM_DEBUG_KMS_RATELIMITED()
so remove it.
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
Cc: Sam Ravnborg
On 1/17/2023 6:48 PM, Alex Deucher wrote:
On Tue, Jan 17, 2023 at 12:45 PM Nirmoy Das wrote:
Replace deprecated DRM_DEBUG_KMS_RATELIMITED() and DRM_ERROR()
with proper APIs.
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/radeon/radeon_dp_auxch.c | 5
memory to uninitialized GART !
Could you please also try https://patchwork.freedesktop.org/patch/469907/ ?
Regards,
Nirmoy
+@Das, Nirmoy
The only thing that touched that file recently was
72f686438de13f121c52f58d7445570a33dfdc61
Could you see if backing that out helps?
Here's
Reviewed-by: Nirmoy Das
On 1/13/2022 7:17 AM, Dan Carpenter wrote:
These if statements need to be indented.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
On 1/13/2022 1:12 PM, Christian König wrote:
Am 13.01.22 um 13:06 schrieb Nirmoy Das:
GEM code should not deal with struct amdgpu_bo_va's ref_count.
Move ref counting to amdgpu_vm.c.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 11 +++
LGTM acked-by: Nirmoy Das
On 1/12/2022 7:52 PM, Jonathan Kim wrote:
Some suggested cleanups to declutter ttm when doing debug VRAM access over
SDMA.
v2: rename post_mortem_allowed func to has_timeouts_enable.
Signed-off-by: Jonathan Kim
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 9
LGTM Acked-by: Nirmoy Das
On 12/22/2021 3:19 PM, Guchun Chen wrote:
amdgpu_umc_poison_handler for UMC RAS consumption gets
called in KFD queue reset, but it needs to return early when
RAS context is NULL. This can guarantee lower access to
RAS context like in amdgpu_umc_do_page_retirement.
On 11/5/2021 3:17 PM, Alex Deucher wrote:
On Fri, Nov 5, 2021 at 10:09 AM Nirmoy Das wrote:
There is a HW bug which prevents CP to read secure buffers
with HIQ being configured and mapped using KIQ. KFD already
does this for amdgpu but when kfd is not enabled amdgpu
should that for itself.
Acked-by: Nirmoy Das
On 10/28/2021 3:26 PM, Christian König wrote:
Don't touch the exclusive fence manually here, but rather use the
general dma_resv function. We did that for better hw reset handling but
this doesn't necessary work correctly.
Signed-off-by: Christian König
---
On 11/2/2021 12:33 PM, Christian König wrote:
Am 02.11.21 um 12:18 schrieb Lazar, Lijo:
On 11/2/2021 4:39 PM, Christian König wrote:
Am 02.11.21 um 11:11 schrieb Das, Nirmoy:
On 11/2/2021 9:00 AM, Lazar, Lijo wrote:
On 10/29/2021 8:39 PM, Nirmoy Das wrote:
We set WC memtype
On 11/2/2021 9:00 AM, Lazar, Lijo wrote:
On 10/29/2021 8:39 PM, Nirmoy Das wrote:
We set WC memtype for aper_base but don't check return value
of arch_io_reserve_memtype_wc(). Be more defensive and return
early on error.
Signed-off-by: Nirmoy Das
---
ping!
On 10/22/2021 1:03 PM, Nirmoy Das wrote:
amdgpu_ttm_backend_bind() only needed for TTM_PL_TT
and AMDGPU_PL_PREEMPT.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
On 10/22/2021 1:46 PM, Christian König wrote:
Reviewed-by: Christian König for the entire
series.
But please keep in mind that this here needs extensive testing.
I will do multiple round of test again on gfx7-10 cards and gfx9 APU
that I have but I don't have gfx6 and sriov cards to
On 10/20/2021 1:51 PM, Christian König wrote:
Am 20.10.21 um 13:50 schrieb Christian König:
Am 13.10.21 um 17:09 schrieb Nirmoy Das:
GTT BO cleanup code is with in the test for loop and
we would skip cleaning up GTT BO on success.
Reported-by: zhang
Signed-off-by: Nirmoy Das
---
On 10/20/2021 12:49 PM, Christian König wrote:
Am 20.10.21 um 11:19 schrieb Lazar, Lijo:
On 10/20/2021 2:18 PM, Das, Nirmoy wrote:
On 10/20/2021 8:49 AM, Christian König wrote:
Am 19.10.21 um 20:14 schrieb Nirmoy Das:
Do not allow exported amdgpu_gtt_mgr_*() to accept
any
On 10/20/2021 12:51 PM, Christian König wrote:
Am 20.10.21 um 12:21 schrieb Das, Nirmoy:
On 10/20/2021 12:15 PM, Lazar, Lijo wrote:
On 10/20/2021 3:42 PM, Das, Nirmoy wrote:
On 10/20/2021 12:03 PM, Lazar, Lijo wrote:
On 10/20/2021 3:23 PM, Das, Nirmoy wrote:
On 10/20/2021 11:11
On 10/20/2021 12:15 PM, Lazar, Lijo wrote:
On 10/20/2021 3:42 PM, Das, Nirmoy wrote:
On 10/20/2021 12:03 PM, Lazar, Lijo wrote:
On 10/20/2021 3:23 PM, Das, Nirmoy wrote:
On 10/20/2021 11:11 AM, Lazar, Lijo wrote:
On 10/19/2021 11:44 PM, Nirmoy Das wrote:
Get rid off pin/unpin
On 10/20/2021 12:03 PM, Lazar, Lijo wrote:
On 10/20/2021 3:23 PM, Das, Nirmoy wrote:
On 10/20/2021 11:11 AM, Lazar, Lijo wrote:
On 10/19/2021 11:44 PM, Nirmoy Das wrote:
Get rid off pin/unpin of gart BO at resume/suspend and
instead pin only once and try to recover gart content
On 10/20/2021 11:11 AM, Lazar, Lijo wrote:
On 10/19/2021 11:44 PM, Nirmoy Das wrote:
Get rid off pin/unpin of gart BO at resume/suspend and
instead pin only once and try to recover gart content
at resume time. This is much more stable in case there
is OOM situation at 2nd call to
ping.
On 10/13/2021 5:09 PM, Nirmoy Das wrote:
GTT BO cleanup code is with in the test for loop and
we would skip cleaning up GTT BO on success.
Reported-by: zhang
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_test.c | 25
1 file changed, 12
On 10/20/2021 8:49 AM, Christian König wrote:
Am 19.10.21 um 20:14 schrieb Nirmoy Das:
Do not allow exported amdgpu_gtt_mgr_*() to accept
any ttm_resource_manager pointer. Also there is no need
to force other module to call a ttm function just to
eventually call gtt_mgr functions.
That's a
On 10/20/2021 8:52 AM, Christian König wrote:
Am 19.10.21 um 20:14 schrieb Nirmoy Das:
Get rid off pin/unpin of gart BO at resume/suspend and
instead pin only once and try to recover gart content
at resume time. This is much more stable in case there
is OOM situation at 2nd call to
On 10/19/2021 5:43 PM, Christian König wrote:
Am 19.10.21 um 15:22 schrieb Nirmoy Das:
Get rid off pin/unpin and evict and swap back gart
page table which should make things less likely to break.
Also remove 2nd call to amdgpu_device_evict_resources()
as we don't need it.
Signed-off-by:
On 10/13/2021 2:29 PM, Christian König wrote:
Am 12.10.21 um 15:12 schrieb Das, Nirmoy:
On 10/12/2021 1:58 PM, Stanley.Yang wrote:
Test scenario:
modprobe amdgpu -> rmmod amdgpu -> modprobe amdgpu
Error log:
[ 54.396807] debugfs: File 'page_pool' in directory 'amdttm'
a
Please ignore this!
On 10/13/2021 5:04 PM, Nirmoy Das wrote:
When gart size is < gtt size this test will fail with
-ENOMEM as we are not freeing gtt bo after each move test.
This is generally not an issue when gart size >= gtt size.
Reported-by: zhang
Signed-off-by: Nirmoy Das
---
On 10/13/2021 12:42 PM, Das, Nirmoy wrote:
On 10/13/2021 3:22 AM, zhang wrote:
Hi . Nirmoy
If you let continue to unpin. this will allways test a same va for gtt
I think we should rafresh calculate the value n
Right, I guess then the test should only run till gart size.
Actually
LGTM as we create a gem object 1st and retrieve amdgpu_bo from the gem
object.
Acked-by: Nirmoy Das
On 10/13/2021 9:28 AM, Lang Yu wrote:
We should unreference a gem object instead of an amdgpu bo here.
Fixes: 5ae0283e831a ("drm/amdgpu: Add userptr support for KFD")
Signed-off-by: Lang Yu
On 10/13/2021 3:22 AM, zhang wrote:
Hi . Nirmoy
If you let continue to unpin. this will allways test a same va for gtt
I think we should rafresh calculate the value n
Right, I guess then the test should only run till gart size.
Regards,
Nirmoy
On 2021/10/12 20:10, Nirmoy Das
On 10/12/2021 1:58 PM, Stanley.Yang wrote:
Test scenario:
modprobe amdgpu -> rmmod amdgpu -> modprobe amdgpu
Error log:
[ 54.396807] debugfs: File 'page_pool' in directory 'amdttm' already
present!
[ 54.396833] debugfs: File 'page_pool_shrink' in directory 'amdttm'
already
On 10/7/2021 12:38 PM, Christian König wrote:
Am 07.10.21 um 12:00 schrieb Nirmoy Das:
Unify BO evicting functionality for possible memory
types in amdgpu_ttm.c.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 8 +++---
On 10/6/2021 4:58 PM, Christian König wrote:
Am 06.10.21 um 16:45 schrieb Nirmoy Das:
Unify BO evicting functionality for VRAM and TT memory
types in amdgpu_object.c. Use amdgpu_bo_evict_gtt()
for evicting gtt memory similar to how we do that
for amdgpu_debugfs_evict_vram().
Signed-off-by:
On 10/6/2021 1:55 PM, Lazar, Lijo wrote:
On 10/6/2021 3:21 PM, Nirmoy Das wrote:
Check first if debugfs is initialized before creating
amdgpu debugfs files.
References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686
Signed-off-by: Nirmoy Das
---
PM, Christian König wrote:
Am 05.10.21 um 15:49 schrieb Das, Nirmoy:
On 10/5/2021 3:22 PM, Christian König wrote:
Am 05.10.21 um 15:11 schrieb Nirmoy Das:
Debugfs core APIs will throw -EPERM when user disables debugfs
using CONFIG_DEBUG_FS_ALLOW_NONE or with kernel param. We
shouldn't
see
On 10/5/2021 3:22 PM, Christian König wrote:
Am 05.10.21 um 15:11 schrieb Nirmoy Das:
Debugfs core APIs will throw -EPERM when user disables debugfs
using CONFIG_DEBUG_FS_ALLOW_NONE or with kernel param. We shouldn't
see that as an error. Also validate drm root dentry before creating
amdgpu
On 10/5/2021 2:41 PM, Christian König wrote:
Am 05.10.21 um 14:20 schrieb Das, Nirmoy:
Hi Christian,
On 10/5/2021 2:01 PM, Christian König wrote:
Am 05.10.21 um 13:58 schrieb Nirmoy Das:
drm_dev_register() will try to init driver's debugfs using
drm_driver.debugfs_init call back function
Hi Christian,
On 10/5/2021 2:01 PM, Christian König wrote:
Am 05.10.21 um 13:58 schrieb Nirmoy Das:
drm_dev_register() will try to init driver's debugfs using
drm_driver.debugfs_init call back function. Use that callback
also for amdgpu to intialize debugfs.
Mhm, why is that useful? We
On 10/5/2021 2:01 PM, Christian König wrote:
Am 05.10.21 um 13:58 schrieb Nirmoy Das:
drm_dev_register() will try to init driver's debugfs using
drm_driver.debugfs_init call back function. Use that callback
also for amdgpu to intialize debugfs.
Mhm, why is that useful? We rather wanted to
On 10/5/2021 1:58 PM, Nirmoy Das wrote:
drm_dev_register() will try to init driver's debugfs using
drm_driver.debugfs_init call back function. Use that callback
also for amdgpu to intialize debugfs.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 10 +-
Acked-by: Nirmoy Das
On 9/30/2021 11:26 AM, Christian König wrote:
This reverts commit 728e7e0cd61899208e924472b9e641dbeb0775c4.
Further discussion reveals that this feature is severely broken
and needs to be reverted ASAP.
GPU reset can never be delayed by userspace even for debugging or
On 9/6/2021 6:45 PM, Sharma, Shashank wrote:
On 9/5/2021 5:01 PM, Das, Nirmoy wrote:
On 9/5/2021 10:03 AM, Sharma, Shashank wrote:
On 9/3/2021 9:44 PM, Das, Nirmoy wrote:
Hi Shashank,
On 9/3/2021 5:51 PM, Das, Nirmoy wrote:
On 9/3/2021 5:26 PM, Sharma, Shashank wrote:
On 9/3/2021
Acked-by: Nirmoy Das for the 1st patch and second
patch is
Reviewed-by: Nirmoy Das
On 9/7/2021 10:14 AM, Christian König wrote:
The memory backing old_mem is already freed at that point, move the
check a bit more up.
Signed-off-by: Christian König
Fixes: bfa3357ef9ab ("drm/ttm: allocate
On 9/5/2021 10:03 AM, Sharma, Shashank wrote:
On 9/3/2021 9:44 PM, Das, Nirmoy wrote:
Hi Shashank,
On 9/3/2021 5:51 PM, Das, Nirmoy wrote:
On 9/3/2021 5:26 PM, Sharma, Shashank wrote:
On 9/3/2021 1:39 PM, Das, Nirmoy wrote:
On 9/3/2021 8:36 AM, Sharma, Shashank wrote:
On 9/2/2021
Hi Shashank,
On 9/3/2021 5:51 PM, Das, Nirmoy wrote:
On 9/3/2021 5:26 PM, Sharma, Shashank wrote:
On 9/3/2021 1:39 PM, Das, Nirmoy wrote:
On 9/3/2021 8:36 AM, Sharma, Shashank wrote:
On 9/2/2021 5:14 PM, Nirmoy Das wrote:
Use debugfs_create_file_size API for creating ring debugfs
file
On 9/3/2021 5:26 PM, Sharma, Shashank wrote:
On 9/3/2021 1:39 PM, Das, Nirmoy wrote:
On 9/3/2021 8:36 AM, Sharma, Shashank wrote:
On 9/2/2021 5:14 PM, Nirmoy Das wrote:
Use debugfs_create_file_size API for creating ring debugfs
file, also cleanup surrounding code.
Signed-off
Hi Christian and Shashank,
Please review the v2 : https://patchwork.freedesktop.org/patch/452175/
In v2, I am returning "PTR_ERR(ent)" instead of -EIO which I think makes more
sense.
Regards,
Nirmoy
On 9/3/2021 9:53 AM, Christian König wrote:
Am 02.09.21 um 13:44 schrieb Nirmoy Das:
On 9/3/2021 8:36 AM, Sharma, Shashank wrote:
On 9/2/2021 5:14 PM, Nirmoy Das wrote:
Use debugfs_create_file_size API for creating ring debugfs
file, also cleanup surrounding code.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 +---
On 8/26/2021 12:48 PM, Christian König wrote:
Am 26.08.21 um 12:08 schrieb Nirmoy Das:
Currently AMDGPU_RING_PRIO_MAX is redefinition of a
max gfx hwip priority, this won't work well when we will
have a hwip with different set of priorities than gfx.
Also, HW ring priorities are different
On 8/26/2021 11:54 AM, Christian König wrote:
Am 26.08.21 um 11:27 schrieb Lazar, Lijo:
On 8/25/2021 9:12 PM, Nirmoy Das wrote:
Currently AMDGPU_RING_PRIO_MAX is redefinition of a
max gfx hwip priority, this won't work well when we will
have a hwip with different set of priorities than gfx.
On 8/26/2021 11:27 AM, Lazar, Lijo wrote:
On 8/25/2021 9:12 PM, Nirmoy Das wrote:
Currently AMDGPU_RING_PRIO_MAX is redefinition of a
max gfx hwip priority, this won't work well when we will
have a hwip with different set of priorities than gfx.
Also, HW ring priorities are different from
On 8/25/2021 2:29 PM, Christian König wrote:
Am 25.08.21 um 14:20 schrieb Lazar, Lijo:
On 8/25/2021 4:52 PM, Nirmoy Das wrote:
To get a hardware queue priority for a context, we are currently
mapping AMDGPU_CTX_PRIORITY_* to DRM_SCHED_PRIORITY_* and then
to hardware queue priority, which is
On 8/25/2021 1:09 PM, Christian König wrote:
I suggest to give this command here at least a try (remembered the
name after a moment):
pahole drivers/gpu/drm/amd/amdgpu/amdgpu.o -C amdgpu_debugfs_regs2_iocdata
It has a rather nifty output with padding holes, byte addresses, cache
lines etc
On 8/24/2021 3:18 PM, Christian König wrote:
Am 24.08.21 um 14:39 schrieb Das, Nirmoy:
On 8/24/2021 2:07 PM, Christian König wrote:
Am 24.08.21 um 13:57 schrieb Das, Nirmoy:
Hi Christian,
On 8/24/2021 8:10 AM, Christian König wrote:
I haven't followed the previous discussion
On 8/24/2021 2:07 PM, Christian König wrote:
Am 24.08.21 um 13:57 schrieb Das, Nirmoy:
Hi Christian,
On 8/24/2021 8:10 AM, Christian König wrote:
I haven't followed the previous discussion, but that looks like this
change is based on a misunderstanding.
In previous discussion I sort
Hi Christian,
On 8/24/2021 8:10 AM, Christian König wrote:
I haven't followed the previous discussion, but that looks like this
change is based on a misunderstanding.
In previous discussion I sort of suggested to have new DRM prio as I
didn't see any other way to map priority provided by
On 8/10/2021 11:38 AM, Sahu, Satyajit wrote:
On 8/10/2021 2:01 PM, Das, Nirmoy wrote:
On 8/10/2021 9:09 AM, Satyajit Sahu wrote:
VCN and VCE support multiple queues with different priority.
Use differnt encoder queue based on the priority set by UMD.
Signed-off-by: Satyajit Sahu
On 8/10/2021 9:09 AM, Satyajit Sahu wrote:
VCN and VCE support multiple queues with different priority.
Use differnt encoder queue based on the priority set by UMD.
Signed-off-by: Satyajit Sahu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 35 +--
Happy to help, Christian :)
Nirmoy
On 7/6/2021 5:33 PM, Christian Zigotzky wrote:
Hi Nirmoy,
This patch works! Thanks a lot! We tested it on an A-EON AmigaOne
X5000/20 today.
Screenshot:
Hi Christian,
This issue looks similar to the one Mikel Rychliski fixed recently :
https://patchwork.freedesktop.org/patch/440791. Let us know if this helps.
Regards,
Nirmoy
On 7/3/2021 9:30 AM, Christian Zigotzky wrote:
Hi All,
Xorg doesn't work anymore after the latest DRM updates.
Please describe bit more with a commit message.
On 7/1/2021 6:37 AM, Emily Deng wrote:
Signed-off-by: Emily Deng
Signed-off-by: Victor
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
On 6/29/2021 7:40 PM, Christian König wrote:
Am 29.06.21 um 17:19 schrieb Nirmoy Das:
Replace idr with xarray as we actually need hash functionality.
Cleanup code related to vm pasid by adding helper function.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 149
LGTM
Acked-by: Nirmoy Das
On 6/29/2021 3:58 PM, Thomas Zimmermann wrote:
Print the name of the DRM driver when taking over fbdev devices. Makes
the output to dmesg more consistent. Note that the driver name is only
used for printing a string to the kernel log. No UAPI is affected by this
Hi Christian,
Could you please pick this up for drm-misc-next or fixes ?
Regards,
Nirmoy
On 6/29/2021 1:44 PM, Nirmoy Das wrote:
Return early for non-TTM_PL_TT BOs so that we don't pass
wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes
ttm_resource argument to be TTM_PL_TT
On 6/29/2021 1:06 PM, Christian König wrote:
Am 29.06.21 um 09:36 schrieb Nirmoy Das:
Be more defensive and raise error on wrong mem_type
argument in amdgpu_gtt_mgr_has_gart_addr().
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +-
1 file changed, 5
Thanks for the detailed commit message :)
Acked-by: Nirmoy Das
On 6/29/2021 1:15 AM, Oak Zeng wrote:
The ttm caching flags (ttm_cached, ttm_write_combined etc) are
used to determine a buffer object's mapping attributes in both
CPU page table and GPU page table (when that buffer is also
On 6/29/2021 1:12 PM, Christian König wrote:
Am 29.06.21 um 09:55 schrieb Nirmoy Das:
VM code should not be responsible for freeing pasid as pasid
gets allocated outside of VM code, before initializing a vm.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 8
On 6/29/2021 1:10 PM, Christian König wrote:
Am 29.06.21 um 09:49 schrieb Nirmoy Das:
Replace idr with xarray as we actually need hash functionality.
Cleanup code related to vm pasid by adding helper function.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 136
On 6/29/2021 1:05 PM, Christian König wrote:
Am 29.06.21 um 09:36 schrieb Nirmoy Das:
Return early for non-TTM_PL_TT BOs so that we don't pass
wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes
ttm_resource argument to be TTM_PL_TT type BO's.
v2: merge if-conditions
Signed-off-by:
On 6/23/2021 9:05 PM, Felix Kuehling wrote:
On 2021-06-23 8:25 a.m., Nirmoy Das wrote:
VM code should not be responsible for freeing pasid as pasid
gets allocated outside of VM code, before initializing a vm.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c |
On 6/23/2021 5:02 PM, Christian König wrote:
Am 23.06.21 um 16:54 schrieb Das, Nirmoy:
On 6/23/2021 3:40 PM, Christian König wrote:
Am 23.06.21 um 15:11 schrieb Das, Nirmoy:
On 6/23/2021 2:50 PM, Christian König wrote:
Am 23.06.21 um 14:25 schrieb Nirmoy Das:
Replace idr
On 6/23/2021 3:40 PM, Christian König wrote:
Am 23.06.21 um 15:11 schrieb Das, Nirmoy:
On 6/23/2021 2:50 PM, Christian König wrote:
Am 23.06.21 um 14:25 schrieb Nirmoy Das:
Replace idr with xarray as we actually need hash functionality.
Cleanup code related to vm pasid by adding helper
On 6/23/2021 2:50 PM, Christian König wrote:
Am 23.06.21 um 14:25 schrieb Nirmoy Das:
Replace idr with xarray as we actually need hash functionality.
Cleanup code related to vm pasid by adding helper function.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 134
On 6/23/2021 10:23 AM, Christian König wrote:
Am 23.06.21 um 09:56 schrieb Nirmoy Das:
Cleanup code related to vm pasid by adding helper functions.
Also replace idr with xarray as we actually need hash functionality.
That looks quite a bit better than before, but I think we should
approach
On 6/22/2021 12:36 PM, Christian König wrote:
Am 22.06.21 um 12:30 schrieb Das, Nirmoy:
On 6/22/2021 10:36 AM, Christian König wrote:
Am 22.06.21 um 09:39 schrieb Das, Nirmoy:
On 6/22/2021 9:03 AM, Christian König wrote:
Am 22.06.21 um 08:57 schrieb Nirmoy Das:
Cleanup code related
On 6/22/2021 10:36 AM, Christian König wrote:
Am 22.06.21 um 09:39 schrieb Das, Nirmoy:
On 6/22/2021 9:03 AM, Christian König wrote:
Am 22.06.21 um 08:57 schrieb Nirmoy Das:
Cleanup code related to vm pasid by adding helper functions.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd
On 6/22/2021 9:03 AM, Christian König wrote:
Am 22.06.21 um 08:57 schrieb Nirmoy Das:
Cleanup code related to vm pasid by adding helper functions.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 105 -
1 file changed, 50 insertions(+), 55
On 6/21/2021 1:35 PM, Christian König wrote:
Am 21.06.21 um 13:27 schrieb Das, Nirmoy:
On 6/21/2021 1:18 PM, Christian König wrote:
Am 21.06.21 um 13:10 schrieb Das, Nirmoy:
On 6/21/2021 12:59 PM, Christian König wrote:
Am 21.06.21 um 12:56 schrieb Das, Nirmoy:
On 6/21/2021 12:26 PM
On 6/21/2021 1:18 PM, Christian König wrote:
Am 21.06.21 um 13:10 schrieb Das, Nirmoy:
On 6/21/2021 12:59 PM, Christian König wrote:
Am 21.06.21 um 12:56 schrieb Das, Nirmoy:
On 6/21/2021 12:26 PM, Christian König wrote:
Well you completely break the handling in amdgpu_vm_handle_fault
On 6/21/2021 12:59 PM, Christian König wrote:
Am 21.06.21 um 12:56 schrieb Das, Nirmoy:
On 6/21/2021 12:26 PM, Christian König wrote:
Well you completely break the handling in amdgpu_vm_handle_fault()
with this.
I see one issue with: if (!vm || (vm && vm->root.bo !=
istian.
Am 21.06.21 um 11:47 schrieb Das, Nirmoy:
ping.
On 6/17/2021 3:03 PM, Nirmoy Das wrote:
Cleanup code related to vm pasid by adding helper function.
This reduces lots code duplication.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 17 +--
drivers/gpu/drm
ping.
On 6/17/2021 3:03 PM, Nirmoy Das wrote:
Cleanup code related to vm pasid by adding helper function.
This reduces lots code duplication.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 17 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 176
On 6/21/2021 12:59 PM, Christian König wrote:
Am 21.06.21 um 12:56 schrieb Das, Nirmoy:
On 6/21/2021 12:26 PM, Christian König wrote:
Well you completely break the handling in amdgpu_vm_handle_fault()
with this.
I see one issue with: if (!vm || (vm && vm->root.bo !=
On 6/15/2021 1:57 PM, Christian König wrote:
Am 15.06.21 um 13:51 schrieb Nirmoy Das:
Move shadow_list to struct amdgpu_bo_vm as shadow BOs
are part of PT/PD BOs.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
On 6/15/2021 12:48 PM, Christian König wrote:
Am 15.06.21 um 11:23 schrieb Nirmoy Das:
Make provision to pass different ttm BO destroy callback
while creating a amdgpu_bo.
v2: remove whitespace.
call amdgpu_bo_destroy_base() at the end for cleaner code.
Signed-off-by: Nirmoy Das
---
On 6/15/2021 12:33 PM, Nirmoy Das wrote:
Remove it.
CC: jonathan@amd.com
CC: felix.kuehl...@amd.com
Fixes: d7b132507384c("drm/amdkfd: fix circular locking on get_wave_state")
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 3 +--
1 file changed, 1
ping.
On 6/14/2021 2:31 PM, Nirmoy Das wrote:
Page table entries are now in embedded in VM BO, so
we do not need struct amdgpu_vm_pt. This patch replaces
struct amdgpu_vm_pt with struct amdgpu_vm_bo_base.
v2: change "!(cursor->level < AMDGPU_VM_PTB)" --> "(cursor->level ==
AMDGPU_VM_PTB)"
On 6/14/2021 10:00 PM, Alex Deucher wrote:
On Mon, Jun 14, 2021 at 3:27 PM Nirmoy Das wrote:
Make provision to pass different ttm BO destroy callback
while creating a amdgpu_bo.
v2: pass destroy callback using amdgpu_bo_param.
Signed-off-by: Nirmoy Das
---
On 6/15/2021 8:53 AM, Christian König wrote:
Am 14.06.21 um 21:26 schrieb Nirmoy Das:
Make provision to pass different ttm BO destroy callback
while creating a amdgpu_bo.
v2: pass destroy callback using amdgpu_bo_param.
Signed-off-by: Nirmoy Das
---
On 6/14/2021 7:10 PM, Christian König wrote:
Am 14.06.21 um 16:32 schrieb Nirmoy Das:
Make provision to pass different ttm BO destroy callback
while creating a amdgpu_bo.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 28 ++
1 file
On 6/14/2021 4:32 PM, Nirmoy Das wrote:
Make provision to pass different ttm BO destroy callback
while creating a amdgpu_bo.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 28 ++
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git
ping.
On 6/10/2021 7:24 PM, Nirmoy Das wrote:
Page table entries are now in embedded in VM BO, so
we do not need struct amdgpu_vm_pt. This patch replaces
struct amdgpu_vm_pt with struct amdgpu_vm_bo_base.
Signed-off-by: Nirmoy Das
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 26 +--
Regards,
Oak
On 2021-06-08, 8:02 AM, "amd-gfx on behalf of Das, Nirmoy"
wrote:
On 6/8/2021 1:42 PM, Christian König wrote:
>
>
> Am 08.06.21 um 13:27 schrieb Nirmoy Das:
>> Fixes handling when page tables are in system memory.
>&
On 6/8/2021 1:42 PM, Christian König wrote:
Am 08.06.21 um 13:27 schrieb Nirmoy Das:
Fixes handling when page tables are in system memory.
v2: remove unwanted variable.
change amdgpu_amdkfd_validate instead of amdgpu_amdkfd_bo_validate.
Signed-off-by: Nirmoy Das
---
On 6/8/2021 11:37 AM, Christian König wrote:
Am 08.06.21 um 11:32 schrieb Nirmoy Das:
Remove fixed domain and use BO's allowed domain for PT/PD
BO validation.
"Fixes handling when page tables are in system memory".
And I think you can now remove the validate structure as well.
Do you
Reviewed-by: Nirmoy Das
On 6/5/2021 4:51 PM, Christian König wrote:
For GTT allocations with a GART address the res contains the VMID0
addresses and can't be used for VM handling.
So ignore the res when the pages array is given or we fill the page
tables with nonsense.
Signed-off-by:
PM
To: Das, Nirmoy ; Zhu, Changfeng ; Huang,
Ray ; amd-...@freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: take back kvmalloc_array for entries alloc
because of kzalloc memory limit
Am 02.06.21 um 10:54 schrieb Das, Nirmoy:
On 6/2/2021 10:30 AM, Changfeng wrote:
From: changzhu
From
On 6/2/2021 10:57 AM, Christian König wrote:
Am 02.06.21 um 10:54 schrieb Das, Nirmoy:
On 6/2/2021 10:30 AM, Changfeng wrote:
From: changzhu
From: Changfeng
It will cause error when alloc memory larger than 128KB in
amdgpu_bo_create->kzalloc.
I wonder why I didn't see the er
On 6/2/2021 10:30 AM, Changfeng wrote:
From: changzhu
From: Changfeng
It will cause error when alloc memory larger than 128KB in
amdgpu_bo_create->kzalloc.
I wonder why I didn't see the error on my machine. Is there any config I
might be missing ?
Thanks,
Nirmoy
Call Trace:
On 5/28/2021 5:28 PM, Christian König wrote:
Am 27.05.21 um 14:14 schrieb Nirmoy Das:
Uuse WARN_ON() inside if-condition when possible.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff
On 5/28/2021 5:59 PM, Christian König wrote:
Am 28.05.21 um 17:54 schrieb Nirmoy Das:
Don't flush gart changes after recovering each BO instead
do it after recovering all the BOs. Flishing gart also needed
for amdgpu_ttm_alloc_gart().
v3: rename amdgpu_gart_tlb_flush() ->
1 - 100 of 115 matches
Mail list logo
