[PATCH libdrm] amdgpu: Use the canonical form in branch predicate

Suggested-by: Emil Velikov <emil.l.veli...@gmail.com> Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- amdgpu/amdgpu_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c index 0993a6d..868eb7b 100644

Re: [PATCH] drm/amd/powerplay: add error message to remind user updating firmware

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/20/2017 05:33 PM, Huang Rui wrote: > Signed-off-by: Huang Rui <ray.hu...@amd.com> > --- > drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +-- > 1 file changed, 5 insertions(+), 2 dele

Re: [PATCH libdrm 1/2] amdgpu: add the interface of waiting multiple fences

On 04/19/2017 04:28 AM, Nicolai Hähnle wrote: > On 18.04.2017 17:47, Edward O'Callaghan wrote: >> On 04/14/2017 12:47 AM, Nicolai Hähnle wrote: >>> From: Nicolai Hähnle <nicolai.haeh...@amd.com> >>> >>> Signed-off-by: Junwei Zhang <jerry.zh...@amd.com

[libdrm] amdgpu/: concisely && consistently check null ptrs in canonical form

Be consistent and use the canonical form while sanity checking null pointers, also combine a few branches for brevity. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- amdgpu/amdgpu_bo.c | 2 +- amdgpu/amdgpu_cs.c | 36 +++-

Re: [PATCH libdrm 1/2] amdgpu: add the interface of waiting multiple fences

On 04/14/2017 12:47 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Signed-off-by: Junwei Zhang > [v2: allow returning the first signaled fence index] > Signed-off-by: monk.liu > [v3: > - cleanup *status setting > - fix

Re: [PATCH umr] Add new AI+ field to RELEASE_MEM decoding

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/17/2017 10:43 PM, Tom St Denis wrote: > As well as add EVENT type decoding to human readable > string. > > Signed-off-by: Tom St Denis <tom.stde...@amd.com> > --- &g

Re: [PATCH umr] Prevent reading sensors far too quickly.

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/12/2017 11:10 PM, Tom St Denis wrote: > On platforms without GPU_POWER sensors the thread reading sensors would > proceed > far too quickly. So it is now rate limited to 50Hz to be consistent. > > Signed

Re: [PATCH umr] Add AI sensors to --top

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 04/07/2017 08:47 PM, Tom St Denis wrote: > Signed-off-by: Tom St Denis <tom.stde...@amd.com> > --- > src/app/top.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff -

Re: [PATCH umr] Add family text for family 141

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/25/2017 01:08 AM, Tom St Denis wrote: > Signed-off-by: Tom St Denis <tom.stde...@amd.com> > --- > src/app/print_config.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/app/print_con

Re: [PATCH] Fix a misspelling of 'acceleration' in amdgpu_kms.c

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/26/2017 12:38 AM, Nicholas Molloy wrote: > --- > src/amdgpu_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c > index 4821e93..c4

Re: [PATCH umr] Add program memory dump to wave status.

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/22/2017 01:11 AM, Tom St Denis wrote: > It will display the leading 4 words up to > the current PC value and then 4 words after. > > Signed-off-by: Tom St Denis <tom.stde...@amd.com> > --- &g

Re: [PATCH 0/6] drm/amdgpu: add get clockgating functions for new asic

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/24/2017 04:47 PM, Huang Rui wrote: > Hi all, > > This patch set adds get_clockgating functions, after that, we can use > debugfs pm to check the dynamic clockgating status. > > Thanks,

Re: [PATCH 000/100] Add Vega10 Support

On 03/21/2017 05:36 PM, Christian König wrote: > Am 21.03.2017 um 00:38 schrieb Tom St Denis: >> On 03/20/2017 06:34 PM, Jan Ziak wrote: >>> On Mon, Mar 20, 2017 at 10:41 PM, Alex Deucher >> > wrote: >>> >>> On Mon, Mar 20, 2017 at 5:36

Re: [PATCH umr] sync up registers/bits with staging tree

ly the one running on your host) > -pk=/nas/work/repos/linux/drivers/gpu/drm/amd/include/asic_reg/ > +if [ "$pk" == "" ]; then > + pk=/nas/work/repos/linux/drivers/gpu/drm/amd/include/asic_reg/ > +fi > Hmm, perhaps this hunk should not be conflated in with the r

Re: [PATCH] drm/amdgpu: bump version for PRT support

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> Alex, as a matter of procedure could you perhaps have the actual version bump as part of the final patch in a given series? This would mitigate the issue of forgetting to bump the version for a given relevant changeset. Kindly,

Re: [PATCH umr] PM4 packets list number of dwords not bytes

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/09/2017 07:03 AM, Tom St Denis wrote: > When counting size of IBs count in dwords... > > Signed-off-by: Tom St Denis <tom.stde...@amd.com> > --- > src/lib/ring_decode.c | 2 +- > 1 file chang

Re: [PATCH 2/2] drm/amdgpu: bump driver version for some new features

On 03/09/2017 10:18 AM, Alex Deucher wrote: > We added new gem ioctl flags and the new fences ioctl, but forgot > to bump the version. Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> Form which commit Alex? perhaps CC stable? > > Signed-off-by: Alex Deuch

Re: [PATCH umr] Fix ring offset to dword instead of bytes

Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/09/2017 03:31 AM, Tom St Denis wrote: > This allows you to specify (say) > > -R gfx[16:32] to read words 16 through 32 which is > consistent with how the data is presented. > > This patch also correctly

Re: [PATCH] drm/amdgpu: fix coding style and printing in amdgpu_doorbell_init

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 03/07/2017 12:54 AM, Christian König wrote: > From: Christian König <christian.koe...@amd.com> > > Based on commit "drm/radeon: remove useless and potentially wrong message". > > The s

Re: [PATCH] drm/amdgpu/powerplay: enable LEDs on Fiji boards

Hi guys, Shouldn't this hook into the "led framework" of the kernel? https://www.kernel.org/doc/Documentation/leds/leds-class.txt Kind Regards, Edward. On 02/24/2017 10:03 AM, Alex Deucher wrote: > On Thu, Feb 23, 2017 at 5:50 PM, Alexandre Demers > wrote: >>

Re: [PATCH] drm/amdgpu: trace amdgpu_job fence details

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/23/2017 10:47 AM, Andres Rodriguez wrote: > This trace is intended to provide the required information to associate > the completion of an amdgpu_job with its corresponding dma_fence_* > tracepoints. > >

Re: [PATCH umr] Simplify --scan and --list-regs syntax

ar *get_block_name(struct umr_asic *asic, char *path) > +{ > + static char asicname[256], block[256], *dot; > + > + memset(asicname, 0, sizeof asicname); > + if ((dot = strstr(path, "."))) { > + memset(block, 0, sizeof block); perhaps mov

Re: [PATCH] drm/amdgpu: add HDMI audio support for si dce6

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/21/2017 09:39 PM, Xiaojie Yuan wrote: > Signed-off-by: Xiaojie Yuan <xiaojie.y...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 130 > +++--- > 1 file ch

Re: [PATCH 17/35] drivers/gpu: Convert remaining uses of pr_warning to pr_warn

;> 20 uses of pr_warn in drivers/gpu >> >> Signed-off-by: Joe Perches <j...@perches.com> > > Acked-by: Christian König <christian.koe...@amd.com>. Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> > >> --- >> drivers/gpu/drm/amd/

Re: [PATCH] amdgpu/powerplay: Fixup printk() usage in pp_debug.h

disregard this, sorry for the noise. On 02/16/2017 07:42 PM, Edward O'Callaghan wrote: > We should properly prefix which kernel module this spewed > from in dmesg for consistency to the user. > > Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> > --- &

Re: [PATCH umr] Add SENSOR for SI/CIK/KV systems.

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/18/2017 06:26 AM, Tom St Denis wrote: > Signed-off-by: Tom St Denis <tom.stde...@amd.com> > --- > src/app/top.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff -

Re: [PATCH 1/1] drm/amdgpu: export gfx capability by gpu info

; Then I send it out for guys review whether to add in the amdgpu_device > directly > or keep current style till we have other features besides gfx. Hmmk, its nothing to stress about I was just more curious about it. Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> Kindly

Re: Change queue/pipe split between amdkfd and amdgpu

On 02/16/2017 03:00 PM, Bridgman, John wrote: > Any objections to authorizing Oded to post the kfdtest binary he is using to > some public place (if not there already) so others (like Andres) can test > changes which touch on amdkfd ? > > We should check it for embarrassing symbols but

Re: [PATCH 1/1] drm/amdgpu: export gfx capability by gpu info

Hi, Question, is this a bit premature to have a new function and struct for this, could it just be put in amdgpu_gfx for now or are we expecting amdgpu_gfx_cap to start growing quickly with far more cap state info? Kind Regards, Edward. On 02/16/2017 01:53 PM, Junwei Zhang wrote: > Change-Id:

Re: [PATCH] Add GPU_POWER sensors

> -//{ "OUTSTANDING_HUB_ATOMIC_RET", 255, 255, _bitfield_default }, >{ "OUTSTANDING_RPB_READ", 255, 255, _bitfield_default }, >{ "OUTSTANDING_RPB_WRITE", 255, 255, _bitfield_default }, > -//{ "OUTSTANDING_RPB_ATOMIC", 255, 255, _

Re: [PATCH] drm/amdgpu: clear framebuffer with GPU

On 02/08/2017 12:24 PM, Pixel Ding wrote: > CPU is not efficient to do this job. There's a failure caused by this > is that handshaking gets timeout of SRIOV virtual function. Can you fixup the commit message a little but otherwise, Reviewed-by: Edward O'Callaghan <funfunc...@folklor

Re: [RFC]: More robust build sys for UMR

utions right off the bat and I would be interested in feedback for that. > > (I'm not saying NAK I'm simply asking for my own edification). Sure sure, this only took me a hour to put together because of _my_ itch so don't stress. > > Thanks, > Tom Kind Regards, Edward.

[PATCH 3/4] README: minor update for cmake buildsys

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- README | 1 + 1 file changed, 1 insertion(+) diff --git a/README b/README index 2700736..7d8b025 100644 --- a/README +++ b/README @@ -32,6 +32,7 @@ To build umr you will need pciaccess and ncurses headers and libraries.

[PATCH 2/4] cmake: Initial build system

V.2: squash in, cmake: Add docs manpage build target cmake: Add install targets cmake: Misc fixes Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- CMakeLists.txt | 40 doc/CMakeLists.txt | 3 ++

[PATCH 4/4] drop orginal Makefile && stub bin/ directory

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- Makefile | 80 --- bin/.keep | 0 2 files changed, 80 deletions(-) delete mode 100644 Makefile delete mode 100644 bin/.keep diff --git a/Makefile b/Makefile d

[RFC]: More robust build sys for UMR

cmake way: `cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr ..` Please kindly review, Edward O'Callaghan (4): [PATCH 1/4] cmake_modules: Add libpciaccess finder [PATCH 2/4] cmake: Initial build system [PATCH 3/4] README: minor update for cmake buildsys [PATCH 4/4] drop orginal Makefile &&

[PATCH 1/4] cmake_modules: Add libpciaccess finder

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- cmake_modules/FindPCIAccess.cmake | 35 +++ 1 file changed, 35 insertions(+) create mode 100644 cmake_modules/FindPCIAccess.cmake diff --git a/cmake_modules/FindPCIAccess.cmake b/cmake_m

Re: [PATCH v5 0/3] Allow ASYNC flip with atomic helpers.

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 02/04/2017 04:46 AM, Alex Deucher wrote: > On Thu, Feb 2, 2017 at 4:56 PM, Andrey Grodzovsky > <andrey.grodzov...@amd.com> wrote: >> This series is a folow-up on >> https://patchwork.kernel.org/patch/

Re: [PATCH libdrm 0/3] some -pro patches for integration

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/29/2017 06:49 AM, Grazvydas Ignotas wrote: > I've taken several patches from amdgpu-pro libdrm that look useful > to me and I think can be applied already. The only things I did was > rebasing, fi

Re: [PATCH v2 0/3] Allow ASYNC flip with atomic helpers.

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/17/2017 04:16 PM, Andrey Grodzovsky wrote: > This series is a folow-up on > https://patchwork.kernel.org/patch/9501787/ > > The first patch makes changes to atomic helpers to allow for > d

Re: More specific libdrm error message

Hi Xie, Perhaps you want to use `fprintf(stderr, "...")` over `printf("..")` and lose the space before the start parenthesis. Also, line wrap your commit message. Side note, use git send-email so that the patch is inline and not a HTML email for easy review and application of the patch. Kind

Re: [PATCH 0/2] drm/amd/amdgpu: locking fixes

this series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/11/2017 06:31 PM, Nicolai Hähnle wrote: > Hi all, > > two fixes for locking issues that I noticed. > > The first one is something that I actually encountered live; it probably > only mat

Re: [PATCH] drm/amd/display: drop min/max wrappers

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/10/2017 09:35 AM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > These aren't needed, and aren't really used in too many places. > > Signed-off-by: Dave Airlie <airl...@redhat.com

Re: [PATCH] drm/amd/display: start using linux hdmi header

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 01/10/2017 10:33 AM, Dave Airlie wrote: > From: Dave Airlie <airl...@redhat.com> > > DAL has defines for things, and it doesn't even use them itself. > > Signed-off-by: Dave Airlie <airl...@redhat.com

Re: [PATCH 01/10] drm/radeon/si: load special ucode for certain MC configs

; > @@ -1746,6 +1749,9 @@ static int si_init_microcode(struct radeon_device *rdev) > default: BUG(); > } > Hi Alex, I suggest just a short one line comment above here and also in the amdgpu patch too explaining what a 'si58_fw' actually means for a non-AMD

Re: [PATCH] drm/amd/amdgpu: fix spelling mistake: "comleted" -> "completed"

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 12/30/2016 12:39 PM, Zhou, David(ChunMing) wrote: > +amd-gfx, patch is Reviewed-by: Chunming Zhou <david1.z...@amd.com> > > -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] &g

Re: [PATCH v2 0/6] drm/amd/powerplay: refine pr_* prints for powerplay

Merry Christmas Huang Rui, This set looks way better and a much more complete solution, good job working though it all! Patches 1-6 are, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> Kindest Regards, Edward. On 12/26/2016 06:56 PM, Huang Rui wrote: > From: Huang Ru

Re: [PATCH 1/2] drm/amd/powerplay: add prefix for all powerplay pr_* prints

On 12/23/2016 08:54 PM, Huang Rui wrote: > On Fri, Dec 23, 2016 at 05:32:58PM +0800, Edward O'Callaghan wrote: >> Hi, >> >> I would say drop all the header relocation churn, it distracts away from >> the functional changes in this commit. Also see inline comments. &

Re: [PATCH 1/2] drm/amd/powerplay: add prefix for all powerplay pr_* prints

Hi, I would say drop all the header relocation churn, it distracts away from the functional changes in this commit. Also see inline comments. With those fixes, Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> Kindest Regards, Edward. On 12/23/2016 01:45 PM, Huang Rui

Re: [PATCH] drm/amdgpu: Remove checking for atombios

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 12/15/2016 07:52 AM, Nils Wallménius wrote: > This is a left over from radeon, amdgpu doesn't support any > non-atombios parts and amdgpu_device_init would bail if the > check for atombios failed anyway. > >

Re: [PATCH] drm/amdgpu: use pin rather than pin_restricted in a few cases

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 12/08/2016 08:17 AM, Alex Deucher wrote: > We don't require a resticted pinning in these cases, so just > use plain pin. > > Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> > --- &g

Re: [PATCH 1/3] drm/amd/amdgpu: Add debugfs support for reading GPRs

Hi Tom, On 12/06/2016 05:36 AM, Tom St Denis wrote: > Implemented for SGPRs for GFX v8 initially. > > Signed-off-by: Tom St Denis > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 + > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 72 > ++

amdgpu: ratelimit on vm faults to avoid spaming console

These are rather minor however should help stop some folks machines grinding to a halt when a userspace application somehow gets the GPU into some horrible state causing the console to fill very quickly. Applies on top of master. Please kindly review, Edward O'Callaghan (2): [PATCH v2 1/2

[PATCH v2 1/2] amdgpu: Use dev_err() over vanilla printk() in vm_decode_fault()

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/

Re: [PATCH 2/2] amdgpu: Use 'dev_err_ratelimited()' over 'dev_err()' on vm faults

On 11/07/2016 02:55 PM, Michel Dänzer wrote: > On 07/11/16 12:47 PM, Edward O'Callaghan wrote: >> It can be the case that upon GPU page faults we start trashing >> the logs, and so let us ratelimit here to avoid that. >> >> Signed-off-by: Edward O'Callaghan &

[PATCH 1/2] amdgpu: Use dev_err() over vanilla printk() in vm_decode_fault()

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/

[PATCH 2/2] amdgpu: Use 'dev_err_ratelimited()' over 'dev_err()' on vm faults

It can be the case that upon GPU page faults we start trashing the logs, and so let us ratelimit here to avoid that. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 8 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 8 d

amdgpu: ratelimit on vm faults to avoid spaming console

These are rather minor however should help stop some folks machines grinding to a halt when a userspace application somehow gets the GPU into some horrible state causing the console to fill very quickly. Applies on top of master. Please kindly review, Edward O'Callaghan (2): [PATCH 1/2] amdgpu

Re: [PATCH 1/2] drm/amd/powerplay: export a function to read fan rpm

Howdy, On 10/30/2016 07:28 AM, Grazvydas Ignotas wrote: > Powerplay hwmgr already has an implementation, all we need to do is to call > it. > > Signed-off-by: Grazvydas Ignotas > --- > drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 18 ++ >

Re: [PATCH] drm/amd/powerplay: don't succeed in getters if fan is missing

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 10/30/2016 07:32 AM, Grazvydas Ignotas wrote: > Otherwise callers end up using uninitialized data. > > Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> > --- > drivers/gpu/drm/amd/powerplay/hwmgr/smu

Re: [PATCH] drm/amdgpu: update kernel-doc for some functions

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 10/24/2016 05:31 AM, Grazvydas Ignotas wrote: > The names were wrong. > > Signed-off-by: Grazvydas Ignotas <nota...@gmail.com> > --- > drivers/gpu/drm/amd/scheduler/sched_fence.c | 4 ++-- > 1 fi

Re: [PATCH] drm/amdgpu: use amdgpu_bo_[create|free]_kernel for wb

Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 10/22/2016 06:31 AM, Alex Deucher wrote: > Rather than open coding it. > > Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 37 > ++

Re: [PATCH] drm/amdgpu/atom: remove a bunch of unused functions

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 10/22/2016 06:55 AM, Alex Deucher wrote: > Leftovers from the radeon. > > Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 82 > -

Re: [PATCH 1/3] x86/pat: export io memory reserve/free api.

On 10/18/2016 07:29 PM, Dave Airlie wrote: > On 18 Oct. 2016 17:23, "Edward O'Callaghan" <funfunc...@folklore1984.net > <mailto:funfunc...@folklore1984.net>> wrote: >> >> NACK, >> >> I think you want to use 'iomap_create_wc()' instead to avo

Re: [PATCH 1/3] x86/pat: export io memory reserve/free api.

NACK, I think you want to use 'iomap_create_wc()' instead to avoid aliasing. Kind Regards, Edward. On 10/18/2016 05:13 PM, Dave Airlie wrote: > From: Dave Airlie > > These functions are needed for gpu/ttm drivers to reserve the > VRAM area as write combined. In a lot of

Re: [PATCH] drm/amdgpu: fix warning in dce_virtual.c

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> if possible can you squash it into the original bad commit? On 10/15/2016 05:00 AM, Alex Deucher wrote: > copy paste typo when I re-arranged the code. > > Signed-off-by: Alex Deucher <alexander.deuc...@amd.com>

Re: [PATCH] drm/radeon: allow TA_CS_BC_BASE_ADDR on SI

On 10/10/2016 10:23 PM, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > Required for border colors in compute shaders. > > Signed-off-by: Marek Olšák <marek.ol...@amd.com> Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net>

Re: [PATCH 9/9] drm/amdgpu:properly fix some JumpTable issues

On 09/28/2016 06:36 PM, Monk Liu wrote: > we found some MEC ucode leads to IB test fail or even > ring test fail if Jump Table of it is not start in > FW bo with page aligned address, fixed by always make > JT address page aligned. > > we don't need to patch JT2 for MEC2, because for VI, > MEC2

Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

s nice and clean looking. > > > Tom > > > > > *From:* amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of > Christian König <deathsim...@vodafone.de> > *Sent:* Tuesday, Sep

Additional amdkfd cleanups for 4.9

These additional minor changes apply on top of my previous set. Nothing too interesting here just yet more clean ups to make way for future changes. Please review, Kind Regards, Edward O'Callaghan (2): [PATCH 1/2] drm/amdkfd: Use kfd_vm_info struct to carry consts state [PATCH 2/2] drm/amdkfd

[PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 15 +-- drivers/gpu/drm/amd/amdkfd/cik_int.h | 20 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/g

[PATCH 1/2] drm/amdkfd: Use kfd_vm_info struct to carry consts state

Use a struct to carry the calculated const state inside the main kfd_dev state to use where we need it. Minor cleanups while we are here. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c| 9 ++--- drivers/gpu/d

Re: VRAM manager

This series is, to the best of my ability, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 09/27/2016 07:49 PM, Christian König wrote: > Hi guys, > > after fixing all those nasty little bugs this seems to be stable now. > > Anybody brave enough to give it a

Re: [PATCH 3/3] drm/amd/amdgpu: Various cleanups for DCEv6

This patch is, Review-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 09/23/2016 02:43 AM, Tom St Denis wrote: > Signed-off-by: Tom St Denis <tom.stde...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 46 > --- > 1

Re: [PATCH 1/5] drm/amdgpu:changes of virtualization cases probe (v2)

On 09/20/2016 03:12 AM, Alex Deucher wrote: > From: Monk Liu > > 1,Changes on virtualization detections > 2,Don't load smu & mc firmware if using sr-iov bios > 3,skip vPost for sriov & force vPost if dev pass-through > > v2: agd: fix missed SI case > > Signed-off-by: Monk

Re: [PATCH 2/5] drm/amdgpu: make sriov bios detection generic (v2)

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> as with the rest of the respective series. On 09/20/2016 04:44 AM, Alex Deucher wrote: > It's not asic specific. > > v2: drop asic macro > > Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> > ---

Re: [PATCH 1/5] drm/amdgpu/vi: whitespace fixes

Series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 09/20/2016 04:35 AM, Alex Deucher wrote: > function declaration parens should be a new line. > > Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> > --- > drivers/gpu/drm/amd/amdgp

Re: [PATCH] drm/amdgpu: use powerplay module for dgpu of VI.

So now just pure PP paths for Tonga, Fiji & Topaz. Is there any perf or power usage difference from this change-set across any of these ASIC's? Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 09/19/2016 10:17 PM, Rex Zhu wrote: > delete vi dpm related code and files. &

Re: [PATCH 0/3] drm/amdgpu: implement raster configuration

This series is, Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 09/18/2016 12:36 PM, Huang Rui wrote: > Hi all, > > This patch set is to introduce the raster configuration for all gfx > generations. > > Thanks, > Rui > > Huang Rui (3):

[PATCH 5/6] drm/amdkfd: Unify multiple calls to pr_debug() into one

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c b/drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c index a

[PATCH 4/6] drm/amdkfd: Fix possible infinite loop

When the loop predicating timeout parameter passed happens to not be a multiple of 20 the unsigned integer will overflow and the loop will become unbounded. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> Reviewed-by: Oded Gabbay <oded.gab...@gmail.com> --- drivers

[PATCH 1/6] drm/amdkfd: Tidy up kfd_generate_gpu_id() uint64_t bitshift unpack

Dereference the one time and unpack the lower and upper 32bit portions with the proper kernel helper macros. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> Reviewed-by: Oded Gabbay <oded.gab...@gmail.com> --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 8 +--- 1

[PATCH 2/6] drm/amdkfd: Add some missing memset zero'ing in queue init func

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> Reviewed-by: Oded Gabbay <oded.gab...@gmail.com> --- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c b/drivers/gpu/dr

drm/amdkfd: Misc patchset lineup for drm-next-4.9

wait up. Please review.. Kind Regards, Edward O'Callaghan (6): [PATCH 1/6] drm/amdkfd: Tidy up kfd_generate_gpu_id() uint64_t [PATCH 2/6] drm/amdkfd: Add some missing memset zero'ing in queue [PATCH 3/6] drm/amdkfd: Reuse function to find a process through [PATCH 4/6] drm/amdkfd: Fix possible

[PATCH 6/6] drm/amdkfd: Pass 'struct queue_propertices' by reference

Allow init_queue() to take 'struct queue_properties' by reference. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 +- drivers/gpu/drm/amd/

Re: Powerplay sensors (v2.5)

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 09/16/2016 10:44 PM, Tom St Denis wrote: > I've rebased the backend to squash the carrizo + rest patches together > and then touched up the debugfs entry per Edwards suggestions. > > Tested

Re: [PATCH 1/3] drm/amdgpu: cleanup VM shadow BO unreferencing

Series is, Acked-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 09/16/2016 10:12 PM, Christian König wrote: > From: Christian König <christian.koe...@amd.com> > > Unreference the shadow BOs in the error path as well and drop the NULL checks. > > Sig

Re: libdrm/amdgpu - Fixup typedef not to hide pointer type

d Regards, Edward. > > Christian. > > Am 16.09.2016 um 10:46 schrieb Edward O'Callaghan: >> Oops, turns out I mailed to dri-devel by mistake so resending here. >> >> The following series fixes up libdrm/amdgpu such that to not hide >> a pointer type behind

[PATCH 2/3] amdgpu: Fix amdgpu_semaphore_handle typedef not to hide pointer type

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- amdgpu/amdgpu.h| 10 +- amdgpu/amdgpu_cs.c | 20 ++-- tests/amdgpu/basic_tests.c | 2 +- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/amdgpu/amdgpu.h b/

[PATCH 3/3] amdgpu: Fix amdgpu_bo_list_handle typedef not to hide pointer type

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- amdgpu/amdgpu.h| 10 +- amdgpu/amdgpu_bo.c | 6 +++--- tests/amdgpu/amdgpu_test.h | 2 +- tests/amdgpu/basic_tests.c | 8 4 files changed, 13 insertions(+), 13 deletions(-) diff

libdrm/amdgpu - Fixup typedef not to hide pointer type

Oops, turns out I mailed to dri-devel by mistake so resending here. The following series fixes up libdrm/amdgpu such that to not hide a pointer type behind a typedef. Please Review, Edward O'Callaghan (3): [PATCH 1/3] amdgpu: Fix amdgpu_va_handle typedef not to hide pointer [PATCH 2/3] amdgpu

[PATCH 1/3] amdgpu: Fix amdgpu_va_handle typedef not to hide pointer type

Fundamentally this change stops us hiding the following pointer type behind a typedef: -typedef struct amdgpu_va *amdgpu_va_handle; +typedef struct amdgpu_va amdgpu_va_handle_t; Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- amdgpu/amdgpu.h| 6 +++---

Re: [PATCH 1/3] drm/amdgpu/gfx6: drop duplicate code

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> P.S., keep these hedge cuttings coming! On 09/16/2016 05:55 AM, Alex Deucher wrote: > The compute functions just called the gfx functions, drop > the wrapper. > > Signed-off-by: Alex Deucher <alex

Re: [PATCH] drm/amd/amdgpu: Add sensors debugfs support

On 09/15/2016 11:22 PM, Tom St Denis wrote: > This patch adds a callback to powerplay which > reads specific PP sensors (vdd/clocks/load) which is then > accessible via debugfs. The idea being is it'll be a standard > interface between different ASICs that userland tools can > read. > >

Re: Add read_sensor() support for fiji/tonga/iceland/polaris10

Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 09/16/2016 04:21 AM, Tom St Denis wrote: > Tested on my Tonga but should in theory work for the others as > well since they're 99% copy/paste (except which SMC reg is read &g

Re: [PATCH 0/3] rename file name.

This series is, Reviewed-by: Edward O'Callaghan <funfunc...@folklore1984.net> On 09/12/2016 06:22 PM, Rex Zhu wrote: > As tonga/fiji/polaris10/11 use ppt table version 1. > so rename tonga_processtable to process_pptables_v1_0 > > > Rex Zhu (3): > d

Re: [PATCH 4/7] drm/amdkfd: Make kfd_lookup_process_by_pasid() well defined

On 09/11/2016 01:55 AM, Oded Gabbay wrote: > On Sat, Sep 10, 2016 at 4:31 AM, Edward O'Callaghan > <funfunc...@folklore1984.net> wrote: >> Ensure we return a NULL on the fail branch so that the call >> site may BUG_ON() it. >> >> Signed-off-by: Edward O'Ca

[PATCH 7/7] drm/amdkfd: Fix possible infinite loop

When the loop predicating timeout parameter passed happens to not be a multiple of 20 the unsigned integer will overflow and the loop will become unbounded. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.

[PATCH 2/7] radeonkfd/amdkfd: Implement get_local_mem_info()

Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 32 --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 2 +- drivers/gpu/drm/amd/

[PATCH 4/7] drm/amdkfd: Make kfd_lookup_process_by_pasid() well defined

Ensure we return a NULL on the fail branch so that the call site may BUG_ON() it. Signed-off-by: Edward O'Callaghan <funfunc...@folklore1984.net> --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/

  1   2   >