Re: [GIT PULL] mmutable branch between pdx86 amd wbrf branch and wifi / amdgpu due for the v6.8 merge window

2023-12-12 Thread Johannes Berg
On Mon, 2023-12-11 at 12:02 +0100, Hans de Goede wrote: > Hi Wifi and AMDGPU maintainers, > > Here is a pull-request for the platform-drivers-x86 parts of: > > https://lore.kernel.org/platform-driver-x86/20231211100630.2170152-1-jun@amd.com/ > > From my pov the pdx86 bits are ready and the

Re: [GIT PULL] mmutable branch between pdx86 amd wbrf branch and wifi / amdgpu due for the v6.8 merge window

2023-12-11 Thread Johannes Berg
Hi, > Here is a pull-request for the platform-drivers-x86 parts of: > > https://lore.kernel.org/platform-driver-x86/20231211100630.2170152-1-jun@amd.com/ > > From my pov the pdx86 bits are ready and the > platform-drivers-x86-amd-wbrf-v6.8-1 tag can be merged by you to merge the >

Re: [Patch v13 4/9] wifi: mac80211: Add support for WBRF features

2023-11-02 Thread Johannes Berg
On Thu, 2023-11-02 at 14:24 +0200, Ilpo Järvinen wrote: > On Thu, 2 Nov 2023, Johannes Berg wrote: > > On Thu, 2023-11-02 at 13:55 +0200, Ilpo Järvinen wrote: > > > > > > +static void get_chan_freq_boundary(u32 center_freq, u32 bandwidth, u6

Re: [Patch v13 4/9] wifi: mac80211: Add support for WBRF features

2023-11-02 Thread Johannes Berg
On Thu, 2023-11-02 at 13:55 +0200, Ilpo Järvinen wrote: [please trim your quotes] > > +static void get_chan_freq_boundary(u32 center_freq, u32 bandwidth, u64 > > *start, u64 *end) > > +{ > > + bandwidth = MHZ_TO_KHZ(bandwidth); > > + center_freq = MHZ_TO_KHZ(center_freq); > > Please use

Re: [V9 4/9] wifi: mac80211: Add support for WBRF features

2023-08-21 Thread Johannes Berg
> +_freq2); > + > + ranges_in->band_list[1].start = start_freq2; > + ranges_in->band_list[1].end = end_freq2; > + } > +} This has to setup ranges_in->num_of_ranges, no? (Also no real good reason for num_of_ranges to be a u64, btw, since it can only go up to 11) With that fixed, you can add Reviewed-by: Johannes Berg johannes

Re: [PATCH V7 4/9] wifi: mac80211: Add support for ACPI WBRF

2023-08-14 Thread Johannes Berg
On Tue, 2023-07-25 at 22:09 +0200, Andrew Lunn wrote: > > > It could well be that AMD based machine has a different ACPI extension > to indicate this policy to what Intel machine has. As far as i > understand it, you have not submitted this yet for formal approval, > this is all vendor specific,

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-23 Thread Johannes Berg
On Wed, 2023-06-21 at 18:14 +0200, Andrew Lunn wrote: > > > Do only ACPI based systems have: > > > > > >    interference of relatively high-powered harmonics of the (G-)DDR > > >    memory clocks with local radio module frequency bands used by > > >    Wifi 6/6e/7." > > > > > > Could Device Tree

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-23 Thread Johannes Berg
On Wed, 2023-06-21 at 21:25 +0200, Andrew Lunn wrote: > > ACPI core does has notifiers that are used, but they don't work the same. > > If you look at patch 4, you'll see amdgpu registers and unregisters using > > both > > > > acpi_install_notify_handler() > > and > > acpi_remove_notify_handler()

Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations

2023-06-23 Thread Johannes Berg
On Wed, 2023-06-21 at 17:36 +0200, Andrew Lunn wrote: > On Wed, Jun 21, 2023 at 01:45:56PM +0800, Evan Quan wrote: > > From: Mario Limonciello > > > > Due to electrical and mechanical constraints in certain platform designs > > there may be likely interference of relatively high-powered

Re: [PATCH V4 3/8] wifi: mac80211: Add support for ACPI WBRF

2023-06-23 Thread Johannes Berg
On Wed, 2023-06-21 at 09:12 -0500, Limonciello, Mario wrote: > > > > But then the next question anyway is how we merge this? The wifi parts > > sort of depend on the first patch, although technically I guess I could > > merge them since it's all hidden behind the CONFIG_ symbol, assuming you > >

Re: [PATCH V4 3/8] wifi: mac80211: Add support for ACPI WBRF

2023-06-21 Thread Johannes Berg
On Wed, 2023-06-21 at 13:45 +0800, Evan Quan wrote: > To support AMD's WBRF interference mitigation mechanism, Wifi adapters > utilized in the system must register the frequencies in use(or unregister > those frequencies no longer used) via the dedicated APCI calls. So that, > other drivers

Re: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-19 Thread Johannes Berg
On Sun, 2023-06-18 at 21:17 -0500, Mario Limonciello wrote: > > > --- a/include/net/cfg80211.h > > +++ b/include/net/cfg80211.h > > @@ -920,6 +920,14 @@ const struct cfg80211_chan_def * > > cfg80211_chandef_compatible(const struct cfg80211_chan_def *chandef1, > > const

Re: [PATCH V2 2/7] wifi: mac80211: Add support for ACPI WBRF

2023-06-09 Thread Johannes Berg
On Fri, 2023-06-09 at 15:28 +0800, Evan Quan wrote: > --- a/include/net/cfg80211.h > +++ b/include/net/cfg80211.h > @@ -5551,6 +5551,10 @@ struct wiphy { > > u16 hw_timestamp_max_peers; > > +#ifdef CONFIG_ACPI_WBRF > + bool wbrf_supported; > +#endif This should be in some private

Re: Build regressions/improvements in v6.1-rc6

2022-11-22 Thread Johannes Berg
On Tue, 2022-11-22 at 08:55 -0500, Alex Deucher wrote: > > > >+ /kisskb/src/arch/um/include/asm/processor-generic.h: error: called > > object is not a function or function pointer: => 94:18 > >+ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: > > error: control reaches

Re: [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Johannes Berg
On Mon, 2022-02-28 at 20:16 +, Matthew Wilcox wrote: > On Mon, Feb 28, 2022 at 12:10:24PM -0800, Linus Torvalds wrote: > > We can do > > > > typeof(pos) pos > > > > in the 'for ()' loop, and never use __iter at all. > > > > That means that inside the for-loop, we use a _different_

Re: [PATCH 4/4] kunit: tool: Disable broken options for --alltests

2022-02-21 Thread Johannes Berg
On Sat, 2022-02-19 at 16:00 +0800, David Gow wrote: > On Fri, Feb 18, 2022 at 8:26 PM Johannes Berg > wrote: > > > > On Fri, 2022-02-18 at 15:57 +0800, David Gow wrote: > > > > > > Note that, while this does build again, it still segfaults on startup, &

Re: [PATCH 4/4] kunit: tool: Disable broken options for --alltests

2022-02-18 Thread Johannes Berg
On Fri, 2022-02-18 at 15:57 +0800, David Gow wrote: > > Note that, while this does build again, it still segfaults on startup, > so more work remains to be done. That's probably just a lot more stuff getting included somehow? > They are: > - CONFIG_VFIO_PCI: Needs ioport_map/ioport_unmap. > -

Re: [PATCH v3 12/26] compat_ioctl: move more drivers to compat_ptr_ioctl

2019-04-25 Thread Johannes Berg
On Thu, 2019-04-25 at 17:55 +0200, Arnd Bergmann wrote: > On Thu, Apr 25, 2019 at 5:35 PM Al Viro wrote: > > > > On Thu, Apr 25, 2019 at 12:21:53PM -0300, Mauro Carvalho Chehab wrote: > > > > > If I understand your patch description well, using compat_ptr_ioctl > > > only works if the driver is