[AMD Official Use Only - AMD Internal Distribution Only]
-Original Message-
From: Alex Deucher
Sent: Wednesday, May 29, 2024 7:16 PM
To: Khatri, Sunil
Cc: Deucher, Alexander ; Koenig, Christian
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v1 1/3] drm/amdgpu: add gfx9 register
On 5/16/2024 1:40 AM, Deucher, Alexander wrote:
[Public]
-Original Message-
From: Sunil Khatri
Sent: Wednesday, May 15, 2024 8:18 AM
To: Deucher, Alexander ; Koenig, Christian
Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil
Subject: [PATCH v3 2/4] drm/amdgpu: Add support to dump
On 5/16/2024 1:42 AM, Deucher, Alexander wrote:
[Public]
-Original Message-
From: Sunil Khatri
Sent: Wednesday, May 15, 2024 8:18 AM
To: Deucher, Alexander ; Koenig, Christian
Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil
Subject: [PATCH v3 3/4] drm/amdgpu: add support to dump
On 5/16/2024 1:37 AM, Deucher, Alexander wrote:
[Public]
-Original Message-
From: Sunil Khatri
Sent: Wednesday, May 15, 2024 8:18 AM
To: Deucher, Alexander ; Koenig, Christian
Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil
Subject: [PATCH v3 1/4] drm/amdgpu: update the ip_dump
On 5/3/2024 9:52 PM, Alex Deucher wrote:
On Fri, May 3, 2024 at 12:09 PM Khatri, Sunil wrote:
On 5/3/2024 9:18 PM, Khatri, Sunil wrote:
On 5/3/2024 8:52 PM, Alex Deucher wrote:
On Fri, May 3, 2024 at 4:45 AM Sunil Khatri
wrote:
add compute registers in set of registers to dump
during ip
On 5/3/2024 9:18 PM, Khatri, Sunil wrote:
On 5/3/2024 8:52 PM, Alex Deucher wrote:
On Fri, May 3, 2024 at 4:45 AM Sunil Khatri
wrote:
add compute registers in set of registers to dump
during ip dump for gfx10.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 42
On 5/3/2024 8:52 PM, Alex Deucher wrote:
On Fri, May 3, 2024 at 4:45 AM Sunil Khatri wrote:
add compute registers in set of registers to dump
during ip dump for gfx10.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 42 +-
1 file changed,
On 4/25/2024 7:43 PM, Lazar, Lijo wrote:
On 4/25/2024 3:53 PM, Sunil Khatri wrote:
Do not dump the ip registers during driver reload
in passthrough environment.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 ++
1 file changed, 6 insertions(+), 4
dev->gfx.ip_dump[i] =
RREG32(SOC15_REG_ENTRY_OFFSET(gc_reg_list_10_1[i]));
}
amdgpu_gfx_off_ctrl(adev, true);
Sunil
Alex
Thanks,
Lijo
-Original Message-
From: Khatri, Sunil
Sent: Wednesday, April 17, 2024 9:42 PM
To: Lazar, Lijo ; Alex Deucher ; Khatri,
Sunil
Cc: Deucher, Ale
On 4/17/2024 9:31 PM, Lazar, Lijo wrote:
On 4/17/2024 9:21 PM, Alex Deucher wrote:
On Wed, Apr 17, 2024 at 5:38 AM Sunil Khatri wrote:
Adding gfx10 gc registers to be used for register
dump via devcoredump during a gpu reset.
Signed-off-by: Sunil Khatri
Reviewed-by: Alex Deucher
---
On 4/17/2024 2:15 PM, Christian König wrote:
Am 17.04.24 um 10:18 schrieb Sunil Khatri:
Adding gfx10 gc registers to be used for register
dump via devcoredump during a gpu reset.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 8 ++
On 4/17/2024 1:19 PM, Lazar, Lijo wrote:
On 4/17/2024 1:14 PM, Khatri, Sunil wrote:
On 4/17/2024 1:06 PM, Khatri, Sunil wrote:
devcoredump is used to debug gpu hangs/resets. So in normal process
when there is a hang due to ring timeout or page fault we are doing a
hard reset as soft reset
On 4/17/2024 1:06 PM, Khatri, Sunil wrote:
devcoredump is used to debug gpu hangs/resets. So in normal process
when there is a hang due to ring timeout or page fault we are doing a
hard reset as soft reset fail in those cases. How are we making sure
that the devcoredump is triggered in those
devcoredump is used to debug gpu hangs/resets. So in normal process when
there is a hang due to ring timeout or page fault we are doing a hard
reset as soft reset fail in those cases. How are we making sure that the
devcoredump is triggered in those cases and captured?
Regards
Sunil Khatri
On 4/16/2024 7:29 PM, Alex Deucher wrote:
On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote:
Add ip dump for each ip of the asic in the
devcoredump for all the ips where a callback
is registered for register dump.
Signed-off-by: Sunil Khatri
---
On 4/16/2024 7:27 PM, Alex Deucher wrote:
On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote:
Add support to print ip information to be
used to print registers in devcoredump
buffer.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 17 -
1 file
On 4/16/2024 7:30 PM, Christian König wrote:
Am 16.04.24 um 15:55 schrieb Alex Deucher:
On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri
wrote:
Adding gfx10 gc registers to be used for register
dump via devcoredump during a gpu reset.
Signed-off-by: Sunil Khatri
---
On 4/16/2024 7:25 PM, Alex Deucher wrote:
On Tue, Apr 16, 2024 at 8:08 AM Sunil Khatri wrote:
Adding gfx10 gc registers to be used for register
dump via devcoredump during a gpu reset.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 12 ++
On 4/16/2024 7:56 PM, Alex Deucher wrote:
On Tue, Apr 16, 2024 at 9:34 AM Sunil Khatri wrote:
Enable redirection of irq for pagefaults for specific
clients to avoid overflow without dropping interrupts.
So here we redirect the interrupts to another IH ring
i.e ring1 where only these
[AMD Official Use Only - General]
-Original Message-
From: Alex Deucher
Sent: Saturday, April 13, 2024 1:56 AM
To: Khatri, Sunil
Cc: Khatri, Sunil ; Deucher, Alexander
; Koenig, Christian ;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/amdgpu: Add support of gfx10
On 4/12/2024 10:42 PM, Alex Deucher wrote:
On Fri, Apr 12, 2024 at 1:05 PM Khatri, Sunil wrote:
On 4/12/2024 8:50 PM, Alex Deucher wrote:
On Fri, Apr 12, 2024 at 10:00 AM Sunil Khatri wrote:
Adding initial set of registers for ipdump during
devcoredump starting with gfx10 gc registers
On 4/12/2024 8:50 PM, Alex Deucher wrote:
On Fri, Apr 12, 2024 at 10:00 AM Sunil Khatri wrote:
Adding initial set of registers for ipdump during
devcoredump starting with gfx10 gc registers.
ip dump is triggered when gpu reset happens via
devcoredump and the memory is allocated by each
ip
On 4/12/2024 8:50 PM, Alex Deucher wrote:
I would split this into two patches, one to add the core
infrastructure in devcoredump and one to add gfx10 support. The core
support could be squashed into patch 1 as well.
Sure would push the v3 with the changes.
Regards
Sunil
[AMD Official Use Only - General]
Ignore the series sent by mistake
-Original Message-
From: Sunil Khatri
Sent: Friday, April 12, 2024 2:30 PM
To: Deucher, Alexander ; Koenig, Christian
Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil
Subject: [PATCH 0/2] First set in IP dump
[AMD Official Use Only - General]
Ignore sent by mistake.
-Original Message-
From: Sunil Khatri
Sent: Friday, April 12, 2024 2:30 PM
To: Deucher, Alexander ; Koenig, Christian
Cc: amd-gfx@lists.freedesktop.org; Khatri, Sunil
Subject: [PATCH 2/2] drm/amdgpu: Add support of gfx10
On 3/28/2024 8:38 AM, Alex Deucher wrote:
On Tue, Mar 26, 2024 at 1:31 PM Sunil Khatri wrote:
Add FW information of all the IP's in the devcoredump.
Signed-off-by: Sunil Khatri
Might want to include the vbios version info as well, e.g.,
atom_context->name
atom_context->vbios_pn
On 3/26/2024 10:23 PM, Alex Deucher wrote:
On Tue, Mar 26, 2024 at 10:38 AM Sunil Khatri wrote:
dump the bios binary in the devcoredump.
Signed-off-by: Sunil Khatri
---
.../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 20 +++
1 file changed, 20 insertions(+)
diff --git
...@vger.kernel.org; Zhang, Hawking ; Kuehling,
Felix ; Lazar, Lijo ; Khatri, Sunil
Subject: [PATCH v2] drm/amdgpu: refactor code to reuse system information
Refactor the code so debugfs and devcoredump can reuse the common information
and avoid unnecessary copy of it.
created a new file which
Sent a new patch based on discussion with Alex.
On 3/19/2024 8:34 PM, Christian König wrote:
Am 19.03.24 um 15:59 schrieb Alex Deucher:
On Tue, Mar 19, 2024 at 10:56 AM Christian König
wrote:
Am 19.03.24 um 15:26 schrieb Alex Deucher:
On Tue, Mar 19, 2024 at 8:32 AM Sunil Khatri
wrote:
On 3/19/2024 8:07 PM, Christian König wrote:
Am 19.03.24 um 15:25 schrieb Sunil Khatri:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used
On 3/19/2024 7:43 PM, Lazar, Lijo wrote:
On 3/19/2024 7:27 PM, Khatri, Sunil wrote:
On 3/19/2024 7:19 PM, Lazar, Lijo wrote:
On 3/19/2024 6:02 PM, Sunil Khatri wrote:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created
On 3/19/2024 7:19 PM, Lazar, Lijo wrote:
On 3/19/2024 6:02 PM, Sunil Khatri wrote:
Refactor the code so debugfs and devcoredump can reuse
the common information and avoid unnecessary copy of it.
created a new file which would be the right place to
hold functions which will be used between
Validated the code by using the function in same way as ioctl would use
in devcoredump and getting the valid values.
Also this would be the container of the information that we need to
share between ioctl, debugfs and devcoredump and keep updating this
based on information needed.
On
[AMD Official Use Only - General]
Got it. Thanks for reported that. Sent the patch for review.
Regards
Sunil khatri
-Original Message-
From: Dan Carpenter
Sent: Saturday, March 16, 2024 2:42 PM
To: Khatri, Sunil
Cc: Khatri, Sunil ; Koenig, Christian
; Deucher, Alexander ;
amd-gfx
Thanks for pointing these. I do have some doubt and i raised inline.
On 3/15/2024 8:46 PM, Dan Carpenter wrote:
Hello Sunil Khatri,
Commit 42742cc541bb ("drm/amdgpu: add ring buffer information in
devcoredump") from Mar 11, 2024 (linux-next), leads to the following
Smatch static checker
On 3/15/2024 6:45 PM, Alex Deucher wrote:
On Fri, Mar 15, 2024 at 8:13 AM Sunil Khatri wrote:
Add all the IP's version information on a SOC to the
devcoredump.
Signed-off-by: Sunil Khatri
This looks great.
Reviewed-by: Alex Deucher
Thanks Alex
---
;
linux-ker...@vger.kernel.org; Khatri, Sunil
Subject: [PATCH] drm/amdgpu: add the hw_ip version of all IP's
Add all the IP's version information on a SOC to the devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 62 +++
1 file changed
On 3/14/2024 8:12 PM, Alex Deucher wrote:
On Thu, Mar 14, 2024 at 1:44 AM Khatri, Sunil wrote:
On 3/14/2024 1:58 AM, Alex Deucher wrote:
On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote:
Add all the IP's information on a SOC to the
devcoredump.
Signed-off-by: Sunil Khatri
On 3/14/2024 11:40 AM, Sharma, Shashank wrote:
On 14/03/2024 06:58, Khatri, Sunil wrote:
On 3/14/2024 2:06 AM, Alex Deucher wrote:
On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri
wrote:
Add firmware version information of each
IP and each instance where applicable.
Is there a way we can
On 3/14/2024 2:06 AM, Alex Deucher wrote:
On Tue, Mar 12, 2024 at 8:42 AM Sunil Khatri wrote:
Add firmware version information of each
IP and each instance where applicable.
Is there a way we can share some common code with devcoredump,
debugfs, and the info IOCTL? All three places need
On 3/14/2024 1:58 AM, Alex Deucher wrote:
On Tue, Mar 12, 2024 at 8:41 AM Sunil Khatri wrote:
Add all the IP's information on a SOC to the
devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 19 +++
1 file changed, 19 insertions(+)
md-gfx@lists.freedesktop.org ;
dri-de...@lists.freedesktop.org ;
linux-ker...@vger.kernel.org ; Khatri, Sunil
Subject: [PATCH 2/2] drm:amdgpu: add firmware information of all IP's
Add firmware version information of each
IP and each instance where applicable.
Signed-off-by: Sunil Khatri
---
drivers/gpu/d
md-gfx@lists.freedesktop.org ;
dri-de...@lists.freedesktop.org ;
linux-ker...@vger.kernel.org ; Khatri, Sunil
Subject: [PATCH 1/2] drm/amdgpu: add the IP information of the soc
Add all the IP's information on a SOC to the
devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/
md-gfx@lists.freedesktop.org ;
dri-de...@lists.freedesktop.org ;
linux-ker...@vger.kernel.org ; Khatri, Sunil
Subject: [PATCH 1/2] drm/amdgpu: add the IP information of the soc
Add all the IP's information on a SOC to the
devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/
On 3/11/2024 7:29 PM, Christian König wrote:
Am 11.03.24 um 13:22 schrieb Sunil Khatri:
Add relevant ringbuffer information such as
rptr, wptr, ring name, ring size and also
the ring contents for each ring on a gpu reset.
Signed-off-by: Sunil Khatri
---
-ker...@vger.kernel.org; Khatri, Sunil
Subject: [PATCH] drm/amdgpu: add all ringbuffer information in devcoredump
Add ringbuffer information such as:
rptr, wptr, ring name, ring size and also the ring contents for each ring on a
gpu reset.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd
On 3/8/2024 2:39 PM, Christian König wrote:
Am 07.03.24 um 21:50 schrieb Sunil Khatri:
Add page fault information to the devcoredump.
Output of devcoredump:
AMDGPU Device Coredump
version: 1
kernel: 6.7.0-amd-staging-drm-next
module: amdgpu
time: 29.725011811
process_name:
On 3/8/2024 12:44 AM, Alex Deucher wrote:
On Thu, Mar 7, 2024 at 12:00 PM Sunil Khatri wrote:
Add page fault information to the devcoredump.
Output of devcoredump:
AMDGPU Device Coredump
version: 1
kernel: 6.7.0-amd-staging-drm-next
module: amdgpu
time: 29.725011811
process_name:
On 3/7/2024 6:10 PM, Christian König wrote:
Am 07.03.24 um 09:37 schrieb Khatri, Sunil:
On 3/7/2024 1:47 PM, Christian König wrote:
Am 06.03.24 um 19:19 schrieb Sunil Khatri:
Add page fault information to the devcoredump.
Output of devcoredump:
AMDGPU Device Coredump
version: 1
On 3/7/2024 1:47 PM, Christian König wrote:
Am 06.03.24 um 19:19 schrieb Sunil Khatri:
Add page fault information to the devcoredump.
Output of devcoredump:
AMDGPU Device Coredump
version: 1
kernel: 6.7.0-amd-staging-drm-next
module: amdgpu
time: 29.725011811
process_name:
...@vger.kernel.org; Joshi, Mukul ; Paneer
Selvam, Arunpravin ; Khatri, Sunil
Subject: [PATCH] drm/amdgpu: add vm fault information to devcoredump
Add page fault information to the devcoredump.
Output of devcoredump:
AMDGPU Device Coredump
version: 1
kernel: 6.7.0-amd-staging-drm-next
module
...@vger.kernel.org; Joshi, Mukul ; Paneer
Selvam, Arunpravin ; Khatri, Sunil
Subject: [PATCH] drm/amdgpu: cache in more vm fault information
When an page fault interrupt is raised there is a lot more information that is
useful for developers to analyse the pagefault.
Add all such information
, we just need to provide faulting address, Fault status
register with gpu family to decode the fault along with process information.
Regards
Sunil Khatri
On 3/6/2024 9:56 PM, Khatri, Sunil wrote:
On 3/6/2024 9:49 PM, Christian König wrote:
Am 06.03.24 um 17:06 schrieb Khatri, Sunil:
On 3/6
On 3/6/2024 9:59 PM, Alex Deucher wrote:
On Wed, Mar 6, 2024 at 11:21 AM Khatri, Sunil wrote:
On 3/6/2024 9:45 PM, Alex Deucher wrote:
On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote:
On 3/6/2024 9:07 PM, Christian König wrote:
Am 06.03.24 um 16:13 schrieb Khatri, Sunil:
On 3/6
On 3/6/2024 9:49 PM, Christian König wrote:
Am 06.03.24 um 17:06 schrieb Khatri, Sunil:
On 3/6/2024 9:07 PM, Christian König wrote:
Am 06.03.24 um 16:13 schrieb Khatri, Sunil:
On 3/6/2024 8:34 PM, Christian König wrote:
Am 06.03.24 um 15:29 schrieb Alex Deucher:
On Wed, Mar 6, 2024 at 8
On 3/6/2024 9:45 PM, Alex Deucher wrote:
On Wed, Mar 6, 2024 at 11:06 AM Khatri, Sunil wrote:
On 3/6/2024 9:07 PM, Christian König wrote:
Am 06.03.24 um 16:13 schrieb Khatri, Sunil:
On 3/6/2024 8:34 PM, Christian König wrote:
Am 06.03.24 um 15:29 schrieb Alex Deucher:
On Wed, Mar 6
On 3/6/2024 9:07 PM, Christian König wrote:
Am 06.03.24 um 16:13 schrieb Khatri, Sunil:
On 3/6/2024 8:34 PM, Christian König wrote:
Am 06.03.24 um 15:29 schrieb Alex Deucher:
On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote:
On 3/6/2024 6:12 PM, Christian König wrote:
Am 06.03.24 um
On 3/6/2024 9:19 PM, Alex Deucher wrote:
On Wed, Mar 6, 2024 at 10:32 AM Alex Deucher wrote:
On Wed, Mar 6, 2024 at 10:13 AM Khatri, Sunil wrote:
On 3/6/2024 8:34 PM, Christian König wrote:
Am 06.03.24 um 15:29 schrieb Alex Deucher:
On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote
On 3/6/2024 8:34 PM, Christian König wrote:
Am 06.03.24 um 15:29 schrieb Alex Deucher:
On Wed, Mar 6, 2024 at 8:04 AM Khatri, Sunil wrote:
On 3/6/2024 6:12 PM, Christian König wrote:
Am 06.03.24 um 11:40 schrieb Khatri, Sunil:
On 3/6/2024 3:37 PM, Christian König wrote:
Am 06.03.24 um
On 3/6/2024 6:12 PM, Christian König wrote:
Am 06.03.24 um 11:40 schrieb Khatri, Sunil:
On 3/6/2024 3:37 PM, Christian König wrote:
Am 06.03.24 um 10:04 schrieb Sunil Khatri:
When an page fault interrupt is raised there
is a lot more information that is useful for
developers to analyse
On 3/6/2024 3:37 PM, Christian König wrote:
Am 06.03.24 um 10:04 schrieb Sunil Khatri:
When an page fault interrupt is raised there
is a lot more information that is useful for
developers to analyse the pagefault.
Well actually those information are not that interesting because they
are
On 3/5/2024 6:40 PM, Christian König wrote:
Am 05.03.24 um 12:58 schrieb Sunil Khatri:
Add ring timeout related information in the amdgpu
devcoredump file for debugging purposes.
During the gpu recovery process the registered call
is triggered and add the debug information in data
file
On 3/5/2024 2:53 PM, Christian König wrote:
> Am 01.03.24 um 13:43 schrieb Sunil Khatri:
>> Add ring timeout related information in the amdgpu
>> devcoredump file for debugging purposes.
>>
>> During the gpu recovery process the registered call
>> is triggered and add the debug information in
[AMD Official Use Only - General]
Acked-by: Sunil Khatri
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Thursday, May 11, 2023 8:13 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
Subject: [PATCH] drm/amdgpu/gmc11: implement get_vbios_fb_size()
Implement
[AMD Official Use Only - General]
Hello Alex, Robert
I too have similar issues which I am facing on chrome. Are there any tools in
linux environment which can help debug such issues like page faults, kernel
panic caused by invalid pointer access.
I have used tools like ramdump parser which
[AMD Official Use Only - General]
@Ernst Sjöstrand<mailto:ern...@gmail.com>
Make sense. Thanks for Review. Pushed another patch without any such names.
Regards
Sunil khatri
From: Ernst Sjöstrand
Sent: Tuesday, May 31, 2022 1:47 AM
To: Khatri, Sunil
Cc: Deucher, Alexander ; amd-gfx m
66 matches
Mail list logo
