_0_unset_enc_ring_funcs(adev);
This looks a little weird to me. Is possible just move initial set ring
funcs to after firmware loading?
Leo
+ adev->uvd.num_enc_rings = 0;
+ }
+
if (adev->uvd.num_enc_rings) {
struct drm_sched_rq *rq;
@@ -16
first.
Regards,
Leo
Thanks,
Christian.
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Sent to the incorrect lists. Please ignores. Thanks.
On 12/04/2017 03:50 PM, Leo Liu wrote:
Following VA spec
Signed-off-by: Leo Liu <leo@amd.com>
---
src/gallium/state_trackers/va/context.c| 2 +-
src/gallium/state_trackers/va/subpicture.c | 2 +-
src/gallium/state_track
Signed-off-by: Leo Liu <leo@amd.com>
---
src/gallium/state_trackers/va/context.c | 99 -
1 file changed, 49 insertions(+), 50 deletions(-)
diff --git a/src/gallium/state_trackers/va/context.c
b/src/gallium/state_trackers/va/context.c
index 0ad4
From: Mark Thompson <s...@jkqxz.net>
It will be present from libva 2.1 (VAAPI 1.1.0 or higher).
v2: rebase to previous patches(Leo)
Signed-off-by: Mark Thompson <s...@jkqxz.net>
Signed-off-by: Leo Liu <leo@amd.com>
---
src/gallium/state_trackers/va/context.c |
Following VA spec
Signed-off-by: Leo Liu <leo@amd.com>
---
src/gallium/state_trackers/va/context.c| 2 +-
src/gallium/state_trackers/va/subpicture.c | 2 +-
src/gallium/state_trackers/va/va_private.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/g
On 2017-11-23 02:52 PM, Harry Wentland wrote:
Signed-off-by: Harry Wentland <harry.wentl...@amd.com>
Reviewed-by: Leo (Sunpeng) Li <sunpeng...@amd.com>
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 2 ++
drivers/gpu/drm/amd/display/dc/dc.h | 2 ++
2 files changed,
On 2017-11-17 11:46 PM, Andrey Grodzovsky wrote:
On 2017-11-16 10:32 AM, Harry Wentland wrote:
From: "Leo (Sunpeng) Li" <sunpeng...@amd.com>
Within atomic check, dm_update_crtcs_state is called twice. First to
remove from the dc_state, and subsequently to add to it
Hi Johannes,
The s3 resume issue looks to be a problem with amdgpu/display. Could you
give the attached patch a try?
Thanks,
Leo
On 2017-11-23 07:27 AM, Johannes Hirte wrote:
On 2017 Nov 23, Chunming Zhou wrote:
See the attached email, they fixed same issue, each of them is ok to fix
your
On 11/21/2017 12:17 PM, Michel Dänzer wrote:
On 2017-11-21 03:28 PM, Leo Liu wrote:
With the enablement of VCN Dec and Enc from user space, User space queries
kernel for the IP information, if HW has UVD/VCE, the info comes from these
IP blocks, but this could end up mis-interpret for VCN
With the enablement of VCN Dec and Enc from user space, User space queries
kernel for the IP information, if HW has UVD/VCE, the info comes from these
IP blocks, but this could end up mis-interpret for VCN when they are in the
union, ther other way same when HW with VCN block.
Signed-off-by: Leo
rqs_on_caller+0x11f/0x190
[ 9066.794466] ? trace_hardirqs_on+0xd/0x10
[ 9066.794492] amdgpu_drm_ioctl+0x47/0x80 [amdgpu]
[ 9066.794495] do_vfs_ioctl+0x8e/0x640
[ 9066.794497] ? trace_hardirqs_on+0xd/0x10
[ 9066.794500] ? security_file_ioctl+0x3e/0x60
On 11/21/2017 09:28 AM, Leo Liu wrote:
With t
On 2017-11-10 01:40 PM, Andrey Grodzovsky wrote:
On 11/10/2017 01:38 PM, Andrey Grodzovsky wrote:
On 11/09/2017 03:05 PM, Harry Wentland wrote:
From: "Leo (Sunpeng) Li" <sunpeng...@amd.com>
This is a followup to the following revert:
Rex Zhu Revert "drm/amd/
On 2017-11-10 02:00 PM, Andrey Grodzovsky wrote:
On 11/09/2017 03:05 PM, Harry Wentland wrote:
From: "Leo (Sunpeng) Li" <sunpeng...@amd.com>
When disabling pipe splitting, we need to make sure we disable both
planes used.
This should be done for Linux as
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
index 90332f55cfba..cf81065e3c5a 100644
--- a/d
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
index 7e4de3e6950f..0c01825a8b9e 100644
--- a/drivers/gpu/drm/amd/
On 2017-10-30 12:36 PM, Leo wrote:
On 2017-10-26 11:06 PM, Andrey Grodzovsky wrote:
On 2017-10-26 02:34 PM, Harry Wentland wrote:
From: "Leo (Sunpeng) Li" <sunpeng...@amd.com>
Abandon new_crtcs array and use for_each_new iterator to acquire new
crtcs.
Signed-off-by:
On 2017-10-26 11:06 PM, Andrey Grodzovsky wrote:
On 2017-10-26 02:34 PM, Harry Wentland wrote:
From: "Leo (Sunpeng) Li" <sunpeng...@amd.com>
Abandon new_crtcs array and use for_each_new iterator to acquire new
crtcs.
Signed-off-by: Leo (Sunpeng) Li <sunpeng...@amd.com&
On 10/24/2017 12:08 PM, Tom St Denis wrote:
The workaround is not required anymor and would result in
hangs during suspend/resume cycles if the uvd block were busy.
Signed-off-by: Tom St Denis <tom.stde...@amd.com>
Acked-by: Leo Liu <leo@amd.com>
---
drivers/gpu/dr
On 10/24/2017 09:07 AM, Tom St Denis wrote:
Thanks Leo,
I don't have any uvd7 gear but that code has the same "workaround."
Should that be removed as well?
Good question. Since we don't have UVD7 APUs to verify, it's up to you
to either re-visit later or remove it now.
Leo
C
Reviewed-by: Leo Liu <leo@amd.com>
On 10/23/2017 01:34 PM, Alex Deucher wrote:
On Mon, Oct 23, 2017 at 1:03 PM, Tom St Denis <tom.stde...@amd.com> wrote:
On APUs the uvd6 driver was skipping proper suspend/resume routines resulting
in a broken state upon resume.
Signed-of
al fix was
introduced later for dGPU by adding save and restore UVD firmware
context cache part.
That fix should apply for APU, Please feel free to send fix.
Thanks,
Leo
Tom
On 23/10/17 09:54 AM, Tom St Denis wrote:
On 23/10/17 09:27 AM, Tom St Denis wrote:
Doing a suspend during
On 2017-10-13 08:39 AM, William Lewis wrote:
On 10/12/2017 04:15 PM, sunpeng...@amd.com wrote:
From: "Leo (Sunpeng) Li" <sunpeng...@amd.com>
To conform to DRM's new API, we should not be accessing a DRM object's
internal state directly. Rather, the DRM for_each_old
On 2017-10-13 04:36 PM, Andrey Grodzovsky wrote:
On 10/13/2017 03:29 PM, sunpeng...@amd.com wrote:
From: "Leo (Sunpeng) Li" <sunpeng...@amd.com>
Use the correct for_each_new/old_* iterators instead of for_each_*
The following functions
On 2017-10-13 11:56 AM, Andrey Grodzovsky wrote:
On 10/13/2017 11:41 AM, Leo wrote:
On 2017-10-13 11:03 AM, Andrey Grodzovsky wrote:
On 10/12/2017 05:15 PM, sunpeng...@amd.com wrote:
From: "Leo (Sunpeng) Li"<sunpeng...@amd.com>
Use the correct for_each_new/old_* i
On 2017-10-13 11:03 AM, Andrey Grodzovsky wrote:
On 10/12/2017 05:15 PM, sunpeng...@amd.com wrote:
From: "Leo (Sunpeng) Li"<sunpeng...@amd.com>
Use the correct for_each_new/old_* iterators instead of for_each_*
List of affected functions:
amdgpu_dm_find_first_crtc_matchin
Hi Tom,
This is a known issue, and we're currently tracking it on ticket
SWDEV-135329. It's reported using Vega10, but we reproduced it on
Carrizo as well.
Thanks,
Leo
On 2017-10-13 09:30 AM, Tom St Denis wrote:
For what it's worth this commit also breaks resume on my Tonga only
system so
On 2017-10-12 02:00 AM, Maarten Lankhorst wrote:
Op 11-10-17 om 22:40 schreef Harry Wentland:
On 2017-10-11 03:46 PM, Maarten Lankhorst wrote:
Op 11-10-17 om 20:55 schreef Leo:
On 2017-10-11 10:30 AM, Maarten Lankhorst wrote:
Op 11-10-17 om 16:24 schreef sunpeng...@amd.com:
From: &quo
On 2017-10-11 10:30 AM, Maarten Lankhorst wrote:
Op 11-10-17 om 16:24 schreef sunpeng...@amd.com:
From: "Leo (Sunpeng) Li" <sunpeng...@amd.com>
Use the correct for_each_new/old_* iterators instead of for_each_*
List of affected functions:
amdgpu_dm_find_first_crtc_matchin
h that fixed, the series is
Reviewed-by: Leo Liu <leo@amd.com>
len += sizeof(uve_encode_param) / 4;
memcpy((ib_cpu + len), uve_op_speed_enc_mode, sizeof(uve_op_speed_enc_mode));
___
amd-gfx mailing list
amd-gfx@lists.fre
On 10/02/2017 11:56 AM, Christian König wrote:
Some minor nit picks on patch #4 and #9, but apart from that it looks
good to me.
With those fixed the series is Reviewed-by: Christian König
<christian.koe...@amd.com>, but Leo should probably take a look as well.
Yes.
On 09/07/2017 08:08 AM, Christian König wrote:
Am 06.09.2017 um 18:33 schrieb Leo Liu:
On 09/06/2017 11:51 AM, Christian König wrote:
From: Christian König <christian.koe...@amd.com>
Use the VM instead of the BO list to find the BO for a virtual address.
This fixes UVD/VCE in ph
On 09/06/2017 11:51 AM, Christian König wrote:
From: Christian König <christian.koe...@amd.com>
Use the VM instead of the BO list to find the BO for a virtual address.
This fixes UVD/VCE in physical mode with VM local BOs.
The series is
Tested-by: Leo Liu <leo@amd.com>
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index d5c63d6c8fb3..0186bf49d5c2 100644
--- a/drive
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
index ff8ae50..b464f62 100644
--- a/drivers/gpu/drm/amd/
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
index 09190fa..d58ca82 100644
--- a/drivers/gp
The power control for vcn has been moved to firmware, kernel'll spins
"amdgpu: [powerplay] pp_dpm_powergate_uvd was not implemented", each
time when application runs, so let's remove it.
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/a
seem to be quite wide, and I'd like some input on this
before I jump in. Any ideas and/or suggestions will be very much
appreciated!
Thanks,
Leo
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
stuck in the moderation queue since Leo
(Sun peng) is fairly new on the FDO mailing lists.
Jani, Daniel, can you check if Leo's IGT emails are stuck in the
moderation queue?
Done. I've whitelisted his email address on intel-gfx, but I suggest
subscribing too.
BR,
Jani.
Thanks Jani.
I'll wait with p
-...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
Wentland, Harry
Cc: Li, Sun peng
Subject: [PATCH i-g-t] tests: Increase value of I915_MAX_PIPES to 6
From: "Leo (Sunpeng) Li" <sunpeng...@amd.com>
Increasing max pipe count to 6 to support AMD GPU's.
Since some tests' behavior depen
When you git email-send first time, there is a message-id, when you
would send follow up patches, using --in-reply-to="message-id" in your
comment line, then that will be in the same thread.
Cheers,
Leo
On 06/01/2017 09:40 AM, Xie, AlexBin wrote:
Ok. I will add the v2 next t
On 06/01/2017 06:55 AM, Christian König wrote:
Am 31.05.2017 um 21:28 schrieb Leo Liu:
To simplify vce bo create
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 27
+++
1 file changed, 3 insertions(+), 24 deletions(-)
We are using PSP to resume firmware after suspend, and it is
resumed at where it got suspended, so we'd better save the
the context.
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h | 1 +
drivers/gpu/drm/amd/amdgpu/vce_v4_0.c
On 05/31/2017 03:54 PM, Deucher, Alexander wrote:
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Leo Liu
> Sent: Wednesday, May 31, 2017 3:28 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Leo
> Subject: [PATCH
We are using PSP to resume firmware after suspend, and it is
resumed at where it got suspended, so we'd better save the
the context.
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h | 1 +
drivers/gpu/drm/amd/amdgpu/vce_v4_0.c
To simplify vce bo create
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 27 +++
1 file changed, 3 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h
index 0a7f18c..c93f74a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu
Signed-off-by: Leo Liu <leo@amd.com>
Acked-by: Christian König <christian.koe...@amd.com>
---
tests/amdgpu/cs_tests.c| 2 +-
tests/amdgpu/decode_messages.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/amdgpu/cs_tests.c b/tests/amdgpu/cs_t
Signed-off-by: Leo Liu <leo@amd.com>
Acked-by: Christian König <christian.koe...@amd.com>
---
tests/amdgpu/decode_messages.h | 30 +
tests/amdgpu/vcn_tests.c | 139 -
2 files changed, 166 insertions(+), 3 deletions(-)
diff -
Signed-off-by: Leo Liu <leo@amd.com>
Acked-by: Christian König <christian.koe...@amd.com>
---
tests/amdgpu/Makefile.am | 3 +-
tests/amdgpu/amdgpu_test.c | 6 +
tests/amdgpu/amdgpu_test.h | 15 +++
tests/amdgpu/vcn_tests.c | 277 ++
AVC decode messages will be common with VCN decode
Signed-off-by: Leo Liu <leo@amd.com>
Acked-by: Christian König <christian.koe...@amd.com>
---
tests/amdgpu/cs_tests.c| 3 ++-
tests/amdgpu/decode_messages.h | 3 +++
2 files changed, 5 insertions(+), 1 deletion(-)
diff -
The series is to add vcn unit tests for decode, and have the common
from previous uvd unit test to be shared with vcn decode.
Leo Liu (5):
tests/amdgpu: rename uvd messages to decode messages
tests/amdgpu: separate decode messages
tests/amdgpu: move decode sum to common
tests/amdgpu: add
On 05/30/2017 12:15 PM, Christian König wrote:
Am 30.05.2017 um 17:56 schrieb Leo Liu:
We need program ring buffer on instance 1 register space domain,
when only if instance 1 available, with two instances or instance 0,
and we need only program instance 0 regsiter space domain for ring
On 05/30/2017 11:13 AM, Christian König wrote:
Am 30.05.2017 um 16:57 schrieb Deucher, Alexander:
-Original Message-
From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
Of Leo Liu
Sent: Monday, May 29, 2017 2:22 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Leo
We need program ring buffer on instance 1 register space domain,
when only if instance 1 available, with two instances or instance 0,
and we need only program instance 0 regsiter space domain for ring.
Signed-off-by: Leo Liu <leo@amd.com>
Reviewed-by: Alex Deucher <alexander.deuc..
when harvest part has only instance 1 available
Signed-off-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 61 +++
1 file changed, 55 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
b/drivers/gpu/d
Signed-off-by: Leo Liu <leo@amd.com>
Reviewed-by: Alex Deucher <alexander.deuc...@amd.com>
---
include/drm/amdgpu_drm.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
index d702a95..96cccd1 100644
--- a
On 10/12/2016 07:05 AM, Christian König wrote:
Andy & Leo could you give that a brief testing?
run `kill -9' over 30 times, no issue.
Patch is:
Reviewed-and-Tested by: Leo Liu <leo@amd.com>
I currently don't have a setup for encoding/transcoding clips.
Regards,
Chri
Adapt to recent firmware update, it's also compatible with previous
firwmare version
Signed-off-by: Leo Liu <leo@amd.com>
---
tests/amdgpu/vce_ib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/amdgpu/vce_ib.h b/tests/amdgpu/vce_ib.h
index bd0bf94..80ab179
From: Christian König <christian.koe...@amd.com>
Supported starting on certain FW versions.
Signed-off-by: Christian König <christian.koe...@amd.com>
Reviewed-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu
From: Christian König <christian.koe...@amd.com>
Context buffers should be denied by default, not allowed.
Signed-off-by: Christian König <christian.koe...@amd.com>
Reviewed-by: Leo Liu <leo@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 +-
1 file changed,
401 - 461 of 461 matches
Mail list logo
