RE: [PATCH] drm/amd/display: prevent register access while in IPS

2024-06-03 Thread Li, Roman
[Public] Reviewed-by: Roman Li > -Original Message- > From: Mahfooz, Hamza > Sent: Monday, June 3, 2024 10:35 AM > To: amd-gfx@lists.freedesktop.org > Cc: Wentland, Harry ; Li, Sun peng (Leo) > ; Siqueira, Rodrigo ; > Deucher, Alexander ; Hung, Alex > ; Li

RE: [PATCH 28/46] drm/amd/display: Enable RCO for PHYSYMCLK in DCN35

2024-04-24 Thread Li, Roman
[Public] > -Original Message- > From: Wayne Lin > Sent: Wednesday, April 24, 2024 4:49 AM > To: amd-gfx@lists.freedesktop.org > Cc: Wentland, Harry ; Li, Sun peng (Leo) > ; Siqueira, Rodrigo ; > Pillai, Aurabindo ; Li, Roman > ; Lin, Wayne ; Gutierrez, > Agus

RE: [PATCH v3] drm/amd/display: Prevent potential buffer overflow in map_hw_resources

2024-02-22 Thread Li, Roman
Reviewed-by: Roman Li > -Original Message- > From: SHANMUGAM, SRINIVASAN > Sent: Wednesday, February 21, 2024 11:37 PM > To: Siqueira, Rodrigo ; Pillai, Aurabindo > ; Chung, ChiaHsuan (Tom) > ; Li, Roman > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVA

RE: [PATCH] drm/amd/display: Fix && vs || in 'edp_set_replay_allow_active()'

2024-02-12 Thread Li, Roman
[AMD Official Use Only - General] Reviewed-by: Roman Li > -Original Message- > From: amd-gfx On Behalf Of > Srinivasan Shanmugam > Sent: Friday, February 9, 2024 9:53 AM > To: Siqueira, Rodrigo ; Pillai, Aurabindo > > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > ; Lakha,

RE: [PATCH] drm/amd/display: Fix possible NULL dereference on device remove/driver unload

2024-02-12 Thread Li, Roman
[AMD Official Use Only - General] Reviewed-by: Roman Li > -Original Message- > From: amd-gfx On Behalf Of > Srinivasan Shanmugam > Sent: Tuesday, February 6, 2024 11:55 PM > To: Siqueira, Rodrigo ; Pillai, Aurabindo > > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > ;

RE: [PATCH] drm/amd/display: Fix possible use of uninitialized 'max_chunks_fbc_mode' in 'calculate_bandwidth()'

2024-02-09 Thread Li, Roman
[Public] Reviewed-by: Roman Li > -Original Message- > From: amd-gfx On Behalf Of > Srinivasan Shanmugam > Sent: Tuesday, February 6, 2024 11:55 PM > To: Siqueira, Rodrigo ; Pillai, Aurabindo > > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > ; Wentland, Harry > ; Deucher,

RE: [PATCH] drm/amd/display: Initialize 'wait_time_microsec' variable in link_dp_training_dpia.c

2024-02-09 Thread Li, Roman
[Public] Reviewed-by: Roman Li > -Original Message- > From: amd-gfx On Behalf Of > Srinivasan Shanmugam > Sent: Tuesday, February 6, 2024 11:55 PM > To: Siqueira, Rodrigo ; Pillai, Aurabindo > > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > ; Liu, Wenjing > > Subject:

RE: [PATCH] drm/amd/display: Fix possible buffer overflow in 'find_dcfclk_for_voltage()'

2024-02-09 Thread Li, Roman
[Public] > -Original Message- > From: SHANMUGAM, SRINIVASAN > Sent: Tuesday, February 6, 2024 11:55 PM > To: Siqueira, Rodrigo ; Pillai, Aurabindo > > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > ; Li, Roman > Subject: [PATCH] drm/amd/display: Fix

RE: [PATCH v2] drm/amd/display: Implement bounds check for stream encoder creation in DCN301

2024-02-06 Thread Li, Roman
[Public] Inline. > -Original Message- > From: SHANMUGAM, SRINIVASAN > Sent: Monday, February 5, 2024 10:47 PM > To: Li, Roman ; Siqueira, Rodrigo > ; Pillai, Aurabindo > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > > Subject: [PATCH v2] drm/amd/d

RE: [PATCH] drm/amd/display: Implement bounds check for stream encoder creation in DCN301

2024-02-05 Thread Li, Roman
[Public] Inline. > -Original Message- > From: SHANMUGAM, SRINIVASAN > Sent: Sunday, February 4, 2024 9:35 PM > To: Siqueira, Rodrigo ; Pillai, Aurabindo > > Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN > ; Li, Roman > Subject: [PATCH] drm/amd/d

RE: [PATCH] drm/amd/display: Remove redundant DRM device struct in amdgpu_dm_, mst_types.c

2023-11-12 Thread Li, Roman
[AMD Official Use Only - General] Reviewed-by: Roman Li > -Original Message- > From: SHANMUGAM, SRINIVASAN > Sent: Saturday, November 11, 2023 11:01 PM > To: Pillai, Aurabindo ; Siqueira, Rodrigo > ; Li, Roman ; Deucher, > Alexander ; Wentland, Harry > ; Mahfooz, H

RE: [PATCH v2] drm/amd/display: Drop unused DCN_BASE variable in dcn314_resource.c

2023-06-01 Thread Li, Roman
[Public] Reviewed-by: Roman Li > -Original Message- > From: SHANMUGAM, SRINIVASAN > Sent: Wednesday, May 31, 2023 1:46 PM > To: Pillai, Aurabindo ; Mahfooz, Hamza > ; Siqueira, Rodrigo > ; Wentland, Harry > ; Li, Roman > Cc: amd-gfx@lists.freedesktop.or

RE: [PATCH v3] drm/amd/display: fix flickering caused by S/G mode

2023-04-20 Thread Li, Roman
[Public] Reviewed-by: Roman Li > -Original Message- > From: amd-gfx On Behalf Of Hamza > Mahfooz > Sent: Thursday, April 20, 2023 9:44 AM > To: amd-gfx@lists.freedesktop.org > Cc: Wang, Chao-kai (Stylon) ; Tuikov, Luben > ; dri-de...@lists.freedesktop.org; Li, Sun peng (Leo) > ; David

RE: [PATCH 12/16] drm/amd/display: Add Function delaration in dc_link

2023-01-26 Thread Li, Roman
a, Rodrigo > ; Pillai, Aurabindo > ; Zhuo, Qingqing (Lillian) > ; Li, Roman ; Lin, Wayne > ; Wang, Chao-kai (Stylon) > ; Chiu, Solomon ; > Kotarac, Pavle ; Gutierrez, Agustin > ; Ghaddar, Mustapha > ; Lei, Jun ; Hung, Alex > > Subject: [PATCH 12/16] drm/amd/display: Ad

RE: [PATCH 2/2] drm/amd/display: disable S/G display on DCN 3.1.4

2023-01-18 Thread Li, Roman
[Public] Reviewed-by: Roman Li > -Original Message- > From: Deucher, Alexander > Sent: Wednesday, January 18, 2023 9:26 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Li, Roman > ; Zhang, Yifan > Subject: [PATCH 2/2] drm/amd/display: disable S/G

RE: [PATCH] drm/amd/display: Align dcn314_smu logging with other DCNs

2022-11-15 Thread Li, Roman
Hi Mario, Thanks for your comments. I replied inline. > -Original Message- > From: Limonciello, Mario > Sent: Monday, November 14, 2022 4:16 PM > To: Li, Roman ; amd-gfx@lists.freedesktop.org; > Deucher, Alexander ; Wentland, Harry > ; Rizvi, Saaem > Cc: Li,

RE: [PATCH 07/21] drm/amd/display: Enable dlg and vba compilation for dcn314

2022-09-07 Thread Li, Roman
bindo > ; Zhuo, Qingqing (Lillian) > ; Li, Roman ; Lin, Wayne > ; Wang, Chao-kai (Stylon) > ; Chiu, Solomon ; > Kotarac, Pavle ; Gutierrez, Agustin > > Subject: [PATCH 07/21] drm/amd/display: Enable dlg and vba compilation for > dcn314 > > From: Rodrigo Siqueira

RE: [PATCH] drm/amd/display: change family id name for DCN314

2022-08-04 Thread Li, Roman
[AMD Official Use Only - General] Reviewed-by: Roman Li > -Original Message- > From: Zhang, Yifan > Sent: Thursday, August 4, 2022 4:49 AM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Roman ; Huang, Tim ; > Deucher, Alexander ; Du, Xiaojian > ; Zhang, Yifan >

RE: [PATCH 07/16] drm/amd/display: Cap OLED brightness per max frame-average luminance

2022-06-08 Thread Li, Roman
[AMD Official Use Only - General] Hi Aaron, Yes, the panel brightness should reach max after we send max-fall value as backlight current peak. Thanks, Roman > -Original Message- > From: Aaron Ma > Sent: Wednesday, June 8, 2022 6:02 AM > To: Mahfooz, Hamza ; Li, Roman >

RE: [PATCH] drm/amd: add dc feature mask flags for PSR allow smu and multi-display optimizations

2022-04-25 Thread Li, Roman
llai, Aurabindo ; > Zhuo, Qingqing (Lillian) ; Li, Roman > ; Lin, Wayne ; Wang, Chao-kai > (Stylon) ; Chiu, Solomon ; > Kotarac, Pavle ; Gutierrez, Agustin > ; Zuo, Jerry > Subject: [PATCH] drm/amd: add dc feature mask flags for PSR allow smu and > multi-display optimizations >

RE: [PATCH] drm/amd/display: Don't fill up the logs

2022-02-25 Thread Li, Roman
: amd-gfx list ; Kuehling, Felix > ; Li, Roman ; Wu, Hersen > ; Wheeler, Daniel ; > Deucher, Alexander > Subject: Re: [PATCH] drm/amd/display: Don't fill up the logs > > I could, but if they enable KMS debug, this prints 100s of times a second. > It literally overflows the l

RE: Backlight control broken on UM325 (OLED) on 5.15 (bisected)

2021-11-17 Thread Li, Roman
[Public] Hi Samuel, Can you please try: https://patchwork.freedesktop.org/patch/463485/ ? Thanks, Roman > -Original Message- > From: Samuel Čavoj > Sent: Tuesday, November 16, 2021 8:33 AM > To: Alex Deucher > Cc: Deucher, Alexander ; Li, Sun peng (Leo) > ; Li, R

RE: [PATCH v3] drm/amd/display: Look at firmware version to determine using dmub on dcn21

2021-11-02 Thread Li, Roman
[Public] Reviewed-by: Roman Li > -Original Message- > From: Alex Deucher > Sent: Tuesday, November 2, 2021 11:58 AM > To: Limonciello, Mario > Cc: amd-gfx list ; Li, Roman > > Subject: Re: [PATCH v3] drm/amd/display: Look at firmware version to > deter

RE: [PATCH v2] drm/amd/display: Look at firmware version to determine using dmub on dcn21

2021-10-29 Thread Li, Roman
[Public] > -Original Message- > From: Alex Deucher > Sent: Friday, October 29, 2021 4:34 PM > To: Limonciello, Mario > Cc: amd-gfx list ; Li, Roman > > Subject: Re: [PATCH v2] drm/amd/display: Look at firmware version to > determine using dmub on dcn21 > >

RE: [PATCH] drm/amd/display: Fully switch to dmub for all dcn21 asics

2021-10-18 Thread Li, Roman
[Public] > -Original Message- > From: Wentland, Harry > Sent: Monday, October 18, 2021 9:57 AM > To: Limonciello, Mario ; Li, Roman > ; amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Siqueira, Rodrigo > > Cc: sta...@vger.kernel.org > Subject: Re: [PA

RE: [PATCH V2] drm/amdgpu/display: add support for multiple backlights

2021-07-27 Thread Li, Roman
[Public] Reviewed-by: Roman Li -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, July 14, 2021 3:00 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; kernel test robot Subject: [PATCH V2] drm/amdgpu/display: add support for multiple backlights

RE: [PATCH] drm/amdgpu/display: only enable aux backlight control for OLED panels

2021-07-26 Thread Li, Roman
[Public] Reviewed-by: Roman Li -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, July 21, 2021 6:18 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/display: only enable aux backlight control for OLED panels We've

RE: [PATCH] drm/amd/display: Allow bandwidth validation for 0 streams.

2021-05-20 Thread Li, Roman
[Public] Reviewed-by: Roman Li -Original Message- From: Bindu Ramamurthy Sent: Thursday, May 20, 2021 5:04 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Roman ; R, Bindu Subject: [PATCH] drm/amd/display: Allow bandwidth validation for 0 streams. [Why] Bandwidth calculations

RE: [PATCH] drm/amd/display: disable dcn10 pipe split by default

2020-12-30 Thread Li, Roman
[AMD Public Use] Reviewed-by: Roman Li mailto:roman...@amd.com>> From: Wu, Hersen Sent: Wednesday, December 30, 2020 12:12 PM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Li, Roman Subject: [PATCH] drm/amd/display: disable dcn10 pipe split by default [Why] the initial p

RE: [PATCH] drm/amd/display: Fix the display corruption issue on Navi10

2020-10-21 Thread Li, Roman
[AMD Public Use] Reviewed-by: Roman Li -Original Message- From: Yifan Zhang Sent: Wednesday, October 21, 2020 10:24 AM To: amd-gfx@lists.freedesktop.org Cc: Li, Sun peng (Leo) ; Wentland, Harry ; Li, Roman ; Zhang, Yifan1 ; Deucher, Alexander Subject: [PATCH] drm/amd/display: Fix

RE: [PATCH] drm/amd/display: Only revalidate bandwidth on medium and fast updates

2020-06-30 Thread Li, Roman
[AMD Public Use] Reviewed-by: Roman Li -Original Message- From: amd-gfx On Behalf Of Nicholas Kazlauskas Sent: Monday, June 29, 2020 4:49 PM To: amd-gfx@lists.freedesktop.org Cc: Lakha, Bhawanpreet ; Siqueira, Rodrigo ; Wu, Hersen ; Kazlauskas, Nicholas Subject: [PATCH]

RE: [PATCH 01/11] drm/amdgpu: Add ucode support for DMCUB

2019-10-31 Thread Li, Roman
On Behalf Of: Hersen Wu Series is: Reviewed-by: Hersen Wu -Original Message- From: amd-gfx On Behalf Of Nicholas Kazlauskas Sent: Monday, October 28, 2019 10:08 AM To: amd-gfx@lists.freedesktop.org Cc: Kazlauskas, Nicholas Subject: [PATCH 01/11] drm/amdgpu: Add ucode support for

RE: [PATCH] drm/amdgpu/display: add dc feature mask for psr enablement

2019-10-22 Thread Li, Roman
> Any reason why we're skipping a flag here going from 0x2 to 0x8? 0x4 is reserved for fractional pwm mask: https://patchwork.freedesktop.org/patch/336923/ Thank you Nicholas for the review. -Original Message- From: Kazlauskas, Nicholas Sent: Tuesday, October 22, 2019 8:39 AM To:

RE: [PATCH 01/29] drm/amd/display: update register field access mechanism

2019-10-11 Thread Li, Roman
Series is Reviewed-by: Roman Li -Original Message- From: amd-gfx On Behalf Of Bhawanpreet Lakha Sent: Friday, October 11, 2019 3:53 PM To: amd-gfx@lists.freedesktop.org Cc: Berthe, Abdoulaye Subject: [PATCH 01/29] drm/amd/display: update register field access mechanism From:

RE: [PATCH 2/2] drm/amd/display: update renoir_ip_offset.h

2019-09-04 Thread Li, Roman
Acked-by: Roman Li -Original Message- From: Liu, Aaron Sent: Wednesday, September 4, 2019 2:07 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Li, Roman ; Liu, Aaron Subject: [PATCH 2/2] drm/amd/display: update renoir_ip_offset.h This patch updates

RE: [PATCH] drm/amd/display: Use context parameters to enable FBC

2019-02-04 Thread Li, Roman
Reviewed-by: Roman Li -Original Message- From: amd-gfx On Behalf Of S, Shirish Sent: Monday, February 4, 2019 4:20 AM To: Li, Sun peng (Leo) ; Wu, Hersen ; Wentland, Harry Cc: amd-gfx@lists.freedesktop.org; S, Shirish Subject: [PATCH] drm/amd/display: Use context parameters to enable

RE: [PATCH 09/16] drm/amd/display: fbc state could not reach while enable fbc

2018-11-29 Thread Li, Roman
Unfortunately, not. I sent this patch to the reporter to try and it didn't work. - Roman From: amd-gfx On Behalf Of Deucher, Alexander Sent: Thursday, November 29, 2018 11:27 AM To: Li, Sun peng (Leo) ; amd-gfx@lists.freedesktop.org Cc: Wu, Hersen Subject: Re: [PATCH 09/16] drm/amd/display:

RE: linux-4.16-rc5/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c:1723]: (warning) Possible null pointer dereference: pipe_ctx

2018-03-12 Thread Li, Roman
airl...@linux.ie; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; linux-ker...@vger.kernel.org; Wentland, Harry <harry.wentl...@amd.com>; Li, Roman <roman...@amd.com> Subject: Re: linux-4.16-rc5/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c:1723]: (war