thesusis.net
> Signed-off-by: Alex Deucher
> Cc: Phillip Susi
> Cc: Luben Tuikov
Thank you Alex for this patch and thank you Phillip for testing it!
(Let's also add a Tested-by tag.)
Reviewed-by: Luben Tuikov
Regards,
Luben
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++
On 2023-11-29 22:36, Luben Tuikov wrote:
> On 2023-11-29 15:49, Alex Deucher wrote:
>> On Wed, Nov 29, 2023 at 3:10 PM Alex Deucher wrote:
>>>
>>> Actually I think I see the problem. I'll try and send out a patch
>>> later today to test.
>>
>
org/archives/amd-gfx/2023-November/101197.html
Link: https://lore.kernel.org/r/87edgv4x3i@vps.thesusis.net
Let's link the start of the thread.
Regards,
Luben
> Signed-off-by: Alex Deucher
> Cc: Phillip Susi
> Cc: Luben Tuikov
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_d
On 2023-11-29 10:22, Alex Deucher wrote:
> On Wed, Nov 29, 2023 at 8:50 AM Alex Deucher wrote:
>>
>> On Tue, Nov 28, 2023 at 11:45 PM Luben Tuikov wrote:
>>>
>>> On 2023-11-28 17:13, Alex Deucher wrote:
>>>> On Mon, Nov 27, 2023 at 6:24 PM Phillip
On 2023-11-29 08:50, Alex Deucher wrote:
> On Tue, Nov 28, 2023 at 11:45 PM Luben Tuikov wrote:
>>
>> On 2023-11-28 17:13, Alex Deucher wrote:
>>> On Mon, Nov 27, 2023 at 6:24 PM Phillip Susi wrote:
>>>>
>>>> Alex Deucher writes:
>>>&
On 2023-11-28 17:13, Alex Deucher wrote:
> On Mon, Nov 27, 2023 at 6:24 PM Phillip Susi wrote:
>>
>> Alex Deucher writes:
>>
In that case those are the already known problems with the scheduler
changes, aren't they?
>>>
>>> Yes. Those changes went into 6.7 though, not 6.6 AFAIK.
On 2023-11-21 17:05, Phillip Susi wrote:
> Alex Deucher writes:
>
>> Does reverting 56e449603f0ac580700621a356d35d5716a62ce5 alone fix it?
>> Can you also attach your full dmesg log for the failed suspend?
>
> No, it doesn't. Here is the full syslog from the boot with only that
> revert:
>
vert the GPU scheduler to variable
>> number of run-queues")
>> Signed-off-by: Alex Deucher
>> Cc: ltuiko...@gmail.com
Reviewed-by: Luben Tuikov
Regards,
Luben
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 12 +++
>> drivers/gpu/drm/am
Pushed to drm-misc-next.
Regards,
Luben
On 2023-10-26 15:52, Luben Tuikov wrote:
> On 2023-10-26 15:32, Alex Deucher wrote:
>> On Thu, Oct 26, 2023 at 2:22 AM Christian König
>> wrote:
>>>
>>> Am 25.10.23 um 19:19 schrieb Alex Deucher:
>>>> Rathe
evel init level.
>>> This should fix the scheduler init ordering.
>>>
>>> v2: drop extra parens
>>> v3: drop SDMA helpers
>>>
>>> Tested-by: Luben Tuikov
>>> Signed-off-by: Alex Deucher
>>
>> I don't know of hand i
Update the GPU Scheduler maintainer email.
Cc: Alex Deucher
Cc: Christian König
Cc: Daniel Vetter
Cc: Dave Airlie
Cc: AMD Graphics
Cc: Direct Rendering Infrastructure - Development
Signed-off-by: Luben Tuikov
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Alex Deucher
Rather than doing this in the IP code for the SDMA paging
engine, move it up to the core device level init level.
This should fix the scheduler init ordering.
v2: Fix checkpatch parens complaint; long lines. (Luben)
Signed-off-by: Alex Deucher
Tested-by: Luben Tuikov
ler init.
>>
>> @Alex, Ideas how to fix this? My best guess is that we should move the
>> call to amdgpu_ttm_set_buffer_funcs_status() from the DMA specific code
>> into the higher level handling in amdgpu_device.c
>
> Yes, I think so, but there could be some tricky ordering
On 2023-10-23 01:49, Christian König wrote:
>
>
> Am 23.10.23 um 05:23 schrieb Luben Tuikov:
>> Initialize ring schedulers before using them, very early in the amdgpu boot,
>> at PCI probe time, specifically at frame-buffer dumb-create at fill-buffer.
>>
>> Thi
Cc: Felix Kuehling
Cc: AMD Graphics
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 4e51dce3aab5d6..575ef7e1e30
On 2023-10-20 12:37, Alex Deucher wrote:
> On Tue, Oct 17, 2023 at 9:22 PM Luben Tuikov wrote:
>>
>> Remove a redundant call to amdgpu_ctx_priority_is_valid() from
>> amdgpu_ctx_priority_permit(), which is called from amdgpu_ctx_init() which is
>> called from amdgpu_
.
Cc: Alex Deucher
Cc: Christian König
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
index
On 2023-10-17 09:22, Alex Deucher wrote:
> On Tue, Oct 17, 2023 at 12:52 AM Luben Tuikov wrote:
>>
>> A context priority value of AMD_CTX_PRIORITY_UNSET is now invalid--instead of
>> carrying it around and passing it to the Direct Rendering Manager--and it
>> beco
off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 3 ++-
include/drm/gpu_scheduler.h | 3 +--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
index 092962b9306
-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
index 0dc9c655c4fbdb..092962b93064fc 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
0x16/0x40 [amdgpu]
> [ +0.000192] drm_minor_release+0x4f/0x80 [drm]
> [ +0.25] drm_release+0xfe/0x150 [drm]
> [ +0.27] __fput+0x9f/0x290
> [ +0.02] fput+0xe/0x20
> [ +0.02] task_work_run+0x61/0xa0
> [ +0.02] exit_to_user_mode_prepare+0x150/0x
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: "Pan, Xinhui"
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: "Gustavo A. R. Silva"
> Cc: Luben Tuikov
> Cc: Christophe JAILLET
> Cc: Felix Kuehling
> Cc: amd-gfx@lists.freedesk
Fix a memory leak in amdgpu_fru_get_product_info().
Cc: Alex Deucher
Reported-by: Yang Wang
Fixes: 0dbf2c56262532 ("drm/amdgpu: Interpret IPMI data for product information
(v2)")
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fru_eeprom.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On 2023-09-22 16:58, Luben Tuikov wrote:
> On 2023-09-22 01:27, Yang Wang wrote:
>> fix a memory leak that occurs when csum is 0,
>> the origin function will return directly and forgets to free 'pia' resource.
>>
>> Fixes: 0dbf2c562625 ("drm/amdgpu: Interpret IPMI
On 2023-09-22 01:27, Yang Wang wrote:
> fix a memory leak that occurs when csum is 0,
> the origin function will return directly and forgets to free 'pia' resource.
>
> Fixes: 0dbf2c562625 ("drm/amdgpu: Interpret IPMI data for product information
> (v2)")
>
>
On 2023-09-22 01:27, Yang Wang wrote:
> fix a memory leak that occurs when csum is 0,
> the origin function will return directly and forgets to free 'pia' resource.
>
> Fixes: 0dbf2c562625 ("drm/amdgpu: Interpret IPMI data for product information
> (v2)")
>
>
Alex Deucher
> Cc: Bert Karwatzki
> Cc: "Pan, Xinhui"
> Cc: Luben Tuikov
> Signed-off-by: Srinivasan Shanmugam
Yeah, looks good.
Reviewed-by: Luben Tuikov
Regards,
Luben
> ---
> v2:
> - Updated commit title as per log levels updated in this patch
> - Updated
g/drm/amd/-/issues/2744
> Cc: Guchun Chen
> Cc: Christian König
> Cc: Alex Deucher
> Cc: Bert Karwatzki
> Cc: "Pan, Xinhui"
> Cc: Luben Tuikov
> Signed-off-by: Srinivasan Shanmugam
> Reviewed-by: Guchun Chen
Reviewed-by: Luben Tuikov
Rega
On 2023-07-31 08:18, Srinivasan Shanmugam wrote:
> Fixes the following style issues:
>
> ERROR: open brace '{' following function definitions go on the next line
> WARNING: printk() should include KERN_ facility level
>
> Cc: Guchun Chen
> Cc: Christian König
> Cc: Alex Deucher
> Cc: Bert
On 2023-07-31 08:04, Srinivasan Shanmugam wrote:
> Usage of container_of is wrong here.
> struct acpi_device *adev = container_of(handle, struct acpi_device, handle)
>
> References: https://gitlab.freedesktop.org/drm/amd/-/issues/2744
> Cc: Guchun Chen
> Cc: Christian König
> Cc: Alex Deucher
On 2023-07-12 09:53, Christian König wrote:
> Am 12.07.23 um 15:38 schrieb Uwe Kleine-König:
>> Hello Maxime,
>>
>> On Wed, Jul 12, 2023 at 02:52:38PM +0200, Maxime Ripard wrote:
>>> On Wed, Jul 12, 2023 at 01:02:53PM +0200, Uwe Kleine-König wrote:
> Background is that this makes merge
On 2023-07-12 03:57, Christian König wrote:
> Am 12.07.23 um 08:58 schrieb Luben Tuikov:
>> Rename struct amdgpu_vm_tlb_seq_cb {...} to struct amdgpu_vm_tlb_seq_struct
>> {...}, so as to not conflict with documentation processing tools. Of course,
>> C
>> has no proble
-7b512d34b...@infradead.org
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 92a84e7b0db85b..32adc31c093d84 100644
s bug.
Cc: Tao Zhou
Cc: Hawking Zhang
Cc: Alex Deucher
Fixes: 400013b268cb66 ("drm/amdgpu: add umc_fill_error_record to make code more
simple")
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --gi
sily shown in a single file.
Cc: Alex Deucher
Cc: Hawking Zhang
Cc: Tao Zhou
Cc: Stanley Yang
Cc: John Clements
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/
On 2023-05-25 12:29, Nathan Chancellor wrote:
> On Thu, May 25, 2023 at 12:26:56PM -0400, Luben Tuikov wrote:
>> On 2023-05-25 11:22, Nathan Chancellor wrote:
>>> On Fri, May 19, 2023 at 06:14:38PM +0530, Srinivasan Shanmugam wrote:
>>>> Silencing the compile
to clang that this
>> is expected, so there is no more warning.
>>
>> Cc: Christian König
>> Cc: Lijo Lazar
>> Cc: Luben Tuikov
>> Cc: Alex Deucher
>> Signed-off-by: Srinivasan Shanmugam
>
> Traditionally, this attribute would go between t
Acked-by: Luben Tuikov
Regards,
Luben
On 2023-05-17 11:56, Srinivasan Shanmugam wrote:
> Fix below checkpatch errors & warnings:
>
> In amdgpu_uvd.c:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> WARNING: Prefer 'unsigned int *' to bare use of 'unsigned
Acked-by: Luben Tuikov
Regards,
Luben
On 2023-05-17 11:13, Srinivasan Shanmugam wrote:
> Fix below checkpatch insisted error & warnings:
>
> ERROR: space required before the open brace '{'
> WARNING: braces {} are not necessary for any arm of this statement
>
Acked-by: Luben Tuikov
Regards,
Luben
On 2023-05-17 09:11, Srinivasan Shanmugam wrote:
> Fix below checkpatch warnings:
>
> WARNING: Missing a blank line after declarations
> + struct amdgpu_connector *amdgpu_connector =
> to_amdgpu_conn
Acked-by: Luben Tuikov
Regards,
Luben
On 2023-05-17 10:45, Srinivasan Shanmugam wrote:
> Fix below checkpatch insisted error & warnings:
>
> ERROR: Macros with complex values should be enclosed in parentheses
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
&
On 2023-05-10 10:24, vitaly prosyak wrote:
>
> On 2023-05-10 10:19, Luben Tuikov wrote:
>> On 2023-05-10 09:51, vitaly.pros...@amd.com wrote:
>>> From: Vitaly Prosyak
>>>
>>> During an IGT GPU reset test we see again oops despite of
>>> commit
occur.
>
> Use the field timeout_wq to prevent oops for uninitialized schedulers.
> The field could be initialized by the work queue of resetting the domain.
>
> Fixes: 0c8c901aaaebc9 ("drm/sched: Check scheduler ready before calling
> timeout handling")
>
> v1: Corr
On 2023-05-09 17:43, vitaly.pros...@amd.com wrote:
> From: Vitaly Prosyak
>
> During an IGT GPU reset test we see again oops despite of
> commit 0c8c901aaaebc9bf8bf189ffc116e678f7a2dc16
> drm/sched: Check scheduler ready before calling timeout handling.
You can probably use the more succinct
I suppose we have this information elsewhere.
Series is:
Reviewed-by: Luben Tuikov
Regards,
Luben
On 2023-05-03 11:02, Alex Deucher wrote:
> Ping?
>
> On Thu, Apr 27, 2023 at 2:34 PM Alex Deucher
> wrote:
>>
>> amdgpu_discovery_get_ip_version() has not been used sinc
Reviewed-by: Luben Tuikov
Regards,
Luben
On 2023-05-01 10:55, Alex Deucher wrote:
> Ping?
>
> Alex
>
> On Fri, Apr 28, 2023 at 11:57 AM Alex Deucher
> wrote:
>>
>> Reduces preemption latency.
>> Only enable this for gfx10 and 11 for now
>> to avoid
Hi Christian,
Thanks for working on this.
Series is,
Reviewed-by: Luben Tuikov
Regards,
Luben
On 2023-04-20 07:57, Christian König wrote:
> When a hw fence is signaled with an error properly forward that to the
> finished fence.
>
> Signed-off-by: Christian König
> ---
>
On 2023-04-11 17:39, Alex Deucher wrote:
> On Thu, Apr 6, 2023 at 4:01 PM Luben Tuikov wrote:
>>
>> From: Vitaly Prosyak
>>
>> During an IGT GPU reset test we see the following oops,
>>
>> [ +0.03] [ cut here ]
>> [
Acked-by: Luben Tuikov
Regards,
Luben
On 2023-04-06 06:13, Tong Liu01 wrote:
> [why]
> regGOLDEN_TSC_COUNT_LOWER/regGOLDEN_TSC_COUNT_UPPER are protected and
> unaccessible under sriov.
> The clock counter high bit may update during reading process.
>
> [How]
> Replace regG
the given scheduler worker thread runs and whether the timeout_wq of the reset
domain has been initialized.
Signed-off-by: Vitaly Prosyak
Cc: Christian König
Reviewed-by: Luben Tuikov
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/scheduler/sched_main.c | 3 ++-
1 file changed, 2 insertions(+), 1
On 2023-04-05 06:06, Shashank Sharma wrote:
>
> On 04/04/2023 22:58, Luben Tuikov wrote:
>> On 2023-04-04 12:36, Shashank Sharma wrote:
>>> On 04/04/2023 18:30, Luben Tuikov wrote:
>>>> On 2023-03-29 12:04, Shashank Sharma wrote:
>>>>> From:
Reviewed-by: Luben Tuikov
Regards,
Luben
On 2023-04-05 05:45, Lijo Lazar wrote:
> Fix below warning due to incompatible types in conditional operator
>
> ../pm/swsmu/smu13/smu_v13_0_6_ppt.c:315:17: sparse: sparse: incompatible
> types in conditional expression (differen
Hi!
On 2023-04-04 04:50, Christian König wrote:
> Adding a bunch of people who have been involved in this before.
>
> Am 03.04.23 um 22:15 schrieb Joshua Ashton:
>> On 4/3/23 20:54, Christian König wrote:
>>> Am 03.04.23 um 21:40 schrieb Joshua Ashton:
[SNIP]
Anyway, please let me know
On 2023-04-04 12:36, Shashank Sharma wrote:
>
> On 04/04/2023 18:30, Luben Tuikov wrote:
>> On 2023-03-29 12:04, Shashank Sharma wrote:
>>> From: Shashank Sharma
>>>
>>> This patch adds new functions to map/unmap a usermode queue into
>>> the
On 2023-03-29 12:04, Shashank Sharma wrote:
> From: Shashank Sharma
>
> This patch adds new functions to map/unmap a usermode queue into
> the FW, using the MES ring. As soon as this mapping is done, the
> queue would be considered ready to accept the workload.
>
> V1: Addressed review
On 2023-03-29 12:04, Shashank Sharma wrote:
> From: Shashank Sharma
>
> The FW expects us to allocate atleast one page as context space to
> process gang, process, shadow, GDS and FW related work. This patch
> creates a joint object for the same, and calculates GPU space offsets
> for each of
On 2023-03-29 12:04, Shashank Sharma wrote:
> From: Shashank Sharma
>
> A Memory queue descriptor (MQD) of a userqueue defines it in the harware's
> context. As MQD format can vary between different graphics IPs, we need gfx
> GEN specific handlers to create MQDs.
>
> This patch:
> - Introduces
On 2023-03-29 11:47, Shashank Sharma wrote:
> From: Shashank Sharma
>
> Rename doorbell.num_doorbells to doorbell.num_kernel_doorbells to
> make it more readable.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-off-by: Shashank Sharma
> ---
Is there any reason you break up the Cc list
On 2023-03-29 12:04, Shashank Sharma wrote:
> From: Shashank Sharma
>
> This patch adds skeleton code for amdgpu usermode queue. It contains:
> - A new files with init functions of usermode queues.
> - A queue context manager in driver private data.
>
> V1: Worked on design review comments from
This patch is,
Reviewed-by: Luben Tuikov
Regards,
Luben
On 2023-03-31 15:54, Alex Deucher wrote:
> All chips that support RAS also support IP discovery, so
> use the IP versions rather than a mix of IP versions and
> asic types. Checking the validity of the atom_ctx pointer
> is
On 2023-03-31 15:30, Alex Deucher wrote:
> On Tue, Mar 28, 2023 at 12:30 PM Luben Tuikov wrote:
>>
>> On 2023-03-27 20:11, Alex Deucher wrote:
>>> All chips that support RAS also support IP discovery, so
>>> use the IP versions rather than a mix of IP versions a
On 2023-03-29 11:47, Shashank Sharma wrote:
> This patch adds a helper function which converts a doorbell's
> relative index in a BO to an absolute doorbell offset in the
> doorbell BAR.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-off-by: Shashank Sharma
> ---
>
On 2023-03-30 10:53, Shashank Sharma wrote:
>
> On 30/03/2023 16:49, Christian König wrote:
>> Am 30.03.23 um 16:40 schrieb Shashank Sharma:
>>>
>>> On 30/03/2023 16:24, Luben Tuikov wrote:
>>>> On 2023-03-29 11:47, Shashank Sharma wrote:
>>&
On 2023-03-30 10:49, Christian König wrote:
> Am 30.03.23 um 16:40 schrieb Shashank Sharma:
>>
>> On 30/03/2023 16:24, Luben Tuikov wrote:
>>> On 2023-03-29 11:47, Shashank Sharma wrote:
>>>> From: Shashank Sharma
>>>>
>>>> This patc
On 2023-03-30 10:37, Shashank Sharma wrote:
>
> On 30/03/2023 16:34, Luben Tuikov wrote:
>> On 2023-03-29 11:47, Shashank Sharma wrote:
>>> This patch:
>>> - updates start/end values for each of the doorbell object
>>>created.
>>> - adds a f
On 2023-03-30 10:28, Alex Deucher wrote:
> On Wed, Mar 29, 2023 at 11:48 AM Shashank Sharma
> wrote:
>>
>> From: Shashank Sharma
>>
>> This patch adds helper functions to create and free doorbell
>> pages for kernel objects.
>
> I think we can probably drop this patch. I think it would be
On 2023-03-30 10:34, Shashank Sharma wrote:
>
> On 30/03/2023 16:15, Luben Tuikov wrote:
>> On 2023-03-30 10:04, Shashank Sharma wrote:
>>> On 30/03/2023 15:42, Luben Tuikov wrote:
>>>> On 2023-03-29 11:47, Shashank Sharma wrote:
>>>>> From: Sha
On 2023-03-29 11:47, Shashank Sharma wrote:
> This patch:
> - updates start/end values for each of the doorbell object
> created.
> - adds a function which validates that the kernel doorbell read/write
> is within this range.
> - uses this function during doorbell writes from kernel.
>
> Cc:
On 2023-03-29 11:47, Shashank Sharma wrote:
> From: Shashank Sharma
>
> This patch:
> - creates a doorbell page for graphics driver usages.
> - removes the adev->doorbell.ptr variable, replaces it with
> kernel-doorbell-bo's cpu address.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
>
On 2023-03-30 10:04, Shashank Sharma wrote:
>
> On 30/03/2023 15:42, Luben Tuikov wrote:
>> On 2023-03-29 11:47, Shashank Sharma wrote:
>>> From: Shashank Sharma
>>>
>>> This patch adds helper functions to create and free doorbell
>>> pages for
On 2023-03-30 09:48, Shashank Sharma wrote:
>
> On 30/03/2023 15:45, Luben Tuikov wrote:
>> On 2023-03-30 09:43, Shashank Sharma wrote:
>>> On 30/03/2023 15:33, Luben Tuikov wrote:
>>>> On 2023-03-30 07:14, Christian König wrote:
>>>>> Am 29.03.
As I'm reviewing this, it is obvious that this patchset hasn't gone
though scripts/checkpatch.pl.
It's good practice to run one's patches through scripts/checkpatch.pl,
to see deviations on common Linux practices, and correct them.
Regards,
Luben
On 2023-03-29 11:47, Shashank Sharma wrote:
>
On 2023-03-30 09:43, Shashank Sharma wrote:
>
> On 30/03/2023 15:33, Luben Tuikov wrote:
>> On 2023-03-30 07:14, Christian König wrote:
>>> Am 29.03.23 um 17:47 schrieb Shashank Sharma:
>>>> From: Alex Deucher
>>>>
>>>> This patch adds c
On 2023-03-30 09:42, Luben Tuikov wrote:
> On 2023-03-29 11:47, Shashank Sharma wrote:
>> From: Shashank Sharma
>>
>> This patch adds helper functions to create and free doorbell
>> pages for kernel objects.
>>
>> Cc: Alex Deucher
>> Cc: Christ
On 2023-03-29 11:47, Shashank Sharma wrote:
> From: Shashank Sharma
>
> This patch adds helper functions to create and free doorbell
> pages for kernel objects.
>
> Cc: Alex Deucher
> Cc: Christian Koenig
> Signed-off-by: Shashank Sharma
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h
On 2023-03-30 07:14, Christian König wrote:
> Am 29.03.23 um 17:47 schrieb Shashank Sharma:
>> From: Alex Deucher
>>
>> This patch adds changes:
>> - to accommodate the new GEM domain DOORBELL
>> - to accommodate the new TTM PL DOORBELL
>>
>> in order to manage doorbell pages as GEM object.
>>
>>
Hi Shashank,
Inline:
On 2023-03-30 07:09, Christian König wrote:
> Am 29.03.23 um 17:47 schrieb Shashank Sharma:
>> From: Shashank Sharma
>>
>> This patch:
>> - creates a new file for doorbell management.
>> - moves doorbell code from amdgpu_device.c to this file.
>>
>> Cc: Alex Deucher
>> Cc:
b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h
> index 7199b6b0be81..12263986f889 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_doorbell.h
> @@ -29,7 +29,9 @@ struct amdgpu_doorbell {
> resource_size_t base;
> resource_size_t size;
> u32 __iomem *ptr;
> - u32 num_doorbells; /* Number of doorbells actually
> reserved for amdgpu. */
> +
> + /* Number of doorbells reserved for amdgpu kernel driver */
> + u32 num_kernel_doorbells;
The variable name should be indented to the same column as the previous
variables.
u32 num_kernel_doorbells;
With that change, this patch is
Acked-by: Luben Tuikov
--
Regards,
Luben
> };
>
> /* Reserved doorbells for amdgpu (including multimedia).
Hi Alan,
Inline:
On 2023-03-30 06:48, Christian König wrote:
> Am 30.03.23 um 11:15 schrieb Liu, HaoPing (Alan):
>>
>> [AMD Official Use Only - General]
>>
>>
>>
>> Hi Christian,
>>
>>
>>
>> Thanks for the review. Please see inline.
>>
>>
>>
>> Best Regards,
>>
>> Alan
>>
>>
>>
>>
Hi Alan,
I'll comment in the other thread, as it seems Christian commented directly to
your
patch the day after my comment, rather than following up with my email sent the
previous
day and we now have two divergent threads where you post two identical
comments, and it shouldn't
be like
Series is,
Acked-by: Luben Tuikov
Regards,
Luben
On 2023-03-29 06:51, Tong Liu01 wrote:
> User can check pp_dpm_vclk1 and pp_dpm_dclk1 for DPM frequency of
> vcn and dcn
>
> Signed-off-by: Tong Liu01
> ---
> .../gpu/drm/amd/include/kgd_pp_interface.h| 2 ++
> d
On 2023-03-27 20:11, Alex Deucher wrote:
> All chips that support RAS also support IP discovery, so
> use the IP versions rather than a mix of IP versions and
> asic types.
>
> Signed-off-by: Alex Deucher
> Cc: Luben Tuikov
> ---
> .../gpu/drm/amd/amdgpu/amd
Looks good--thanks!
Acked-by: Luben Tuikov
Regards,
Luben
On 2023-03-28 07:41, Tong Liu01 wrote:
> Add sysfs node pp_dpm_vclk1 for gc11.0.3
>
> Signed-off-by: Tong Liu01
> ---
> .../gpu/drm/amd/include/kgd_pp_interface.h| 1 +
> drivers/gpu/drm/amd/pm/amdgpu_pm
Hi,
That's a good fix. Some questions and comments below:
On 2023-03-27 11:20, Alan Liu wrote:
> [Why]
> After gpu-reset, sometimes the driver would fail to enable vblank irq,
> causing flip_done timed out and the desktop freezed.
>
> During gpu-reset, we will disable and enable vblank irq in
Pushed through drm-misc-next.
Regards,
Luben
On 2023-03-27 11:02, Luben Tuikov wrote:
> Thanks for the fix. I'll push this via amd-staging-drm-next.
>
> Reviewed-by: Luben Tuikov
>
> Regards,
> Luben
>
> On 2023-03-25 09:15, Caio Novais wrote:
>> Compilin
Thanks for the fix. I'll push this via amd-staging-drm-next.
Reviewed-by: Luben Tuikov
Regards,
Luben
On 2023-03-25 09:15, Caio Novais wrote:
> Compiling AMD GPU drivers displays two warnings:
>
> drivers/gpu/drm/scheduler/sched_main.c:738: warning: Function parameter or
>
On 2023-03-23 09:29, Christian König wrote:
> Am 23.03.23 um 13:04 schrieb Srinivasan Shanmugam:
>> CC drivers/gpu/drm/amd/amdgpu/amdgpu_ras.o
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2567:28: error: bitwise or with
>> non-zero value always evaluates to true
>>
: Alex Deucher
Fixes: 15822529468331 ("drm/amdgpu: Add EEPROM I2C address for smu v13_0_0")
Fixes: c9bdc6c3cf39df ("drm/amdgpu: Add EEPROM I2C address support for ip
discovery")
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 9
the switch is final and
terminal, and that there should be no code after the switch.
Cc: Candice Li
Cc: Kent Russell
Cc: Alex Deucher
Signed-off-by: Luben Tuikov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff -
on the command line, in order to
exclude more than one suite and/or suite and test combination from being run.
Cc: Alex Deucher
Signed-off-by: Luben Tuikov
---
tests/amdgpu/amdgpu_test.c | 187 ++---
1 file changed, 152 insertions(+), 35 deletions(-)
diff --git a/tests
Add -s and -t to the help output, as well as sort
the options output alphabetically.
Cc: Alex Deucher
Signed-off-by: Luben Tuikov
---
tests/amdgpu/amdgpu_test.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
MR 291 has been updated.
diff --git a/tests/amdgpu
Fix the Usage: string on -h (help) in amdgpu_tests.c,
so brackets match, and remove mismatched angle brackets.
Cc: Alex Deucher
Signed-off-by: Luben Tuikov
---
tests/amdgpu/amdgpu_test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/amdgpu/amdgpu_test.c b/tests
Add umrgui to bash command line completion as well.
Cc: Tom StDenis
Signed-off-by: Luben Tuikov
---
scripts/umr-completion.bash | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/umr-completion.bash b/scripts/umr-completion.bash
index 344095b5d0633d..8bb2e7abb1fe97 100644
m in fence_drv
* and they will remain unsignaled during sa_bo free.
*/
job = container_of(old, struct amdgpu_job, hw_fence);
if (!job->base.s_fence && !dma_fence_is_signaled(old))
dma_fence_signal
On 2023-03-08 21:27, YuBiao Wang wrote:
> v2: Add comments to clarify in the code.
>
> [Why]
> For engines not supporting soft reset, i.e. VCN, there will be a failed
> ib test before mode 1 reset during asic reset. The fences in this case
> are never signaled and next time when we try to free
On 2023-03-07 15:36, Luben Tuikov wrote:
> + job = container_of(old, struct amdgpu_job, hw_fence);
> + if (!job->base.s_fence && !dma_fence_is_signaled(old))
> + dma_fence_signal(old);
Thinking abou
Hi,
Thanks for your patch!
On 2023-03-07 02:07, Christian König wrote:
> Am 07.03.23 um 08:02 schrieb YuBiao Wang:
>> [Why]
>> For engines not supporting soft reset, i.e. VCN, there will be a failed
>> ib test before mode 1 reset during asic reset. The fences in this case
>> are never signaled
On 2023-02-28 03:33, Christian König wrote:
> This adds the infrastructure for an execution context for GEM buffers
> which is similar to the existinc TTMs execbuf util and intended to replace
> it in the long term.
>
> The basic functionality is that we abstracts the necessary loop to lock
>
On 2023-02-28 14:13, Danilo Krummrich wrote:
> On 2/28/23 09:33, Christian König wrote:
>> This adds the infrastructure for an execution context for GEM buffers
>> which is similar to the existinc TTMs execbuf util and intended to replace
>
> "existing"
>
>> it in the long term.
>>
>> The basic
Hi Guilherme,
Thanks for redoing to a v3. This patch is:
Reviewed-by: Luben Tuikov
Regards,
Luben
On 2023-02-02 08:48, Guilherme G. Piccoli wrote:
> Currently amdgpu calls drm_sched_fini() from the fence driver sw fini
> routine - such function is expected to be called only
1 - 100 of 878 matches
Mail list logo
