[ANNOUNCE] libdrm 2.4.88

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 libdrm 2.4.88 has been released. Andrey Grodzovsky (1): amdgpu: Fix wrappers for AMDGPU_VM IOCTL. Marek Olšák (1): configure.ac: bump version for release git tag: libdrm-2.4.88 https://dri.freedesktop.org/libdrm/libdrm-2.4.88

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

process, not just a context. > > Regards, > Christian. > > > Am 31.10.2017 um 16:57 schrieb Marek Olšák: >> >> I addressed the feedback and pushed the patch. >> >> Marek >> >> On Tue, Oct 31, 2017 at 4:50 PM, Michel Dänzer <mic...@daenzer.net>

Re: [Mesa-dev] [PATCH] amdgpu: Add R600_DEBUG flag to reserve VMID per ctx.

I addressed the feedback and pushed the patch. Marek On Tue, Oct 31, 2017 at 4:50 PM, Michel Dänzer wrote: > On 31/10/17 04:40 PM, Andrey Grodzovsky wrote: >> Signed-off-by: Andrey Grodzovsky > > [...] > >> diff --git

[ANNOUNCE] libdrm 2.4.87

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 libdrm 2.4.87 has been released. Marek Olšák (2): amdgpu: fix 32-bit build configure.ac: bump version for release git tag: libdrm-2.4.87 https://dri.freedesktop.org/libdrm/libdrm-2.4.87.tar.bz2 MD5: b4f9063838559d08649d45fec2d1184a

[ANNOUNCE] libdrm 2.4.86

whitespace issues Marek Olšák (1): configure.ac: bump version for release git tag: libdrm-2.4.86 https://dri.freedesktop.org/libdrm/libdrm-2.4.86.tar.bz2 MD5: 8dabf172c9695c24d000cbddfa849a82 libdrm-2.4.86.tar.bz2 SHA1: b2c428326843dfaa5fb88899b8dfaa43b792dc70 libdrm-2.4.86.tar.bz2

Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

gmail.com> 于 2017年9月30日 下午11:56写道： > > The idea sounds good. > > Marek > > On Sat, Sep 30, 2017 at 3:55 AM, Chunming Zhou <zhou...@amd.com> wrote: >> My mean is like the attached, I revert part of yours. >> >> Regards, >> >> David zhou >> >&g

[ANNOUNCE] libdrm 2.4.84

data corruption issue Jan Vesely (1): amdgpu: Do not write beyond allocated memory when parsing ids Marek Olšák (7): amdgpu: print error messages when amdgpu_device_initialize is failing include: sync drm.h and amdgpu_drm.h with airlied/drm-next amdgpu: add sync_file import

Re: [PATCH] drm/amdgpu: introduce AMDGPU_GEM_CREATE_EXPLICIT_SYNC v2

On Thu, Sep 21, 2017 at 4:38 PM, Andres Rodriguez wrote: > Hi Christian, > > The reference radv patches are on the list. The basic idea is to only set > the explicit sync flag for buffers allocated for dri usage. Did you mean "only set the explicit sync flag for buffers NOT

Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

The idea sounds good. Marek On Sat, Sep 30, 2017 at 3:55 AM, Chunming Zhou <zhou...@amd.com> wrote: > My mean is like the attached, I revert part of yours. > > Regards, > > David zhou > > > > On 2017年09月29日 22:15, Marek Olšák wrote: >> >> On F

Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

On Fri, Sep 29, 2017 at 4:13 PM, Marek Olšák <mar...@gmail.com> wrote: > On Fri, Sep 29, 2017 at 4:44 AM, Chunming Zhou <zhou...@amd.com> wrote: >> >> >> On 2017年09月13日 04:42, Marek Olšák wrote: >>> >>> From: Marek Olšák <marek.ol...@a

Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

On Fri, Sep 29, 2017 at 4:44 AM, Chunming Zhou <zhou...@amd.com> wrote: > > > On 2017年09月13日 04:42, Marek Olšák wrote: >> >> From: Marek Olšák <marek.ol...@amd.com> >> >> For amdgpu. >> >> drm_syncobj_create is renamed to drm_syncob

Re: [PATCH libdrm 2/4] drm: add drmSyncobjWait wrapper

On Fri, Sep 29, 2017 at 4:12 AM, Chunming Zhou <zhou...@amd.com> wrote: > > > On 2017年09月29日 06:10, Marek Olšák wrote: >> >> From: Marek Olšák <marek.ol...@amd.com> >> >> --- >> include/drm/drm.h | 24 >> xf8

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

On Fri, Sep 29, 2017 at 1:42 AM, Dave Airlie <airl...@gmail.com> wrote: > On 29 September 2017 at 06:41, Marek Olšák <mar...@gmail.com> wrote: >> Can I get Rb for this series? >> > > For the series, > > Reviewed-by: Dave Airlie <airl...@redhat.com> >

[PATCH libdrm 2/4] drm: add drmSyncobjWait wrapper

From: Marek Olšák <marek.ol...@amd.com> --- include/drm/drm.h | 24 xf86drm.c | 22 ++ xf86drm.h | 3 +++ 3 files changed, 49 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index bf3674a..4da1667

[PATCH libdrm 3/4] amdgpu: add amdgpu_cs_syncobj_wait

From: Marek Olšák <marek.ol...@amd.com> v2: update amdgpu-symbol-check --- amdgpu/amdgpu-symbol-check | 1 + amdgpu/amdgpu.h| 20 amdgpu/amdgpu_cs.c | 12 3 files changed, 33 insertions(+) diff --git a/amdgpu/amdgpu-symbol-check b/

[PATCH libdrm 4/4] amdgpu: add amdgpu_cs_fence_to_handle

From: Marek Olšák <marek.ol...@amd.com> v2: update amdgpu-symbol-check --- amdgpu/amdgpu-symbol-check | 1 + amdgpu/amdgpu.h| 14 ++ amdgpu/amdgpu_cs.c | 22 ++ include/drm/amdgpu_drm.h | 21 + 4 files chang

[PATCH libdrm 1/4] amdgpu: add sync_file import and export functions

From: Marek Olšák <marek.ol...@amd.com> v2: update amdgpu-symbol-check --- amdgpu/amdgpu-symbol-check | 2 ++ amdgpu/amdgpu.h| 30 ++ amdgpu/amdgpu_cs.c | 20 3 files changed, 52 insertions(+) diff --git a/amdgpu/

Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

On Thu, Sep 14, 2017 at 10:01 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote: > On 14 September 2017 at 08:56, Emil Velikov <emil.l.veli...@gmail.com> wrote: >> Hi Marek, >> >> On 12 September 2017 at 21:42, Marek Olšák <mar...@gmail.com> wrote: >

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

Can I get Rb for this series? Thanks, Marek On Tue, Sep 12, 2017 at 10:42 PM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@amd.com> > > for being able to convert an amdgpu fence into one of the handles. > Mesa will use this. > > Signed

Re: [PATCH 5/5] drm/amd/sched: signal and free remaining fences in amd_sched_entity_fini

Thanks for this series. I can finally finish piglit on VI. Marek On Thu, Sep 28, 2017 at 4:55 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Highly concurrent Piglit runs can trigger a race condition where a pending > SDMA job on a buffer

Re: [PATCH 11/18] drm/amdgpu:add vgt_flush for gfx9

Yes, the UMD does it. Marek On Mon, Sep 18, 2017 at 11:18 AM, Christian König wrote: > Am 18.09.2017 um 08:11 schrieb Monk Liu: >> >> Change-Id: I584572cfb9145ee1b8d11d69ba2989bd6acfd706 >> Signed-off-by: Monk Liu > > > I could be wrong, but

Re: [PATCH] drm/amdgpu: revert tile table update for oland

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Mon, Sep 11, 2017 at 5:43 PM, Jean Delvare <jdelv...@suse.de> wrote: > Several users have complained that the tile table update broke Oland > support. Despite several attempts to fix it, the root cause is still >

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

On Wed, Sep 13, 2017 at 3:46 PM, Zhou, David(ChunMing) wrote: > For android using mesa instance, egl draw will dequeue an android buffer, > after egl draw, the buffer will back to android bufffer queue, but need > append a syncfile fd. If getting syncfile fd for every egl

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

On Wed, Sep 13, 2017 at 1:32 PM, Zhou, David(ChunMing) wrote: > Could you describe how difficult to directly use CS syncfile fd in Mesa > compared with concerting CS seq to syncfile fd via several syncobj ioctls? It just simplifies things. Mesa primarily uses seq_no-based

Re: [PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

On Wed, Sep 13, 2017 at 5:03 AM, zhoucm1 wrote: > Hi Marek, > > You're doing same things with me, see my "introduce syncfile as fence > reuturn" patch set, which makes things more simple, we just need to directly > return syncfile fd to UMD when CS, then the fence UMD get

[PATCH libdrm 3/4] amdgpu: add amdgpu_cs_syncobj_wait

From: Marek Olšák <marek.ol...@amd.com> --- amdgpu/amdgpu.h| 20 amdgpu/amdgpu_cs.c | 12 2 files changed, 32 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index b44b9b6..979acfc 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -

[PATCH libdrm 4/4] amdgpu: add amdgpu_cs_fence_to_handle

From: Marek Olšák <marek.ol...@amd.com> --- amdgpu/amdgpu.h | 14 ++ amdgpu/amdgpu_cs.c | 22 ++ include/drm/amdgpu_drm.h | 21 + 3 files changed, 57 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 9

[PATCH libdrm 2/4] drm: add drmSyncobjWait wrapper

From: Marek Olšák <marek.ol...@amd.com> --- include/drm/drm.h | 24 xf86drm.c | 22 ++ xf86drm.h | 3 +++ 3 files changed, 49 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index bf3674a..4da1667

[PATCH libdrm 1/4] amdgpu: add sync_file import and export functions

From: Marek Olšák <marek.ol...@amd.com> --- amdgpu/amdgpu.h| 30 ++ amdgpu/amdgpu_cs.c | 20 2 files changed, 50 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 238b1aa..b44b9b6 100644 --- a/amdgpu/amdgpu.h +++ b/

[PATCH 2/3] drm/syncobj: add a new helper drm_syncobj_get_fd

From: Marek Olšák <marek.ol...@amd.com> Signed-off-by: Marek Olšák <marek.ol...@amd.com> --- drivers/gpu/drm/drm_syncobj.c | 33 +++-- include/drm/drm_syncobj.h | 1 + 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/d

[PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

From: Marek Olšák <marek.ol...@amd.com> For amdgpu. drm_syncobj_create is renamed to drm_syncobj_create_as_handle, and new helpers drm_syncobj_create and drm_syncobj_get_handle are added. Signed-off-by: Marek Olšák <marek.ol...@amd.com> --- drivers/gpu/drm/drm_sy

[PATCH 3/3] drm/amdgpu: add FENCE_TO_HANDLE ioctl that returns syncobj or sync_file

From: Marek Olšák <marek.ol...@amd.com> for being able to convert an amdgpu fence into one of the handles. Mesa will use this. Signed-off-by: Marek Olšák <marek.ol...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgp

[PATCH libdrm] amdgpu: print error messages when amdgpu_device_initialize is failing

From: Marek Olšák <marek.ol...@amd.com> --- amdgpu/amdgpu_device.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c index 9a238d9..2b31c45 100644 --- a/amdgpu/amdgpu_device.c +++ b/amdgpu/amdgpu_de

Re: [PATCH] drm/amdgpu: fix VM sync with always valid BOs

The hang seems to be gone with this patch. Marek On Fri, Sep 8, 2017 at 2:26 PM, Christian König wrote: > Marek this one will most likely fix your issues with always valid BOs on > Raven. > > Please give it a try when you have time. > > Thanks, > Christian. > > > Am

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

On Fri, Sep 1, 2017 at 5:36 PM, Marek Olšák <mar...@gmail.com> wrote: > On Thu, Jul 6, 2017 at 3:17 AM, Dave Airlie <airl...@gmail.com> wrote: >> From: Dave Airlie <airl...@redhat.com> >> >> This adds kernel semaphore support to the command submission >

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

On Thu, Jul 6, 2017 at 3:17 AM, Dave Airlie wrote: > From: Dave Airlie > > This adds kernel semaphore support to the command submission > interface in what should be a backwards compatible manner, > it adds a new command submission API. > > Signed-off-by:

Re: [PATCH 9/9] drm/amdgpu: WIP add IOCTL interface for per VM BOs

m 28.08.2017 um 14:59 schrieb Zhou, David(ChunMing): > > I will push our vulkan guys to test it, their bo list is very long. > > 发自坚果 Pro > > Christian K鰊ig <deathsim...@vodafone.de> 于 2017年8月28日 下午7:55写道： > > Am 28.08.2017 um 06:21 schrieb zhoucm1: >> >> >&

Re: [PATCH 9/9] drm/amdgpu: WIP add IOCTL interface for per VM BOs

On Fri, Aug 25, 2017 at 3:00 PM, Christian König wrote: > Am 25.08.2017 um 12:32 schrieb zhoucm1: >> >> >> >> On 2017年08月25日 17:38, Christian König wrote: >>> >>> From: Christian König >>> >>> Add the IOCTL interface so that applications can

Re: [PATCH] drm/amdgpu: Fix undue fallthroughs in golden registers initialization

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Sun, Jul 30, 2017 at 10:18 AM, Jean Delvare <jdelv...@suse.de> wrote: > As I was staring at the si_init_golden_registers code, I noticed that > the Pitcairn initialization silently falls through the Cape Verd

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

On Jul 19, 2017 10:21 PM, "zhoucm1" <david1.z...@amd.com> wrote: On 2017年07月19日 23:34, Marek Olšák wrote: On Jul 19, 2017 3:36 AM, "zhoucm1" <david1.z...@amd.com> wrote: On 2017年07月19日 04:08, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd

Re: [Mesa-dev] [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

On Jul 19, 2017 3:36 AM, "zhoucm1" <david1.z...@amd.com> wrote: On 2017年07月19日 04:08, Marek Olšák wrote: > From: Marek Olšák <marek.ol...@amd.com> > > For lower overhead in the CS ioctl. > Winsys allocators are not used with interprocess-sharable resources.

Re: [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

On Tue, Jul 18, 2017 at 5:11 PM, Michel Dänzer <mic...@daenzer.net> wrote: > On 18/07/17 04:08 PM, Marek Olšák wrote: >> >> From: Marek Olšák <marek.ol...@amd.com> >> >> For lower overhead in the CS ioctl. >> Winsys allocators are not used w

[RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing (v2)

From: Marek Olšák <marek.ol...@amd.com> For lower overhead in the CS ioctl. Winsys allocators are not used with interprocess-sharable resources. v2: It shouldn't crash anymore, but the kernel will reject the new flag. --- src/gallium/drivers/radeon/r600_buffer_common.c | 7 + src/g

Re: [RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing

For comments only. There are some assertion failures. Marek On Tue, Jul 18, 2017 at 1:47 PM, Marek Olšák <mar...@gmail.com> wrote: > From: Marek Olšák <marek.ol...@amd.com> > > for lower overhead in the CS ioctl > --- > src/gallium/drivers/radeon/r600_buffer_common.c

[RFC PATCH] radeonsi: set a per-buffer flag that disables inter-process sharing

From: Marek Olšák <marek.ol...@amd.com> for lower overhead in the CS ioctl --- src/gallium/drivers/radeon/r600_buffer_common.c | 7 +++ src/gallium/drivers/radeon/radeon_winsys.h | 1 + src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 6 ++ 3 files changed, 14 insertions(+)

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

Hi Dave, If you just add "get" functions for what you need from amdgpu objects, that should be fine. Marek On Mon, Jul 17, 2017 at 11:00 PM, Dave Airlie wrote: > On 18 July 2017 at 03:02, Christian König wrote: >> Am 17.07.2017 um 05:36 schrieb Dave

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

On Sun, Jul 16, 2017 at 11:36 PM, Dave Airlie wrote: >> >> I can take a look at it, I just won't have time until next week most likely. > > I've taken a look, and it's seemingly more complicated than I'm > expecting I'd want to land in Mesa before 17.2 ships, I'd really >

Re: [PATCH libdrm] libdrm_amdgpu: add kernel semaphore support

On Tue, Jul 11, 2017 at 11:20 AM, Dave Airlie wrote: > On 11 July 2017 at 18:36, Christian König wrote: >> Am 11.07.2017 um 08:49 schrieb Dave Airlie: >>> >>> On 7 July 2017 at 19:07, Christian König wrote: Hi Dave,

Re: [PATCH 1/3] drm/amdgpu/atom: fix atom_fw check

On Mon, Jul 10, 2017 at 3:49 PM, Deucher, Alexander < alexander.deuc...@amd.com> wrote: > > -Original Message- > > From: Marek Olšák [mailto:mar...@gmail.com] > > Sent: Saturday, July 08, 2017 7:08 PM > > To: Alex Deucher > > Cc: amd-gfx mailing list

Re: [PATCH 1/3] drm/amdgpu/atom: fix atom_fw check

Hi Alex, This commit causes that clock_crystal_freq is 0 on Raven, demoting OpenGL support from 4.5 to 3.2. Can I revert? Marek On Wed, Jul 5, 2017 at 9:51 PM, Alex Deucher wrote: > Not all vbios images seem to set the version appropriately. > Switch the check based on

Re: [PATCH 4/5] drm/amdgpu: Set/clear CPU_ACCESS_REQUIRED flag on page fault and CS

On Fri, Jun 30, 2017 at 8:47 AM, Christian König wrote: > Am 30.06.2017 um 04:24 schrieb Michel Dänzer: >> >> On 29/06/17 07:05 PM, Daniel Vetter wrote: >>> >>> On Thu, Jun 29, 2017 at 06:58:05PM +0900, Michel Dänzer wrote: On 29/06/17 05:23 PM, Christian König

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

On Tue, Jul 4, 2017 at 10:09 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 03/07/17 10:03 PM, Marek Olšák wrote: >> On Mon, Jul 3, 2017 at 12:08 PM, Michel Dänzer <mic...@daenzer.net> wrote: >>> On 30/06/17 08:43 PM, Marek Olšák wrote: >>>> >>

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

On Mon, Jul 3, 2017 at 12:08 PM, Michel Dänzer <mic...@daenzer.net> wrote: > On 30/06/17 08:43 PM, Marek Olšák wrote: >> >> I don't know what is being talked about here anymore, but I wouldn't >> like to use CPU_ACCESS_REQUIRED or CPU_ACCESS_REALLY_REQUIRED

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

On Fri, Jun 30, 2017 at 12:34 PM, Christian König wrote: > Am 30.06.2017 um 09:14 schrieb Michel Dänzer: >> >> On 30/06/17 03:59 PM, Christian König wrote: >>> >>> Am 30.06.2017 um 08:51 schrieb Michel Dänzer: We can deal with that internally in the kernel,

Re: Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

s, but we > should really stop using this as a hint in Mesa. > > Regards, > Christian. > > > Am 29.06.2017 um 16:41 schrieb Marek Olšák: >> >> Hi, >> >> Given how our memory manager works and the guesswork that UMDs have to >> do to d

Deprecation of AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED

Hi, Given how our memory manager works and the guesswork that UMDs have to do to determine whether to set the flag, I think the flag isn't useful. I'm proposing that CPU_ACCESS_REQUIRED: - will be deprecated. - It will remain to be accepted by the kernel driver, but it will either not have any

Re: [PATCH 6/9] drm/amdgpu: Set/clear CPU_ACCESS_REQUIRED flag on page fault and CS

On Mon, Jun 26, 2017 at 11:27 AM, Michel Dänzer wrote: > On 25/06/17 03:00 AM, Christian König wrote: >> Am 23.06.2017 um 19:39 schrieb John Brooks: >>> When the AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED flag is given by >>> userspace, >>> it should only be treated as a hint to

Re: [PATCH 1/3] drm/amdgpu: fix a typo

On Fri, Jun 23, 2017 at 3:45 PM, axie wrote: > Hi Marek, > > I understand you spent time on your original logic too. I really don't > understand why you talked about pain if somebody can improve it. > > To reduce the pain, now I am seriously considering dropping this patch. But >

Re: [PATCH 1/3] drm/amdgpu: fix a typo

On Fri, Jun 23, 2017 at 1:55 PM, Zhou, David(ChunMing) <david1.z...@amd.com> wrote: > > ____ > From: Marek Olšák [mar...@gmail.com] > Sent: Friday, June 23, 2017 6:49 PM > To: Christian König > Cc: Zhou, David(ChunMing

Re: [PATCH 1/3] drm/amdgpu: fix a typo

IB contained 1000 per-process resources and 1-2 inter-process sharable? Marek > > Christian. > > > Am 23.06.2017 um 13:37 schrieb Marek Olšák: >> >> I agree with you about the spinlock. You seem to be good at this. >> >> It's always good to do measurements

Re: [PATCH 1/3] drm/amdgpu: fix a typo

3% to much bigger percentage. It depends > on many factors, even depends on the application itself. > > > This is not the first bottleneck fixed. This is surely not the last one. > > > Thanks, > > Alex Bin > > > > On 2017-06-22 07:54 PM, Marek Olšák wrote: &

Re: [PATCH 1/3] drm/amdgpu: fix a typo

On Fri, Jun 23, 2017 at 11:27 AM, Christian König wrote: > Am 23.06.2017 um 11:08 schrieb zhoucm1: >> >> >> >> On 2017年06月23日 17:01, zhoucm1 wrote: >>> >>> >>> >>> On 2017年06月23日 16:25, Christian König wrote: Am 23.06.2017 um 09:09 schrieb zhoucm1: > >

Re: [PATCH 1/3] drm/amdgpu: fix a typo

ong flags; >> >> if (unlikely(current->lockdep_recursion)) >> return; >> >> raw_local_irq_save(flags); >> check_flags(flags); >> >> current->lockdep_recursion = 1; >> trace_lock_acquire(lock, subclass, trylo

Re: [PATCH 1/3] drm/amdgpu: fix a typo

On Thu, Jun 22, 2017 at 5:33 PM, Xie, AlexBin wrote: > Hi Christian, > > > In fact, the change from spinlock to atomic is quite painful. When I > started, I thought it was easy but later I found there might be race > condition here and there. Now I think the change looks more

Re: GART write flush error on SI w/ amdgpu

On Tue, Jun 20, 2017 at 1:46 PM, Christian König <deathsim...@vodafone.de> wrote: > Am 20.06.2017 um 12:34 schrieb Marek Olšák: >> >> BTW, I noticed the flush sequence in the kernel is wrong. The correct >> flush sequence should be: >> >> 1) EVENT_WRITE_EOP -

Re: GART write flush error on SI w/ amdgpu

On Tue, Jun 20, 2017 at 1:49 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > On 20.06.2017 12:34, Marek Olšák wrote: >> >> BTW, I noticed the flush sequence in the kernel is wrong. The correct >> flush sequence should be: >> >> 1) EVENT_WRITE_EOP - CACHE_FLU

Re: GART write flush error on SI w/ amdgpu

is that it doesn't wait for idle before writing CP_COHER_CNTL2 and SURFACE_SYNC. So far we've been able to avoid the bug by waiting for idle in userspace IBs. Marek On Fri, May 26, 2017 at 5:47 PM, Marek Olšák <mar...@gmail.com> wrote: > On Tue, May 9, 2017 at 2:13 PM, Nicolai Hähnle <nhaeh.

Re: GART write flush error on SI w/ amdgpu

On Tue, May 9, 2017 at 2:13 PM, Nicolai Hähnle wrote: > Hi all, > > I'm seeing some very strange errors on Verde with CPU readback from GART, > and am pretty much out of ideas. Some help would be very much appreciated. > > The error manifests with the >

Re: [PATCH 0/3] drm/amdgpu: Tweaks for high pressure on CPU visible VRAM

On Thu, May 25, 2017 at 5:31 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 24/05/17 08:27 PM, Christian König wrote: >> Am 24.05.2017 um 13:03 schrieb Marek Olšák: >>>> >>> I think the final solution (done in fault_reserve_notify) should be: >>> i

Re: [PATCH 0/3] drm/amdgpu: Tweaks for high pressure on CPU visible VRAM

On Wed, May 24, 2017 at 9:56 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 23/05/17 07:38 PM, Marek Olšák wrote: >> On Tue, May 23, 2017 at 2:45 AM, Michel Dänzer <mic...@daenzer.net> wrote: >>> On 22/05/17 07:09 PM, Marek Olšák wrote: >>>> On Mon, Ma

Re: [PATCH] winsys/amdgpu: align VA allocations to fragment size

sys.h > b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.h > index 896a463..88975e2 100644 > --- a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.h > +++ b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.h > @@ -73,6 +73,7 @@ struct amdgpu_winsys { > > struct amdgpu_gpu_info amd

Re: [PATCH 0/3] drm/amdgpu: Tweaks for high pressure on CPU visible VRAM

On Tue, May 23, 2017 at 2:45 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 22/05/17 07:09 PM, Marek Olšák wrote: >> On Mon, May 22, 2017 at 12:00 PM, Michel Dänzer <mic...@daenzer.net> wrote: >>> On 20/05/17 06:26 PM, Marek Olšák wrote: >>>> On

Re: [PATCH 0/3] drm/amdgpu: Tweaks for high pressure on CPU visible VRAM

On Mon, May 22, 2017 at 12:00 PM, Michel Dänzer <mic...@daenzer.net> wrote: > On 20/05/17 06:26 PM, Marek Olšák wrote: >> On May 20, 2017 3:26 AM, "Michel Dänzer" <mic...@daenzer.net >> <mailto:mic...@daenzer.net>> wrote: >> >> On 2

Re: [PATCH 0/3] drm/amdgpu: Tweaks for high pressure on CPU visible VRAM

On May 20, 2017 3:26 AM, "Michel Dänzer" <mic...@daenzer.net> wrote: On 20/05/17 01:14 AM, Marek Olšák wrote: > Hi Michel, > > I've applied your series Thanks for testing it. > and it doesn't help with low Dirt Rally performance on Fiji. I see TTM > buffer move

Re: [PATCH 0/3] drm/amdgpu: Tweaks for high pressure on CPU visible VRAM

Hi Michel, I've applied your series and it doesn't help with low Dirt Rally performance on Fiji. I see TTM buffer moves at 800MB/s and many VRAM page faults. Marek On Thu, May 18, 2017 at 11:08 AM, Michel Dänzer wrote: > From: Michel Dänzer > > This

Re: [PATCH 0/3] drm/amdgpu: Tweaks for high pressure on CPU visible VRAM

On Fri, May 19, 2017 at 5:27 PM, John Brooks <j...@fastquake.com> wrote: > On Fri, May 19, 2017 at 05:24:36PM +0200, Marek Olšák wrote: >> Where is your "attached" patch? >> >> Marek > > It's actually a reply to my message. Sorry if that was unclear. Th

Re: [PATCH 0/3] drm/amdgpu: Tweaks for high pressure on CPU visible VRAM

Where is your "attached" patch? Marek On Fri, May 19, 2017 at 5:04 AM, John Brooks wrote: > I'm glad this is being worked on. However, somewhat to my surprise, this patch > series didn't help Dying Light's BO eviction problem. For those who don't > know, > that game

Re: Plan: BO move throttling for visible VRAM evictions

On May 18, 2017 10:17 AM, "Michel Dänzer" <mic...@daenzer.net> wrote: On 17/05/17 09:35 PM, Marek Olšák wrote: > On May 16, 2017 3:57 AM, "Michel Dänzer" <mic...@daenzer.net > <mailto:mic...@daenzer.net>> wrote: > On 15/05/17 07:11 PM, Mar

[PATCH] drm/amdgpu: add an INFO query for monitoring VRAM CPU page faults

From: Marek Olšák <marek.ol...@amd.com> Signed-off-by: Marek Olšák <marek.ol...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 1 + include/uapi/drm/amdgpu_drm.h

Re: Plan: BO move throttling for visible VRAM evictions

On May 16, 2017 3:57 AM, "Michel Dänzer" <mic...@daenzer.net> wrote: On 15/05/17 07:11 PM, Marek Olšák wrote: > On May 15, 2017 4:29 AM, "Michel Dänzer" <mic...@daenzer.net > <mailto:mic...@daenzer.net>> wrote: > > I think the next step

Re: [PATCH 4/4] drm/amdgpu: reset fpriv vram_lost_counter

David, We already have a query that returns whether a device is lost. It's called amdgpu_cs_query_reset_state. That should return whether a hang was caused by a certain context or whether the hang happened but the context is innocent. You can extend it to accept no context, in which case it will

Re: Plan: BO move throttling for visible VRAM evictions

On Mon, Apr 17, 2017 at 11:55 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 17/04/17 07:58 AM, Marek Olšák wrote: >> On Fri, Apr 14, 2017 at 12:14 PM, Michel Dänzer <mic...@daenzer.net> wrote: >>> On 04/04/17 05:11 AM, Marek Olšák wrote: >>>> On F

Re: Plan: BO move throttling for visible VRAM evictions

On Fri, Apr 14, 2017 at 12:14 PM, Michel Dänzer <mic...@daenzer.net> wrote: > On 04/04/17 05:11 AM, Marek Olšák wrote: >> On Fri, Mar 31, 2017 at 5:24 AM, Michel Dänzer <mic...@daenzer.net> wrote: >>> On 30/03/17 07:03 PM, Michel Dänzer wrote: >>>> On 25/0

Re: [PATCH 3/3] drm/amdgpu: CIK support is no longer experimental

On Thu, Apr 13, 2017 at 6:41 PM, Nicolai Hähnle wrote: > On 11.04.2017 00:06, Felix Kuehling wrote: >> >> On 17-04-08 04:50 AM, Nicolai Hähnle wrote: >>> >>> On 07.04.2017 22:15, Felix Kuehling wrote: Change the wording of the CONFIG_DRM_AMDGPU_CIK option to indicate

Re: [PATCH libdrm v2] amdgpu: allow to query GPU sensor related information

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Tue, Apr 4, 2017 at 4:34 PM, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > This exposes amdgpu_query_sensor_info(). > > v2: - add amdgpu_query_sensor_info() to the symbols list > > Signed-off-by: Sa

Re: Plan: BO move throttling for visible VRAM evictions

On Fri, Mar 31, 2017 at 5:24 AM, Michel Dänzer <mic...@daenzer.net> wrote: > On 30/03/17 07:03 PM, Michel Dänzer wrote: >> On 25/03/17 01:33 AM, Marek Olšák wrote: >>> Hi, >>> >>> I'm sharing this idea here, because it's something that has been >

Re: Plan: BO move throttling for visible VRAM evictions

On Mar 28, 2017 3:07 AM, "Michel Dänzer" <mic...@daenzer.net> wrote: On 27/03/17 07:29 PM, Marek Olšák wrote: > On Mar 27, 2017 9:35 AM, "Michel Dänzer" <mic...@daenzer.net > <mailto:mic...@daenzer.net>> wrote: > > On 25/03/17 01:33 AM,

Re: Plan: BO move throttling for visible VRAM evictions

On Mar 28, 2017 10:41 AM, "Christian König" wrote: Am 28.03.2017 um 10:35 schrieb Michel Dänzer: > On 28/03/17 05:29 PM, Christian König wrote: > >> Am 28.03.2017 um 08:00 schrieb Michel Dänzer: >> >>> On 28/03/17 12:50 PM, zhoucm1 wrote: >>> On 2017年03月28日 10:40,

Re: [PATCH libdrm] amdgpu_drm: add AMDGPU_HW_IP_UVD_ENC

FYI, I've pushed the patch to libdrm/master. Marek On Thu, Mar 23, 2017 at 3:43 PM, Leo Liu wrote: > Signed-off-by: Leo Liu > Reviewed-by: Alex Deucher > --- > include/drm/amdgpu_drm.h | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [PATCH libdrm] amdgpu: stop reading CC_RB_BACKEND_DISABLE on Vega10

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Mon, Mar 27, 2017 at 3:44 PM, Christian König <deathsim...@vodafone.de> wrote: > From: Christian König <christian.koe...@amd.com> > > Follow up to 'drm: don't access deprecated register on Vega10'. > >

Re: Plan: BO move throttling for visible VRAM evictions

On Mar 27, 2017 9:35 AM, "Michel Dänzer" <mic...@daenzer.net> wrote: On 25/03/17 01:33 AM, Marek Olšák wrote: > Hi, > > I'm sharing this idea here, because it's something that has been > decreasing our performance a lot recently, for example: > http://openbench

Re: Plan: BO move throttling for visible VRAM evictions

On Fri, Mar 24, 2017 at 5:45 PM, Christian König <deathsim...@vodafone.de> wrote: > Am 24.03.2017 um 17:33 schrieb Marek Olšák: >> >> Hi, >> >> I'm sharing this idea here, because it's something that has been >> decreasing our performance

Plan: BO move throttling for visible VRAM evictions

Hi, I'm sharing this idea here, because it's something that has been decreasing our performance a lot recently, for example: http://openbenchmarking.org/prospect/1703011-RI-RADEONDIR06/7b7668cfc109d1c3dc27e871c8aea71ca13f23fa I think the problem there is that Mesa git started uploading

Re: [PATCH] drm/amdgpu: allow shifts >= 32 in AMDGPU_TILING_SET/GET

On Wed, Mar 22, 2017 at 11:43 AM, Grazvydas Ignotas <nota...@gmail.com> wrote: > On Tue, Mar 21, 2017 at 9:44 PM, Marek Olšák <mar...@gmail.com> wrote: >> From: Marek Olšák <marek.ol...@amd.com> >> >> also adjust the comments >> >&

Re: [PATCH libdrm 2/7] amdgpu: update amdgpu_drm.h for Vega10

On Mar 22, 2017 2:44 AM, "Michel Dänzer" <mic...@daenzer.net> wrote: On 22/03/17 06:46 AM, Marek Olšák wrote: > On Tue, Mar 21, 2017 at 10:27 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: >> In the past, I was told off for patches that update this file wit

Re: [PATCH libdrm 2/7] amdgpu: update amdgpu_drm.h for Vega10

On Tue, Mar 21, 2017 at 10:27 PM, Nicolai Hähnle wrote: > In the past, I was told off for patches that update this file without > following the procedure described in include/drm/README. Tbh, that procedure > causes some annoyances. > > Anyway, it's definitely useful to have

[PATCH libdrm 1/7] amdgpu: sync amdgpu_drm.h with kernel 4.11-rc2

From: Marek Olšák <marek.ol...@amd.com> --- include/drm/amdgpu_drm.h | 396 ++- 1 file changed, 251 insertions(+), 145 deletions(-) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index d8f2497..5797283 100644 --- a/inclu

[PATCH libdrm 4/7] tests/amdgpu: fix the count number for vega10

From: Huang Rui Signed-off-by: Huang Rui Reviewed-by: Ken Wang Reviewed-by: Christian König --- tests/amdgpu/basic_tests.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-)

[PATCH libdrm 5/7] tests/amdgpu: add uvd unit test support for vega10

From: Leo Liu Signed-off-by: Leo Liu Acked-by: Alex Deucher --- tests/amdgpu/cs_tests.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/tests/amdgpu/cs_tests.c

[PATCH libdrm 2/7] amdgpu: update amdgpu_drm.h for Vega10

From: Marek Olšák <marek.ol...@amd.com> --- include/drm/amdgpu_drm.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 5797283..d702a95 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu

<    1   2   3   4   5   >