that they want to use. So,
prevent user space from changing the ABM level if the module parameter
is set to a non-auto value.
Signed-off-by: Hamza Mahfooz
Reviewed-by: Mario Limonciello
Tested-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
drivers/gpu/drm
On 2/9/2024 05:07, Daniel Vetter wrote:
On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote:
On Wed, 07 Feb 2024, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers can call this
helper
for PSR-SU displays.
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
I think this with this patch in place you could also revert
571c2fa26aa6 ("drm/amd/display: Disable PSR-SU on Parade 0803 TCON again")
One minor nit below otherwise LGTM.
Reviewed-by: Mario Limonciello
---
On 2/8/2024 08:31, Jani Nikula wrote:
On Thu, 08 Feb 2024, Maxime Ripard wrote:
On Thu, Feb 08, 2024 at 11:57:11AM +0200, Jani Nikula wrote:
On Wed, 07 Feb 2024, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel
On 2/8/2024 00:54, Christian König wrote:
Am 08.02.24 um 06:52 schrieb Mario Limonciello:
amdgpu_acpi_is_s0ix_active() and amdgpu_acpi_is_s0ix_active() aren't
needed to be checked multiple times in a suspend cycle. Checking and
setting up policy one time in the prepare() callback is sufficient
://gitlab.freedesktop.org/drm/amd/-/issues/3097
Syntax should be "Closes: $URL"
Fixes: 0a1844bf0b53 ("drm/buddy: Improve contiguous memory allocation")
Signed-off-by: Arunpravin Paneer Selvam
Tested-by: Mario Limonciello
Acked-by: Christian König
CC: stable.. ?
I will chec
t resources during PM ops prepare()
callback")
Signed-off-by: Mario Limonciello
---
v3->v4:
* New function to set s0ix/s3 and explicitly unset in cleanup
v2->v3:
* Whitespace
v1->v2:
* Add and use new in_prepare member
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h
amdgpu_acpi_is_s0ix_active() and amdgpu_acpi_is_s0ix_active() aren't
needed to be checked multiple times in a suspend cycle. Checking and
setting up policy one time in the prepare() callback is sufficient.
Signed-off-by: Mario Limonciello
---
v4: New patch
---
drivers/gpu/drm/amd/amdgpu
again.
Users report that by using GNOME to suspend the lockscreen trigger will
cause SDMA traffic and the system can deadlock.
This reverts commit 0dee726395333fea833eaaf838bc80962df886c8.
Acked-by: Alex Deucher
Fixes: ab4750332dbe ("drm/amdgpu/sdma5.2: add begin/end_use ring callbacks")
Si
All of the selects on ACPI_VIDEO are unnecessary when DRM does the
select for ACPI_VIDEO as it provides a helper for acpi based EDID.
Reviewed-by: Pranjal Ramajor Asha Kanojiya
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 7 ---
drivers/gpu/drm/gma500/Kconfig
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers can call this
helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/Kconfig| 5 +++
drivers/gpu/drm
drm_edid at the same time.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/nouveau/nouveau_acpi.c | 27 -
drivers/gpu/drm/nouveau/nouveau_acpi.h | 2 --
drivers/gpu/drm/nouveau/nouveau_connector.c | 20 +++
3 files changed, 9 insertions(+), 40
drm_edid. There will be a follow up
patch to amdgpu after Melissa Wen finishes that effort [2].
https://lore.kernel.org/dri-devel/20240201221119.42564-1-mario.limoncie...@amd.com/
[1]
https://lore.kernel.org/amd-gfx/20240126163429.56714-1-m...@igalia.com/ [2]
Mario Limonciello (3):
drm: Add
On 2/7/2024 16:34, Alex Deucher wrote:
On Wed, Feb 7, 2024 at 3:48 PM Mario Limonciello
wrote:
commit 5095d5418193 ("drm/amd: Evict resources during PM ops prepare()
callback")
intentionally moved the eviction of resources to earlier in the suspend
process, but this introduce
s prepare()
callback")
Signed-off-by: Mario Limonciello
---
v1->v2:
* Add and use new in_prepare member
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 46 --
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 21 ++
3
again.
Users report that by using GNOME to suspend the lockscreen trigger will
cause SDMA traffic and the system can deadlock.
This reverts commit 0dee726395333fea833eaaf838bc80962df886c8.
Fixes: ab4750332dbe ("drm/amdgpu/sdma5.2: add begin/end_use ring callbacks")
Signed-off-by: Mario Limonci
On 2/6/2024 16:00, Deucher, Alexander wrote:
[AMD Official Use Only - General]
-Original Message-
From: amd-gfx On Behalf Of Mario
Limonciello
Sent: Tuesday, February 6, 2024 4:32 PM
To: amd-gfx@lists.freedesktop.org
Cc: Limonciello, Mario ; Jürg Billeter
Subject: [PATCH] drm/amd
r
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3132#note_2271038
Fixes: 5095d5418193 ("drm/amd: Evict resources during PM ops prepare()
callback")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
/drm/amd/uploads/8f13ff3b00963c833e23e68aa8116959/output.log
[2]
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2645
Signed-off-by: Mario Limonciello
---
---
drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd
The 38-ec-11 TCON contained in some AUO panels will hang when used
with PSR-SU and changing the brightness.
Forcing a full frame update works around the issue, so add a quirk
for this panel to do just that.
Reported-by: aaron...@canonical.com
Signed-off-by: Mario Limonciello
---
Cc: hamza.mahf
When dc_state_destruct() was refactored the new phantom_stream_count
and phantom_plane_count members weren't cleared.
Fixes: 012a04b1d6af ("drm/amd/display: Refactor phantom resource allocation")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/dc/core/dc_state.c | 3 +
"panel_power_savings" sysfs attribute.
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
Reviewed-by: Mario Limonciello
Tested-by: Mario Limonciello
---
v2: hide ABM_LEVEL_IMMEDIATE_DISABLE in the read case, force an atomic
commit when setting the value, call sysfs_re
On 2/2/2024 10:07, Rafael J. Wysocki wrote:
On Thu, Feb 1, 2024 at 11:11 PM Mario Limonciello
wrote:
The ACPI specification allows for an EDID to be up to 512 bytes but
the _DDC EDID fetching code will only try up to 256 bytes.
Modify the code to instead start at 512 bytes and work it's way
On 2/2/2024 04:29, Jani Nikula wrote:
On Thu, 01 Feb 2024, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers can call this
helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method.
I'm
drivers
Mario Limonciello (5):
ACPI: video: Handle fetching EDID that is longer than 256 bytes
drm: Add drm_get_acpi_edid() helper
drm/amd: Fetch the EDID from _DDC if available for eDP
drm/nouveau: Use drm_get_acpi_edid() helper
drm: Drop unneeded selects in DRM drivers
drivers/acpi
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers can call this
helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method.
Signed-off-by: Mario Limonciello
---
v1->v2:
* Split code from previous amdgpu speci
All of the selects on ACPI_VIDEO are unnecessary when DRM does the
select for ACPI_VIDEO as it provides a helper for acpi based EDID.
Signed-off-by: Mario Limonciello
---
v2->v3:
* new patch
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 7 ---
drivers/gpu/drm/gma500/Kconfig
Rather than inventing a wrapper to acpi_video_get_edid() use the
one provided by drm. This fixes two problems:
1. A memory leak that the memory provided by the ACPI call was
never freed.
2. Validation of the BIOS provided blob.
Signed-off-by: Mario Limonciello
---
v1->v2:
* New pa
necessary. Decrease from info to debug.
Link:
https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/Apx_B_Video_Extensions/output-device-specific-methods.html#ddc-return-the-edid-for-this-device
Signed-off-by: Mario Limonciello
---
v1->v2:
* Use for loop for acpi_video_get_edid()
* Use one of Rafae
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops.
Attempt to fetch this EDID if it exists and prefer it over the EDID
that is provided by the panel.
Signed-off-by: Mario Limonciello
---
v2:
* Use drm helper which will run more
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops.
Attempt to fetch this EDID if it exists and prefer it over the EDID
that is provided by the panel.
Signed-off-by: Mario Limonciello
---
v2:
* Use drm helper which will run more
Rather than inventing a wrapper to acpi_video_get_edid() use the
one provided by drm. This fixes two problems:
1. A memory leak that the memory provided by the ACPI call was
never freed.
2. Validation of the BIOS provided blob.
Signed-off-by: Mario Limonciello
---
v1->v2:
* New pa
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops. Drivers can call this
helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method.
Signed-off-by: Mario Limonciello
---
v1->v2:
* Split code from previous amdgpu speci
necessary. Decrease from info to debug.
Link:
https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/Apx_B_Video_Extensions/output-device-specific-methods.html#ddc-return-the-edid-for-this-device
Signed-off-by: Mario Limonciello
---
v1->v2:
* Use for loop for acpi_video_get_edid()
* Use one of Rafae
more involved
amdgpu display driver work that will come separately as part of follow-ups
to: https://lore.kernel.org/amd-gfx/20240126163429.56714-1-m...@igalia.com/
Mario Limonciello (4):
ACPI: video: Handle fetching EDID that is longer than 256 bytes
drm: Add drm_get_acpi_edid() helper
drm
Reviewed-by: Mario Limonciello
And I'll apply this now.
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index d63cab294883..b0ba68016a02 100644
--- a/drivers/gpu/drm/
On 1/29/2024 14:46, Mario Limonciello wrote:
On 1/28/2024 10:18, David McFarland wrote:
The same calls are made directly above, but conditional on the firmware
loading and validating successfully.
Fixes: 9931b67690cf ("drm/amd: Load GFX10 microcode during early_init")
This is a
it to our tree
and Alex should send it in a future fixes PR.
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index d63cab294883..b0
On 1/29/2024 10:46, Jani Nikula wrote:
On Mon, 29 Jan 2024, Mario Limonciello wrote:
On 1/29/2024 03:39, Jani Nikula wrote:
On Fri, 26 Jan 2024, Mario Limonciello wrote:
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index
On 1/29/2024 07:54, Rafael J. Wysocki wrote:
On Fri, Jan 26, 2024 at 7:55 PM Mario Limonciello
wrote:
The ACPI specification allows for an EDID to be up to 512 bytes but
the _DDC EDID fetching code will only try up to 256 bytes.
Modify the code to instead start at 512 bytes and work it's way
On 1/29/2024 03:39, Jani Nikula wrote:
On Fri, 26 Jan 2024, Mario Limonciello wrote:
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops.
Attempt to fetch this EDID if it exists and prefer it over the EDID
that is provided by the panel
On 1/26/2024 16:34, Mario Limonciello wrote:
On 1/26/2024 16:22, Hamza Mahfooz wrote:
We want programs besides the compositor to be able to enable or disable
panel power saving features. However, since they are currently only
configurable through DRM properties, that isn't possible. So
"panel_power_savings" sysfs attribute.
Cc: Mario Limonciello
Signed-off-by: Hamza Mahfooz
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 59 +++
1 file changed, 59 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display
Some manufacturers have intentionally put an EDID that differs from
the EDID on the internal panel on laptops.
Attempt to fetch this EDID if it exists and prefer it over the EDID
that is provided by the panel.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h
-specific-methods.html#ddc-return-the-edid-for-this-device
Signed-off-by: Mario Limonciello
---
drivers/acpi/acpi_video.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index 62f4364e4460
that when an eDP panel is found the BIOS
is checked first for an EDID and that used as a preference if found.
Mario Limonciello (2):
ACPI: video: Handle fetching EDID that is longer than 256 bytes
drm/amd: Fetch the EDID from _DDC if available for eDP
drivers/acpi/acpi_video.c
On 1/26/2024 10:28, Melissa Wen wrote:
Hi,
I'm debugging a null-pointer dereference when running
igt@kms_connector_force_edid and the way I found to solve the bug is to
stop using raw edid handler in amdgpu_connector_funcs_force and
create_eml_sink in favor of managing resouces via sruct
On 1/24/2024 11:09, roman...@amd.com wrote:
From: Roman Li
For debugging IPS-related issues, expose a new debug mask
that allows to disable IPS.
Usage:
amdgpu.dcdebugmask=0x800
Signed-off-by: Roman Li
Tested-by: Mark Broadworth
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/amd
t;
[How]
Enable IPS by default.
Disable IPS if 0x800 bit set in amdgpu.dcdebugmask module params
Signed-off-by: Roman Li
Tested-by: Mark Broadworth
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
.
Signed-off-by: Roman Li
Tested-by: Mark Broadworth
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
b/drivers/gpu/drm/amd
On 1/24/2024 08:37, Mikhail Gavrilov wrote:
On Wed, Jan 24, 2024 at 7:19 AM Mikhail Gavrilov
wrote:
Who could dig into it, please?
You decided to revert it?
https://lkml.org/lkml/2024/1/22/1866
It's not a straight "git revert" on 6.8-rc1 because of some other
contextual changes.
I
Documentation/gpu/amdgpu/display/display-contributing.rst
delete mode 100644 drivers/gpu/drm/amd/display/TODO
Reviewed-by: Mario Limonciello
ssues/3062
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 24 --
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 33 ++-
drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 1 -
.../drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 8 +---
On 12/20/2023 19:58, Ma, Jun wrote:
Hi Christian,
On 12/20/2023 10:10 PM, Christian König wrote:
Am 19.12.23 um 06:58 schrieb Ma Jun:
Print a warnning message if the system can't access
the resize bar register when using large bar.
Well pretty clear NAK, we have embedded use cases where
vokxygd6-e+8p-4qo6fowa6zp2...@mail.gmail.com/
Signed-off-by: Hamza Mahfooz
Reviewed-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
b/drivers/g
`/` wasn't meant to be in the Dragon Range line
Signed-off-by: Mario Limonciello
---
Documentation/gpu/amdgpu/apu-asic-info-table.csv | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/gpu/amdgpu/apu-asic-info-table.csv
b/Documentation/gpu/amdgpu/apu-asic-info
These have been announced so add them to the table.
Link: https://www.amd.com/en/product/13971
Signed-off-by: Mario Limonciello
---
Documentation/gpu/amdgpu/apu-asic-info-table.csv | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/gpu/amdgpu/apu-asic-info
-off-by: Mario Limonciello
---
v1->v2:
* s/VDDGFX/VDDC/
---
drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 ++
drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c
b/driv
smu_set_gfx_power_up_by_imu() is called by both
smu_set_gfx_imu_enable() and amdgpu_dpm_set_gfx_power_up_by_imu()
but only uses a mutex in amdgpu_dpm_set_gfx_power_up_by_imu().
Move the mutex use into smu_set_gfx_imu_enable() to protect multiple
simultaneous calls.
Signed-off-by: Mario
The SW CTF delayed work handler triggers a shutdown if a sensor
read failed for any reason.
The specific circumstance of a busy sensor should be retried
however to ensure that a good value can be returned.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 6
to catch this circumstance and output a warning.
Signed-off-by: Mario Limonciello
---
v2->v3:
* Correctly handle fallthrough case
v1->v2:
* Only show `Failed to read hotspot temperature` when sensor read fails
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 24 ++-
Any callers to read_sensor() may get the wrong data if the RAS
interrupt has been triggered and no actual sensor read occurred.
Adjust the return code for this condition to be -EBUSY.
Suggested-by: Lijo Lazar
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/swsmu/smu11
to catch this circumstance and output a warning.
Signed-off-by: Mario Limonciello
---
v1->v2:
* Only show `Failed to read hotspot temperature` when sensor read fails
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
d
The SW CTF delayed work handler triggers a shutdown if a sensor
read failed for any reason.
The specific circumstance of a busy sensor should be retried
however to ensure that a good value can be returned.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 6
Any callers to read_sensor() may get the wrong data if the RAS
interrupt has been triggered and no actual sensor read occurred.
Adjust the return code for this condition to be -EBUSY.
Suggested-by: Lijo Lazar
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/swsmu/smu11
this out to the
field, introduce a workaround that will add an extra dummy read on resume that
the result is discarded.
Cc: sta...@vger.kernel.org # 6.1+
Cc: Tim Huang
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3045
Signed-off-by: Mario Limonciello
---
v1->v2:
* Add a dummy r
Some issues have been raised that appear to be tied to PSR-SU.
To allow users to confirm they're tied to PSR-SU without turning off
PSR entirely introduce a new debug mask:
amdgpu.dcdebugmask=0x200
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 3
://gitlab.freedesktop.org/drm/amd/-/issues/3049
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 2 ++
drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr
On 12/14/2023 03:21, Christian König wrote:
Am 13.12.23 um 20:44 schrieb Alex Deucher:
On Wed, Dec 13, 2023 at 2:32 PM Mario Limonciello
wrote:
On 12/13/2023 13:12, Mario Limonciello wrote:
On 12/13/2023 13:07, Alex Deucher wrote:
On Wed, Dec 13, 2023 at 1:00 PM Mario Limonciello
wrote
to catch this circumstance and output a warning.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
b/drivers/gpu/drm/amd/pm/swsmu
On 12/14/2023 10:36, Kalle Valo wrote:
Hans de Goede writes:
Hi Wifi and AMDGPU maintainers,
Here is a pull-request for the platform-drivers-x86 parts of:
https://lore.kernel.org/platform-driver-x86/20231211100630.2170152-1-jun@amd.com/
From my pov the pdx86 bits are ready and the
that will add an extra dummy
read on resume that the result is discarded.
Cc: sta...@vger.kernel.org # 6.1+
Cc: Tim Huang
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3045
Signed-off-by: Mario Limonciello
---
v1->v2:
* Add a dummy read callback instead and use that.
---
drivers/gpu/
On 12/13/2023 13:12, Mario Limonciello wrote:
On 12/13/2023 13:07, Alex Deucher wrote:
On Wed, Dec 13, 2023 at 1:00 PM Mario Limonciello
wrote:
Some systems with MP1 13.0.4 or 13.0.11 have a firmware bug that
causes the first MES packet after resume to fail. This packet is
used to flush
On 12/13/2023 13:07, Alex Deucher wrote:
On Wed, Dec 13, 2023 at 1:00 PM Mario Limonciello
wrote:
Some systems with MP1 13.0.4 or 13.0.11 have a firmware bug that
causes the first MES packet after resume to fail. This packet is
used to flush the TLB when GART is enabled.
This issue is fixed
that will retry the flush
when detecting running on an older firmware and decrease relevant
error messages to debug while workaround is in use.
Cc: sta...@vger.kernel.org # 6.1+
Cc: Tim Huang
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3045
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd
On 12/13/2023 08:17, Alex Deucher wrote:
On Tue, Dec 12, 2023 at 9:00 PM Mario Limonciello
wrote:
On 12/12/2023 18:08, Oliver Schmidt wrote:
Hi Wayne,
On 12.12.23 17:06, Mario Limonciello wrote:
I looked through your bugs related to this and I didn't see a reference to the
specific docking
On 12/12/2023 18:08, Oliver Schmidt wrote:
Hi Wayne,
On 12.12.23 17:06, Mario Limonciello wrote:
I looked through your bugs related to this and I didn't see a reference to the
specific docking station model.
The logs mentioned "Thinkpad dock" but no model.
Could you share more a
nit_microcode().
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3043
Fixes: 751e293f2c99 ("drm/amd: Move microcode init from sw_init to early_init
for SDMA v2.4")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 4 ++--
1 file changed, 2 insertions(+
On 12/12/2023 03:46, Johannes Berg wrote:
On Mon, 2023-12-11 at 12:02 +0100, Hans de Goede wrote:
Hi Wifi and AMDGPU maintainers,
Here is a pull-request for the platform-drivers-x86 parts of:
https://lore.kernel.org/platform-driver-x86/20231211100630.2170152-1-jun@amd.com/
From my pov
On 12/5/2023 13:54, Mario Limonciello wrote:
This reverts commit ec5fa9fcdeca69edf7dab5ca3b2e0ceb1c08fe9a.
Reports are that this causes problems with external monitors after
wake up from suspend, which is something it was directly supposed to help.
Cc: Linux Regressions
Cc: sta...@vger.kernel.or
On 12/11/2023 09:27, Alex Deucher wrote:
On Mon, Dec 11, 2023 at 10:20 AM Mario Limonciello
wrote:
On 12/11/2023 08:47, Christian König wrote:
Am 11.12.23 um 12:02 schrieb Hans de Goede:
Hi Wifi and AMDGPU maintainers,
Here is a pull-request for the platform-drivers-x86 parts of:
https
Ping on this one.
On 12/5/2023 13:54, Mario Limonciello wrote:
This reverts commit ec5fa9fcdeca69edf7dab5ca3b2e0ceb1c08fe9a.
Reports are that this causes problems with external monitors after wake up
from suspend, which is something it was directly supposed to help.
Cc: Linux Regressions
Cc
On 12/11/2023 08:47, Christian König wrote:
Am 11.12.23 um 12:02 schrieb Hans de Goede:
Hi Wifi and AMDGPU maintainers,
Here is a pull-request for the platform-drivers-x86 parts of:
https://lore.kernel.org/platform-driver-x86/20231211100630.2170152-1-jun@amd.com/
From my pov the pdx86
On 12/9/2023 14:08, Mario Limonciello wrote:
When screen brightness is rapidly changed and PSR-SU is enabled the
display hangs on panels with this TCON even on the latest DCN 3.1.4
microcode (0x8002a81 at this time).
This was disabled previously as commit 072030b17830 ("drm/amd: Disable
P
lly with this TCON, disable PSR-SU
again for it until it can be root caused.
Cc: sta...@vger.kernel.org
Cc: aaron...@canonical.com
Cc: bi...@gnome.org
Cc: Marc Rossi
Cc: Hamza Mahfooz
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 ++
1 file changed, 2
://gitlab.freedesktop.org/drm/amd/-/issues/2220
Reviewed-by: Mario Limonciello (v1)
Tested-by: Mario Limonciello (v1)
Signed-off-by: Alex Deucher
As SDMA5.2 is supported back to LTS ~5.15 I suggest also:
Cc: sta...@vger.kernel.org # 5.15+
---
drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 16
. This should not impact power as SDMA usage is pretty
minimal and GFXOSS should not be active when SDMA is active
anyway, this just makes it explicit.
Signed-off-by: Alex Deucher
---
For the series:
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2220
Reviewed-by: Mario Limonciello
Tested
("drm/amd/display: add FB_DAMAGE_CLIPS support")
Reported-by: Kai-Heng Feng
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2952
Tested-by: Kai-Heng Feng
Tested-by: Bin Li
Signed-off-by: Hamza Mahfooz
Reviewed-by: Mario Limonciello
---
v2: fix style issues and add tags
---
d
:
On Thu, Dec 7, 2023 at 10:10 AM Mario Limonciello
wrote:
On 12/6/2023 20:07, Kai-Heng Feng wrote:
On Thu, Dec 7, 2023 at 9:57 AM Mario Limonciello
wrote:
On 12/6/2023 19:23, Kai-Heng Feng wrote:
On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello
wrote:
On 12/5/2023 14:17, Hamza Mahfooz wrote
On 12/6/2023 20:07, Kai-Heng Feng wrote:
On Thu, Dec 7, 2023 at 9:57 AM Mario Limonciello
wrote:
On 12/6/2023 19:23, Kai-Heng Feng wrote:
On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello
wrote:
On 12/5/2023 14:17, Hamza Mahfooz wrote:
We currently don't support dirty rectangles
On 12/6/2023 19:23, Kai-Heng Feng wrote:
On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello
wrote:
On 12/5/2023 14:17, Hamza Mahfooz wrote:
We currently don't support dirty rectangles on hardware rotated modes.
So, if a user is using hardware rotated modes with PSR-SU enabled,
use PSR-SU FFU
Kovac
Cc: Hamza Mahfooz
Fixes: d9e865826c20 ("drm/amd/display: Simplify brightness initialization")
Signed-off-by: Mario Limonciello
---
.../amd/display/dc/link/protocols/link_edp_panel_control.c| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/drivers/gpu/drm
On 12/5/2023 14:17, Hamza Mahfooz wrote:
We currently don't support dirty rectangles on hardware rotated modes.
So, if a user is using hardware rotated modes with PSR-SU enabled,
use PSR-SU FFU for all rotated planes (including cursor planes).
Here is the email for the original reporter to
Reported-by: Oliver Schmidt
Link: https://bugzilla.kernel.org/show_bug.cgi?id=218211
Link:
https://forum.manjaro.org/t/problems-with-external-monitor-wake-up-after-suspend/151840
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3023
Signed-off-by: Mario Limonciello
---
.../gpu/drm/amd/display
During hibernate sequence the source context might not have a clk_mgr.
So don't use it to look for DML2 support.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2980
Fixes: a2815ada8616 ("drm/amd/display: Introduce DML2")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/
work".
Otherwise LGTM.
Reviewed-by: Mario Limonciello
--
v8->v9:
- correct typo(Mhz -> MHz) (Johnson)
v13:
- Fix the format issue (IIpo Jarvinen)
---
include/net/cfg80211.h | 9 +
net/wireless/chan.c| 3 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --g
that if no other feedback is needed for
the series can be fixed when committing.
Reviewed-by: Mario Limonciello
--
v11:
- fix typo(Simon)
v12:
- Fix the code logic (Rafael)
- Move amd_wbrf.c to drivers/platform/x86/amd/wbrf.c
- Updated Evan's email because he's no longer
On 11/29/2023 03:13, Ma Jun wrote:
Add documentation about AMD's Wifi band RFI mitigation (WBRF) mechanism
explaining the theory and how it is used.
Signed-off-by: Ma Jun
Reviewed-by: Hans de Goede
Reviewed-by: Mario Limonciello
--
v14:
- Fix the format issue (IIpo Jarvinen
On 11/29/2023 06:36, Lijo Lazar wrote:
Only PSPv13.0.6 SOCs take a longer time to reach steady state. Other
PSPv13 based SOCs don't need extended wait. Also, reduce PSPv13.0.6 wait
time.
Signed-off-by: Lijo Lazar
Thanks!
Reviewed-by: Mario Limonciello
When you commit can you please add
On 11/29/2023 02:51, Ma Jun wrote:
Some platforms can't resume from d3cold state, So add a
new module parameter to disable d3cold state for debugging
purpose or workaround.
Signed-off-by: Ma Jun
---
This patch is essentially an 'amdgpu knob' for d3cold on the root port.
At least for
101 - 200 of 832 matches
Mail list logo
