re-load the
driver or re-attach using sysfs and it gracefully recovers.
[ 665.080480] [drm] Initialized amdgpu 3.49.0 20150101 for :63:00.0 on
minor 0
[ 665.090075] fbcon: amdgpudrmfb (fb0) is primary device
[ 665.090248] [drm] DSC precompute is not needed.
Mario Limonciello (2):
firmware: sysfb:
firmware.
So when probe fails, re-create the system framebuffer so that the
user at least has basic graphics support.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b
-by: Tim Huang
Reviewed-by: Mario Limonciello
v2: make the comment clean and use adev->in_s0ix instead of
adev->suspend
---
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
b/drivers/g
.
This was intended as a safety mechanism with the backlight overhaul that
occurred in kernel 6.1, but as it doesn't appear necesssary set it to be
disabled by default.
Suggested-by: Hans de Goede
Signed-off-by: Mario Limonciello
Reviewed-by: Hans de Goede
---
v2->v3:
* Add Hans' R-b
v1->v2:
* New
panels were found. Allow using this information to factor
in whether to enable the fallback logic for making an acpi_video0
backlight device.
Suggested-by: Hans de Goede
Signed-off-by: Mario Limonciello
Reviewed-by: Hans de Goede
---
v2->v3:
* Add Hans' R-b
* Add missing declaration for
Signed-off-by: Mario Limonciello
Reviewed-by: Hans de Goede
---
v2->v3:
* Add Hans' R-b
v1->v2:
* No changes
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/d
. If this turns out to be mistake and this part is reverted, the
other patches for preventing desktop problems will avoid regressions on
desktops.
Mario Limonciello (3):
ACPI: video: Allow GPU drivers to report no panels
drm/amd/display: Report to ACPI video if no panels were found
ACPI: video: Don't
Signed-off-by: Mario Limonciello
---
v1->v2:
* No changes
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 512c32327
.
This was intended as a safety mechanism with the backlight overhaul that
occurred in kernel 6.1, but as it doesn't appear necesssary set it to be
disabled by default.
Suggested-by: Hans de Goede
Signed-off-by: Mario Limonciello
---
v1->v2:
* New patch
drivers/acpi/acpi_video.c | 6 +-
1 file chan
panels were found. Allow using this information to factor
in whether to enable the fallback logic for making an acpi_video0
backlight device.
Suggested-by: Hans de Goede
Signed-off-by: Mario Limonciello
---
v1->v2:
* Cancel registration for backlight device instead (Hans)
* drop desktop ch
. If this turns out to be mistake and this part is reverted, the
other patches for preventing desktop problems will avoid regressions on
desktops.
Mario Limonciello (3):
ACPI: video: Allow GPU drivers to report no panels
drm/amd/display: Report to ACPI video if no panels were found
ACPI: video: Don't
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 512c32327eb1..b73f61ac5dd5 100644
.
Suggested-by: Hans de Goede
Signed-off-by: Mario Limonciello
---
drivers/acpi/acpi_video.c | 12
include/acpi/video.h | 1 +
2 files changed, 13 insertions(+)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index 32953646caeb..e297f8877797 100644
--- a/drivers
multi-GPU systems:
* only use this logic when the system is reported as a desktop enclosure.
* in the amdgpu code only report into this for APUs.
Mario Limonciello (2):
ACPI: video: Allow GPU drivers to report no panels
drm/amd/display: Report to ACPI video if no panels were found
drivers/acpi/ac
On 10/27/22 01:30, Christian König wrote:
Am 26.10.22 um 21:03 schrieb Mario Limonciello:
If a system does not have swap and memory is under 100% usage,
amdgpu will fail to evict resources. Currently the suspend
carries on proceeding to reset the GPU:
```
[drm] evicting device resources
davidak.de
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2223
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/
://bugzilla.kernel.org/show_bug.cgi?id=216516
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8
3 files changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
This reverts commit 60da2f7440f22dba48944602c2a0373068f13880.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216119
Fixes: 087451f372bf ("drm/amdgpu: use generic fb helpers instead of setting up
AMD own's.")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu
back to generic fb helpers
can be brought back in for amdgpu.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216119
Fixes: 087451f372bf ("drm/amdgpu: use generic fb helpers instead of setting up
AMD own's.")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/Makefile
.
This series reverts all the code to move to generic fbdev helpers to
fix both issues.
Mario Limonciello (4):
Revert "drm/amdgpu/display: disable prefer_shadow for generic fb
helpers"
Revert "drm/amdgpu: keep fbdev buffers pinned during suspend"
Reve
This reverts commit da427a501e9b5e2cac8c8042df12eb203726903c.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216119
Fixes: 087451f372bf ("drm/amdgpu: use generic fb helpers instead of setting up
AMD own's.")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu
ic fb
helpers")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 3 +--
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 3 +--
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c| 3 +--
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 3 +--
drivers/g
can just enable HSA_AMD_P2P.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdkfd/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig
b/drivers/gpu/drm/amd/amdkfd/Kconfig
index 93bd4eda0d94..b153c26903ee 100644
Rather than examining the suspend target, examine what the system is
configured to use. This should be no functional change, just improves
readability by taking the helper instead.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 4 ++--
1 file changed, 2
Drop the direct check from the FADT and use the helper instead.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
n eDP stream is already enabled"). Revert this commit
to fix the issue.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2047
Reported-by: Aaron Ma
Fixes: 559e2655220d ("drm/amd/display: keep eDP Vdd on when eDP stream is
already enabled")
Signed-off-by: Mario Limonciello
---
.
ootup clocks")
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
index f18f9605e586..0e59ab2192bf 100644
--- a/d
Loading amdgpu on GC 10.3.7 shows an ERR level message:
`kfd kfd: amdgpu: GC IP 0a0307 not supported in kfd`
Add these targets to match yellow carp structures.
Reported-by: David Chang
Reviewed-by: Felix Kuehling
Tested-by: Jesse(Jie) Zhang
Signed-off-by: Mario Limonciello
---
drivers/gpu
/#mf90fc5d39b02d4cf7d430a49d3b58243083042a7
Signed-off-by: Mario Limonciello
---
This is RFC as it's conceptual, and we should wait for testing
that it actually works.
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu
ASIC reset, but this still doesn't work on the A+A
configuration in s2idle.
Avoid doing the reset on dGPUs specifically when using s2idle.
Fixes: daf8de0874ab5b ("drm/amdgpu: always reset the asic in suspend (v2)")
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2008
Signed-off-b
ASIC reset, but this still doesn't work on the A+A
configuration in s2idle.
Avoid doing the reset on dGPUs specifically when using s2idle.
Fixes: daf8de0874ab5b ("drm/amdgpu: always reset the asic in suspend (v2)")
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2008
Signed-off-b
in
`amdgpu_device_support_smart_shift`, so this can be simplified.
This causes attributes to not be shown on APUs.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
b/drivers/gpu/drm/amd/pm
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
As all drivers now look at the removable attribute, drop this function.
Signed-off-by: Mario Limonciello
---
include/linux/pci.h | 22 --
1 file changed, 22 deletions(-)
diff
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/radeon/radeon_device.c | 4 ++--
drivers/gpu/drm
Compl+ for Thunderbolt ports") into pci quirks.
Suggested-by: Lukas Wunner
Signed-off-by: Mario Limonciello
---
drivers/pci/hotplug/pciehp_hpc.c | 6 +-
drivers/pci/quirks.c | 17 +
include/linux/pci.h | 2 ++
3 files changed, 20 insertions(+), 5
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/nouveau/nouveau_vga.c | 4 ++--
1 file changed, 2
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Reviewed-by: Macpaul Lin
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2
The `is_thunderbolt` attribute originally had a well defined list of
quirks that it existed for, but it has been overloaded with more
meaning.
Instead use the driver core removable attribute to indicate the
detail a device is attached to a thunderbolt or USB4 chain.
Signed-off-by: Mario
this should be a fixed list.
Suggested-by: Mika Westerberg
Signed-off-by: Mario Limonciello
---
drivers/pci/pci.c| 17 +++
drivers/pci/quirks.c | 67
2 files changed, 79 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci
umers of old attribute to use removable
Note: this spans USB/DRM/platform-x86/PCI trees.
As a majority of the changes are in PCI, it should probably come through
that tree if possible.
Mario Limonciello (7):
PCI: Move `is_thunderbolt` check for lack of command completed to a
quirk
PCI: Mo
that can be called by individual dGPUs to
react to the `amdgpu_aspm` module parameter without having negative results
for other dGPUs on the PCIe bus.
Suggested-by: Lijo Lazar
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu
The `program_aspm` callback is already guarded for aspm, but the
`enable_aspm` callback doesn't follow the module parameter.
Update it to use the helper `amdgpu_device_should_use_aspm`.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/nv.c | 3 ++-
1 file changed, 2 insertions
cs.com/w/images/a/ad/P9_PHB_version1.0_27July2018_pub.pdf
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1723
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1739
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1885
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1907
Tested-by: koba...@canonical.com
The message `Voltage value looks like a Leakage ID but it's not patched`
shows up as an error on Dell Precision 3540. This doesn't cause functional
problems and should be downgraded to info.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1162
Signed-off-by: Mario Limonciello
---
drivers
The `is_thunderbolt` attribute originally had a well defined list of
quirks that it existed for, but it has been overloaded with more
meaning.
Instead use the driver core removable attribute to indicate the
detail a device is attached to a thunderbolt or USB4 chain.
Signed-off-by: Mario
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
As all drivers now look at the removable attribute, drop this function.
Signed-off-by: Mario Limonciello
---
include/linux/pci.h | 22 --
1 file changed, 22 deletions(-)
diff
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/radeon/radeon_device.c | 4 ++--
drivers/gpu/drm
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/nouveau/nouveau_vga.c | 4 ++--
1 file changed, 2
this should be a fixed list.
Suggested-by: Mika Westerberg
Signed-off-by: Mario Limonciello
---
drivers/pci/pci.c| 17 +++
drivers/pci/quirks.c | 67
2 files changed, 79 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Reviewed-by: Macpaul Lin
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2
attribute, use the USB4 DVSEC extended
capabability set on these root ports to determine if they are located
on a discrete USB4 controller.
Suggested-by: Mika Westerberg
Link: https://usb.org/sites/default/files/USB4%20Specification%202026.zip
Signed-off-by: Mario Limonciello
---
drivers/pci
-displayport-tunneled-through-usb4-to-usb4-host-routers
Signed-off-by: Mario Limonciello
---
drivers/pci/pci-acpi.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index a42dbf448860..695dbd88b8b7 100644
--- a/drivers/pci
Compl+ for Thunderbolt ports") into pci quirks.
Suggested-by: Lukas Wunner
Signed-off-by: Mario Limonciello
---
drivers/pci/hotplug/pciehp_hpc.c | 6 +-
drivers/pci/quirks.c | 17 +
include/linux/pci.h | 2 ++
3 files changed, 20 insertions(+), 5
This PCI class definition of the USB4 device is currently located only in
the thunderbolt driver.
It will be needed by a few other drivers for upcoming changes. Move it into
the common include file.
Acked-by: Bjorn Helgaas
Acked-by: Alex Deucher
Acked-by: Mika Westerberg
Signed-off-by: Mario
it should probably come through
that tree if possible.
Mario Limonciello (10):
PCI: Add USB4 class definition
PCI: Move `is_thunderbolt` check for lack of command completed to a
quirk
PCI: Detect root port of internal USB4 controllers
PCI: Detect PCIe root ports for discrete USB4 contr
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Acked-by: Hans de Goede
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/apple-gmux.c | 2 +-
1
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
As all drivers now look at the removable attribute, drop this function.
Signed-off-by: Mario Limonciello
---
include/linux/pci.h | 22 --
1 file changed, 22 deletions(-)
diff
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/nouveau/nouveau_vga.c | 4 ++--
1 file changed, 2
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/radeon/radeon_device.c | 4 ++--
drivers/gpu/drm
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Reviewed-by: Macpaul Lin
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2
/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#mapping-native-protocols-pcie-displayport-tunneled-through-usb4-to-usb4-host-routers
Signed-off-by: Mario Limonciello
---
drivers/pci/pci-acpi.c | 10 ++
drivers/pci/pci.h | 5 +
drivers/pci/probe.c| 1 +
3 files changed
USB4 class devices are also removable like Intel Thunderbolt devices.
Drivers of downstream devices use this information to declare functional
differences in how the drivers perform by knowing that they are connected
to an upstream TBT/USB4 port.
Reviewed-by: Macpaul Lin
Signed-off-by: Mario
This PCI class definition of the USB4 device is currently located only in
the thunderbolt driver.
It will be needed by a few other drivers for upcoming changes. Move it into
the common include file.
Acked-by: Alex Deucher
Acked-by: Mika Westerberg
Signed-off-by: Mario Limonciello
---
drivers
.
Suggested-by: Mika Westerberg
Link: https://usb.org/sites/default/files/USB4%20Specification%202026.zip
Signed-off-by: Mario Limonciello
---
drivers/pci/probe.c | 33 +
include/linux/pci_ids.h | 2 ++
2 files changed, 35 insertions(+)
diff --git a/drivers/pci
`pci_bridge_d3_possible` currently checks explicitly for a Thunderbolt
controller to indicate that D3 is possible. As this is used solely
for older Apple systems, move it into a quirk that enumerates across
all Intel TBT controllers.
Suggested-by: Mika Westerberg
Signed-off-by: Mario
The `is_thunderbolt` attribute is currently a dumping ground for a
variety of things.
Instead use the driver core removable attribute to indicate the
detail a device is attached to a thunderbolt or USB4 chain.
Signed-off-by: Mario Limonciello
---
drivers/pci/probe.c | 20
Compl+ for Thunderbolt ports") into pci quirks.
Suggested-by: Lukas Wunner
Signed-off-by: Mario Limonciello
---
drivers/pci/hotplug/pciehp_hpc.c | 6 +-
drivers/pci/quirks.c | 17 +
include/linux/pci.h | 2 ++
3 files changed, 20 insertions(+), 5
nd
use device core removable attribute instead
- Adjust all consumers of old attribute to use removable
Note: this spans USB/DRM/platform-x86/PCI trees.
As a majority of the changes are in PCI, it should probably come through
that tree if possible.
Mario Limonciello (12):
thunderbolt: move d
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/nouveau/nouveau_vga.c | 4 ++--
1 file changed, 2
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/radeon/radeon_device.c | 4 ++--
drivers/gpu/drm
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Signed-off-by: Mario Limonciello
---
drivers/platform/x86/apple-gmux.c | 2 +-
1 file changed, 1 insertion
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
As all drivers now look at the removable attribute, drop this function.
Signed-off-by: Mario Limonciello
---
include/linux/pci.h | 22 --
1 file changed, 22 deletions(-)
diff
Currently `pci_is_thunderbolt_attached` is used to indicate a device
is connected externally.
The PCI core now marks such devices as removable and downstream drivers
can use this instead.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-
drivers/gpu/drm/amd
This PCI class definition of the USB4 device is currently located only in
the thunderbolt driver.
It will be needed by a few other drivers for upcoming changes. Move it into
the common include file.
Acked-by: Alex Deucher
Signed-off-by: Mario Limonciello
---
drivers/thunderbolt/nhi.h | 2
USB4 class devices are also removable like Intel Thunderbolt devices.
Drivers of downstream devices use this information to declare functional
differences in how the drivers perform by knowing that they are connected
to an upstream TBT/USB4 port.
Signed-off-by: Mario Limonciello
---
drivers
Compl+ for Thunderbolt ports") into pci quirks.
Suggested-by: Lukas Wunner
Signed-off-by: Mario Limonciello
---
drivers/pci/hotplug/pciehp_hpc.c | 6 +-
drivers/pci/quirks.c | 17 +
include/linux/pci.h | 2 ++
3 files changed, 20 insertions(+), 5
The `is_thunderbolt` attribute is currently a dumping ground for a
variety of things.
Instead use the driver core removable attribute to indicate the
detail a device is attached to a thunderbolt or USB4 chain.
Signed-off-by: Mario Limonciello
---
drivers/pci/pci.c | 2
core.
Changes from v1->v2:
- Add Alex's tag to first patch
- Move lack of command completion into a quirk (Lukas)
- Drop `is_thunderbolt` attribute and `pci_is_thunderbolt_attached` and
use device core removable attribute instead
- Adjust all consumers of old attribute to use removable
Ma
Signed-off-by: Mario Limonciello
---
v5->v6:
* Make CONFIG_SUSPEND wrap around entire function to make more readable
* Return false if system not properly configured (relevant with later patch)
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 8 ++--
drivers/gpu/drm/amd/amdgpu/amdgp
This will be used to help make decisions on what to do in
misconfigured systems.
Signed-off-by: Mario Limonciello
---
v5->v6:
* Move in CONFIG_SUSPEND block
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 13 +
2 files changed,
and system misconfigured
the GPU will stay fully powered for the suspend.
* In systems that are intended to be s2idle, but AMD dGPU is also
present, the dGPU will go through S3
Signed-off-by: Mario Limonciello
---
v5->v6:
* Move code into prepare vfunc and use DPM_FLAG_SMART_SUSPEND to s
d/-/issues/1879
Signed-off-by: Mario Limonciello
---
v5->v6:
* Move patch to the start of the series so it can go in even if the rest need
work
* Change approach that if dGPU is in BOCO just skip suspend
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 delet
and system misconfigured
the GPU will stay fully powered for the suspend.
* In systems that are intended to be s2idle, but AMD dGPU is also
present, the dGPU will go through S3
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 +---
1 file
rg/drm/amd/-/issues/1879
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 123ec5a07dd5..66290f986544 100644
---
This will be used to help make decisions on what to do in
misconfigured systems.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 17 +
2 files changed, 19 insertions(+)
diff --git a/drivers/gpu
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
index 4811b0faafd9..2531da6cbec3 100644
---
.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c
b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c
index
Signed-off-by: Mario Limonciello
---
v3->v4:
* Add back in CONFIG_SUSPEND check
v2->v3:
* Better direct users how to recover in the bad cases
v1->v2:
* Only show messages in s2idle cases
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 21 +++--
1 file changed, 15 inserti
two programs from a similar family but different
codebase.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 10 +-
drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 10 +-
drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 10 +-
drivers
esktop.org/drm/amd/-/issues/1824
Signed-off-by: Mario Limonciello
---
v2->v3:
* Better direct users how to recover in the bad cases
v1->v2:
* Only show messages in s2idle cases
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletion
Signed-off-by: Mario Limonciello
---
v1->v2:
* Only show messages in s2idle cases
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu
that put the GPU driver into the S3 codepaths
when the user has selected s2idle.
Reported-by: Bjoren Dasse
BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1824
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215387
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/amdgpu
Otherwise future commands may fail as well leading to downstream
problems that look like they stemmed from a timeout the first time
but really didn't.
Signed-off-by: Mario Limonciello
---
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c | 6 ++
1 file changed, 6 insertions(+)
diff
ay: Extend w/a for hard hang on HPD to
dcn20")
Signed-off-by: Mario Limonciello
---
.../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 11 +---
.../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 11 +---
.../display/dc/irq/dcn20/irq_service_dcn20.c | 25 ---
.../displa
Fixes: 1bd3bc745e7f ("drm/amd/display: Extend w/a for hard hang on HPD to
dcn20")
Signed-off-by: Mario Limonciello
---
changes from v3->v4:
* Move into new function
* Explicitly check that current_state is active for safety
* Change metadata from BugLink to Link
changes from v2-&g
This will make it cleaner to read through the logic for an upcoming change.
Signed-off-by: Mario Limonciello
---
Changes from v3->v4:
* New patch
.../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 30 +++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/drivers/
This can be used by the display core to let decisions be made based
upon the requested power state.
Cc: Qingqing Zhuo
Cc: Scott Bruce
Cc: Chris Hixon
Cc: spassw...@web.de
Signed-off-by: Mario Limonciello
---
changes from v3->v4:
* Initialize power_state when context is created (0 should
When UBSAN is enabled a case is shown on unplugging the display that
this variable hasn't been initialized by `update_dsc_caps`, presumably
when the display was unplugged it wasn't copied from the DPCD.
Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1956497
Signed-off-by: Mario
d hang on HPD")
Fixes: 1bd3bc745e7f ("drm/amd/display: Extend w/a for hard hang on HPD to
dcn20")
Signed-off-by: Mario Limonciello
---
changes from v2->v3:
* stop depending on adev, get value of power state from display core
changes from v1->v2:
* Add fallthrough statement
* Extend ca
This can be used by the display core to let decisions be made based
upon the requested power state.
Cc: Qingqing Zhuo
Cc: Scott Bruce
Cc: Chris Hixon
Cc: spassw...@web.de
Signed-off-by: Mario Limonciello
---
changes from v2->v3:
* New patch
drivers/gpu/drm/amd/display/dc/core/d
701 - 800 of 834 matches
Mail list logo
