Re: [PATCH] drm/amdkfd: avoid svm dump when dynamic debug disabled

2023-08-11 Thread Mike Lothian
On Thu, 3 Aug 2023 at 20:43, Felix Kuehling wrote: > > Is your kernel configured without dynamic debugging? Maybe we need to > wrap this in some #if defined(CONFIG_DYNAMIC_DEBUG_CORE). > Apologies, I thought I'd replied to this, yes I didn't have dynamic debugging enabled

Re: [PATCH V2 1/5] drm/amdkfd: ignore crat by default

2023-08-08 Thread Mike Lothian
ATC, it wasn't really nice with you :) > > Acked-by: Christian König for the whole series. > Tested-by: Mike Lothian

Re: [PATCH] drm/amdkfd: avoid svm dump when dynamic debug disabled

2023-08-03 Thread Mike Lothian
Hi I'm seeing a compiler failure with Clang 16 CC drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.o drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:3568:2: error: call to undeclared function '_dynamic_func_call_no_desc'; ISO C99 and later do not support implicit function declarations

Re: [PATCH] Revert "drm/amd/display: fix dpms_off issue when disabling bios mode"

2023-06-12 Thread Mike Lothian
commit 58e67bb3c131 ("drm/amd/display: fix dpms_off issue when disabling > > bios mode") > > Revert it again as it breaks Asus G513QY / 6800M laptops. > > > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2259 > > Cc: Rodrigo Siqueira > > Cc: Zho

Re: [PATCH 61/66] drm/amd/display: fix dpms_off issue when disabling bios mode

2023-06-11 Thread Mike Lothian
Hi This gives me a blank screen when booting on my Ryzen 9 5900HX Laptop 03:00.0 Display controller [0380]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 22 [Radeon RX 6700/6700 XT/6750 XT / 6800M/6850M XT] [1002:73df] (rev c3) 08:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc.

Re: [PATCH 06/29] drm/amdgpu: keep amdgpu_ctx_mgr in ctx structure

2023-05-19 Thread Mike Lothian
On Wed, 10 May 2023 at 22:24, Alex Deucher wrote: > > From: James Zhu > > Keep amdgpu_ctx_mgr in ctx structure to track fpriv. > > Signed-off-by: James Zhu > Acked-by: Lijo Lazar > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 1 + >

Re: [PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS

2022-12-21 Thread Mike Lothian
On Wed, 21 Dec 2022 at 15:52, Luben Tuikov wrote: > > On 2022-12-21 10:34, Mike Lothian wrote: > > On Fri, 14 Oct 2022 at 09:47, Christian König > > wrote: > >> > >> Entirely remove the sync obj in the job. > >> > >> Signed-off-by: Chri

Re: [PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS

2022-12-21 Thread Mike Lothian
https://gitlab.freedesktop.org/drm/amd/-/issues/2309 On Wed, 21 Dec 2022 at 15:34, Mike Lothian wrote: > > On Fri, 14 Oct 2022 at 09:47, Christian König > wrote: > > > > Entirely remove the sync obj in the job. > > > > Signed-off-by: Christian König > &

Re: [PATCH 10/13] drm/amdgpu: use scheduler depenencies for CS

2022-12-21 Thread Mike Lothian
On Fri, 14 Oct 2022 at 09:47, Christian König wrote: > > Entirely remove the sync obj in the job. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 21 ++--- > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.h | 2 ++ >

Re: [PATCH] Revert "drm/amd/display: fix dpms_off issue when disabling bios mode"

2022-11-17 Thread Mike Lothian
ue; > + pipe->stream->dpms_off = > false; > } > } > } > -- > 2.38.1 > Thanks for the quick turn around. Feel free to add: Tested-by: Mike Lothian

Re: [PATCH 04/29] drm/amd/display: fix dpms_off issue when disabling bios mode

2022-11-17 Thread Mike Lothian
On Wed, 9 Nov 2022 at 06:15, Tom Chung wrote: > > From: Zhongwei Zhang > > [Why] > disable_vbios_mode_if_required() will set dpms_off to false > during boot when pixel clk dismatches with driver requires. > This will cause extra backlight on and off if OS call 2 > times setmode. > > [How] > Set

Re: [PATCH] Revert "drm/amdgpu: add drm buddy support to amdgpu"

2022-08-04 Thread Mike Lothian
Hi When is this relanding? Cheers Mike On Mon, 18 Jul 2022 at 21:40, Dixit, Ashutosh wrote: > > On Thu, 14 Jul 2022 08:00:32 -0700, Christian König wrote: > > > > Am 14.07.22 um 15:33 schrieb Alex Deucher: > > > On Thu, Jul 14, 2022 at 9:09 AM Christian König > > > wrote: > > >> Hi Mauro, >

Re: Please consider Open-source OpenCL support in amdgpu/mesa

2022-07-29 Thread Mike Lothian
I've recently gotten ROCm 5.1.3 working on Gentoo with the open drivers and using upstream llvm 14.0.6, it's enough to get LuxMark 3 running (well with fast math disabled) You might want to look for a distro that packages ROCm for you as Clover is nowhere near ready On Fri, 29 Jul 2022 at 11:06,

Re: Command "clinfo" causes BUG: kernel NULL pointer dereference, address: 0000000000000008 on driver amdgpu

2022-07-19 Thread Mike Lothian
I was told that this patch replaces the patch you mentioned https://patchwork.freedesktop.org/series/106078/ and it the one that'll hopefully land in Linus's tree On Tue, 19 Jul 2022 at 03:33, Chen, Guchun wrote: > > Patch https://patchwork.freedesktop.org/series/106024/ should fix this. > >

Re: [PATCH] drm/amdgpu: Remove one duplicated ef removal

2022-07-19 Thread Mike Lothian
With this patch applied on Linus's tree 5.18-rc7 I get the following warning: drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1367:20: warning: unused variable 'pd' [-Wunused-variable] struct amdgpu_bo *pd = vm->root.bo; ^ 1 warning generated. It does fix the

Re: [PATCH] drm/amdgpu: Fix a NULL pointer of fence

2022-07-18 Thread Mike Lothian
Is this likely to land before 5.19 final? It's been nearly 2 weeks since I said if fixed an issue I was seeing https://gitlab.freedesktop.org/drm/amd/-/issues/2074 On Fri, 8 Jul 2022 at 10:05, Christian König wrote: > > Hi guys, > > well the practice to remove all fences by adding a NULL

Re: [PATCH] drm/amdgpu: Fix a NULL pointer of fence

2022-07-07 Thread Mike Lothian
Hi This appears to fix https://gitlab.freedesktop.org/drm/amd/-/issues/2074 Feel free to add my tested by Thanks Mike On Thu, 7 Jul 2022 at 10:51, xinhui pan wrote: > > Fence is accessed by dma_resv_add_fence() now. > Use amdgpu_amdkfd_remove_eviction_fence instead. > > Signed-off-by: xinhui

Re: [PATCH 10/20] drm/amd/display: Insert pulling smu busy status before sending another request

2022-06-28 Thread Mike Lothian
Hi I'm seeing the following stack trace, I'm guessing due to the assert: [3.516409] [ cut here ] [3.516412] WARNING: CPU: 1 PID: 1 at drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn21/rn_clk_mgr_vbios_smu.c:98 rn_vbios_smu_send_msg_with_param+0x3e/0xe0 [

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-06-23 Thread Mike Lothian
Hi The buddy allocator is still causing me issues in 5.19-rc3 (https://gitlab.freedesktop.org/drm/amd/-/issues/2059) I'm no longer seeing null pointers though, so I think the bulk move fix did it's bit Let me know if there's anything I can help with, now there aren't freezes I can offer remote

Re: [PATCH] drm/amdgpu: Fix GTT size reporting in amdgpu_ioctl

2022-06-14 Thread Mike Lothian
On Mon, 13 Jun 2022 at 10:11, Michel Dänzer wrote: > > On 2022-06-11 09:19, Christian König wrote: > > Am 10.06.22 um 15:54 schrieb Michel Dänzer: > >> From: Michel Dänzer > >> > >> The commit below changed the TTM manager size unit from pages to > >> bytes, but failed to adjust the

Re: [PATCH 2/2] Revert "Revert "drm/amdgpu: Ensure that the modifier requested is supported by plane.""

2022-06-13 Thread Mike Lothian
Hi I'm seeing the following warning when building agd5f's tree with clang 14: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4940:6: warning: unused variable 'i' [-Wunused-variable] int i; ^ 1 warning generated. Which points to this revert On Mon, 10 May 2021 at

Re: [PATCH] drm/amdgpu: Fix GTT size reporting in amdgpu_ioctl

2022-06-11 Thread Mike Lothian
Thanks for finding this I'll have access to my machine on Monday and will close those issues off once I've tested things Cheers Mike On Sat, 11 Jun 2022, 09:19 Christian König, < ckoenig.leichtzumer...@gmail.com> wrote: > Am 10.06.22 um 15:54 schrieb Michel Dänzer: > > From: Michel Dänzer >

Re: [PATCH] drm/ttm: fix bulk move handling during resource init

2022-06-02 Thread Mike Lothian
n top of drm-next. > > Regards, > Christian. > > Am 02.06.22 um 20:08 schrieb Mike Lothian: > > Hi > > > > I'm still seeing Null pointers against Linus's tree and drm-misc with this > > patch > > > > Jun 02 19:04:05 axion.fireburn.co.uk kernel: BUG: k

Re: [PATCH] drm/ttm: fix bulk move handling during resource init

2022-06-02 Thread Mike Lothian
e: GravityMark.x64[1040] exited with preempt_count 1 On Thu, 2 Jun 2022 at 19:08, Mike Lothian wrote: > > Hi > > I'm still seeing Null pointers against Linus's tree and drm-misc with this > patch > > Jun 02 19:04:05 axion.fireburn.co.uk kernel: BUG: kernel NULL pointer > de

Re: [PATCH] drm/ttm: fix bulk move handling during resource init

2022-06-02 Thread Mike Lothian
Hi I'm still seeing Null pointers against Linus's tree and drm-misc with this patch Jun 02 19:04:05 axion.fireburn.co.uk kernel: BUG: kernel NULL pointer dereference, address: 0008 Jun 02 19:04:05 axion.fireburn.co.uk kernel: #PF: supervisor write access in kernel mode Jun 02

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-28 Thread Mike Lothian
On Sat, 28 May 2022 at 08:44, Paneer Selvam, Arunpravin wrote: > > [Public] > > Hi, > > After investigating quite some time on this issue, found freeze problem is > not with the amdgpu part of buddy allocator patch as the patch doesn’t throw > any issues when applied separately on top of the

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-16 Thread Mike Lothian
Hi The merge window for 5.19 will probably be opening next week, has there been any progress with this bug? Thanks Mike On Mon, 2 May 2022 at 17:31, Mike Lothian wrote: > > On Mon, 2 May 2022 at 16:54, Arunpravin Paneer Selvam > wrote: > > > > > > > > On 5/2

[PATCH v2 0/2] drm/amdgpu: Fix a couple of clang warnings

2022-05-04 Thread Mike Lothian
The 3rd patch from the previous series was already applied This reworks the other two based on Alex's comments Mike Lothian (2): drm/amdgpu/gfx10: Avoid uninitialised variable 'index' drm/amdgpu/gfx11: Avoid uninitialised variable 'index' drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3

[PATCH 1/2] drm/amdgpu/gfx10: Avoid uninitialised variable 'index'

2022-05-04 Thread Mike Lothian
_queue) { ^ drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3839:16: note: initialize the variable 'index' to silence this warning unsigned index; ^ = 0 Signed-off-by: Mike Lothian --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 ++- 1 file changed, 2 insertions

[PATCH 2/2] drm/amdgpu/gfx11: Avoid uninitialised variable 'index'

2022-05-04 Thread Mike Lothian
rivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:364:16: note: initialize the variable 'index' to silence this warning unsigned index; ^ = 0 Signed-off-by: Mike Lothian --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 3 ++- 1 file changed, 2 insertions

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-02 Thread Mike Lothian
On Mon, 2 May 2022 at 16:54, Arunpravin Paneer Selvam wrote: > > > > On 5/2/2022 8:41 PM, Mike Lothian wrote: > > On Wed, 27 Apr 2022 at 12:55, Mike Lothian wrote: > >> On Tue, 26 Apr 2022 at 17:36, Christian König > >> wrote: > >>> Hi Mike, &g

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-05-02 Thread Mike Lothian
On Wed, 27 Apr 2022 at 12:55, Mike Lothian wrote: > > On Tue, 26 Apr 2022 at 17:36, Christian König > wrote: > > > > Hi Mike, > > > > sounds like somehow stitching together the SG table for PRIME doesn't > > work any more with this patch. &g

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-04-27 Thread Mike Lothian
On Tue, 26 Apr 2022 at 17:36, Christian König wrote: > > Hi Mike, > > sounds like somehow stitching together the SG table for PRIME doesn't > work any more with this patch. > > Can you try with P2P DMA disabled? -CONFIG_PCI_P2PDMA=y +# CONFIG_PCI_P2PDMA is not set If that's what you're meaning,

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-04-26 Thread Mike Lothian
Hi I'm having issues with this patch on my PRIME system and vulkan workloads https://gitlab.freedesktop.org/drm/amd/-/issues/1992 Is there any chance you could take a look? Cheers Mike

Re: [PATCH v8] drm/amdgpu: handle IH ring1 overflow

2021-12-02 Thread Mike Lothian
On Thu, 25 Nov 2021 at 20:42, Felix Kuehling wrote: > > OK. Dealing with processed timestamp rather than decoded timestamp fixes > the race condition where drain would have returned before the last fault > was processed. But we're still assuming that each interrupt has a unique > timestamp. We

Re: [PATCH 16/27] drm/amd/display: increase Z9 latency to workaround underflow in Z9

2021-10-15 Thread Mike Lothian
This patch seems to change z8 - not that I know what z8 or z9 are On Fri, 15 Oct 2021 at 19:44, Agustin Gutierrez wrote: > > From: Eric Yang > > [Why] > Z9 latency is higher than when we originally tuned the watermark > parameters, causing underflow. Increasing the value until the latency >

Re: [PATCH 28/64] drm/amdgpu: drive all navi asics from the IP discovery table

2021-10-11 Thread Mike Lothian
I've raised a bug with hopefully everything you need https://gitlab.freedesktop.org/drm/amd/-/issues/1743 On Mon, 11 Oct 2021 at 18:35, Alex Deucher wrote: > > On Mon, Oct 11, 2021 at 1:20 PM Mike Lothian wrote: > > > > Hi > > > > This patch breaks things for

Re: [PATCH 28/64] drm/amdgpu: drive all navi asics from the IP discovery table

2021-10-11 Thread Mike Lothian
Hi This patch breaks things for me on my Green Sardine & Navy Flounder system (Asus ROG G513QY) It doesn't get past post with amdgpu built in, will try as a module Cheers Mike On Tue, 28 Sept 2021 at 17:44, Alex Deucher wrote: > > Rather than hardcoding based on asic_type, use the IP >

Re: [PATCH v2 11/23] drm/amd/display: Implement DPIA clock recovery phase

2021-10-07 Thread Mike Lothian
Hi This patch is giving me a build error with Werror when building with Clang-13 drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:195:2: error: variable 'ts' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized] default: ^~~

Re: [PATCH] drm/amdkfd: avoid conflicting address mappings

2021-09-29 Thread Mike Lothian
Hi This patch is causing a compile failure for me drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_chardev.c:1254:25: error: unused variable 'svms' [-Werror,-Wunused-variable] struct svm_range_list *svms = >svms; ^ 1 error generated. I'll turn off Werror On Mon, 19

Re: [PATCH] drm/amd/display: Add NULL checks for vblank workqueue

2021-09-07 Thread Mike Lothian
t is. > > > > Cc: Roman Li > > Cc: Wayne Lin > > Cc: Harry Wentland > > Reported-by: Mike Lothian > > BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1700 > > Fixes: 91f86d4cce2 ("drm/amd/display: Use vblank control events for P

Re: [PATCH 3/7] drm/amd/display: Use vblank control events for PSR enable/disable

2021-09-04 Thread Mike Lothian
Hi This patch is causing issues on my PRIME system I've opened https://gitlab.freedesktop.org/drm/amd/-/issues/1700 to track Cheers Mike On Fri, 13 Aug 2021 at 07:35, Wayne Lin wrote: > > From: Nicholas Kazlauskas > > [Why] > PSR can disable the HUBP along with the OTG when PSR is active.

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-19 Thread Mike Lothian
Hi Do I need to open a new bug report for this? Cheers Mike On Wed, 18 Aug 2021 at 06:26, Andrey Grodzovsky wrote: > > On 2021-08-02 1:16 a.m., Guchun Chen wrote: > > In amdgpu_fence_driver_hw_fini, no need to call drm_sched_fini to stop > > scheduler in s3 test, otherwise, fence related

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-17 Thread Mike Lothian
Hi I've just noticed something similar when starting weston, I still see it with this patch, but not on linus's tree I'll confirm for sure tomorrow and send the stack trace if I can save it Cheers Mike On Tue, 3 Aug 2021 at 02:56, Chen, Guchun wrote: > [Public] > > Hi Alex, > > I submitted

Re: [PATCH] drm/amdgpu: avoid over-handle of fence driver fini in s3 test (v2)

2021-08-02 Thread Mike Lothian
I've just tested it and it seem to fix my issue Feel free to add my Tested-by: Mike Lothian On Mon, 2 Aug 2021 at 14:35, Alex Deucher wrote: > On Mon, Aug 2, 2021 at 4:23 AM Chen, Guchun wrote: > > > > [Public] > > > > Thank you, Christian. > > > > Re

Re: [PATCH] drm/amdgpu: adjust fence driver enable sequence

2021-08-01 Thread Mike Lothian
Hi This patch is causing me issues on my Skylake/Tonga PRIME laptop, reverting sorts it More details here: https://gitlab.freedesktop.org/drm/amd/-/issues/1668 Cheers Mike On Wed, 28 Jul 2021 at 05:07, Likun Gao wrote: > From: Likun Gao > > Fence driver was enabled per ring when sw init on

Re: amdgpu does not support 3840x2160@30Hz on kaveri apu

2021-01-03 Thread Mike Lothian
Hi You're probably best reporting the bug here: https://gitlab.freedesktop.org/drm/amd/-/issues Attach the output of dmesg from both Radeon and AMDGPU and the compositor / Wayland logs (as you're not using X) Cheers Mike On Sun, 3 Jan 2021, 06:32 Davide Corrado, wrote: > hello, I'd like

Re: [Patch v1 0/5] Enable BACO with KFD

2020-01-28 Thread Mike Lothian
Is this designed to work with PRIME laptops too? On Tue, 28 Jan 2020 at 01:29, Rajneesh Bhardwaj wrote: > > This series aims to enable BACO by default on supported AMD platforms > and ensures that the AMD Kernel Fusion Driver can co-exist with this > feature when the GPU devices are runtime

Re: [pull] amdgpu, amdkfd, radeon drm-next-5.6

2019-12-12 Thread Mike Lothian
Hi Please can amdgpu/raven_ta.bin be published somewhere Thanks Mike On Wed, 11 Dec 2019 at 22:30, Alex Deucher wrote: > > Hi Dave, Daniel, > > Kicking off 5.6 with new stuff from AMD. There is a UAPI addition. We > added a new firmware for display, and this just adds the version query > to

Re: [PATCH] drm/amdgpu/psp: declare PSP TA firmware

2019-11-20 Thread Mike Lothian
Hi Any idea where I can find those blobs? Cheers Mike On Wed, 16 Oct 2019 at 03:48, chen gong wrote: > > Add PSP TA firmware declaration for raven raven2 picasso > > Signed-off-by: chen gong > --- > drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff

Re: [PATCH 10/49] drm/amd/display: make firmware info only load once during dc_bios create

2019-08-20 Thread Mike Lothian
On Fri, 9 Aug 2019 at 22:38, wrote: > > From: Dmytro Laktyushkin > > Currently every time DC wants to access firmware info we make a call > into VBIOS. This makes no sense as there is nothing that can change > runtime inside fw info and can cause issues when calling unstable > bios during

Re: [PATCH] Revert "drm/amd/display: Enable fast plane updates when state->allow_modeset = true"

2019-06-20 Thread Mike Lothian
Just FYI my system was Raven1 not Raven2 On Thu, 20 Jun 2019 at 13:34, Nicholas Kazlauskas wrote: > > This reverts commit ebc8c6f18322ad54275997a888ca1731d74b711f. > > There are still missing corner cases with cursor interaction and these > fast plane updates on Picasso and Raven2 leading to

Re: [PATCH] drm/amd/display: Enable fast plane updates when state->allow_modeset = true

2019-06-20 Thread Mike Lothian
Hi This patch causes warnings for me in a continuous loop https://bugs.freedesktop.org/show_bug.cgi?id=110949 Let me know if you'd like any more detail Cheers Mike On Fri, 7 Jun 2019 at 16:42, Francis, David wrote: > > Patch is > > Reviewed-by: David Francis > >

Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2)

2019-05-24 Thread Mike Lothian
I realise you don't want to enable this as it's breaking some people's systems, but could we add a new boot parameter to force it for working systems? Or check against a black list maybe? On Fri, 24 May 2019 at 17:20, Alex Deucher wrote: > > On Fri, May 24, 2019 at 12:09 PM Mike Lothian

Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2)

2019-05-24 Thread Mike Lothian
Hi Curious to know what this means for folk that have newer Raven1 boards that didn't have issues loading the firmware Cheers Mike On Fri, 24 May 2019 at 16:34, Alex Deucher wrote: > > From: Harry Wentland > > [WHY] > Some early Raven boards had a bad SBIOS that doesn't play nicely with >

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Mike Lothian
into releasing that firmware. > > Regards, > Christian. > > > Am 08.10.2018 um 13:22 schrieb Mauro Rossi: > > Hi Mike, > On Mon, Oct 8, 2018 at 1:00 PM Mike Lothian wrote: > >> Hi Mauro >> >> Do you know if there are any plans to add in UVD support o

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Mike Lothian
Hi Mauro Do you know if there are any plans to add in UVD support on SI too? Thanks Mike On Mon, 8 Oct 2018 at 03:24 Mauro Rossi wrote: > [PATCH 01/10] drm/amd/display: add asics info for SI parts > [PATCH 02/10] drm/amd/display: dc/dce: add DCE6 support > [PATCH 03/10] drm/amd/display:

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-03 Thread Mike Lothian
Hi I'm curious to know whether this will/could work over PRIME If the discrete card is rendering slower than the display's frequency could the frequency be dropped on integrated display? I think there are laptops that have freesync now Cheers Mike On Mon, 1 Oct 2018 at 08:15 Daniel Vetter

Re: VegaM DP dpms issue

2018-10-01 Thread Mike Lothian
Hi I'm pretty sure unless you're offloading using DRI_PRIME=1 then it'll be your Intel graphics that'll be driving the displays I'd recommend you raise a bug on https://bugs.freedesktop.org/ under DRI then DRM/Intel Make sure you attach your dmesg and Xorg.0.log and hopefully they'll be able to

Re: [PATCH 2/2] drm/ttm: once more fix ttm_bo_bulk_move_lru_tail v2

2018-09-13 Thread Mike Lothian
Hi This fixes a boot issue I had on Raven ( https://bugs.freedesktop.org/show_bug.cgi?id=107922) Feel free to add to both patches: Tested-by: Mike Lothian Cheers Mike On Thu, 13 Sep 2018 at 12:22 Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > While cutting the

Re: [PATCH v5 0/5] drm/ttm, amdgpu: Introduce LRU bulk move functionality

2018-09-02 Thread Mike Lothian
Hi Is there an updated series? These no longer apply for me Thanks Mike On Wed, 22 Aug 2018 at 09:42 Huang Rui wrote: > On Wed, Aug 22, 2018 at 04:24:02PM +0800, Christian König wrote: > > Please commit patches #1, #2 and #3, doesn't make much sense to send > > them out even more often. > >

Re: [PATCH v2 0/5] drm/ttm, amdgpu: Introduce LRU bulk move functionality

2018-08-12 Thread Mike Lothian
Hi I've been testing these patches over the weekend on my Tonga and Raven systems Tested-by: Mike Lothian Cheers Mike On Fri, 10 Aug 2018 at 12:56 Huang Rui wrote: > The idea and proposal is originally from Christian, and I continue to work > to > deliver it. > > Backg

Re: [PATCH] drm/amdgpu: Don't warn on destroying a pinned BO

2018-07-23 Thread Mike Lothian
Hi I was hitting this Feel free to add my tested by Tested-by: Mike Lothian Cheers Mike On Mon, 23 Jul 2018 at 17:50 Michel Dänzer wrote: > On 2018-07-19 05:39 PM, Michel Dänzer wrote: > > From: Michel Dänzer > > > > The warning turned out to be not so useful, as

Re: [PATCH 0/6] Raven support for KFD

2018-07-12 Thread Mike Lothian
Hi I'm happy to test this out, just wondering what userspace I should pair it with Cheers Mike On Thu, 12 Jul 2018 at 22:25 Felix Kuehling wrote: > Raven refers to Ryzen APUs with integrated GFXv9 GPU. > This patch series completes Raven support for KFD: > > * fix up memory banks info from

Re: [PATCH xf86-video-amdgpu 0/7] Enabling Color Management - Round 3

2018-06-07 Thread Mike Lothian
It seems messy having to create a whole xorg.conf just for one parameter On Thu, 7 Jun 2018 at 08:31 Michel Dänzer wrote: > On 2018-06-07 09:22 AM, Mike Lothian wrote: > > Hi > > > > Is there a way to set depth using a xorg.conf.d snippet rather than > > crea

Re: [PATCH xf86-video-amdgpu 0/7] Enabling Color Management - Round 3

2018-06-07 Thread Mike Lothian
Hi Is there a way to set depth using a xorg.conf.d snippet rather than creating an xorg.conf? Cheers Mike On Wed, 6 Jun 2018 at 17:01 Michel Dänzer wrote: > > Hi Leo, > > > On 2018-06-01 06:03 PM, sunpeng...@amd.com wrote: > > From: "Leo (Sunpeng) Li" > > > > This ended up being different

Re: Raven Ridge Ryzen 2500U hang reproduced

2018-03-28 Thread Mike Lothian
On Tue, 27 Mar 2018, 00:30 Bráulio Bhavamitra, wrote: > Hi all, > > Following the random crashes happenning with many users (e.g. > https://www.phoronix.com/scan.php?page=news_item; > px=Raven-Ridge-March-Update), not only on Linux but also Windows, I've > been struggling to

Re: [PATCH] drm/amdgpu: fix "mitigate workaround for i915"

2018-03-21 Thread Mike Lothian
dma_buf->ops != _dmabuf_ops && bo->prime_shared_count) > + if (attach->dev->driver != adev->dev->driver && > bo->prime_shared_count) > bo->prime_shared_count--; > amdgpu_bo_unreserve(bo); > > -- > 2.14.1 > >

Re: [PATCH 2/2] drm/amdgpu: mitigate workaround for i915

2018-03-20 Thread Mike Lothian
On Mon, 19 Feb 2018 at 13:58 Christian König wrote: > To be able to use DRI_PRIME with amdgpu and i915 we add all our fences > only as exclusive ones. > > Disable that behavior when sharing between amdgpu itself cause it > hinders concurrent execution. > >

Re: [PATCH] drm/amd/display: Fix DCN build breakage

2018-03-13 Thread Mike Lothian
___ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx Tested-by: Mike Lothian <m...@fireburn.co.uk> ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: LLVM 7.0 + Wayland = broken mouse control

2018-01-30 Thread Mike Lothian
I think you can set it by: echo "allow_rgb10_configs=false" >> /etc/environment On Tue, 30 Jan 2018 at 16:38 mikhail wrote: > On Tue, 2018-01-30 at 11:55 +0100, Michel Dänzer wrote: > > > > No, it just means there's an error in the way you're trying to set > > the

Re: [PATCH] drm/amdgpu: remove DC special casing for KB/ML

2018-01-25 Thread Mike Lothian
> - case CHIP_KABINI: > - case CHIP_MULLINS: > - return amdgpu_dc > 0; > case CHIP_VEGA10: > #if defined(CONFIG_DRM_AMD_DC_DCN1_0) > case CHIP_RAVEN: > -- > 2.13.6 > > ___ &

Re: Initial release of AMD Open Source Driver for Vulkan

2017-12-22 Thread Mike Lothian
; Thanks. > Best Regards, > David > > > On Dec 22, 2017, at 9:48 PM, Mike Lothian <m...@fireburn.co.uk> wrote: > > Congratulations on getting this out the door > > It didn't compile for me without these changes: > > In pal: > > diff --git a/src/util/math.cpp

Re: Initial release of AMD Open Source Driver for Vulkan

2017-12-22 Thread Mike Lothian
Congratulations on getting this out the door It didn't compile for me without these changes: In pal: diff --git a/src/util/math.cpp b/src/util/math.cpp index 46e9ede..3af4259 100644 --- a/src/util/math.cpp +++ b/src/util/math.cpp @@ -54,7 +54,7 @@ static uint32 Float32ToFloatN(float f, const

Re: [PATCH] drm/amdgpu: Fix no irq process when evict vram

2017-12-13 Thread Mike Lothian
next-4.16-wip=b9141cd3930e390f156739829ca9589fda7926e4> > is > the word-around for the issue. And I think the varible “shutdown” > assignment is better to be located after amdgpu_fini() to ensure no irq > miss. > > > > Best Regards > > Yintian Tao > > > > &

Re: [PATCH] drm/amdgpu: Fix no irq process when evict vram

2017-12-13 Thread Mike Lothian
Is this a follow on to https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-4.16-wip=b9141cd3930e390f156739829ca9589fda7926e4 On Wed, 13 Dec 2017 at 07:11 Yintian Tao wrote: > When unload amdgpu driver we use sdma to evict vram but there is no > irq process after sdma

Warnings on amd-staging-drm-next branch

2017-01-04 Thread Mike Lothian
Hi I get the following warnings when using GCC 6.3 and the new amd-staging-drm-next branch axion agd5f # make -j20 CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h CHK include/generated/timeconst.h CHK

Re: [PATCH 02/23] drm/amdgpu: add kiq into compiling

2016-12-23 Thread Mike Lothian
Ah, I've clicked now - I thought Vega was a star name AI - Arctic Islands :D On Tue, 20 Dec 2016 at 04:07 Bridgman, John <john.bridg...@amd.com> wrote: > An upcoming GPU generation (Vega). > > > > > > *From:* amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] *O

Re: [PATCH] drm/amdgpu: just suspend the hw on pci shutdown

2016-12-06 Thread Mike Lothian
Feel free to add a reported and tested by flag Thanks for sorting this On Tue, 6 Dec 2016 at 22:55 Alex Deucher wrote: > We can't just reuse pci_remove as there may be userspace still > doing things. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98638 >

Re: [PATCH 1/2] drm/amdgpu: fix power state when port pm is unavailable

2016-11-27 Thread Mike Lothian
to false. > > Can you try the attached patch? > > Kind regards, > Peter > > On Sat, Nov 26, 2016 at 01:49:08PM +, Mike Lothian wrote: > > I can confirm the patch allows my machine to boot again > > > > On Sat, 26 Nov 2016 at 11:39 Peter Wu <pe...@leken

Re: [PATCH 1/2] drm/amdgpu: fix power state when port pm is unavailable

2016-11-26 Thread Mike Lothian
amdgpu_atpx_priv.dhandle = dhandle; > > This is not intended for merging, but just testing a hypothesis. > > Kind regards, > Peter > > On Sat, Nov 26, 2016 at 11:20:28AM +, Mike Lothian wrote: > > He's some screen shots of the booting screens, apologies they

Re: [PATCH 1/2] drm/amdgpu: fix power state when port pm is unavailable

2016-11-26 Thread Mike Lothian
He's some screen shots of the booting screens, apologies they're not that clear https://imgur.com/a/V7mRA On Sat, 26 Nov 2016 at 11:00 Mike Lothian <m...@fireburn.co.uk> wrote: > Hi > > The previous working kernel, was the patch before this - reverting fixes it > > My bios

Re: [PATCH 1/2] drm/amdgpu: fix power state when port pm is unavailable

2016-11-26 Thread Mike Lothian
shot them Regards Mike On Sat, 26 Nov 2016 at 10:20 Peter Wu <pe...@lekensteyn.nl> wrote: > Hi Mike, > > On Sat, Nov 26, 2016 at 12:36:27AM +0000, Mike Lothian wrote: > > This patch is preventing my laptop from booting, I'm getting D3 error > > messages and atom bios

Re: [PATCH 1/2] drm/amdgpu: fix power state when port pm is unavailable

2016-11-25 Thread Mike Lothian
This patch is preventing my laptop from booting, I'm getting D3 error messages and atom bios stuck messages I mistakenly saw the v2 patch and didn't realise it was for radeon not amdgpu - this branch and Linus's tree are currently not booting for me On Wed, 23 Nov 2016 at 17:16 Deucher,

Re: [AMDGPU][CIK] PRIME with DRI3 + stalls rendering

2016-11-16 Thread Mike Lothian
Alternatively you can switch to the modesetting driver - it works well here On Wed, 16 Nov 2016 at 01:33 Mario Kleiner wrote: > On 11/15/2016 09:25 AM, Shawn Starr wrote: > > On Monday, November 14, 2016 3:40:17 PM EST Shawn Starr wrote: > >> On Monday, November 14,

Re: [PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v5)

2016-11-13 Thread Mike Lothian
detach from our exported bo. > > - Also switch to exclusive fence for prime imported bo's. > > v5: - Drop lret, instead use int ret -> long ret, as proposed > by Christian. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95472 > Tested-by: Mike Lothian

Re: [PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-10-28 Thread Mike Lothian
that applies cleanly to 4.10-wip On Fri, 28 Oct 2016 at 18:37 Mario Kleiner <mario.kleiner...@gmail.com> wrote: > > > On 10/28/2016 03:34 AM, Michel Dänzer wrote: > > On 27/10/16 10:33 PM, Mike Lothian wrote: > >> > >> Just another gentle ping to see where y

Re: [PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-10-27 Thread Mike Lothian
Hi Just another gentle ping to see where you are with this? Cheers Mike On Wed, 12 Oct 2016 at 01:40 Michel Dänzer <mic...@daenzer.net> wrote: > On 11/10/16 09:04 PM, Christian König wrote: > > Am 11.10.2016 um 05:58 schrieb Michel Dänzer: > >> On 07/10/16 09:3

Re: [PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-10-07 Thread Mike Lothian
Hi This has discussion has gone a little quiet Was there any agreement about what needed doing to get this working for i965/amdgpu? Regards Mike On Mon, 26 Sep 2016 at 09:04 Daniel Vetter wrote: > > On Mon, Sep 26, 2016 at 09:48:37AM +0900, Michel Dänzer wrote: > > On

Re: VRAM manager

2016-09-27 Thread Mike Lothian
Hi Christian It's working for me on my Tonga now, thanks for fixing those bugs Feel free to add a testing by Cheers Mike On 27 September 2016 at 10:49, Christian König wrote: > Hi guys, > > after fixing all those nasty little bugs this seems to be stable now. > >

Re: [PATCH] drm/amdgpu: allocate GTT space for shadow VM page tables

2016-09-16 Thread Mike Lothian
Does this fix the issue I was seeing since the new memory manager went into thr 4.9-wip branch? On Fri, 16 Sep 2016, 10:48 am Christian König, wrote: > From: Christian König > > We need to access those with the system domain. > > Fixes fallout