[PATCH] drm/amdgpu: Log if device is unsupported

2023-06-05 Thread Paul Menzel
the individual device is supported by the driver or not. Log that case, so users looking at the logs know what is going on. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2608 Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: How are the DC patches tested?

2022-05-10 Thread Paul Menzel
Dear Daniel, Am 09.05.22 um 17:21 schrieb Wheeler, Daniel: I've made some edits to my cover letter to hopefully make it clearer with what is being done. Thank you. Hi all, This week this patchset was tested on the following systems: HP Envy 360, with Ryzen 5 4500U

Fwd: Re: amd | ASUS ROG Strix G513QY fails to resume from suspend [regression] (#2008)

2022-05-10 Thread Paul Menzel
Dear Linux regressions folks, A user reported a regression [1], which also trickled down to the stable series, for example between 5.15.13 and 5.15.14. Kind regards, Paul [1]: https://gitlab.freedesktop.org/drm/amd/-/issues/2008--- Begin Message --- spin83 commented: It doesn't work

Re: [PATCH] drm/amdgpu/gfx11: fix mes mqd settings and map_queue packet

2022-05-10 Thread Paul Menzel
Dear Alex, dear Jack, Thank you for the patch. Am 09.05.22 um 21:06 schrieb Alex Deucher: From: Jack Xiao a. use correct mes mqd settings Can you please elaborate? What is wrong with the old ones, and what are the correct ones? b. fix me field in map_queue packet Can you please add

Re: [PATCH] drm/amdgpu: Check kernel version for 'hypervisor_is_type'

2022-05-10 Thread Paul Menzel
Dear Yongqiang, Thank you for your patch. Am 09.05.22 um 19:07 schrieb Yongqiang Sun: hypervisor_is_type is added since kernel 4.15, dkms package failed to Also mention the commit hash and summary of the commit adding that. install on older kernel e.g. 3.10. Use marcro check kernel

Re: How are the DC patches tested?

2022-05-09 Thread Paul Menzel
Dear Rodrigo, Thank you for the quick response. Am 09.05.22 um 16:15 schrieb Rodrigo Siqueira Jordao: On 2022-05-09 10:00, Paul Menzel wrote: Am 09.05.22 um 15:14 schrieb Wheeler, Daniel: […] This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2

How are the DC patches tested? (was: [PATCH 00/15] DC Patches May 9, 2022)

2022-05-09 Thread Paul Menzel
[Sorry for the incomplete first message.] Dear Daniel, Am 09.05.22 um 15:14 schrieb Wheeler, Daniel: […] This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to

Re: [PATCH 00/15] DC Patches May 9, 2022

2022-05-09 Thread Paul Menzel
Dear Daniel, Am 09.05.22 um 15:14 schrieb Wheeler, Daniel: […] This week this patchset was tested on the following systems: Lenovo Thinkpad T14s Gen2 with AMD Ryzen 5 5650U, with the following display types: eDP 1080p 60hz, 4k 60hz (via USB-C to DP/HDMI), 1440p 144hz (via USB-C to

Re: [PATCH] drm/amdgpu/vcn: fixed no previous prototype warning.

2022-05-09 Thread Paul Menzel
Dear James, You sent this message 30 minutes after sending the same message before (Message-ID: <20220508173008.281673-1-james@amd.com>). Are there any differences? Am 08.05.22 um 20:00 schrieb James Zhu: Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence' Please

Re: [PATCH] amdgpu/pm: Disable managing power profiles on SRIOV for Sienna Cichlid

2022-05-06 Thread Paul Menzel
Dear Danijel, Am 06.05.22 um 09:52 schrieb Danijel Slivka: Please add a reasoning/motivation in the commit message body. Kind regards, Paul Signed-off-by: Danijel Slivka --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 9 + 1 file changed, 9 insertions(+) diff --git

Re: [PATCH] drm/amdgpu: flush delete wq after wait fence

2022-05-05 Thread Paul Menzel
Dear Yiging, Thank you for your patch. Am 05.05.22 um 08:35 schrieb Yiqing Yao: [why] lru_list not empty warning in sw fini during repeated device bind unbind. There should be a amdgpu_fence_wait_empty() before the flush_delayed_work() call as sugested. sug*g*ested Suggested by whom? Or do

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-05-03 Thread Paul Menzel
Dear Daniel, Am 03.05.22 um 14:25 schrieb Daniel Stone: On Sun, 1 May 2022 at 08:08, Paul Menzel wrote: Am 26.04.22 um 15:53 schrieb Gong, Richard: I think so. We captured dmesg log. Then the (whole) system did *not* freeze, if you could still log in (maybe over network) and execute

Re: [PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

2022-05-01 Thread Paul Menzel
Dear Richard, Am 29.04.22 um 18:06 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD Volcanic Islands (VI) GFX cards, such as the WX3200 and RX640, that do not work with ASPM-enabled Intel Alder Lake based systems. Using these

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-05-01 Thread Paul Menzel
Dear Richard, Sorry for the late reply. Am 26.04.22 um 15:53 schrieb Gong, Richard: On 4/21/2022 12:35 AM, Paul Menzel wrote: Am 21.04.22 um 03:12 schrieb Gong, Richard: On 4/20/2022 3:29 PM, Paul Menzel wrote: Am 19.04.22 um 23:46 schrieb Gong, Richard: On 4/14/2022 2:52 AM, Paul

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-20 Thread Paul Menzel
Dear Richard, Am 21.04.22 um 03:12 schrieb Gong, Richard: On 4/20/2022 3:29 PM, Paul Menzel wrote: Am 19.04.22 um 23:46 schrieb Gong, Richard: On 4/14/2022 2:52 AM, Paul Menzel wrote: [Cc: -kernel test robot ] […] Am 13.04.22 um 15:00 schrieb Alex Deucher: On Wed, Apr 13, 2022 at 3

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-20 Thread Paul Menzel
Dear Richard, Am 20.04.22 um 22:56 schrieb Gong, Richard: On 4/20/2022 3:48 PM, Paul Menzel wrote: Am 20.04.22 um 22:40 schrieb Alex Deucher: On Wed, Apr 20, 2022 at 4:29 PM Paul Menzel wrote: Am 19.04.22 um 23:46 schrieb Gong, Richard: On 4/14/2022 2:52 AM, Paul Menzel wrote: [Cc

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-20 Thread Paul Menzel
Dear Alex, Am 20.04.22 um 22:40 schrieb Alex Deucher: On Wed, Apr 20, 2022 at 4:29 PM Paul Menzel wrote: Am 19.04.22 um 23:46 schrieb Gong, Richard: On 4/14/2022 2:52 AM, Paul Menzel wrote: [Cc: -kernel test robot ] […] Am 13.04.22 um 15:00 schrieb Alex Deucher: On Wed, Apr 13

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-20 Thread Paul Menzel
Dear Richard, Am 19.04.22 um 23:46 schrieb Gong, Richard: On 4/14/2022 2:52 AM, Paul Menzel wrote: [Cc: -kernel test robot ] […] Am 13.04.22 um 15:00 schrieb Alex Deucher: On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel wrote: Thank you for sending out v4. Am 12.04.22 um 23:50 schrieb

Re: [PATCH] drm/amdgpu: clean up psp ip if hw_init failed v2

2022-04-20 Thread Paul Menzel
Dear Alice, Thank you for your patch. Am 20.04.22 um 21:37 schrieb Alice Wong: Call psp_hw_fini when psp_hw_init failed. Please amend the commit message, and add the motivation/reasoning too [1]. I think it’s common, if a patch (series) is rerolled to list the changes between the

Re: [PATCH] drm/amdgpu: don't runtime suspend if there are displays attached (v2)

2022-04-19 Thread Paul Menzel
Dear Alex, Thank you for the patch. Am 13.04.22 um 22:15 schrieb Alex Deucher: We normally runtime suspend when there are displays attached if they are in the DPMS off state, however, if something wakes the GPU we send a hotplug event on resume (in case any displays were connected while the

Re: [PATCH v2 2/2] drm/amdkfd: CRIU add support for GWS queues

2022-04-19 Thread Paul Menzel
Dear David, Thank you for sending out v3 of these patches. Am 19.04.22 um 02:04 schrieb Yat Sin, David: -Original Message- From: Paul Menzel Sent: Monday, April 18, 2022 4:23 PM […] Am 18.04.22 um 18:44 schrieb David Yat Sin: In the commit message summary, you could reorder

Re: [PATCH v3 1/2] drm/amdkfd: Fix GWS queue count

2022-04-19 Thread Paul Menzel
Dear David, Thank you for rerolling the patches. Am 19.04.22 um 03:32 schrieb David Yat Sin: dqm->gws_queue_count and pdd->qpd.mapped_gws_queue need to be updated each time the queue gets evicted. Fixes: b8020b0304c8 ("drm/amdkfd: Enable over-subscription with >1 GWS queue") For the

Re: [PATCH v2 2/2] drm/amdkfd: CRIU add support for GWS queues

2022-04-18 Thread Paul Menzel
Dear David, Thank you for your patch. Am 18.04.22 um 18:44 schrieb David Yat Sin: In the commit message summary, you could reorder some words: Add CRIU support for GWS queues Adding support to checkpoint/restore GWS(Global Wave Sync) queues. s/Adding/Add/ Please add a space before the

Re: [PATCH v2 1/2] drm/amdkfd: Fix GWS queue count

2022-04-18 Thread Paul Menzel
Dear David, Thank you for your patch. Am 18.04.22 um 18:44 schrieb David Yat Sin: dqm->gws_queue_count and pdd->qpd.mapped_gws_queue needs to be updated s/needs/need/ each time the queue gets evicted. Why? Do you only change the case, when an element of the queue gets evicted? Next

Re: [PATCH 1/2] Documentation/gpu: Add entries to amdgpu glossary

2022-04-17 Thread Paul Menzel
Dear Tales, Thank you for your patch. Am 15.04.22 um 21:50 schrieb Tales Lelo da Aparecida: Add missing acronyms to the amdgppu glossary. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737 Signed-off-by: Tales Lelo da Aparecida ---

Re: [PATCH] drm/amdkfd: only allow heavy-weight TLB flush on some ASICs for SVM too

2022-04-14 Thread Paul Menzel
Dear Lang, Am 15.04.22 um 05:20 schrieb Lang Yu: On 04/14/ , Paul Menzel wrote: Am 14.04.22 um 10:19 schrieb Lang Yu: The idea is from commit a50fe7078035 ("drm/amdkfd: Only apply heavy-weight TLB flush on Aldebaran") and commit f61c40c0757a ("drm/amdkfd: enable heavy-w

Re: [PATCH] drm/amd/amdgpu: Remove static from variable in RLCG Reg RW.

2022-04-14 Thread Paul Menzel
Dear Gavin, Thank you for your patch. Am 13.04.22 um 17:26 schrieb Gavin Wan: Should you re-roll your patch (v2), please remove the dot/period from the end of the git commit message summary (subject). [why] These static variables saves the RLC Scratch registers address. s/saves/save/

Re: [PATCH] drm/amdkfd: only allow heavy-weight TLB flush on some ASICs for SVM too

2022-04-14 Thread Paul Menzel
Dear Lang, Thank you for the patch. Am 14.04.22 um 10:19 schrieb Lang Yu: The idea is from commit a50fe7078035 ("drm/amdkfd: Only apply heavy-weight TLB flush on Aldebaran") and commit f61c40c0757a ("drm/amdkfd: enable heavy-weight TLB flush on Arcturus"). Otherwise, we will run into problems

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-14 Thread Paul Menzel
[Cc: -kernel test robot ] Dear Alex, dear Richard, Am 13.04.22 um 15:00 schrieb Alex Deucher: On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel wrote: Thank you for sending out v4. Am 12.04.22 um 23:50 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel

Re: [PATCH v2] drm/amdgpu: Fix one use-after-free of VM

2022-04-14 Thread Paul Menzel
Dear Xinhui, Am 14.04.22 um 07:45 schrieb Paul Menzel: Thank you for rerolling the patch. Am 14.04.22 um 07:03 schrieb xinhui pan: VM might already be freed when amdgpu_vm_tlb_seq_cb() is called. We see the calltrace below. Fix it by keeping the last flush fence around and wait

Re: [PATCH v2] drm/amdgpu: Fix one use-after-free of VM

2022-04-13 Thread Paul Menzel
Dear Xinhui, Thank you for rerolling the patch. Am 14.04.22 um 07:03 schrieb xinhui pan: VM might already be freed when amdgpu_vm_tlb_seq_cb() is called. We see the calltrace below. Fix it by keeping the last flush fence around and wait for it to signal Nit: Please add a dot/period to the

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-13 Thread Paul Menzel
Dear Richard, Thank you for sending out v4. Am 12.04.22 um 23:50 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that won't work with ASPM-enabled Intel Alder Lake based systems. Using

Re: [PATCH v2] drm/amdgpu: Make sure ttm delayed work finished

2022-04-13 Thread Paul Menzel
Dear xinhui, Am 13.04.22 um 08:46 schrieb xinhui pan: ttm_device_delayed_workqueue would reschedule itself if there is pending BO to be destroyed. So just one flush + cancel_sync is not enough. We still see lru_list not empty warnging. warning (`scripts/checkpatch.pl --codespell` should

Re: Vega 56 failing to process EDID from VR Headset

2022-04-13 Thread Paul Menzel
Dear James, Am 13.04.22 um 00:13 schrieb James Dutton: On Tue, 12 Apr 2022 at 07:13, Paul Menzel wrote: Am 11.04.22 um 23:39 schrieb James Dutton: So, did you do any changes to Linux? Why do you think the EDID is at fault? […] I suggest to analyze, why `No DP link bandwidth` is logged

Re: [PATCH 1/2] drm/amd/amdgpu: Update PF2VF header

2022-04-13 Thread Paul Menzel
[Removed unintended paste in second line] Am 13.04.22 um 09:03 schrieb Paul Menzel: Dear Bokun, Thank you for rerolling the patch. Please add the iteration/version in the subject next time `[PATCH v2 1/2]` or so. Am 12.04.22 um 23:31 schrieb Bokun Zhang: - Add proper indentation

Re: [PATCH 1/2] drm/amd/amdgpu: Update PF2VF header

2022-04-13 Thread Paul Menzel
Dear Bokun, drm/amd/amdgpu: Update PF2VF header Thank you for rerolling the patch. Please add the iteration/version in the subject next time `[PATCH v2 1/2]` or so. Am 12.04.22 um 23:31 schrieb Bokun Zhang: - Add proper indentation in the header file Please use that as the commit message

Re: [PATCH] Revert "drm/amd/display: Pass HostVM enable flag into DCN3.1 DML"

2022-04-12 Thread Paul Menzel
Dear Rodrigo, Thank you for the patch. Am 12.04.22 um 20:44 schrieb Rodrigo Siqueira: This reverts commit 367b3e934f578f6c0d5d8ca5987dc6ac4cd6831d. While we were testing DCN3.1 with a hub, we noticed that only one of 2 connected displays lights up when using some specific display

Re: AMDGPU: RX 6500 XT: System reset when loading module [SOLVED]

2022-04-12 Thread Paul Menzel
Dear Cal, Am 12.04.22 um 00:31 schrieb Cal Peake: I wanted to put a capper on this just in case anyone was interested, or in case any future people find this thread, because I did find a resolution. Yes, that is very much appreciated. Turns out the way to stop the system from crashing was

Re: [PATCH ] drm/amdgpu: fix discovery ip failed

2022-04-12 Thread Paul Menzel
Dear Jie, Am 12.04.22 um 03:52 schrieb Zhang, Jesse (Jie): [AMD Official Use Only] Thanks Paul Menzel Attach the patch file . Please do not attach patch files, as it breaks work flows and inline commenting. Please use `git send-email` or equivalent. Your colleagues should be able

Re: [PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-12 Thread Paul Menzel
[Cc: +x86 folks] Dear Alex, dear x86 folks, x86 folks, can you think of alternatives to access `X86_HYPER_MS_HYPERV` from `arch/x86/include/asm/hypervisor.h` without any preprocessor ifdef-ery? Am 11.04.22 um 18:28 schrieb Alex Deucher: On Mon, Apr 11, 2022 at 11:28 AM Paul Menzel wrote

AMD Display Core (DC) patches (was: [PATCH 13/16] drm/amd/display: Revert FEC check in validation)

2022-04-12 Thread Paul Menzel
[Cc: +dri-de...@lists.freedesktop.org, +Daniel Vetter, +Alexander Deucher, +Greg KH] Dear Alex, I am a little confused and upset about how Display Core patches are handled in the Linux kernel. Am 25.03.22 um 23:53 schrieb Alex Hung: From: Martin Leung git puts a line “This reverts

Re: [PATCH 04/13] drm/amd/display: FEC check in timing validation

2022-04-12 Thread Paul Menzel
Dear Alex, Am 19.03.22 um 08:43 schrieb Paul Menzel: Dear Alex, dear Chiawen, Thank you for your patch. Am 18.03.22 um 22:47 schrieb Alex Hung: From: Chiawen Huang [Why] disable/enable leads fec mismatch between hw/sw fec state. 1.  Disable/enable of what? 2.  How can

Re: Vega 56 failing to process EDID from VR Headset

2022-04-12 Thread Paul Menzel
Dear James, Am 11.04.22 um 23:39 schrieb James Dutton: I have an Oculus Rift S, that I am trying to get working in Linux. Please always mention the Linux kernel version. I have an AMD Vega 56 graphics card. The VR headset plugs into a display port of the Vega56. The amdgpu driver sees

Re: [PATCH] drm/amd/amdgpu: Not request init data for MS_HYPERV with vega10

2022-04-11 Thread Paul Menzel
Dear Yongqiang, Thank you for your patch. Am 11.04.22 um 15:59 schrieb Yongqiang Sun: MS_HYPERV with vega10 doesn't have the interface to process request init data msg. Should some Hyper-V folks be added to the reviewers list too? Check hypervisor type to not send the request for

Re: [PATCH ] drm/amdgpu: fix discovery ip failed

2022-04-11 Thread Paul Menzel
Dear Jie, Thank you for your patch. Am 11.04.22 um 17:15 schrieb Zhang, Jesse(Jie): You might want to add a space before the (. [AMD Official Use Only] Please send a patch with `git format-patch` or similar. Fix discovery ip failed, and the log: On what system? 56.129549]

Re: [PATCH v2] drm/amd/pm: Disable fan control if not supported

2022-04-11 Thread Paul Menzel
Dear Elena, Am 11.04.22 um 15:32 schrieb Elena Sakhnovitch: On Sienna Cichild, not all platforms use PMFW based fan control. On such ASICs fan control by PMFW will be disabled in PPTable. Disable hwmon knobs for fan control also as it is not possible to report or control fan speed on such

Re: [PATCH] drm/amdgpu: Release memory when psp sw_init is failed

2022-04-11 Thread Paul Menzel
(ret) { - return ret; - } + if (ret) + goto failure; } return 0; +failure: + kfree(psp->cmd); + return ret; } static int psp_sw_fini(void *handle) Acked-by: Paul Menzel Kind regards, Paul

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
Dear Richard, Am 11.04.22 um 13:38 schrieb Gong, Richard: On 4/11/2022 2:41 AM, Paul Menzel wrote: [Cc: +] Am 11.04.22 um 02:27 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature

Re: [PATCH] drm/amd/pm: fix the deadlock issue observed on SI

2022-04-11 Thread Paul Menzel
-off-by: Evan Quan Change-Id: I75de4350d9c2517aba0d6adc12e1bc69430fd800 Without the Gerrit instance URL, the Change-Id is useless. As it’s a regression, please follow the documentation, and add the related tags. Fixes: 3712e7a49459 ("drm/amd/pm: unified lock protections in amdgpu_dpm.c&q

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
[Cc: +] Dear Richard, Am 11.04.22 um 02:27 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
Dear Richard, Thank you for your response, but please reply to your own reply next time. Am 11.04.22 um 02:37 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Thank you for your patch. Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature

Re: [PATCH 04/20] drm/amd/display: Disallow entering PSR when panel is disconnected

2022-04-09 Thread Paul Menzel
Dear Pavle, dear Max, Am 08.04.22 um 19:18 schrieb Pavle Kotarac: From: Max Erenberg [WHY] The dGPU cannot enter PSR when it is not connected to a panel. Maybe spell out Panel Self Refresh once. [HOW] Added a check to dc_link_set_psr_allow_active s/Added/Add/ which returns early if

Re: [PATCH 12/20] drm/amd/display: Add odm seamless boot support

2022-04-09 Thread Paul Menzel
Dear Pavle, dear Duncan, Thank you for the patch. Am 08.04.22 um 19:19 schrieb Pavle Kotarac: From: Duncan Ma [WHY] Implement changes to transition from Pre-OS odm to What is odm/ODM? Original Device Manufacturer? Post-OS odm support. Seamless boot case is also considered. Please

Re: [PATCH 03/20] drm/amd/display: Disabling Z10 on DCN31

2022-04-09 Thread Paul Menzel
Dear Pavle, dear syerizvi, Thank you for the patch. Am 08.04.22 um 19:18 schrieb Pavle Kotarac: From: "AMD\\syerizvi" Please correct the author name. Imperative mood should be used in the commit message summary: Disable Z10 …. [WHY] Z10 is should not be enabled by default on DCN31.

Re: [PATCH 02/20] drm/amd/display: do not wait for mpc idle if tg is disabled

2022-04-09 Thread Paul Menzel
Dear Pavle, Thank you for the patch. Am 08.04.22 um 19:18 schrieb Pavle Kotarac: From: Josip Pavic [Why] When booting, the driver waits for the MPC idle bit to be set as part of pipe initialization. However, on some systems this occurs before OTG is enabled, and since the MPC idle bit won't

Re: [PATCH 01/20] drm/amd/display: undo clearing of z10 related function pointers

2022-04-09 Thread Paul Menzel
Dear Eric, dear Pavle, Thank you for the patch. Am 08.04.22 um 19:18 schrieb Pavle Kotarac: From: Eric Yang [Why] Z10 and S0i3 have some shared path. Previous code clean up , 1. cleanup 2. Remove the space before the comma, or remove the unneeded comma. incorrectly removed these

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-08 Thread Paul Menzel
Dear Richard, Thank you for your patch. Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that cannot be used with Intel AlderLake based systems to enable ASPM. Using

Re: [PATCH Review 1/1] drm/amdgpu: add umc query error status function

2022-04-08 Thread Paul Menzel
Dear Stanley, Thank you for the patch. Am 08.04.22 um 10:10 schrieb Stanley.Yang: Please remove the dot/period from the name. In order to debug ras error, driver will print IPID/SYND/MISC0 register value if detect correctable or uncorrectable error. … if it detects … Provide

Re: [PATCH 1/1] amdgpu/pm: Clarify Documentation of error handling in send_smc_mesg

2022-04-08 Thread Paul Menzel
Dear Darren, Thank you for your patch. Am 08.04.22 um 04:26 schrieb Darren Powell: Contrary to the smu_cmn_send_smc_msg_with_param documentation, two cases exist where messages are silently dropped with no error returned to the caller. These cases occur in unusual situations where

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-04-07 Thread Paul Menzel
Dear Arunpravin, Thank you for your patch. Am 07.04.22 um 07:46 schrieb Arunpravin Paneer Selvam: - Switch to drm buddy allocator - Add resource cursor support for drm buddy I though after the last long discussion, you would actually act on the review comments. Daniel wrote a good summary,

Re: [PATCH] drm/amdgpu/smu10: fix SoC/fclk units in auto mode

2022-04-06 Thread Paul Menzel
lock_vol_info.vdd_dep_on_socclk->entries[index_socclk].clk / 100, NULL); smum_send_msg_to_smc_with_parameter(hwmgr, PPSMC_MSG_SetSoftMaxVcn, Reviewed-by: Paul Menzel Kind regards, Paul

Re: Public patches but non-public development branch

2022-04-05 Thread Paul Menzel
Dear Alex, Am 05.04.22 um 16:13 schrieb Alex Deucher: On Tue, Apr 5, 2022 at 10:03 AM Paul Menzel wrote: Am 05.04.22 um 15:14 schrieb Alex Deucher: On Tue, Apr 5, 2022 at 3:02 AM Paul Menzel wrote: Am 05.04.22 um 08:54 schrieb Christian König: Am 05.04.22 um 08:45 schrieb Paul Menzel

Re: Public patches but non-public development branch

2022-04-05 Thread Paul Menzel
Dear Alex, Am 05.04.22 um 15:14 schrieb Alex Deucher: On Tue, Apr 5, 2022 at 3:02 AM Paul Menzel wrote: Am 05.04.22 um 08:54 schrieb Christian König: Am 05.04.22 um 08:45 schrieb Paul Menzel: Am 04.04.22 um 23:42 schrieb Philip Yang: bo_adev is NULL for system memory mapping to GPU

Public patches but non-public development branch (Re: [PATCH 1/1] drm/amdkfd: Add missing NULL check in svm_range_map_to_gpu)

2022-04-05 Thread Paul Menzel
Dear Christian, Am 05.04.22 um 08:54 schrieb Christian König: Am 05.04.22 um 08:45 schrieb Paul Menzel: Am 04.04.22 um 23:42 schrieb Philip Yang: bo_adev is NULL for system memory mapping to GPU. Fixes: 05fe8eeca92 (drm/amdgpu: fix TLB flushing during eviction) Sorry, where can I find

Re: [PATCH 1/1] drm/amdkfd: Add missing NULL check in svm_range_map_to_gpu

2022-04-05 Thread Paul Menzel
Dear Philip, Am 04.04.22 um 23:42 schrieb Philip Yang: bo_adev is NULL for system memory mapping to GPU. Fixes: 05fe8eeca92 (drm/amdgpu: fix TLB flushing during eviction) Sorry, where can I find that commit? I do not see it in drm-next from agd5f git archive

Re: [PATCH 1/1] drm/amdgpu: Flush TLB after mapping for VG20+XGMI

2022-04-04 Thread Paul Menzel
Dear Philip, Thank you for your response. Am 04.04.22 um 18:52 schrieb philip yang: On 2022-04-04 12:19, Paul Menzel wrote: Am 01.04.22 um 21:57 schrieb Philip Yang: For VG20 + XGMI bridge, all mappings PTEs cache in TC, this may have stall invalid PTEs in TC because one cache line has 8

Re: [PATCH 1/1] drm/amdgpu: Flush TLB after mapping for VG20+XGMI

2022-04-04 Thread Paul Menzel
Dear Philip, Thank you for your patch. Am 01.04.22 um 21:57 schrieb Philip Yang: For VG20 + XGMI bridge, all mappings PTEs cache in TC, this may have stall invalid PTEs in TC because one cache line has 8 pages. Need always Can you please rephrase. “may have stall …” is really hard to

Regression: No signal when loading amdgpu, and system lockup (was: [PATCH V4 17/17] drm/amd/pm: unified lock protections in amdgpu_dpm.c)

2022-04-04 Thread Paul Menzel
#regzbot introduced: 3712e7a494596b26861f4dc9b81676d1d0272eaf #regzbot title: No signal when loading amdgpu, and system lockup #regzbot monitor: https://gitlab.freedesktop.org/drm/amd/-/issues/1957 Dear Arthur, Thank you for your message. Too bad you didn’t update the subject, and didn’t

Re: [Bug][5.18-rc0] Between commits ed4643521e6a and 34af78c4e616, appears warning "WARNING: CPU: 31 PID: 51848 at drivers/dma-buf/dma-fence-array.c:191 dma_fence_array_create+0x101/0x120" and some ga

2022-04-04 Thread Paul Menzel
Dear Christian, Am 04.04.22 um 08:30 schrieb Christian König: those are two independent and already known problems. The warning triggered from the sync_file is already fixed in drm-misc-next-fixes, but so far I couldn't figure out why the games suddenly doesn't work any more. There is a

Re: [PATCH] drm/amdgpu/vcn: remove Unneeded semicolon

2022-03-31 Thread Paul Menzel
Dear Haowen, Thank you for your patch. Am 31.03.22 um 07:56 schrieb Haowen Bai: In the commit message summary, please use: Remove unneeded semicolon report by coccicheck: drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:1951:2-3: Unneeded semicolon fixed c543dcb ("drm/amdgpu/vcn: Add VCN ras error

Re: [PATCH] drm/amdgpu: don't use BACO for reset in S3

2022-03-31 Thread Paul Menzel
Dear Alex, Thank you for your patch. Am 31.03.22 um 16:56 schrieb Alex Deucher: Seems to cause a reboots or hangs on some systems. It’d be great if you listed the systems from the bug reports. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1924 Bug:

Re: [PATCH 1/1] drm: add PSR2 support and capability definition as per eDP 1.5

2022-03-31 Thread Paul Menzel
Dear David, Thank you for your patch. Am 31.03.22 um 19:26 schrieb David Zhang: [why & how] In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU support. You could be specific by using the exact number two. Maybe: As per eDP 1.5 specification, add the two DPCD bit fields below

Re: [PATCH V2] drm/amdgpu: fix incorrect GCR_GENERAL_CNTL address

2022-03-30 Thread Paul Menzel
Dear Ruili, Am 29.03.22 um 11:17 schrieb Ji, Ruili: This is not related to any issue. I didn’t mean an issue (where I’d use Resolves to differentiate the two cases), but the commit introducing the incorrect address. Kind regards, Paul PS: Please use interleaved style when replying

Re: [PATCH v2] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

2022-03-30 Thread Paul Menzel
[Cc: Remove undeliverable Chun Ming Zhou <mailto:david1.z...@amd.com>] Am 30.03.22 um 08:34 schrieb Paul Menzel: Dear Tsung-Hua, Thank you for your patch. Am 30.03.22 um 04:46 schrieb Ryan Lin: The commit message summary is quite long and confusing. Maybe: Use 3 CRTC for 3250c

Re: [PATCH v2] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

2022-03-30 Thread Paul Menzel
Dear Tsung-Hua, Thank you for your patch. Am 30.03.22 um 04:46 schrieb Ryan Lin: The commit message summary is quite long and confusing. Maybe: Use 3 CRTC for 3250c to get internal display working [Why] External displays take priority over internal display when there are fewer display

Re: [PATCH] drm/amd/display: Fix by adding FPU protection for dcn30_internal_validate_bw

2022-03-29 Thread Paul Menzel
Dear Chandan, Am 29.03.22 um 10:29 schrieb CHANDAN VURDIGERE NATARAJ: Is it common to spell your name all uppercase? If not, please use Chandan nVurdigere Nataraj. [WHY] The [] already emphasize the word, so Why could be used. Below general protection fault observed when WebGL Aquarium

Re: [PATCH] drm/amdgpu: Support AMDGPU RAS debugfs poll interface

2022-03-29 Thread Paul Menzel
Dear Yi Peng, Thank you for the patch. Two nits regarding the commit message. Am 29.03.22 um 09:38 schrieb yipechai: Some AMDGPU RAS debugfs operations like UE injection can cause gpu reset. Before doing the next debugfs operation, the application should call poll to check if the gpu has

Re: [PATCH V2] drm/amdgpu: fix incorrect GCR_GENERAL_CNTL address

2022-03-29 Thread Paul Menzel
Dear Ruili, Thank you for your patch. Am 28.03.22 um 06:58 schrieb Ji, Ruili: From: Ruili Ji gfx10.3.3/gfx10.3.6/gfx10.3.7 shall use 0x1580 address for GCR_GENERAL_CNTL Is any “user-visible“ problem fixed by this? Please add a Fixes tag. Kind regards, Paul Signed-off-by: Ruili Ji

Re: 回复: Re: [PATCH] drm/amdgpu: resolve s3 hang for r7340

2022-03-29 Thread Paul Menzel
:38 *发件人:*Paul Menzel […] Am 28.03.22 um 09:36 schrieb Paul Menzel: > Dear Zhenneng, > > > Thank you for your patch. > > Am 28.03.22 um 06:05 schrieb Zhenneng Li: >> This is a workaround for s3 hang for r7340(amdgpu). > > Is it hanging when res

Re: [PATCH] amd/display: set backlight only if required

2022-03-28 Thread Paul Menzel
Dear Shirish, Thank you for the patch. Am 11.03.22 um 16:33 schrieb Shirish S: [Why] comparing pwm bl values (coverted) with user brightness(converted) 1. co*n*verted 2. Please add a space before the (. levels in commit_tail leads to continuous setting of backlight via dmub as they

Re: BUG: Bad page state in process systemd-udevd (was: [PATCH v9 bpf-next 1/9] x86/Kconfig: select HAVE_ARCH_HUGE_VMALLOC with HAVE_ARCH_HUGE_VMAP)

2022-03-28 Thread Paul Menzel
Dear Song, Am 28.03.22 um 21:24 schrieb Song Liu: On Mar 27, 2022, at 11:51 PM, Paul Menzel wrote: Am 28.03.22 um 08:37 schrieb Song Liu: […] On Mar 27, 2022, at 3:36 AM, Paul Menzel wrote: Am 26.03.22 um 19:46 schrieb Paul Menzel: #regzbot introduced

Re: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Paul Menzel
Dear Mohammad, Am 28.03.22 um 11:49 schrieb Ziya, Mohammad zafar: -Original Message- From: Paul Menzel Sent: Monday, March 28, 2022 3:08 PM Am 28.03.22 um 10:47 schrieb Ziya, Mohammad zafar: […] -Original Message- From: Paul Menzel Sent: Monday, March 28, 2022 1:39 PM

Re: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Paul Menzel
Dear Mohammad, Am 28.03.22 um 10:47 schrieb Ziya, Mohammad zafar: […] -Original Message- From: Paul Menzel Sent: Monday, March 28, 2022 1:39 PM Am 28.03.22 um 10:00 schrieb Ziya, Mohammad zafar: […] From: Paul Menzel Sent: Monday, March 28, 2022 1:22 PM Am 28.03.22 um 09

Re: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Paul Menzel
Dear Mohammad, Am 28.03.22 um 10:00 schrieb Ziya, Mohammad zafar: […] From: Paul Menzel Sent: Monday, March 28, 2022 1:22 PM […] Tao, it’s hard to find your reply in the quote, as the message is not quoted correctly (> prepended). Is it possible to use a different email client?

Re: [PATCH v4 5/6] drm/amdgpu/vcn: VCN ras error query support

2022-03-28 Thread Paul Menzel
Dear Mohammad, dear Tao, Tao, it’s hard to find your reply in the quote, as the message is not quoted correctly (> prepended). Is it possible to use a different email client? Am 28.03.22 um 09:43 schrieb Zhou1, Tao: -Original Message- From: Ziya, Mohammad zafar Sent: Monday,

Re: [PATCH] drm/amdgpu: resolve s3 hang for r7340

2022-03-28 Thread Paul Menzel
[Cc: -Jack Zhang (invalid address) Am 28.03.22 um 09:36 schrieb Paul Menzel: Dear Zhenneng, Thank you for your patch. Am 28.03.22 um 06:05 schrieb Zhenneng Li: This is a workaround for s3 hang for r7340(amdgpu). Is it hanging when resuming from S3? Maybe also use the line below

Re: [PATCH] drm/amdgpu: resolve s3 hang for r7340

2022-03-28 Thread Paul Menzel
Dear Zhenneng, Thank you for your patch. Am 28.03.22 um 06:05 schrieb Zhenneng Li: This is a workaround for s3 hang for r7340(amdgpu). Is it hanging when resuming from S3? Maybe also use the line below for the commit message summary: drm/amdgpu: Add 1 ms delay to init handler to fix s3

Re: [PATCH v4 2/6] drm/amdgpu/vcn: Add vcn ras support

2022-03-28 Thread Paul Menzel
Dear Mohammad, Thank you for your patch. Am 28.03.22 um 08:24 schrieb Mohammad Zafar Ziya: VCN block ras feature support addition V2: default ras callback removed Signed-off-by: Mohammad Zafar Ziya Reviewed-by: Hawking Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 10 ++

Re: [PATCH v4 0/6] VCN and JPEG RAS poison detection

2022-03-28 Thread Paul Menzel
Dear Mahommad, Am 28.03.22 um 08:24 schrieb Mohammad Zafar Ziya: VCN and JPEG RAS poison detection It’d be great if you extended this a little bit. Especially, how it can be tested. Mohammad Zafar Ziya (6): drm/amdgpu: Add vcn and jpeg ras support flag drm/amdgpu/vcn: Add vcn ras

Re: [PATCH 01/13] drm/amd/display: HDCP SEND AKI INIT error

2022-03-27 Thread Paul Menzel
Dear Alex, Am 25.03.22 um 21:43 schrieb Hung, Alex: Thanks for your feedback. Thank you for your reply. For the future, it’d be great if you could use interleaved style [1], when replying, or when it’s a new topic, do not cite the previous message. I fixed many errors and typos you

Re: Commit messages

2022-03-25 Thread Paul Menzel
Dear Christian, dear Daniel, dear Alex, Am 23.03.22 um 16:32 schrieb Christian König: Am 23.03.22 um 16:24 schrieb Daniel Stone: On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: That's not what anyone's saying here ... No-one's

Re: [PATCH V2] drm/amdgpu/vcn3: send smu interface type

2022-03-25 Thread Paul Menzel
Dear Boyuan, Am 25.03.22 um 06:53 schrieb Paul Menzel: Dear Boyuan, Thank for the improved patch. Am 24.03.22 um 18:25 schrieb Zhang, Boyuan: [AMD Official Use Only] No idea if this would confuse `git am`. From: Boyuan Zhang mailto:boyuan.zh...@amd.com>> Your mailer(?) m

Re: [PATCH V2] drm/amdgpu/vcn3: send smu interface type

2022-03-24 Thread Paul Menzel
Dear Boyuan, Thank for the improved patch. Am 24.03.22 um 18:25 schrieb Zhang, Boyuan: [AMD Official Use Only] No idea if this would confuse `git am`. From: Boyuan Zhang mailto:boyuan.zh...@amd.com>> Your mailer(?) mangled the patch. Did you edit it in your MUA’s compose window?

Re: [PATCH v2] drm/amdkfd: Check use_xgmi_p2p before reporting hive_id

2022-03-24 Thread Paul Menzel
Dear Divya, Am 23.03.22 um 15:20 schrieb Divya Shikre: Recently introduced commit "845ebd6b7c32 drm/amdgpu: Add use_xgmi_p2p module parameter" did not update XGMI iolinks when use_xgmi_p2p is disabled. Add fix to not create XGMI iolinks in KFD topology when this parameter is disabled. Thank

Re: ATI Radeon Mobility 3470 fails with Kernel 5.0

2022-03-24 Thread Paul Menzel
Dear Craig, Am 24.03.22 um 02:09 schrieb Craig M: I should add some further information: I have tried using Manjaro KDE, Kubuntu 20 and Kubuntu 18.03 live disks and all exhibit this 'tearing' issue. The problem begins rather early on in the boot sequence while the TUI is logging the startup

Re: [PATCH] drm/amdgpu/vcn3: send smu interface type

2022-03-23 Thread Paul Menzel
Dear Yifan, dear Boyuan, Am 24.03.22 um 03:59 schrieb Yifan Zhang: From: Boyuan Zhang For VCN FW to detect ASIC type What affect does this have? How does VCN FW behave different now? Signed-off-by: Boyuan Zhang Signed-off-by: Yifan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h |

Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Paul Menzel
Dear Christian, Am 23.03.22 um 08:42 schrieb Christian König: Am 23.03.22 um 07:42 schrieb Paul Menzel: Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: - Remove drm_mm references and replace with drm buddy functionalities The commit message summary to me suggested, you can

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-23 Thread Paul Menzel
Dear Arunprivin, Thank you for your patch. Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: - Remove drm_mm references and replace with drm buddy functionalities The commit message summary to me suggested, you can somehow use both allocators now. Two suggestions below: 1. Switch

Re: [PATCH] drm/amdkfd:Check use_xgmi_p2p before reporting hive_id

2022-03-23 Thread Paul Menzel
Dear Divya, Thank you for your patch. Am 22.03.22 um 20:23 schrieb Divya Shikre: Please add a space after the colon in the commit message summary. XGMI iolinks will not be created in KFD topology when use_xgmi_p2p module parameter is disabled in a dGPU. 1. Is “will not be” the current

Re: [PATCH] drm/amdgpu: Correct the parameter name of amdgpu_ring_init

2022-03-23 Thread Paul Menzel
Dear Jun, Thank you for your patch. Am 23.03.22 um 04:02 schrieb Ma, Jun: On 3/22/2022 9:33 PM, Christian König wrote: Am 22.03.22 um 13:53 schrieb Ma Jun: Correct the parameter name of amdgpu_ring_init() in header file. Maybe write "Sync up header and implementation to use the same

  1   2   3   >