[PATCH 17/19] drm/amd/display: Set dcn32 caps.seamless_odm

2023-03-18 Thread Qingqing Zhuo
From: Hersen Wu [Why & How] seamless_odm set was not picked up while merging 2d017189e2b3 ("drm/amd/display: Blank eDP on enable drv if odm enabled") Fixes: 2d017189e2b3 ("drm/amd/display: Blank eDP on enable drv if odm enabled") Reviewed-by: Qingqing Zhuo Acked-by: Q

[PATCH 16/19] drm/amd/display: fix wrong index used in dccg32_set_dpstreamclk

2023-03-18 Thread Qingqing Zhuo
gramming") Reviewed-by: Qingqing Zhuo Acked-by: Qingqing Zhuo Signed-off-by: Hersen Wu --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dccg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dccg.c b/drivers/gpu/drm/amd/displ

[PATCH 15/19] drm/amd/display: align commit_planes_for_stream to latest dc code

2023-03-18 Thread Qingqing Zhuo
From: Hersen Wu [Why & How] Due to historic issues, commit_planes_for_stream() has grown differently compared to latest dc code. Apply missed changes to make it aligned. Acked-by: Qingqing Zhuo Signed-off-by: Hersen Wu --- drivers/gpu/drm/amd/display/dc/core/dc.c

[PATCH 14/19] Revert "drm/amdgpu/display: change pipe policy for DCN 2.0"

2023-03-18 Thread Qingqing Zhuo
-by: Qingqing Zhuo Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c index

[PATCH 13/19] drm/amd/display: Set MPC_SPLIT_DYNAMIC for DCN301

2023-03-18 Thread Qingqing Zhuo
, improving the bandwidth and fixing the cursor bug on KDE when it tries hardware rotation. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2247 Cc: Melissa Wen Cc: Xaver Hugl Reviewed-by: Melissa Wen Acked-by: Qingqing Zhuo Acked-by: Hamza Mahfooz Signed-off-by: Rodrigo Siqueira

[PATCH 12/19] drm/amd/display: Set MPC_SPLIT_DYNAMIC for DCN10

2023-03-18 Thread Qingqing Zhuo
to use the pipe policy as MPC_SPLIT_DYNAMIC, and this commit makes this change. Acked-by: Qingqing Zhuo Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc

[PATCH 11/19] drm/amd/display: add missing code change init pix_per_cycle

2023-03-18 Thread Qingqing Zhuo
From: Charlene Liu [why] missing change when port to these two dcn version. Reviewed-by: Chris Park Reviewed-by: Leo Ma Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dio_stream_encoder.c | 1 + 1 file

[PATCH 10/19] drm/amd/display: Add CRC and DMUB test support

2023-03-18 Thread Qingqing Zhuo
From: Charlene Liu [Why & How] - Add CRC for test support - Add params to allow control into to DMUB. Reviewed-by: Chris Park Acked-by: Qingqing Zhuo Signed-off-by: Charlene Liu --- .../gpu/drm/amd/display/dc/dcn10/dcn10_optc.h | 29 +++ drivers/gpu/drm/amd/display/

[PATCH 09/19] drm/amd/display: Add function pointer for validate bw usb4

2023-03-18 Thread Qingqing Zhuo
From: Mustapha Ghaddar [WHY] In order to follow the new protocol of calling link functions [HOW] Add the function pointer to the link_srv Reviewed-by: Kshitij Bhardwaj Acked-by: Qingqing Zhuo Signed-off-by: Mustapha Ghaddar --- .../drm/amd/display/dc/core/dc_link_exports.c | 5

[PATCH 08/19] drm/amd/display: initialize link_srv in virtual env

2023-03-18 Thread Qingqing Zhuo
From: Martin Leung [why] when refactoring to link_srv, we did not include the virtual environment case where dc_construct_ctx gets called instead of dc_construct [how] add initialize link_srv to dc_construct_ctx as well Reviewed-by: Leo Ma Acked-by: Qingqing Zhuo Signed-off-by: Martin Leung

[PATCH 07/19] drm/amd/display: power down eDP if eDP not present

2023-03-18 Thread Qingqing Zhuo
From: Paul Hsieh [Why] When init, driver will power up eDP to check eDP present or not. If eDP not present, driver doesn't power off eDP VDD cause power consumption. [How] If eDP is not present when detection, power off eDP VDD. Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off

[PATCH 06/19] drm/amd/display: update dio for two pixel per container case

2023-03-18 Thread Qingqing Zhuo
From: Charlene Liu [why] Processing rate of the DP encoder, must be programmed to be the same as DIG_FIFO_OUTPUT_ PROCESSING_MODE in DP mode 0: 1 pixel per cycle 1: 2 pixel per cycle Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Charlene Liu --- .../gpu/drm/amd/display/dc

[PATCH 05/19] drm/amd/display: skip wait vblank

2023-03-18 Thread Qingqing Zhuo
From: Zhikai Zhai [WHY] There is no need to wait vblank in the vupdate locked region at a full type update [HOW] skip wait vblank when global sync change Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Zhikai Zhai --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 4

[PATCH 03/19] drm/amd/display: Make DCN32 3dlut function available to future DCNs

2023-03-18 Thread Qingqing Zhuo
From: Wesley Chalmers [Why & How] Make DCN32 3dlut function non-static and thus available for future DCNs. Reviewed-by: Chris Park Acked-by: Qingqing Zhuo Signed-off-by: Wesley Chalmers --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 2 +- drivers/gpu/drm/amd/display/dc/d

[PATCH 04/19] drm/amd/display: Add const to a function

2023-03-18 Thread Qingqing Zhuo
target type [-Werror=discarded-qualifiers] 997 | aconnector->dc_link->dc, This commit fix this issue by making DC a constant variable since we only use it to invoke the function bw_kbps_from_raw_frl_link_rate_data(). Reviewed-by: Chris Park Acked-by: Qingqin

[PATCH 02/19] drm/amd/display: remove outdated 8bpc comments

2023-03-18 Thread Qingqing Zhuo
From: Alex Hung [Why] The commit ad9adba9d1cf ("drm/amd/display: Don't restrict bpc to 8 bpc") removes the historical 8bpc dependency and sets max_bpc to 16. [How] The comment that states "8bpc for non-edp" needs to be removed as well. Reviewed-by: Harry Wentland Ack

[PATCH 01/19] drm/amd/display: Implement workaround for writing to OTG_PIXEL_RATE_DIV register

2023-03-18 Thread Qingqing Zhuo
for FPGA to be exactly the same allowing for more consistent testing. Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Saaem Rizvi --- .../gpu/drm/amd/display/dc/dcn20/dcn20_dccg.h | 3 ++- .../gpu/drm/amd/display/dc/dcn32/dcn32_dccg.c | 22 +++ .../gpu/drm/amd

[PATCH 00/19] DC Patches Mar 20th, 2023

2023-03-18 Thread Qingqing Zhuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: - Power down eDP if eDP not present - Set MPC_SPLIT_DYNAMIC for DCN10 and DCN301 - Initialize link_srv in virtual env - Code cleanup and alignment Cc: Daniel Wheeler --- Alex Deucher (2): Revert

[PATCH 19/19] drm/amd/display: 3.2.227

2023-03-10 Thread Qingqing Zhuo
From: Aric Cyr This version brings along the following: - FW Release 0.0.158.0 - Fixes to HDCP, DP MST and more - Improvements on USB4 links and more - Code re-architecture on link.h Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc

[PATCH 18/19] drm/amd/display: [FW Promotion] Release 0.0.158.0

2023-03-10 Thread Qingqing Zhuo
From: Anthony Koo [Why & How] Add boot control bit to control dispclk and dppclk deep sleep Acked-by: Qingqing Zhuo Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 16/19] drm/amd/display: Clearly states if long or short HPD event in dmesg logs

2023-03-10 Thread Qingqing Zhuo
wo, making debugging on DPIA related issues a bit more troublesome. [How] Clearly states in dmesg logs whether this is a long or short hotplug event. Reviewed-by: Hamza Mahfooz Acked-by: Qingqing Zhuo Signed-off-by: Stylon Wang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 9 +++

[PATCH 17/19] drm/amd/display: fix assert condition

2023-03-10 Thread Qingqing Zhuo
From: Samson Tam [Why & How] Reversed assert condition when checking that phy_pix_clk[] is not 0 Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Samson Tam --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[PATCH 15/19] drm/amd/display: Make DCN32 functions available to future DCNs

2023-03-10 Thread Qingqing Zhuo
From: Wesley Chalmers [Why & How] Make DCN32 functions available for more DCNs. Reviewed-by: Chris Park Acked-by: Qingqing Zhuo Signed-off-by: Wesley Chalmers --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 8 drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.h

[PATCH 14/19] drm/amd/display: reallocate DET for dual displays with high pixel rate ratio

2023-03-10 Thread Qingqing Zhuo
-by: Qingqing Zhuo Signed-off-by: Samson Tam --- .../display/dc/dcn32/dcn32_resource_helpers.c | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c b/drivers/gpu/drm/amd/display/dc/dcn32

[PATCH 13/19] drm/amd/display: disconnect MPCC only on OTG change

2023-03-10 Thread Qingqing Zhuo
-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Ayush Gupta --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c b/drivers/gpu/drm/amd/display/dc/dcn32

[PATCH 12/19] drm/amd/display: Fix DP MST sinks removal issue

2023-03-10 Thread Qingqing Zhuo
. And not all sinks are removed behind the MST branch. [How] Restore the link connection type if it fails to read DPCD register. Cc: sta...@vger.kernel.org Cc: Mario Limonciello Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Cruise Hung --- drivers/gpu/drm/amd/display/dc/link

[PATCH 11/19] drm/amd/display: hpd rx irq not working with eDP interface

2023-03-10 Thread Qingqing Zhuo
2263 ("drm/amd/display: Allow individual control of eDP hotplug support") Cc: sta...@vger.kernel.org Cc: Mario Limonciello Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Robin Chen --- drivers/gpu/drm/amd/display/dc/dc_types.h | 7 +++ drivers/gpu/drm

[PATCH 10/19] drm/amd/display: Do not set DRR on pipe Commit

2023-03-10 Thread Qingqing Zhuo
From: Wesley Chalmers [WHY] Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a pipe commit can cause underflow. Cc: sta...@vger.kernel.org Cc: Mario Limonciello Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wesley Chalmers --- drivers/gpu/drm/amd/display

[PATCH 09/19] drm/amd/display: Take FEC Overhead into Timeslot Calculation

2023-03-10 Thread Qingqing Zhuo
allocation. Cc: sta...@vger.kernel.org Cc: Mario Limonciello Reviewed-by: Hersen Wu Acked-by: Qingqing Zhuo Signed-off-by: Fangzhi Zuo --- .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 32 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.h | 3 ++ 2 files changed, 27

[PATCH 08/19] drm/amd/display: Add Validate BW for USB4 Links

2023-03-10 Thread Qingqing Zhuo
From: Mustapha Ghaddar [WHY] To validate the BW used for DPIAs per HostRouter [HOW] Add the Validate function in C source file Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Mustapha Ghaddar --- .../dc/link/protocols/link_dp_dpia_bw.c | 34 +++ .../dc

[PATCH 06/19] drm/amd/display: convert link.h functions to function pointer style

2023-03-10 Thread Qingqing Zhuo
ract is extracted into a single link service structure defined in link.h header file and implemented only in link_factory.c instead of spreading across multiple files in link component file structure. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/dis

[PATCH 07/19] drm/amd/display: Remove OTG DIV register write for Virtual signals.

2023-03-10 Thread Qingqing Zhuo
values to register if signal is virtual, we have safe guards in place in the case that k1 and k2 is unassigned so that an unknown value is not written to the register either. Cc: sta...@vger.kernel.org Cc: Mario Limonciello Reviewed-by: Samson Tam Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo

[PATCH 05/19] drm/amd/display: reset the scaler boundary mode

2023-03-10 Thread Qingqing Zhuo
From: Zhikai Zhai [WHY] The VBIOS select the black boundary mode when using auto scale mode. But it doesn't recover if there is no reset. [HOW] Clean the scaler boundary mode to default edge in the manual scale mode. Reviewed-by: Dmytro Laktyushkin Acked-by: Qingqing Zhuo Signed-off

[PATCH 04/19] drm/amd/display: Use DPP inst instead of pipe idx for DPP DTO programming

2023-03-10 Thread Qingqing Zhuo
From: Alvin Lee [Description] - For pipe harvesting cases we must use DPP inst instead of pipe index for DPP related programming Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- .../display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 38 ++- .../display/dc

[PATCH 03/19] drm/amd/display: default values for luminance range if they are 0

2023-03-10 Thread Qingqing Zhuo
From: Swapnil Patel [why] Currently if invalid luminescence range is reported in edid, then the driver doesn't have default range to fallback to. [How] Add default range if, the range is 0. Reviewed-by: Roman Li Acked-by: Qingqing Zhuo Signed-off-by: Swapnil Patel --- drivers/gpu/drm/amd

[PATCH 02/19] drm/amd/display: Add DSC Support for Synaptics Cascaded MST Hub

2023-03-10 Thread Qingqing Zhuo
From: Fangzhi Zuo Traditional synaptics hub has one MST branch device without virtual dpcd. Synaptics cascaded hub has two chained MST branch devices. DSC decoding is performed via root MST branch device, instead of the second MST branch device. Reviewed-by: Hersen Wu Acked-by: Qingqing Zhuo

[PATCH 01/19] drm/amd/display: Fix HDCP failing to enable after suspend

2023-03-10 Thread Qingqing Zhuo
with compliance, 2 seconds should enough for compliance and the s3 resume case. [How] Change the Delay to 2 seconds. Reviewed-by: Aurabindo Pillai Acked-by: Qingqing Zhuo Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 00/19] DC Patches Mar 13rd, 2023

2023-03-10 Thread Qingqing Zhuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: - FW Release 0.0.158.0 - Fixes to HDCP, DP MST and more - Improvements on USB4 links and more - Code re-architecture on link.h Cc: Daniel Wheeler Alvin Lee (1): drm/amd/display: Use DPP inst instead of pipe idx

[PATCH 2/2] drm/amd/amdkfd: Fix build error with unmatched argument type

2023-03-08 Thread Qingqing Zhuo
=format=] 35 | #define pr_fmt(fmt) "amdgpu: " fmt | ^~ [How] use %llx instead of %lx for ttm_res_offset. Fixes: d5db9d377c021 ("drm/amdkfd: Fix BO offset for multi-VMA page migration") Signed-off-by: Qingqing Zhuo Cc: Xiaogang Chen

[PATCH 1/2] drm/vc4: Fix build error with undefined label

2023-03-08 Thread Qingqing Zhuo
[Why] drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_bind’: drivers/gpu/drm/vc4/vc4_hdmi.c:3448:17: error: label ‘err_disable_runtime_pm’ used but not defined [How] update err_disable_runtime_pm to err_put_runtime_pm. Signed-off-by: Qingqing Zhuo --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2

[PATCH 33/33] drm/amd/display: 3.2.226

2023-03-03 Thread Qingqing Zhuo
which type of code this guard is intended for. Finally, this version brings along the following: - Enable HostVM based on rIOMMU active - Keep PHY active for dp confi - Improves Z8 - Update clock table - Code and directives clean up Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu

[PATCH 32/33] drm/amd/display: Ensure that planes are in the same order

2023-03-03 Thread Qingqing Zhuo
lue. Since the function dc_add_all_planes_for_stream re-append all the new planes back to the dc_validation_set, this commit ensures that the original sequence is maintained. After this change, all CI tests in all ASICs start to pass again. Reviewed-by: Harry Wentland Acked-by: Qingqing Zhuo Sugges

[PATCH 31/33] drm/amd/display: Add wrapper to call planes and stream update

2023-03-03 Thread Qingqing Zhuo
side DM that enable our drivers to do any necessary preparation or change before we offload the plane/stream update to DC. Reviewed-by: Harry Wentland Acked-by: Qingqing Zhuo Signed-off-by: Rodrigo Siqueira --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 51 +++ 1 file cha

[PATCH 30/33] drm/amd/display: Use DC_LOG_DC in the trasform pixel function

2023-03-03 Thread Qingqing Zhuo
ssue only happens in a transition state on DC, this commit replace BREAK_TO_DEBUGGER with DC_LOG_DC. Reviewed-by: Harry Wentland Acked-by: Qingqing Zhuo Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 5 ++--- 1 file changed, 2 insertions(+), 3 delet

[PATCH 29/33] drm/amd/display: Use dc_update_planes_and_stream

2023-03-03 Thread Qingqing Zhuo
nize and unify our internal API, this commit replaces the old dc_commit_updates_for_stream with dc_update_planes_and_stream, which has more features. Reviewed-by: Harry Wentland Acked-by: Qingqing Zhuo Signed-off-by: Rodrigo Siqueira --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 28/33] drm/amd/display: Drop dc_commit_state in favor of dc_commit_streams

2023-03-03 Thread Qingqing Zhuo
akes maintainability unnecessarily complicated. This commit replaces the old dc_commit_state in favor of dc_commit_streams, and removes the old dc_commit_state. Reviewed-by: Harry Wentland Acked-by: Qingqing Zhuo Signed-off-by: Rodrigo Siqueira --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 27/33] drm/amd/display: Ensure vmin and vmax adjust for DCE

2023-03-03 Thread Qingqing Zhuo
pending") Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/core/dc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core

[PATCH 26/33] drm/amd/display: Pass tg and hubp inst instead of pipe index for SubVP

2023-03-03 Thread Qingqing Zhuo
accessing opp for pipe harvesting cases Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/core/dc.c | 30 +--- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 8 +++--- 2 files changed, 23 insertions(+), 15 deletions

[PATCH 25/33] drm/amd/display: Enable HostVM based on rIOMMU active

2023-03-03 Thread Qingqing Zhuo
to true if riommu is active. Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Gabe Teeger --- drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c b/drivers/gpu

[PATCH 24/33] drm/amd/display: Pass the right info to drm_dp_remove_payload

2023-03-03 Thread Qingqing Zhuo
From: Wayne Lin [Why & How] drm_dp_remove_payload() interface was changed. Correct amdgpu dm code to pass the right parameter to the drm helper function. Reviewed-by: Jerry Zuo Acked-by: Qingqing Zhuo Signed-off-by: Wayne Lin --- .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c

[PATCH 23/33] drm/amd/display: Update to correct min FCLK when construction BB

2023-03-03 Thread Qingqing Zhuo
From: Alvin Lee [Description] - For min FCLK, choose the min of 300Mhz and PMFW requirement - Also only apply min DET check in DML for non-UR cases Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c| 5

[PATCH 22/33] drm/amd/display: Rename DCN config to FP

2023-03-03 Thread Qingqing Zhuo
From: Harry Wentland [Why & How] The only reason we have the DCN config is for floating point support. Rename it to make that clear and (hopefully) avoid misuse of the config in the future. Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Harry Wentland --- drivers

[PATCH 21/33] drm/amd/display: Drop unnecessary DCN guards

2023-03-03 Thread Qingqing Zhuo
From: Harry Wentland [Why & How] DC is littered with many DCN guards that are not needed. Drop them. Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Harry Wentland --- .../drm/amd/display/dc/core/dc_vm_helper.c| 2 -- drivers/gpu/drm/amd/display/dc/dc_dmub_s

[PATCH 20/33] drm/amd/display: Drop unnecessary DCN guards

2023-03-03 Thread Qingqing Zhuo
From: Harry Wentland [Why] DM is littered with DCN guards leading to frequent breakages on non-DCN builds when new code is added. [How] Remove all guards that are not needed. Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Harry Wentland --- .../gpu/drm/amd/display

[PATCH 19/33] drm/amd/display: Keep PHY active for dp config

2023-03-03 Thread Qingqing Zhuo
From: Agustin Gutierrez [Why] Current hotplug sequence causes temporary hang at the re-entry of the optimized power state. [How] Keep a PHY active when detecting DP signal + DPMS active Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Agustin Gutierrez --- .../gpu

[PATCH 18/33] drm/amd/display: Simplify register offsets

2023-03-03 Thread Qingqing Zhuo
. Reviewed-by: Martin Leung Acked-by: Qingqing Zhuo Signed-off-by: Chris Park --- .../gpu/drm/amd/display/dc/dcn32/dcn32_dccg.h | 36 -- .../dc/dcn32/dcn32_dio_stream_encoder.h | 64 - .../drm/amd/display/dc/dcn32/dcn32_hubbub.h | 62 .../gpu/drm/amd

[PATCH 17/33] drm/amd/display: replace all dc_link function call in link with link functions

2023-03-03 Thread Qingqing Zhuo
From: Wenjing Liu [why] Link components should not reply on dc_link_exports to access link function in other link components. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wenjing Liu --- .../display/dc/dcn31/dcn31_dio_link_encoder.c | 5 ++-- .../display/dc/link/accessories

[PATCH 16/33] drm/amd/display: move dc_link functions in protocols folder to dc_link_exports

2023-03-03 Thread Qingqing Zhuo
dc_link functions under protocols folder to dc_link_exports. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wenjing Liu --- .../drm/amd/display/dc/core/dc_link_exports.c | 199 ++ drivers/gpu/drm/amd/display/dc/dc.h | 5 +- .../display/dc/dce110

[PATCH 15/33] drm/amd/display: link link_dp_dpia_bw.o in makefile

2023-03-03 Thread Qingqing Zhuo
From: Wenjing Liu [Why & How] - We have added link_dp_dpia_bw code but it is not currently added in makefile. We are adding this to makefile so it would be built. - Remove unused dc_link.h Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wenjing Liu --- drivers/gpu/drm

[PATCH 14/33] drm/amd/display: move dc_link functions in link root folder to dc_link_exports

2023-03-03 Thread Qingqing Zhuo
dc_link functions under link root folder to dc_link_exports. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/display/dc/core/dc_link_exports.c | 15 +++ drivers/gpu/drm/amd/display/dc/inc/link.h | 6 ++ .../gpu/drm/amd/display

[PATCH 13/33] drm/amd/display: move dc_link functions in accessories folder to dc_link_exports

2023-03-03 Thread Qingqing Zhuo
dc_link functions under accessories folder to dc_link_exports. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 + .../drm/amd/display/dc/core/dc_link_exports.c | 78 +++ drivers/gpu/drm/amd/display/dc

[PATCH 12/33] drm/amd/display: Build DSC without DCN config

2023-03-03 Thread Qingqing Zhuo
any effect. Reviewed-by: Hamza Mahfooz Acked-by: Qingqing Zhuo Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/Makefile | 3 +-- drivers/gpu/drm/amd/display/dc/dsc/rc_calc.c | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/displa

[PATCH 11/33] drm/amd/display: call remove_stream_from_ctx from res_pool funcs

2023-03-03 Thread Qingqing Zhuo
From: Harry Wentland [Why & How] DM should never use a non-interface function to call into DC. The original code is incorrect on ASICs that don't use DCN20's remove_stream_from_ctx function. Reviewed-by: Aurabindo Pillai Acked-by: Qingqing Zhuo Signed-off-by: Harry Wentland --- .../gpu

[PATCH 10/33] drm/amd/display: Drop CONFIG_DRM_AMD_DC_HDCP

2023-03-03 Thread Qingqing Zhuo
From: Harry Wentland [Why & How] There is no reason we still need a config option for this. Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/Kconfig | 6 - drivers/gpu/drm/amd/display/Makefile

[PATCH 09/33] drm/amd/display: fix typo in dc_dsc_config_options structure

2023-03-03 Thread Qingqing Zhuo
From: Mike Hsieh [WHY] There is a typo in dc_dsc_config_options structure [HOW] Fix the typo Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Mike Hsieh --- drivers/gpu/drm/amd/display/dc/dc_dsc.h | 2 +- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 6 +++--- 2 files

[PATCH 08/33] drm/amd/display: Fix no-DCN build

2023-03-03 Thread Qingqing Zhuo
From: Harry Wentland [Why & How] This fixes a couple misplaced CONFIG_DRM_AMD_DC_DCN blocks. Reviewed-by: Sun peng Li Acked-by: Qingqing Zhuo Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 3 +++ 1 file changed, 3 insertions(+) diff -

[PATCH 07/33] drm/amd/display: Drop CONFIG_DRM_AMD_DC_HDR

2023-03-03 Thread Qingqing Zhuo
From: Harry Wentland [Why & How] Remove dead code. Reviewed-by: Sun peng Li Acked-by: Qingqing Zhuo Signed-off-by: Harry Wentland --- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 129 -- 1 file changed, 129 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgp

[PATCH 06/33] drm/amd/display: Update minimum stutter residency for DCN314 Z8

2023-03-03 Thread Qingqing Zhuo
From: Nicholas Kazlauskas [Why] Block periods that are too short as they have the potential to currently cause hangs in other firmware components on the system. [How] Update the threshold, mostly targeting a block of 4k and downscaling. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off

[PATCH 05/33] drm/amd/display: Add minimum Z8 residency debug option

2023-03-03 Thread Qingqing Zhuo
From: Nicholas Kazlauskas [Why] Allows finer control and tuning for debug and profiling. [How] Add the debug option into DC. The default remains the same as before for now. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc

[PATCH 04/33] drm/amd/display: 3.2.225

2023-03-03 Thread Qingqing Zhuo
From: Aric Cyr This version brings along the following: - Correct way to find OPP index - Unify DC logging for BW Alloc - Add height granularity limitation for dsc slice height calculation Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file

[PATCH 03/33] drm/amd/display: When blanking during init loop to find OPP index

2023-03-03 Thread Qingqing Zhuo
From: Alvin Lee [Description] For pipe harvesting cases we cannot rely on array index to get the correct OPP instance, we must loop through each instance to find the correct one. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- .../drm/amd/display/dc/dcn32

[PATCH 02/33] drm/amd/display: Unify DC logging for BW Alloc

2023-03-03 Thread Qingqing Zhuo
From: Mustapha Ghaddar [WHY] To keep all logging within DC unified [HOW] Use the standard DC Logging functions Reviewed-by: Wenjing Liu Reviewed-by: Meenakshikumar Somasundaram Acked-by: Qingqing Zhuo Signed-off-by: Mustapha Ghaddar --- .../dc/link/protocols/link_dp_dpia_bw.c | 56

[PATCH 01/33] drm/amd/display: Add height granularity limitation for dsc slice height calculation

2023-03-03 Thread Qingqing Zhuo
From: Mike Hsieh [WHY] eDP add new limitation for Y granularity for selected update feature. DSC does not include this limitation while calculating slice height. [HOW] Add new limitation while looking for DSC slice height. Reviewed-by: Cruise Hung Acked-by: Qingqing Zhuo Signed-off-by: Mike

[PATCH 00/33] DC Patches Mar 6th, 2023

2023-03-03 Thread Qingqing Zhuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: 1) Transitioning to the new DC commit sequence There is an extended effort to migrate to the new DC commit sequence that better adheres to the DCN hardware constraints. Most of the code was upstreamed already but

[PATCH 20/20] drm/amd/display: Promote DAL to 3.2.224

2023-02-21 Thread Qingqing Zhuo
From: Aric Cyr This version brings along the following: - Correct DML calculation - Extend Freesync over Pcon support - Fixes in pstate hang and more - Code cleanup for dc_link.h and dc_link.c Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1

[PATCH 19/20] drm/amd/display: Only wait for blank completion if OTG active

2023-02-21 Thread Qingqing Zhuo
From: Aric Cyr [why] If OTG is not active, waiting for blank completion will always fail and timeout resulting in unnecessary driver delays. [how] Check that OTG is enabled before waiting for blank. Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm

[PATCH 18/20] drm/amd/display: enable DPG when disabling plane for phantom pipe

2023-02-21 Thread Qingqing Zhuo
From: Samson Tam [Why] In disable_dangling_plane, for phantom pipes, we enable OTG so disable programming gets the double buffer update. But this causes an underflow to occur. [How] Enable DPG prior to enabling OTG. Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Samson Tam

[PATCH 17/20] drm/amd/display: remove empty dc_link.c

2023-02-21 Thread Qingqing Zhuo
From: Wenjing Liu [why] We kept an empty dc_link.c file due to external build dependency. Now the last build dependency has been removed. We can safely delete this file. Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/core

[PATCH 16/20] drm/amd/display: Correct DML calculation as HW SpreadSheet

2023-02-21 Thread Qingqing Zhuo
-by: Qingqing Zhuo Signed-off-by: Paul Hsieh --- .../dc/dml/dcn31/display_mode_vba_31.c| 298 -- .../dc/dml/dcn314/display_mode_vba_314.c | 298 -- 2 files changed, 392 insertions(+), 204 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31

[PATCH 15/20] drm/amd/display: merge dc_link.h into dc.h and dc_types.h

2023-02-21 Thread Qingqing Zhuo
From: Wenjing Liu [why] Remove the need to include dc_link.h separately. dc.h should contain everything needed on DM side. [How] Merge dc_link.h into dc.h and dc_types.h so DM only needs to include dc.h to use all link public functions. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off

[PATCH 14/20] drm/amd/display: Update BW ALLOCATION Function declaration

2023-02-21 Thread Qingqing Zhuo
From: Mustapha Ghaddar [WHY & HOW] Update the declaration to give a better idea of what the function does. Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Mustapha Ghaddar --- drivers/gpu/drm/amd/display/dc/dc_link.h| 6 +++--- .../gpu/drm/amd/displa

[PATCH 13/20] drm/amd/display: Do not update DRR while BW optimizations pending

2023-02-21 Thread Qingqing Zhuo
-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/core/dc.c | 48 ++-- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 1c218c526650..cfb6f4eefce9

[PATCH 12/20] Revert "drm/amd/display: Fix FreeSync active bit issue"

2023-02-21 Thread Qingqing Zhuo
From: Aric Cyr This reverts commit 768ba5d529ae198c3a7cbcb1cbacb8c99dc77f07. [Why & How] Original change causes black screen. Revert until fix is available. Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- .../gpu/drm/amd/display/modules/freesync/freesync.c

[PATCH 11/20] drm/amd/display: DAL to program DISPCLK WDIVIDER if PMFW doesn't

2023-02-21 Thread Qingqing Zhuo
From: Alvin Lee [Why & How] - If for any reason PMFW fails to set the expected (or valid) DISPCLK WDIVIDER, then DAL will program DENTIST DISPCLK WDIVIDER to correct for this issue Reviewed-by: Samson Tam Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- .../display/dc/clk_mgr/d

[PATCH 10/20] drm/amd/display: Extend Freesync over PCon support for more devices

2023-02-21 Thread Qingqing Zhuo
From: Sung Joon Kim [why] More branch devices are able to support Freesync over PCon so include them in the list of supporting devices. [how] Add more compatible PCon devices in the whitelist for Freesync over Pcon. Reviewed-by: Harry Wentland Acked-by: Qingqing Zhuo Signed-off-by: Sung Joon

[PATCH 09/20] drm/amd/display: update pixel format in DP hw sequence

2023-02-21 Thread Qingqing Zhuo
From: Yihan Zhu [WHY] DP 420 formats do not light up because the pixel processing mode of the DP_FORMAT is misprogrammed [HOW] Added appropriate programming for DP pixel format Reviewed-by: Charlene Liu Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Yihan Zhu

[PATCH 08/20] drm/amd/display: populate subvp cmd info only for the top pipe

2023-02-21 Thread Qingqing Zhuo
the page fault. added checks to allow the top pipe only to fix this issue. Co-authored-by: Ayush Gupta Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Ayush Gupta --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 07/20] drm/amd/display: dcn32/321 dsc_pg_control not executed properly

2023-02-21 Thread Qingqing Zhuo
viewed-by: Nevenko Stupar Acked-by: Qingqing Zhuo Signed-off-by: Hersen Wu --- .../drm/amd/display/dc/dcn20/dcn20_hwseq.c| 9 + .../drm/amd/display/dc/dcn30/dcn30_hwseq.c| 5 - .../drm/amd/display/dc/dcn32/dcn32_hwseq.c| 19 +-- 3 files changed, 22 insertions(

[PATCH 06/20] drm/amd/display: Allocation at stream Enable

2023-02-21 Thread Qingqing Zhuo
From: Mustapha Ghaddar [WHY & HOW] After we allocate BW at plug, we will de-alloc and allocate only what stream needs at stream_enable() [HOW] Introduce bw allocation check at link_enable() for DPIA links Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Mustapha Gha

[PATCH 05/20] Revert "drm/amd/display: Do not set DRR on pipe commit"

2023-02-21 Thread Qingqing Zhuo
From: Aric Cyr This reverts commit 723a86ab744043dadf9ff40b34be81efa78895e5. [Why & How] Original change causes a regression. Revert until fix is available. Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_hwseq.c

[PATCH 04/20] drm/amd/display: Updating Video Format Fall Back Policy.

2023-02-21 Thread Qingqing Zhuo
From: Jasdeep Dhillon [WHY] Adding 1920x1080 as fail safe mode for Video Format Fall Back Policy. Reviewed-by: Jerry Zuo Acked-by: Qingqing Zhuo Signed-off-by: Jasdeep Dhillon --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 + drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH 03/20] drm/amd/display: Reduce CPU busy-waiting for long delays

2023-02-21 Thread Qingqing Zhuo
From: Aric Cyr [WHY] udelay should not be used for long waits since it keeps CPU active, wasting power. [HOW] Use fsleep where acceptable to allow CPU cores to be parked by the scheduler. Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd

[PATCH 02/20] drm/amd/display: fix shift-out-of-bounds in CalculateVMAndRowBytes

2023-02-21 Thread Qingqing Zhuo
() and assign the result directly. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Alex Hung --- .../gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c

[PATCH 01/20] drm/amd/display: Ext displays with dock can't recognized after resume

2023-02-21 Thread Qingqing Zhuo
From: Ryan Lin [Why] Needs to set the default value of the LTTPR timeout after resume. [How] Set the default (3.2ms) timeout at resuming if the sink supports LTTPR Reviewed-by: Jerry Zuo Acked-by: Qingqing Zhuo Signed-off-by: Ryan Lin --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 00/20] DC Patches Feb 27th, 2023

2023-02-21 Thread Qingqing Zhuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: - Correct DML calculation - Extend Freesync over Pcon support - Fixes in pstate hang and more - Code cleanup for dc_link.h and dc_link.c Cc: Daniel Wheeler Alex Hung (1): drm/amd/display: fix

[PATCH] Revert "drm/amd/display: enable DPG when disabling plane for phantom pipe"

2023-02-14 Thread Qingqing Zhuo
This reverts commit b73cf50bd1d0008027cc1b41881b671d9c9054b9. regression detected by the change. Revert until fix is available. Signed-off-by: Qingqing Zhuo --- drivers/gpu/drm/amd/display/dc/core/dc.c | 47 +--- 1 file changed, 1 insertion(+), 46 deletions(-) diff --git

[PATCH 21/22] drm/amd/display: temporary fix for page faulting

2023-02-12 Thread Qingqing Zhuo
From: Ayush Gupta This reverts a part of the commit f90a13e4d888ba58cb74ed04bb330c622780bb86 ("drm/amd/display: [FW Promotion] Release 0.0.153.0") Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Ayush Gupta --- drivers/gpu/drm/amd/display/dmub/inc/dmub

[PATCH 19/22] drm/amd/display: Disable HUBP/DPP PG on DCN314 for now

2023-02-12 Thread Qingqing Zhuo
From: Nicholas Kazlauskas [Why] The DMCUB implementation required to workaround corruption is not currently stable and may cause intermittent corruption or hangs. [How] Disable PG until the sequence is stable. Reviewed-by: Hansen Dsouza Acked-by: Qingqing Zhuo Signed-off-by: Nicholas

[PATCH 17/22] drm/amd/display: move public dc link function implementation to dc_link_exports

2023-02-12 Thread Qingqing Zhuo
subcomponent of link which is already a subcomponent of dc. So we are decoupling it by implementing a dc_link_exports in dc. This file will be a thin translation layer that breaks the dependency so link is able to make interface changes without breaking DM. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo

[PATCH 20/22] drm/amd/display: upstream link_dp_dpia_bw.c

2023-02-12 Thread Qingqing Zhuo
From: Mustapha Ghaddar [WHY & HOW] - make link_dp_dpia_bw.c available for linux. - add the verify link peak bw - clean up code and comment format. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Mustapha Ghaddar --- drivers/gpu/drm/amd/display/dc/dc_link.h | 12 + ..

<    1   2   3   4   5   6   >