[PATCH 18/22] drm/amd/display: Add support for multiple overlay planes

2023-02-12 Thread Qingqing Zhuo
the topmost plane is a video plane (overlay only). Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Bhawanpreet Lakha --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 25 ++- .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 22 +++- .../amd

[PATCH 13/22] drm/amd/display: Remove stutter only configurations

2023-02-12 Thread Qingqing Zhuo
for dcn30_internal_validate_bw and created a validate_bw method for DCN314 with the allow_self_refresh_only flag set to false (to support mem clk switching). Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Nasir Osman --- .../drm/amd/display/dc/dcn30/dcn30_resource.c | 16 +++--- .../drm

[PATCH 11/22] drm/amd/display: add NULL pointer check

2023-02-12 Thread Qingqing Zhuo
From: Charlene Liu [Why] In virtual link use case, link->ddc could be NULL. [How] Add null pointer check to avoid undefined behavior. Reviewed-by: Martin Leung Reviewed-by: Hansen Dsouza Acked-by: Qingqing Zhuo Signed-off-by: Charlene Liu --- .../amd/display/dc/dcn10/dcn10_hw_sequence

[PATCH 14/22] drm/amd/display: Disable unbounded request mode during rotation

2023-02-12 Thread Qingqing Zhuo
with rotation configs, hence disabling it. [how] Within DML, modified unbounded request mode to be configured only when the rotation angle of the plane is 0. Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Nasir Osman --- drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c

[PATCH 16/22] drm/amd/display: Update Z8 SR exit/enter latencies

2023-02-12 Thread Qingqing Zhuo
From: Nicholas Kazlauskas [Why] Request from HW team to update the latencies to the new measured values. [How] Update the values in the bounding box. Reviewed-by: Charlene Liu Acked-by: Qingqing Zhuo Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/dml/dcn314

[PATCH 22/22] drm/amd/display: Promote DAL to 3.2.223

2023-02-12 Thread Qingqing Zhuo
From: Aric Cyr This version brings along the following: - Move domain power control to DMCUB for DCN314 - Enable P-state validation check for DCN314 - Add support for multiple overlay planes - Fixes in prefetch, k1 k2 divider programming and more - Code cleanup Acked-by: Qingqing Zhuo Signed

[PATCH 10/22] drm/amd/display: on dp link lost event toggle dpms for master pipe only

2023-02-12 Thread Qingqing Zhuo
master pipes for current link and only toggle DPMS for active master pipes connected to the link. Add assert in case we get called to program dpms with non master pipe. Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Wenjing Liu --- .../display/dc/link/accessories/link_dp_cts.c | 42

[PATCH 12/22] drm/amd/display: Fix video glitch while drag window in PSR-SU

2023-02-12 Thread Qingqing Zhuo
-enabled after the video window is stable. Reviewed-by: Sun peng Li Acked-by: Qingqing Zhuo Signed-off-by: Tom Chung --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 41 --- drivers/gpu/drm/amd/display/dc/dc_link.h | 1 + 2 files changed, 37 insertions(+), 5 deletions

[PATCH 15/22] drm/amd/display: Fix FreeSync active bit issue

2023-02-12 Thread Qingqing Zhuo
From: "Leo (Hanghong) Ma" [Why] The FreeSync active bit unconditionally set in HDMI VSIF. [How] Set this bit to true when FAMS is enable on desktop. Reviewed-by: Felipe Clark Acked-by: Qingqing Zhuo Signed-off-by: Leo (Hanghong) Ma --- .../gpu/drm/amd/display/modules/freesync/

[PATCH 09/22] drm/amd/display: Extract temp drm mst deallocation wa into its own function

2023-02-12 Thread Qingqing Zhuo
generic sequence. Reviewed-by: Jerry Zuo Acked-by: Qingqing Zhuo Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 drivers/gpu/drm/amd/display/dc/dc.h | 1 + .../gpu/drm/amd/display/dc/link/link_dpms.c | 95 --- 3 files changed

[PATCH 03/22] drm/amd/display: fix k1 k2 divider programming for phantom streams

2023-02-12 Thread Qingqing Zhuo
ewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hws

[PATCH 05/22] drm/amd/display: Fix prefetch vratio check

2023-02-12 Thread Qingqing Zhuo
h bw Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- .../dc/dml/dcn32/display_mode_vba_32.c| 9 .../dc/dml/dcn32/display_mode_vba_util_32.c | 21 ++- .../dc/dml/dcn32/display_mode_vba_util_32.h | 5 - 3 files changed, 29 insertions(+

[PATCH 07/22] Revert "drm/amd/display: Correct bw_params population"

2023-02-12 Thread Qingqing Zhuo
From: Daniel Miess This reverts commit 59ce92eba0df932949c7c557868a9b2f379baa5e [Why] This commit causes corruption when viewing a P010 video clip on a 300Hz eDP Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Daniel Miess --- .../dc/clk_mgr/dcn314/dcn314_clk_mgr.c

[PATCH 08/22] drm/amd/display: enable DPG when disabling plane for phantom pipe

2023-02-12 Thread Qingqing Zhuo
From: Samson Tam [Why] In disable_dangling_plane, for phantom pipes, we enable OTG so disable programming gets the double buffer update. But this causes an underflow to occur. [How] Enable DPG prior to enabling OTG. Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Samson Tam

[PATCH 06/22] drm/amd/display: do not set RX back to SST mode for non 0 mst stream count

2023-02-12 Thread Qingqing Zhuo
some further refactor so the logic is easier to understand to prevent future coding error in this sequence. Reviewed-by: Samson Tam Acked-by: Qingqing Zhuo Signed-off-by: Wenjing Liu --- .../gpu/drm/amd/display/dc/link/link_dpms.c | 51 +-- .../display/dc/link/protocols

[PATCH 02/22] drm/amd/display: Set max vratio for prefetch to 7.9 for YUV420 MPO

2023-02-12 Thread Qingqing Zhuo
MPO video cases - Ensure that global vratio prefetch (i.e. total prefetch BW vs. total active bandwidth) does not excited 4.0 Reviewed-by: Nevenko Stupar Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- .../drm/amd/display/dc/dcn32/dcn32_resource.h | 2 ++ .../drm/amd/display/dc/dml

[PATCH 01/22] drm/amd/display: Move DCN314 DOMAIN power control to DMCUB

2023-02-12 Thread Qingqing Zhuo
potential display corruption issues. The command will be ignored on firmware that does not support DOMAIN power control and the pipes will remain always on - frequent PG cycling can cause the issue to occur on the old sequence, so we should avoid it. Reviewed-by: Hansen Dsouza Acked-by: Qingqing

[PATCH 00/22] DC Patches Feb 13, 2023

2023-02-12 Thread Qingqing Zhuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: - Move domain power control to DMCUB for DCN314 - Enable P-state validation check for DCN314 - Add support for multiple overlay planes - Fixes in prefetch, k1 k2 divider programming and more - Code cleanup Cc:

[PATCH 04/22] drm/amd/display: Enable P-state validation checks for DCN314

2023-02-12 Thread Qingqing Zhuo
From: Nicholas Kazlauskas [Why] To align with DCN31 behavior. This helps avoid p-state hangs in the case where underflow does occur. [How] Flip the bit to true. Reviewed-by: Hansen Dsouza Acked-by: Qingqing Zhuo Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/dcn314

[PATCH 11/12] drm/amd/display: avoid disable otg when dig was disabled

2023-02-03 Thread Qingqing Zhuo
82dca8576d14f3dcb775b3be5f1bbb5df9a682ac which was incorrectly reverted. Reviewed-by: Josip Pavic Acked-by: Qingqing Zhuo Signed-off-by: Jingwen Zhu --- .../dc/clk_mgr/dcn315/dcn315_clk_mgr.c| 26 ++- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display

[PATCH 12/12] drm/amd/display: 3.2.222

2023-02-03 Thread Qingqing Zhuo
From: Aric Cyr This version brings along the following: - FW 0.0.153.0 - Code re-organize for dc_link.c - Bug fixes on rotation, DRR and more - DCN314 domain power control moved to dmcub Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file

[PATCH 08/12] drm/amd/display: Move DCN314 DOMAIN power control to DMCUB

2023-02-03 Thread Qingqing Zhuo
potential display corruption issues. The command will be ignored on firmware that does not support DOMAIN power control and the pipes will remain always on - frequent PG cycling can cause the issue to occur on the old sequence, so we should avoid it. Reviewed-by: Hansen Dsouza Acked-by: Qingqing

[PATCH 09/12] drm/amd/display: Drop CONFIG_BACKLIGHT_CLASS_DEVICE ifdefs

2023-02-03 Thread Qingqing Zhuo
From: Hans de Goede Remove CONFI_BACKLIGHT_CLASS_DEVICE ifdef that was accidently introduced back. Reviewed-by: Hamza Mahfooz Acked-by: Qingqing Zhuo Signed-off-by: Hans de Goede Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 --- 1 file changed, 3

[PATCH 10/12] drm/amd/display: [FW Promotion] Release 0.0.153.0

2023-02-03 Thread Qingqing Zhuo
From: Anthony Koo [Why] - Reduce reserved size from 9 to 8 dwords to reduce structure size and allow the union dmub_rb_cmd to fit into max 64-bytes cmd size Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 2 +- 1

[PATCH 06/12] drm/amd/display: Set max vratio for prefetch to 7.9 for YUV420 MPO

2023-02-03 Thread Qingqing Zhuo
MPO video cases - Ensure that global vratio prefetch (i.e. total prefetch BW vs. total active bandwidth) does not excited 4.0 Reviewed-by: Nevenko Stupar Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- .../drm/amd/display/dc/dcn32/dcn32_resource.h | 2 ++ .../drm/amd/display/dc/dml

[PATCH 05/12] drm/amd/display: Add HDMI manufacturer OUI and device id read

2023-02-03 Thread Qingqing Zhuo
From: "Leo (Hanghong) Ma" [Why && How] Add support to read manufacturer OUI and device id from HDMI SCDC. Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Leo (Hanghong) Ma --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 17 drivers/gpu/

[PATCH 02/12] drm/amd/display: Do not commit pipe when updating DRR

2023-02-03 Thread Qingqing Zhuo
From: Wesley Chalmers [WHY] DRR and Pipe cannot be updated on the same frame, or else underflow will occur. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wesley Chalmers --- drivers/gpu/drm/amd/display/dc/core/dc.c | 15 +++ drivers/gpu/drm/amd/display/dc

[PATCH 04/12] drm/amd/display: Fix null pointer deref error on rotation

2023-02-03 Thread Qingqing Zhuo
5643f0991d70 [ 42.725361] R13: 0009 R14: 5643f22d0c50 R15: 5643f0a74550 [ 42.732621] Reviewed-by: Samson Tam Acked-by: Qingqing Zhuo Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 10 ++ 1 file changed, 6 insertions(+),

[PATCH 03/12] drm/amd/display: Only raise FP2 outside of lock

2023-02-03 Thread Qingqing Zhuo
is lower than OTG FP2, no such problems occur. [HOW] If FP2 is being lowered, update the VTG register in lock as normal. If FP2 is being raised, wait until after OTG unlock, so that OTG FP2 is raised first, then update VTG. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wesley Chalmers

[PATCH 01/12] drm/amd/display: Do not set DRR on pipe commit

2023-02-03 Thread Qingqing Zhuo
From: Wesley Chalmers [WHY] Writing to DRR registers such as OTG_V_TOTAL_MIN on the same frame as a pipe commit can cause underflow. [HOW] Defer all DPP adjustment requests till optimized_required is false. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Wesley Chalmers

[PATCH 00/12] DC Patches Feb 6th, 2023

2023-02-03 Thread Qingqing Zhuo
This DC patchset brings improvements in multiple areas. In summary, we have: - DC 3.2.222 - FW 0.0.153.0 - Code re-organize for dc_link.c - Bug fixes on rotation, DRR and more - DCN314 domain power control moved to dmcub Cc: Daniel Wheeler --- Alvin Lee (1): drm/amd/display: Set max vratio

[PATCH 21/23] drm/amd/display: Remove wrong pipe control lock

2022-10-06 Thread Qingqing Zhuo
ub operation when it was unnecessary and causing the hang issue. This commit drops the unnecessary dmub code and, consequently, fixes the second display not lighting up the issue. Acked-by: Qingqing Zhuo Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 12 +--

[PATCH 20/23] drm/amd/display: Fix watermark calculation

2022-10-06 Thread Qingqing Zhuo
From: Alvin Lee Watermark calculation was incorrect due to missing brackets. Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH 19/23] drm/amd/display: Drop uncessary OTG lock check

2022-10-06 Thread Qingqing Zhuo
that check. Acked-by: Qingqing Zhuo Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c b/drivers/gpu/drm/amd/display/dc/dcn10

[PATCH 22/23] drm/amd/display: Don't return false if no stream

2022-10-06 Thread Qingqing Zhuo
From: Alvin Lee pipe_ctx[i] exists even if the pipe is not in use. If the pipe is not in use it will always have a null stream, so don't return false in this case. Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/dcn32

[PATCH 17/23] drm/amd/display: Clean some DCN32 macros

2022-10-06 Thread Qingqing Zhuo
From: Rodrigo Siqueira Some unused macros might mislead developers during the debug, which can be removed without any issue. This commit drops some unused references to SE_COMMON_MASK_SH_LIST_DCN32. Acked-by: Qingqing Zhuo Signed-off-by: Rodrigo Siqueira --- .../amd/display/dc/dcn32

[PATCH 23/23] drm/amd/display: 3.2.207

2022-10-06 Thread Qingqing Zhuo
From: Aric Cyr DC version 3.2.207 brings along the following: - PMFW z-state interface update - Cursor update refactor - Fixes to DSC validation, DCFCLK during Freesync, etc. - Code cleanup Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file

[PATCH 18/23] drm/amd/display: Use set_vtotal_min_max to configure OTG VTOTAL

2022-10-06 Thread Qingqing Zhuo
From: Rodrigo Siqueira In multiple parts of the DCN code, we write directly to the OTG_V_TOTAL_* registers in some OPTC functions. Let's avoid it by using the set_vtotal_min_max. Acked-by: Qingqing Zhuo Signed-off-by: Rodrigo Siqueira --- .../gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 18

[PATCH 13/23] drm/amd/display: Use the same cursor info across features

2022-10-06 Thread Qingqing Zhuo
Lei Acked-by: Qingqing Zhuo Signed-off-by: Max Tseng --- .../gpu/drm/amd/display/dc/core/dc_stream.c | 4 + drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 145 ++ drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h | 1 + .../gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 1

[PATCH 16/23] drm/amd/display: Add a missing hook to DCN20

2022-10-06 Thread Qingqing Zhuo
did not set it for DCN20, this commit initializes the set_vtotal_min_max with the DCN10 function. Acked-by: Qingqing Zhuo Signed-off-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_optc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc

[PATCH 10/23] drm/amd/display: Validate DSC After Enable All New CRTCs

2022-10-06 Thread Qingqing Zhuo
unt in dc_state correctly reflect that in drm_atomic_state which comes up with correct dsc decision. Fixes: 71be4b16d39a ("drm/amd/display: dsc validate fail not pass to atomic check") Reviewed-by: Roman Li Acked-by: Qingqing Zhuo Signed-off-by: Fangzhi Zuo Tested-by: Mark Broadw

[PATCH 12/23] drm/amd/display: Fix bug preventing FCLK Pstate allow message being sent

2022-10-06 Thread Qingqing Zhuo
From: Dillon Varone [Why & How] FCLK pstate allow message should not be dependent on local "update_fclk". Reviewed-by: Martin Leung Acked-by: Qingqing Zhuo Signed-off-by: Dillon Varone --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c | 4 ++-- 1 file changed

[PATCH 14/23] drm/amd/display: Display does not light up after S4 resume

2022-10-06 Thread Qingqing Zhuo
-by: Mustapha Ghaddar Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Meenakshikumar Somasundaram --- drivers/gpu/drm/amd/display/dc/core/dc.c | 31 +++ drivers/gpu/drm/amd/display/dc/dc.h | 3 ++ drivers/gpu/drm/amd/display/dmub/dmub_srv.h | 1

[PATCH 07/23] drm/amd/display: Do not trigger timing sync for phantom pipes

2022-10-06 Thread Qingqing Zhuo
From: Aurabindo Pillai [Why] Doing timing sync seqence for phantom pipes will not go through since they are not fully programmed like normal pipes. Skip the sequence on such pipes Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Aurabindo Pillai --- .../amd/display/dc/dcn10

[PATCH 15/23] drm/amd/display: always allow pstate change when no dpps are active on dcn315

2022-10-06 Thread Qingqing Zhuo
From: Dmytro Laktyushkin [Why & How] Prevents certain configs blocking s0i3 when streams aren't completely removed Reviewed-by: Charlene Liu Acked-by: Qingqing Zhuo Signed-off-by: Dmytro Laktyushkin --- drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c | 9 ++--- 1 file change

[PATCH 11/23] drm/amd/display: Acquire FCLK DPM levels on DCN32

2022-10-06 Thread Qingqing Zhuo
From: Dillon Varone [Why & How] Acquire FCLK DPM levels to properly construct DML clock limits. Further add new logic to keep number of indices for each clock in clk_mgr. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Dillon Varone --- .../display/dc/clk_mgr/d

[PATCH 09/23] drm/amd/display: Add a helper to map ODM/MPC/Multi-Plane resources

2022-10-06 Thread Qingqing Zhuo
From: Jun Lei [Why & How] Add a helper to map ODM/MPC/Multi-Plane resources from DC Reviewed-by: Nevenko Stupar Reviewed-by: Chaitanya Dhere Acked-by: Qingqing Zhuo Signed-off-by: Jun Lei --- .../gpu/drm/amd/display/dc/core/dc_resource.c | 49 ++- drivers/gpu/drm

[PATCH 08/23] drm/amd/display: increase hardware status wait time

2022-10-06 Thread Qingqing Zhuo
] Increase HW status waiting time for DISPCLK frequency divider change and OTG busy status when disable OTG. Reviewed-by: Ariel Bernstein Acked-by: Qingqing Zhuo Signed-off-by: Vladimir Stempen --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 4 ++-- drivers/gpu/drm/amd/display

[PATCH 06/23] drm/amd/display: Use correct pixel clock to program DTBCLK DTO's

2022-10-06 Thread Qingqing Zhuo
From: Dillon Varone [Why?] Currently phy_pix_clk is used to program DTO's which is incorrect. [How?] Use the timing pixel clock to program DTO's correctly. Reviewed-by: Martin Leung Acked-by: Qingqing Zhuo Signed-off-by: Dillon Varone --- drivers/gpu/drm/amd/display/dc/link

[PATCH 05/23] drm/amd/display: do not compare integers of different widths

2022-10-06 Thread Qingqing Zhuo
From: Josip Pavic [Why & How] Increase width of some variables to avoid comparing integers of different widths Reviewed-by: Alvin Lee Acked-by: Qingqing Zhuo Signed-off-by: Josip Pavic --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 3 +-- 1 file changed, 1 insertion(+

[PATCH 04/23] drm/amd/display: zeromem mypipe heap struct before using it

2022-10-06 Thread Qingqing Zhuo
From: Martin Leung [Why & How] bug was caused when moving variable from stack to heap because it was reusable and garbage was left over, so we need to zero mem Fixes: 593eef8c1a5e ("drm/amd/display: reduce stack size in dcn32 dml (v2)") Reviewed-by: Rodrigo Siqueira Acked-by:

[PATCH 03/23] drm/amd/display: properly configure DCFCLK when enable/disable Freesync

2022-10-06 Thread Qingqing Zhuo
. Take DCFCLK calculated after Freesync bandwidth parameters are assigned and bandwidth is recalculated. Reviewed-by: Martin Leung Reviewed-by: Nevenko Stupar Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Vladimir Stempen --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c

[PATCH 02/23] Revert "drm/amd/display: skip commit minimal transition state"

2022-10-06 Thread Qingqing Zhuo
From: Dillon Varone This reverts commit 0a1b86a611f14df7a490b827556a4b8c2e31c050. [Why & How] The reverted commit creates memory leak and causes issue upon driver install. Reviewed-by: Martin Leung Acked-by: Qingqing Zhuo Signed-off-by: Dillon Varone --- drivers/gpu/drm/amd/display/dc/

[PATCH 00/23] DC Patches October 17th, 2022

2022-10-06 Thread Qingqing Zhuo
This DC patch-set brings improvements in multiple areas. In summary, we highlight: - PMFW z-state interface update - Cursor update refactor - Fixes to DSC validation, DCFCLK during Freesync, etc. - Code cleanup Cc: Daniel Wheeler --- Alvin Lee (2): drm/amd/display: Fix watermark

[PATCH 01/23] drm/amd/display: Update PMFW z-state interface for DCN314

2022-10-06 Thread Qingqing Zhuo
From: Nicholas Kazlauskas [Why] Request from PMFW to change the messaging format to specify whether we support z-state via individual bits. [How] Update the args we pass in the support message. Reviewed-by: Charlene Liu Acked-by: Qingqing Zhuo Signed-off-by: Nicholas Kazlauskas --- .../drm

[PATCH v2 10/11] Revert "drm/amd/display: Refactor LTTPR cap retrieval"

2022-05-13 Thread Qingqing Zhuo
From: Michael Strauss This reverts commit f07023c8bb2c596af97dea9995d9f5a0140cddd3. [WHY] Regressions untentionally caused by change, reverting until this can be resolved. Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Michael Strauss --- .../gpu/drm/amd/display/dc/core

[PATCH v2 11/11] drm/amd/display: 3.2.186

2022-05-13 Thread Qingqing Zhuo
From: Aric Cyr This version brings along the following: - Improvements in link training fallback - Adding individual edp hotplug support - Fixes in DPIA HPD status, display clock change hang, etc. - FPU isolation work for DCN30 Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu

[PATCH v2 08/11] drm/amd/display: Move FPU associated DCN30 code to DML folder

2022-05-13 Thread Qingqing Zhuo
From: Jasdeep Dhillon [why & how] As part of the FPU isolation work documented in https://patchwork.freedesktop.org/series/93042/, isolate code that uses FPU in DCN30 to DML, where all FPU code should locate. Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Jasdeep Dhi

[PATCH v2 09/11] drm/amd/display: Fic incorrect pipe being used for clk update

2022-05-13 Thread Qingqing Zhuo
ing dpp_inst instead of i Reviewed-by: Dmytro Laktyushkin Acked-by: Qingqing Zhuo Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_

[PATCH v2 02/11] drm/amd/display: Query DPIA HPD status.

2022-05-13 Thread Qingqing Zhuo
From: Jimmy Kizito [Why] Driver needs up to date DPIA HPD status. [How] Use HPD query command to get DPIA HPD status. Reviewed-by: Meenakshikumar Somasundaram Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Jimmy Kizito --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3

[PATCH v2 05/11] drm/amd/display: Check if modulo is 0 before dividing.

2022-05-13 Thread Qingqing Zhuo
From: David Galiffi [How & Why] If a value of 0 is read, then this will cause a divide-by-0 panic. Reviewed-by: Martin Leung Acked-by: Qingqing Zhuo Signed-off-by: David Galiffi --- drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c | 9 ++--- 1 file changed, 6 insertions(+

[PATCH v2 07/11] drm/amd/display: Check zero planes for OTG disable W/A on clock change

2022-05-13 Thread Qingqing Zhuo
tus in the context associated with the stream, so let's do that. The primary, non MPO pipe should not have a NULL plane state. Reviewed-by: Dmytro Laktyushkin Acked-by: Qingqing Zhuo Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c | 3 ++- drivers/

[PATCH v2 06/11] drm/amd/display: Allow individual control of eDP hotplug support

2022-05-13 Thread Qingqing Zhuo
or the second eDP in a dual eDP system. Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Derek Lai --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 21 +-- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 2 files changed, 20 insertions(+), 3 deletions

[PATCH v2 03/11] drm/amd/display: Clean up code in dc

2022-05-13 Thread Qingqing Zhuo
From: Alvin Lee [Why & How] Code clean up in dc. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/core/dc.c | 15 +-- .../gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c| 1 - 2 files changed, 9 insertions(+

[PATCH v2 04/11] drm/amd/display: clear request when release aux engine

2022-05-13 Thread Qingqing Zhuo
bit as well. Reviewed-by: Anthony Koo Acked-by: Qingqing Zhuo Signed-off-by: Paul Hsieh --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce

[PATCH v2 00/11] DC Patches May 16, 2022

2022-05-13 Thread Qingqing Zhuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Improvements in link training fallback * Adding individual edp hotplug support * Fixes in DPIA HPD status, display clock change hang, etc. * FPU isolation work for DCN30 --- Alvin Lee (1): drm/amd/display:

[PATCH v2 01/11] drm/amd/display: Update link training fallback behaviour.

2022-05-13 Thread Qingqing Zhuo
bandwidth. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Jimmy Kizito --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 77 +-- 1 file changed, 53 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd

[PATCH 11/11] drm/amd/display: 3.2.186

2022-05-13 Thread Qingqing Zhuo
From: Aric Cyr This version brings along the following: - Improvements in link training fallback - Adding individual edp hotplug support - Fixes in DPIA HPD status, display clock change hang, etc. - FPU isolation work for DCN30 Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers/gpu

[PATCH 08/11] drm/amd/display: Move FPU associated DCN30 code to DML folder

2022-05-13 Thread Qingqing Zhuo
From: Jasdeep Dhillon [why & how] As part of the FPU isolation work documented in https://patchwork.freedesktop.org/series/93042/, isolate code that uses FPU in DCN30 to DML, where all FPU code should locate. Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Jasdeep Dhi

[PATCH 10/11] drm/amd/display: Revert refactor LTTPR cap retrieval

2022-05-13 Thread Qingqing Zhuo
From: Michael Strauss [WHY] Regressions untentionally caused by change, reverting until this can be resolved. Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Michael Strauss --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 171 +++--- drivers/gpu/drm/amd/display

[PATCH 06/11] drm/amd/display: Allow individual control of eDP hotplug support

2022-05-13 Thread Qingqing Zhuo
or the second eDP in a dual eDP system. Reviewed-by: Nicholas Kazlauskas Acked-by: Qingqing Zhuo Signed-off-by: Derek Lai --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 21 +-- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 2 files changed, 20 insertions(+), 3 deletions

[PATCH 07/11] drm/amd/display: Check zero planes for OTG disable W/A on clock change

2022-05-13 Thread Qingqing Zhuo
tus in the context associated with the stream, so let's do that. The primary, non MPO pipe should not have a NULL plane state. Reviewed-by: Dmytro Laktyushkin Acked-by: Qingqing Zhuo Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c | 3 ++- drivers/

[PATCH 04/11] drm/amd/display: clear request when release aux engine

2022-05-13 Thread Qingqing Zhuo
bit as well. Reviewed-by: Anthony Koo Acked-by: Qingqing Zhuo Signed-off-by: Paul Hsieh --- drivers/gpu/drm/amd/display/dc/dce/dce_aux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_aux.c b/drivers/gpu/drm/amd/display/dc/dce

[PATCH 09/11] drm/amd/display: Fic incorrect pipe being used for clk update

2022-05-13 Thread Qingqing Zhuo
ing dpp_inst instead of i Reviewed-by: Dmytro Laktyushkin Acked-by: Qingqing Zhuo Signed-off-by: Bhawanpreet Lakha --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_

[PATCH 05/11] drm/amd/display: Check if modulo is 0 before dividing.

2022-05-13 Thread Qingqing Zhuo
From: David Galiffi [How & Why] If a value of 0 is read, then this will cause a divide-by-0 panic. Reviewed-by: Martin Leung Acked-by: Qingqing Zhuo Signed-off-by: David Galiffi --- drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c | 9 ++--- 1 file changed, 6 insertions(+

[PATCH 03/11] drm/amd/display: Clean up code in dc

2022-05-13 Thread Qingqing Zhuo
From: Alvin Lee [Why & How] Code clean up in dc. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/core/dc.c | 15 +-- .../gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c| 1 - 2 files changed, 9 insertions(+

[PATCH 02/11] drm/amd/display: Query DPIA HPD status.

2022-05-13 Thread Qingqing Zhuo
From: Jimmy Kizito [Why] Driver needs up to date DPIA HPD status. [How] Use HPD query command to get DPIA HPD status. Reviewed-by: Meenakshikumar Somasundaram Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Jimmy Kizito --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3

[PATCH 01/11] drm/amd/display: Update link training fallback behaviour.

2022-05-13 Thread Qingqing Zhuo
bandwidth. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Jimmy Kizito --- .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 77 +-- 1 file changed, 53 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd

[PATCH 00/11] DC Patches May 16, 2022

2022-05-13 Thread Qingqing Zhuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: * Improvements in link training fallback * Adding individual edp hotplug support * Fixes in DPIA HPD status, display clock change hang, etc. * FPU isolation work for DCN30 --- Alvin Lee (1): drm/amd/display:

[PATCH 4/4] drm/amd/display: increasing DRAM BW percent for DCN315

2022-02-22 Thread Qingqing Zhuo
From: Sung Joon Kim [why] DML validation fails when we connect two or more displays with HDR. Need to increase DRAM BW to make the validation passing. Following the value from DCN31. [how] Change the max DRAM BW DML field to 60%. Reviewed-by: Charlene Liu Acked-by: Qingqing Zhuo Signed-off

[PATCH 3/4] drm/amd/display: Set compbuf size to min at prep prevent overbook crb

2022-02-22 Thread Qingqing Zhuo
er size. When it is to optimize BW, set compbuf size back to maximum possible size. Reviewed-by: Charlene Liu Acked-by: Qingqing Zhuo Signed-off-by: Duncan Ma Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 12 ++-- .../gpu/drm/amd/disp

[PATCH 2/4] drm/amd/display: revert populating dcn315 clk table based on dcfclk

2022-02-22 Thread Qingqing Zhuo
From: Dmytro Laktyushkin [Why & How] Due to how pmfw fills out the table when dcfclk states are disabled, using dcfclk based clk table would cause a no read situation. Revert the change to prevent underflow until a better solution is coded. Reviewed-by: Charlene Liu Acked-by: Qingqing

[PATCH 1/4] drm/amd/display: limit unbounded requesting to 5k

2022-02-22 Thread Qingqing Zhuo
From: Dmytro Laktyushkin [WHy & How] Unbounded requesting is unsupported on pipe split modes and this change prevents us running into such a situation with wide modes. Reviewed-by: Charlene Liu Acked-by: Qingqing Zhuo Signed-off-by: Dmytro Laktyushkin Reviewed-by: Harry Went

[PATCH 15/16] drm/amd/display: [FW Promotion] Release 0.0.94

2021-11-19 Thread Qingqing Zhuo
From: Anthony Koo [Why & How] - Remove tick count definition since it can be different per HW revision Acked-by: Qingqing Zhuo Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff -

[PATCH 16/16] drm/amd/display: 3.2.163

2021-11-19 Thread Qingqing Zhuo
From: Aric Cyr This version brings along the following: - FW promotion to 0.0.94 - Enable seamless boot for DCN301 - Improvements in bandwidth validation - Fixes in flags update, link encoder assignments, DSC, ODM combine and more Acked-by: Qingqing Zhuo Signed-off-by: Aric Cyr --- drivers

[PATCH 14/16] drm/amd/display: add else to avoid double destroy clk_mgr

2021-11-19 Thread Qingqing Zhuo
From: Martin Leung [Why & How] when changing some code we accidentally changed else if-> if. reverting that. Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Martin Leung --- drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 3 +-- 1 file changed, 1 insertion(+), 2 de

[PATCH 13/16] drm/amd/display: Fix ODM combine issue with fast boot

2021-11-19 Thread Qingqing Zhuo
. Reviewed-by: Dmytro Laktyushkin Acked-by: Qingqing Zhuo Signed-off-by: Danny Wang --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core

[PATCH 12/16] drm/amd/display: Fixed DSC would not PG after removing DSC stream

2021-11-19 Thread Qingqing Zhuo
From: Yi-Ling Chen [WHY] Due to pass the wrong parameter down to the enable_stream_gating(), it would cause the DSC of the removing stream would not be PG. [HOW] To pass the correct parameter down th the enable_stream_gating(). Reviewed-by: Anthony Koo Acked-by: Qingqing Zhuo Signed-off

[PATCH 11/16] drm/amd/display: Display object info table changes

2021-11-19 Thread Qingqing Zhuo
: ATOM_CONNECTOR_CAP_RECORD_TYPE, ATOM_CONNECTOR_SPEED_UPTO and ATOM_BRACKET_LAYOUT_V2_RECORD_TYPE. Reviewed-by: Jun Lei Acked-by: Qingqing Zhuo Signed-off-by: Nevenko Stupar --- drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 10/16] drm/amd/display: fix accidental casting enum to bool

2021-11-19 Thread Qingqing Zhuo
From: Mikita Lipski [why/how] Fixing -Wint-in-bool-context Clang Build Failure Reviewed-by: Nicholas Choi Acked-by: Qingqing Zhuo Signed-off-by: Mikita Lipski --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 09/16] drm/amd/display: retain/release at proper places in link_enc assignment

2021-11-19 Thread Qingqing Zhuo
From: Sung Joon Kim [why] Need to keep track of number of references to stream pointer. [how] Call stream retain/release whenever necessary in link_enc table assignment sequence. Reviewed-by: Aric Cyr Acked-by: Qingqing Zhuo Signed-off-by: Sung Joon Kim --- drivers/gpu/drm/amd/display/dc

[PATCH 08/16] drm/amd/display: Rename dcn_validate_bandwidth to dcn10_validate_bandwidth

2021-11-19 Thread Qingqing Zhuo
From: Zhan Liu [Why] Rename function name so it aligns with other resource function names being used by dcn10. [How] Rename function name for consistency. Reviewed-by: Ahmad Othman Acked-by: Qingqing Zhuo Signed-off-by: Zhan Liu --- drivers/gpu/drm/amd/display/dc/calcs/dcn_calcs.c

[PATCH 07/16] drm/amd/display: Reset link encoder assignments for GPU reset

2021-11-19 Thread Qingqing Zhuo
signments are *not* valid when committing a state, so as a workaround it needs to be cleared before passing it back into DC. Fixes: 1a80a0d88ac5 ("drm/amd/display: Fix dynamic encoder reassignment") Reviewed-by: Harry Wentland Acked-by: Qingqing Zhuo Signed-off-by: Nicholas Kazlauskas ---

[PATCH 06/16] drm/amd/display: fixed an error related to 4:2:0/4:2:2 DSC

2021-11-19 Thread Qingqing Zhuo
From: "Guo, Bing" [Why] OPTC_BYTES_PER_PIXEL calculation for 4:2:2 and 4:2:0 could have error. [How] Change to use following formula: OPTC_DSC_BYTES_PER_PIXEL = ceiling((chunk size * 2^28) / slice width) Reviewed-by: Wenjing Liu Acked-by: Qingqing Zhuo Signed-off-by: Bing Guo --

[PATCH 05/16] drm/amd/display: Set plane update flags for all planes in reset

2021-11-19 Thread Qingqing Zhuo
- it's a 1:1 mapping. Fixes: cdaae8371aa9 ("drm/amd/display: Handle GPU reset for DC block") Reviewed-by: Harry Wentland Acked-by: Qingqing Zhuo Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 04/16] drm/amd/display: enable seamless boot for DCN301

2021-11-19 Thread Qingqing Zhuo
From: Zhan Liu [Why] DCN301 is capable of running seamless boot if keep_stolen_vga_memory is not set. [How] Add a helper to check whether an ASIC can support seamless boot and set it based on base driver flags. Reviewed-by: Charlene Liu Acked-by: Qingqing Zhuo Signed-off-by: Zhan Liu

[PATCH 01/16] drm/amd/display: Fix DPIA outbox timeout after GPU reset

2021-11-19 Thread Qingqing Zhuo
interrupts. Fixes: 81927e2808be ("drm/amd/display: Support for DMUB AUX") Reviewed-by: Jude Shih Acked-by: Qingqing Zhuo Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/a

[PATCH 03/16] drm/amd/display: Run full global validation in dc_commit_state

2021-11-19 Thread Qingqing Zhuo
and Acked-by: Qingqing Zhuo Signed-off-by: Nicholas Kazlauskas --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 19 +-- drivers/gpu/drm/amd/display/dc/core/dc.c | 13 + 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/display

[PATCH 02/16] drm/amd/display: based on flag reset z10 function pointer

2021-11-19 Thread Qingqing Zhuo
From: Charlene Liu [Why & How] Per hardware requirements, add a flag to control z10 enable/disable. Reviewed-by: Sung joon Kim Acked-by: Qingqing Zhuo Signed-off-by: Charlene Liu --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 5 + 1 file changed, 5 insertions(+) diff -

[PATCH 00/16] DC Patches November 22nd, 2021

2021-11-19 Thread Qingqing Zhuo
This DC patchset brings improvements in multiple areas. In summary, we highlight: - DC 3.2.163 - FW promotion to 0.0.94 - Enable seamless boot for DCN301 - Improvements in bandwidth validation - Fixes in flags update, link encoder assignments, DSC, ODM combine and more Thank you, Lillian ---

<    1   2   3   4   5   6   >