RE: [PATCH] drm/amdkfd: On GFX11 check PCIe atomics support and set CP_HQD_HQ_STATUS0[29]

2023-04-10 Thread Sider, Graham
[Public] A minor nitpick/suggestions below to make the comments a bit more concise. With that change the patch is Reviewed-by: Graham Sider Best, Graham > -Original Message- > From: amd-gfx On Behalf Of > Sreekant Somasekharan > Sent: Monday, April 3, 2023 3:59 PM > To:

RE: [PATCH v2] drm/amdgpu: add print for iommu translation mode

2023-04-04 Thread Sider, Graham
[AMD Official Use Only - General] Ping :) Best, Graham > -Original Message- > From: Kuehling, Felix > Sent: Monday, March 20, 2023 12:16 PM > To: Sider, Graham ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH v2] drm/amdgpu: add print for iommu translation mo

RE: [PATCH] drm/amdkfd: On GFX11 check PCIe atomics support and set CP_HQD_HQ_STATUS0[29]

2023-04-04 Thread Sider, Graham
[Public] > -Original Message- > From: amd-gfx On Behalf Of > Russell, Kent > Sent: Tuesday, April 4, 2023 9:43 AM > To: Somasekharan, Sreekant ; amd- > g...@lists.freedesktop.org > Cc: Somasekharan, Sreekant > Subject: RE: [PATCH] drm/amdkfd: On GFX11 check PCIe atomics support and >

RE: [PATCH] drm/amdgpu: add print for iommu translation mode

2023-03-21 Thread Sider, Graham
[Public] > -Original Message- > From: Christian König > Sent: Tuesday, March 21, 2023 2:53 PM > To: Sider, Graham ; Russell, Kent > ; Mahfooz, Hamza ; > amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix > Subject: Re: [PATCH] drm/amdgpu: add print fo

RE: [PATCH] drm/amdgpu: add print for iommu translation mode

2023-03-20 Thread Sider, Graham
[Public] > -Original Message- > From: Kuehling, Felix > Sent: Friday, March 17, 2023 5:16 PM > To: Sider, Graham ; Russell, Kent > ; Mahfooz, Hamza ; > amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: add print for iommu translation mode > >

RE: [PATCH] drm/amdgpu: add print for iommu translation mode

2023-03-17 Thread Sider, Graham
[AMD Official Use Only - General] > -Original Message- > From: Russell, Kent > Sent: Friday, March 17, 2023 3:58 PM > To: Mahfooz, Hamza ; Sider, Graham > ; amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix > Subject: RE: [PATCH] drm/amdgpu: add print for i

RE: [PATCH] drm/amdgpu: remove unconditional trap enable on add gfx11 queues

2023-01-19 Thread Sider, Graham
[AMD Official Use Only - General] Reviewed-by: Graham Sider -Original Message- From: Kim, Jonathan Sent: Thursday, January 19, 2023 7:44 PM To: amd-gfx@lists.freedesktop.org Cc: Sider, Graham ; Kuehling, Felix ; Kim, Jonathan ; Sider, Graham Subject: [PATCH] drm/amdgpu: remove

RE: [PATCH] drm/amdkfd: update GFX11 CWSR trap handler

2022-11-01 Thread Sider, Graham
[AMD Official Use Only - General] > -Original Message- > From: Sider, Graham > Sent: Wednesday, October 26, 2022 5:05 PM > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix ; Kasiviswanathan, Harish > ; Cornwall, Jay > ; Sider, Graham > Subject: [PATCH]

RE: [PATCH v2] drm/amdkfd: Fix UBSAN shift-out-of-bounds warning

2022-09-28 Thread Sider, Graham
[Public] Reviewed-by: Graham Sider > -Original Message- > From: Kuehling, Felix > Sent: Monday, September 26, 2022 6:36 PM > To: amd-gfx@lists.freedesktop.org > Cc: Sider, Graham ; Ellis Michael > > Subject: [PATCH v2] drm/amdkfd: Fix UBSAN shift-

RE: [PATCH] drm/amdkfd: Fix UBSAN shift-out-of-bounds warning

2022-09-26 Thread Sider, Graham
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Felix > Kuehling > Sent: Wednesday, September 21, 2022 6:30 PM > To: amd-gfx@lists.freedesktop.org > Cc: Ellis Michael > Subject: [PATCH] drm/amdkfd: Fix UBSAN shift-out-of-bounds warning > > Caution:

RE: [PATCH] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread Sider, Graham
[Public] > -Original Message- > From: Belanger, David > Sent: Thursday, September 22, 2022 2:49 PM > To: Sider, Graham ; amd- > g...@lists.freedesktop.org > Cc: Cornwall, Jay ; Kuehling, Felix > > Subject: RE: [PATCH] drm/amdgpu: Enable SA sof

RE: [PATCH] drm/amdgpu: Enable SA software trap.

2022-09-22 Thread Sider, Graham
[Public] > -Original Message- > From: amd-gfx On Behalf Of > David Belanger > Sent: Thursday, September 22, 2022 12:17 PM > To: amd-gfx@lists.freedesktop.org > Cc: Cornwall, Jay ; Kuehling, Felix > ; Belanger, David > Subject: [PATCH] drm/amdgpu: Enable SA software trap. > > Caution:

RE: [PATCH v4 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-22 Thread Sider, Graham
[AMD Official Use Only - General] >> On 2022-06-22 11:36, Graham Sider wrote: >> Starting with GFX11, MES requires wptr BOs to be GTT allocated/mapped to >> GART for usermode queues in order to support oversubscription. In the >> case that work is submitted to an unmapped queue, MES must have a

RE: [PATCH v2 2/2] drm/amdkfd: Free queue after unmap queue success

2022-06-20 Thread Sider, Graham
[Public] Reviewed-by: Graham Sider -Original Message- From: Yang, Philip Sent: Friday, June 17, 2022 3:55 PM To: amd-gfx@lists.freedesktop.org Cc: Sider, Graham ; Yang, Philip Subject: [PATCH v2 2/2] drm/amdkfd: Free queue after unmap queue success After queue unmap or remove from

RE: [PATCH v2 1/2] drm/amdkfd: Add queue to MES if it becomes active

2022-06-20 Thread Sider, Graham
[Public] Reviewed-by: Graham Sider -Original Message- From: Yang, Philip Sent: Friday, June 17, 2022 3:55 PM To: amd-gfx@lists.freedesktop.org Cc: Sider, Graham ; Yang, Philip Subject: [PATCH v2 1/2] drm/amdkfd: Add queue to MES if it becomes active We remove the user queue from MES

RE: [PATCH 1/2] drm/amdkfd: Add queue to MES if it becomes active

2022-06-15 Thread Sider, Graham
[Public] Reviewed-by: Graham Sider > -Original Message- > From: Yang, Philip > Sent: Wednesday, June 15, 2022 5:57 PM > To: amd-gfx@lists.freedesktop.org > Cc: Sider, Graham ; Yang, Philip > > Subject: [PATCH 1/2] drm/amdkfd: Add queue to MES if it becomes

RE: [PATCH v3 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-15 Thread Sider, Graham
[AMD Official Use Only - General] > -Original Message- > From: Koenig, Christian > Sent: Wednesday, June 15, 2022 3:29 AM > To: Sider, Graham ; amd- > g...@lists.freedesktop.org > Cc: Joshi, Mukul ; Kuehling, Felix > ; Yang, Philip > Subject: Re: [PATCH v3 2/3]

RE: [PATCH v3 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-14 Thread Sider, Graham
[AMD Official Use Only - General] >> From: Yang, Philip >> Sent: Tuesday, June 14, 2022 2:22 PM >> To: Sider, Graham ; amd-gfx@lists.freedesktop.org >> Cc: Kuehling, Felix ; Joshi, Mukul >> ; Yang, Philip >> Subject: Re: [PATCH v3 2/3] drm

RE: [PATCH v2 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-13 Thread Sider, Graham
[Public] > -Original Message- > From: Yu, Lang > Sent: Friday, June 10, 2022 10:38 PM > To: Sider, Graham > Cc: amd-gfx@lists.freedesktop.org; Joshi, Mukul ; > Kuehling, Felix ; Yang, Philip > > Subject: Re: [PATCH v2 2/3] drm/amdkfd: Enable GFX11 usermode

RE: [PATCH v2 2/3] drm/amdkfd: Enable GFX11 usermode queue oversubscription

2022-06-13 Thread Sider, Graham
[AMD Official Use Only - General] Thanks for the great comments Felix--will apply these. Best, Graham -Original Message- From: Kuehling, Felix Sent: Friday, June 10, 2022 7:06 PM To: Sider, Graham ; amd-gfx@lists.freedesktop.org Cc: Joshi, Mukul ; Yang, Philip Subject: Re: [PATCH v2

RE: [PATCH 2/4] drm/amdkfd: Pass MES/RS64 information to sysfs

2022-06-08 Thread Sider, Graham
adding this to debugfs, I agree. Thanks, Graham -Original Message- From: Kuehling, Felix Sent: Wednesday, June 8, 2022 3:31 PM To: Sider, Graham ; amd-gfx@lists.freedesktop.org Cc: Yang, Philip ; Joshi, Mukul Subject: Re: [PATCH 2/4] drm/amdkfd: Pass MES/RS64 information to sysfs

RE: [PATCH] drm/amdkfd: Fix static checker warning on MES queue type

2022-05-12 Thread Sider, Graham
[AMD Official Use Only - General] Thanks for mentioning, yes I'll add a reported-by for Dan on the commit. Best, Graham > -Original Message- > From: Alex Deucher > Sent: Thursday, May 12, 2022 5:33 PM > To: Sider, Graham > Cc: amd-gfx list ; Joshi, Mukul > ; Kue

RE: [PATCH] drm/amdkfd: correct sdma queue number in kfd device init (v2)

2021-12-19 Thread Sider, Graham
[Public] > -Original Message- > From: Kim, Jonathan > Sent: Monday, December 20, 2021 12:44 AM > To: Chen, Guchun ; amd- > g...@lists.freedesktop.org; Deucher, Alexander > ; Sider, Graham > ; Kuehling, Felix > Subject: RE: [PATCH] drm/amdkfd: correct sdma qu

RE: [PATCH] drm/amdkfd: correct sdma queue number in kfd device init

2021-12-17 Thread Sider, Graham
[Public] > -Original Message- > From: Chen, Guchun > Sent: Friday, December 17, 2021 9:31 AM > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Sider, Graham > ; Kuehling, Felix ; > Kim, Jonathan > Cc: Chen, Guchun > Subject: [PATCH] drm/amdkfd

RE: [PATCH] drm/amdkfd: Correct the value of the no_atomic_fw_version variable

2021-12-02 Thread Sider, Graham
[AMD Official Use Only] > From: chen gong > Sent: Thursday, December 2, 2021 3:56 AM > To: amd-gfx@lists.freedesktop.org > Cc: Sider, Graham ; Gong, Curry > > Subject: [PATCH] drm/amdkfd: Correct the value of the > no_atomic_fw_version variable > > 145: > navi10

RE: [PATCH v2 3/4] drm/amdkfd: move to dynamic device_info creation

2021-11-22 Thread Sider, Graham
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Friday, November 19, 2021 4:30 PM > To: Sider, Graham ; amd- > g...@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH v2 3/4] drm/amdkfd: move to dynamic device_info &g

RE: [PATCH v2 2/4] drm/amdkfd: add kfd_device_info_init function

2021-11-22 Thread Sider, Graham
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Friday, November 19, 2021 4:20 PM > To: Sider, Graham ; amd- > g...@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH v2 2/4] drm/amdkfd: add kfd_device_info_init functi

RE: [PATCH 2/4] drm/amdkfd: add kfd_device_info_init function

2021-11-19 Thread Sider, Graham
[AMD Official Use Only] > -Original Message- > From: Alex Deucher > Sent: Friday, November 19, 2021 1:55 PM > To: Sider, Graham > Cc: amd-gfx list ; Kuehling, Felix > > Subject: Re: [PATCH 2/4] drm/amdkfd: add kfd_device_info_init function > > On Fri, Nov

RE: [PATCH] drm/amdkfd: Remove unused entries in table

2021-11-18 Thread Sider, Graham
[AMD Official Use Only] Reviewed-by: Graham Sider > Remove unused entries in kfd_device_info table: num_xgmi_sdma_engines > and num_sdma_queues_per_engine. They are calculated in > kfd_get_num_sdma_engines and kfd_get_num_xgmi_sdma_engines > instead. > > Signed-off-by: Amber Lin > --- >

RE: [PATCH v2 3/3] drm/amdkfd: convert misc checks to IP version checking

2021-11-10 Thread Sider, Graham
[AMD Official Use Only] > Am 2021-11-09 um 5:42 p.m. schrieb Graham Sider: > > Switch to IP version checking instead of asic_type on various KFD > > version checks. > > > > Signed-off-by: Graham Sider > > --- > > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- > >

RE: [PATCH 10/13] drm/amdkfd: replace kgd_dev in get amdgpu_amdkfd funcs

2021-10-26 Thread Sider, Graham
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Tuesday, October 26, 2021 5:24 PM > To: Sider, Graham ; amd- > g...@lists.freedesktop.org > Cc: Joshi, Mukul > Subject: Re: [PATCH 10/13] drm/amdkfd: replace kgd_dev in get > amdgpu_amdk

RE: [PATCH 02/13] drm/amdkfd: replace kgd_dev in static gfx v7 funcs

2021-10-26 Thread Sider, Graham
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Tuesday, October 26, 2021 4:07 PM > To: Sider, Graham ; amd- > g...@lists.freedesktop.org > Cc: Joshi, Mukul > Subject: Re: [PATCH 02/13] drm/amdkfd: replace kgd_dev in static gfx v7 >

RE: [PATCH v5 7/9] drm/amd/pm: Add vangogh throttler translation

2021-06-07 Thread Sider, Graham
room in the temperature field to add two new definitions. Best, Graham -Original Message- From: Lazar, Lijo Sent: Monday, June 7, 2021 10:35 AM To: Sider, Graham ; amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Sakhnovitch, Elena (Elen) Subject: Re: [PATCH v5 7/9] drm/amd/pm

RE: [PATCH v3 4/8] drm/amd/pm: Add navi1x throttler translation

2021-06-04 Thread Sider, Graham
. If you have a problem with this approach let me know. Best, Graham -Original Message- From: Lazar, Lijo Sent: Friday, June 4, 2021 12:52 AM To: Quan, Evan ; Sider, Graham ; amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Sakhnovitch, Elena (Elen) Subject: RE: [PATCH v3 4

RE: [PATCH v3 4/8] drm/amd/pm: Add navi1x throttler translation

2021-06-03 Thread Sider, Graham
, 2021 12:37 AM To: Sider, Graham ; amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Kasiviswanathan, Harish ; Sider, Graham ; Sakhnovitch, Elena (Elen) Subject: RE: [PATCH v3 4/8] drm/amd/pm: Add navi1x throttler translation [AMD Official Use Only] > -Original Message- > From: a

RE: [PATCH v2 4/8] drm/amd/pm: Add navi1x throttler translation

2021-05-31 Thread Sider, Graham
. Thanks for the feedback. Graham -Original Message- From: Lazar, Lijo Sent: Monday, May 31, 2021 1:13 AM To: Sider, Graham ; amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Sider, Graham ; Sakhnovitch, Elena (Elen) Subject: RE: [PATCH v2 4/8] drm/amd/pm: Add navi1x

RE: [PATCH 1/6] drm/amd/pm: Add ASIC independent throttle bits

2021-05-25 Thread Sider, Graham
SMU_THROTTLER_TDC_GFX_BIT THROTTLER_STATUS_BIT_TDC_CVIP -> SMU_THROTTLER_TDC_CVIP_BIT Graham -Original Message- From: Lazar, Lijo Sent: Monday, May 24, 2021 2:58 AM To: Sider, Graham ; amd-gfx@lists.freedesktop.org Cc: Kasiviswanathan, Harish ; Sakhnovitch, Elena (Elen) Subject

RE: [PATCH 2/6] drm/amd/pm: Add arcturus throttler translation

2021-05-21 Thread Sider, Graham
Right, that all makes sense. I'm fine with either of these options. Thanks for the insights -- I'll give this a bit more thought and get back to you. Best, Graham -Original Message- From: Alex Deucher Sent: Friday, May 21, 2021 5:50 PM To: Sider, Graham Cc: amd-gfx list

RE: [PATCH 2/6] drm/amd/pm: Add arcturus throttler translation

2021-05-21 Thread Sider, Graham
, Graham Cc: amd-gfx list ; Kasiviswanathan, Harish ; Sakhnovitch, Elena (Elen) Subject: Re: [PATCH 2/6] drm/amd/pm: Add arcturus throttler translation [CAUTION: External Email] On Fri, May 21, 2021 at 1:39 PM Sider, Graham wrote: > > Hi Alex, > > Are you referrin

RE: [PATCH 2/6] drm/amd/pm: Add arcturus throttler translation

2021-05-21 Thread Sider, Graham
). Technically speaking no new fields have been added to any of the gpu_metrics versions, just a change in representation in the throttle_status field. Let me know your thoughts on this. Best, Graham -Original Message- From: Alex Deucher Sent: Friday, May 21, 2021 10:27 AM To: Sider, Graham Cc