Re: [PATCH v2 1/4] drm/amdgpu: add pmlog structure definition

, October 6, 2023 08:36 To: Wang, Yang(Kevin); amd-gfx@lists.freedesktop.org; Deucher, Alexander; StDenis, Tom Cc: Zhang, Hawking Subject: RE: [PATCH v2 1/4] drm/amdgpu: add pmlog structure definition [AMD Official Use Only - General] Presently only a byte stream is intended. If version is needed

Re: [PATCH umr 02/17] Use the correct prefix for Navi3 in halt_waves

[Public] This shouldn't be necessary as it tries both mm and then reg... From: Haehnle, Nicolai Sent: Tuesday, June 6, 2023 05:17 To: amd-gfx@lists.freedesktop.org; StDenis, Tom Cc: Haehnle, Nicolai Subject: [PATCH umr 02/17] Use the correct prefix

Re: Fix for UMR on newer C++

Thanks I'll apply it upon the morrow From: Newton, Jeremy Sent: Monday, January 23, 2023 18:04 To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: Fix for UMR on newer C++ [AMD Official Use Only - General] I noticed this today; it's required

Re: [PATCH] drm/amdgpu: expand cg_flags from u32 to u64

[AMD Official Use Only] I'll update umr once this goes live. Unless you have a umr patch handy :-) Tom From: Zhang, Hawking Sent: Thursday, March 31, 2022 00:12 To: Quan, Evan; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; StDenis, Tom; Quan

Re: [PATCH 5/5] umr: Completion: update new format options

[AMD Official Use Only] Thanks Luben, I've committed and pushed out these patches. Cheers, Tom From: Tuikov, Luben Sent: Sunday, March 27, 2022 06:42 To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben; StDenis, Tom; Su, Jinzhou (Joe) Subject: [PATCH 5

Re: [PATCH 0/6] Complete and add dynamic completion to umr

, Pierre-Eric; StDenis, Tom; Koenig, Christian Subject: [PATCH 0/6] Complete and add dynamic completion to umr Complete and add dynamic completion to umr. Some of the difficulties seen in this work were, *) slightly different output of sysfs files depending on the system configuration

Re: [PATCH 4/4] umr: Fix unhandled enumeration value in switch

der; StDenis, Tom Subject: [PATCH 4/4] umr: Fix unhandled enumeration value in switch Add a default case in the switch, instead of the last unhandled value, FAMILY_CONFIGURE. This solves the case when in the future other families are not handled--they'll all fall into the default case. A

Re: [PATCH 1/4] umr: Print errors to stderr

[AMD Official Use Only] The asic structure has a function callback "errmsg" which should be used for this. Tom From: Tuikov, Luben Sent: Wednesday, March 9, 2022 19:42 To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben; Deucher, Alexande

Re: [PATCH] drm/amdgpu: Dynamically initialize IP instance attributes

but I imagine it'll cause some confusion later on. Tom From: Alex Deucher Sent: Thursday, February 17, 2022 13:32 To: StDenis, Tom Cc: Tuikov, Luben; amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: Dynamically initialize IP

Re: [PATCH] drm/amdgpu: Dynamically initialize IP instance attributes

mr to know if a newer or older header is better. Tom From: Tuikov, Luben Sent: Thursday, February 17, 2022 11:35 To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben; Deucher, Alexander; StDenis, Tom Subject: [PATCH] drm/amdgpu: Dynamically initialize I

Re: [PATCH] drm/amd/amdgpu: Add APU flag to gca_config debugfs data (v2)

[AMD Official Use Only] umr uses the config debugfs during init anyways so adding apu status here instead of fetching it out of DRM makes sense (for umr). I'll send a v3. Tom From: Alex Deucher Sent: Wednesday, February 16, 2022 09:36 To: StDenis, Tom

Re: FIx for UMR arm build

[AMD Official Use Only] Pushed out, with your Rb. From: Alex Deucher Sent: Thursday, January 27, 2022 09:11 To: Newton, Jeremy Cc: amd-gfx@lists.freedesktop.org; StDenis, Tom Subject: Re: FIx for UMR arm build Reviewed-by: Alex Deucher On Thu, Jan

Re: [PATCH 2/2] drm/amdgpu: add sysfs files for XGMI segment size and physical node id

[AMD Official Use Only] Sadly I don't control any XGMI hosts to try it out. So if they pick it up in their builds I can but otherwise we'll have to wait. Tom From: Tuikov, Luben Sent: Wednesday, January 26, 2022 07:55 To: Christian König; StDenis, Tom

Re: [PATCH] drm/amd/amdgpu: Add ip_discovery_text sysfs entry

I literally brought this up in our initial discussion Frankly from umrs point of view a single file is easier. But I can't code anything until it's in the tree... Tom From: Alex Deucher Sent: Tuesday, January 25, 2022 11:39 To: StDenis, Tom Cc: amd

Re: [PATCH] drm/amd/display: Fix surface optimization regression on Carrizo

[AMD Official Use Only] Tested-by: Tom St Denis Thanks. From: Alex Deucher Sent: Tuesday, October 12, 2021 10:15 To: Kazlauskas, Nicholas Cc: amd-gfx list; Lakha, Bhawanpreet; Lipski, Mikita; StDenis, Tom Subject: Re: [PATCH] drm/amd/display: Fix

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

To: StDenis, Tom; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5) Does that really need a lock? Can't local variables solve it? Thanks, Lijo On 8/26/2021 5:52 PM, StDenis, Tom wrote: > [AMD Official Use Only] > > The issue i

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

is fine. Tom From: Lazar, Lijo Sent: Thursday, August 26, 2021 08:19 To: StDenis, Tom; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5) If there are two threads using the same fd, I don't

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v5)

is the only likely user of this it's still ideal to avoid potential race conditions as a matter of correctness. Tom From: Lazar, Lijo Sent: Thursday, August 26, 2021 08:12 To: StDenis, Tom; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: New

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers

esn't have to be this way though but I figured the fewer LOC the better. Tom From: Christian König Sent: Tuesday, August 24, 2021 08:20 To: StDenis, Tom; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers Am 2

Re: [PATCH v2 umr 3/3] Enhance printing of page tables in AI+

[AMD Official Use Only] Tested and pushed out to main. Thanks, Tom From: Greathouse, Joseph Sent: Monday, June 21, 2021 12:37 To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom; Greathouse, Joseph Subject: [PATCH v2 umr 3/3] Enhance printing of page

Re: [PATCH v2 umr 3/3] Enhance printing of page tables in AI+

@lists.freedesktop.org Cc: StDenis, Tom; Greathouse, Joseph Subject: [PATCH v2 umr 3/3] Enhance printing of page tables in AI+ Pulls print functions for GPUVM page tables on AI+ chips into their own set of generalized functions, so that we don't have subtly different printouts for different layers

Re: display regression on Carrizo

ne_res.xfm != NULL) Tom From: Mario Kleiner Sent: Tuesday, June 1, 2021 09:17 To: StDenis, Tom Cc: amd-gfx list; Deucher, Alexander Subject: Re: display regression on Carrizo On Mon, May 31, 2021 at 4:14 PM StDenis, Tom wrote: > > [AMD Official Use O

display regression on Carrizo

[AMD Official Use Only] Hi Mario, The following commit causes a display regression on my Carrizo when booting linux into a console (e.g. no WM). When the driver inits the display goes green and is unusable. The commit prior to this one on amd-staging-drm-next results in a clean init.

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

[AMD Official Use Only - Internal Distribution Only] If changing the ioctl is an issue why not just use sysfs? umr already makes uses of all three for it's purposes so it's fine by me for either. Tom From: amd-gfx on behalf of Christian König Sent:

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

[AMD Official Use Only - Internal Distribution Only] Done. From: Alex Deucher Sent: Wednesday, April 28, 2021 16:53 To: StDenis, Tom Cc: Gu, JiaWei (Will); Christian König; Nieto, David M; amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: Re

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

, David M; amd-gfx@lists.freedesktop.org; StDenis, Tom Cc: Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface [AMD Official Use Only - Internal Distribution Only] Hi @StDenis, Tom<mailto:tom.stde...@amd.com>, We have merged vbios info ioctl patch. Could you h

Re: [PATCH 1/1] drm/amdgpu: make BO type check less restrictive

[AMD Official Use Only - Internal Distribution Only] FWIW the patch seems to fix the issue I was seeing :-) Tom From: Koenig, Christian Sent: Monday, March 15, 2021 11:22 To: Das, Nirmoy Cc: amd-gfx@lists.freedesktop.org; StDenis, Tom Subject: Re

Re: [PATCH umr] Fix register name lookup for sdma POLL_REGMEM packet

Sent: Monday, September 21, 2020 23:02 To: amd-gfx@lists.freedesktop.org; StDenis, Tom Cc: Yuan, Xiaojie Subject: [PATCH umr] Fix register name lookup for sdma POLL_REGMEM packet POLL_REGMEM_ADDR_LO/HI are in byte but umr_reg_name() expects register address in dword Signed-off-by: Xiaojie Yuan

Re: [PATCH] drm/amd/powerplay: Fix uninitialized warning in arcturus ppt driver

[AMD Official Use Only - Internal Distribution Only] Hi Kevin, Ah ok disregard the (v2) I just sent then :-) Thanks, Tom From: Wang, Kevin(Yang) Sent: Wednesday, August 12, 2020 22:47 To: Quan, Evan; StDenis, Tom; amd-gfx@lists.freedesktop.org Subject

Re: [PATCH] drm/amd/powerplay: Fix uninitialized warning in arcturus ppt driver

: Wednesday, August 12, 2020 08:40 To: StDenis, Tom; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/powerplay: Fix uninitialized warning in arcturus ppt driver On 8/12/20 2:20 PM, Tom St Denis wrote: > Fixes: > >CC [M] > drivers/gpu/drm/amd/amdgpu/../displ

Re: [PATCH UMR] Fix off-by-one error for decoding sdma linear write packet

[AMD Official Use Only - Internal Distribution Only] Applied and pushed out to master. Thanks! Tom From: Yuan, Xiaojie Sent: Tuesday, July 14, 2020 11:35 To: StDenis, Tom; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH UMR] Fix off-by-one error

Re: [PATCH UMR] Fix off-by-one error for decoding sdma linear write packet

[AMD Official Use Only - Internal Distribution Only] Thanks, can you attach the patch to your email instead though so it applies cleanly? Cheers, Tom From: Yuan, Xiaojie Sent: Tuesday, July 14, 2020 00:18 To: amd-gfx@lists.freedesktop.org; StDenis, Tom

Re: [PATCH] drm/amdgpu: remove PT BOs when unmapping

I could try it on my carrizo/polaris setup.  Is there a test procedure I could folllow to trigger the changed code paths? Tom On 2019-10-31 6:41 a.m., Koenig, Christian wrote: > Just tested this and amdgpu_vm_update_ptes() indeed works as expected. > > When you free at least a 2MB the lowest

Re: [PATCH 1/1] drm/amdgpu: add missing amdgpu_ras.h header include

> *To:* amd-gfx@lists.freedesktop.org > *Cc:* StDenis, Tom ; Ma, Le > *Subject:* [PATCH 1/1] drm/amdgpu: add missing amdgpu_ras.h header > include > Fix compilation error. > > Change-Id: I461c558778f9a52378269324dc41b8d639f3ccbe > Signed-off-by: Le Ma > --- >  driver

Re: [PATCH] Ring range argument improvements (v3)

Thanks, pushed out. Cheers, Tom On 2019-10-24 2:27 p.m., Tuikov, Luben wrote: > The valid contents of rings is invariably the > range [rptr, wptr). Augment the ring range to > interpret the '.' ("here") notation to mean rptr > or wptr when given on the left or right of the > range limits. This

Re: [PATCH] Ring range argument improvements (v2)

This diff fixes your patch, can you resend please? diff --git a/src/app/ring_read.c b/src/app/ring_read.c index 9cbecb0..c1c9187 100644 --- a/src/app/ring_read.c +++ b/src/app/ring_read.c @@ -120,16 +120,16 @@ void umr_read_ring(struct umr_asic *asic, char *ringpath)    

Re: [PATCH] Ring range argument improvements (v2)

NAK, this patch breaks something in decoding the words of the packets.  Instead of decoding I get a lot of PKT0 lines.  I'll see if I can debug this. Tom On 2019-10-23 5:11 p.m., Tuikov, Luben wrote: > The valid contents of rings is invariably the > range [rptr, wptr). Augment the ring range

[PATCH] drm/amd/amdgpu: Disable GFX_PG on laptop raven part

GFX_PG causes visual (and likely memory) corruption on laptop raven parts. Until it's fully diagnosed let's disable it to ensure stable operation. Tested on a Dell Latitude 5495. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/soc15.c | 5 + 1 file changed, 5 insertions(+)

Re: [PATCH 5/5] drm/amd/powerplay: implment sysfs feature status function in smu

No it doesn't.  We get clocks for --top from the sensors interface. On 2019-07-25 9:01 a.m., Deucher, Alexander wrote: > Tom, does umr use it? > > Alex > > *From:* Huang, Ray > *Sent:* Thursday, July 25, 2019 4:49 AM >

[PATCH] Collect all page_base_address bits for pte-further addresses (v2)

The specification says to treat a PTE with the F bit set "like a PDE" which means that all but the lower 6 bits are part of the page base address. Indeed, in the wild a comment came back indicating that we were stripping off bits needed to properly fetch the next PTE. (v2): Only capture excess

[PATCH] Collect all page_base_address bits for pte-further addresses

The specification says to treat a PTE with the F bit set "like a PDE" which means that all but the lower 6 bits are part of the page base address. Indeed, in the wild a comment came back indicating that we were stripping off bits needed to properly fetch the next PTE. Signed-off-by: Tom St Denis

Re: [PATCH] drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface

Thanks. Alex can I grab an R-b please? Cheers, Tom On 2019-07-16 7:30 a.m., Christian König wrote: > Am 16.07.19 um 13:24 schrieb StDenis, Tom: >> The register debugfs interface was using the wrong bitmask for vmid >> selection for GFX_CNTL. >> >> Signed-off-

[PATCH] drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface

The register debugfs interface was using the wrong bitmask for vmid selection for GFX_CNTL. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c

[PATCH 2/2] drm/amd/amdgpu: Add missing select_me_pipe_q() for gfx10

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c index 0d94c812df1b..7d5207bbe382 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c

[PATCH 1/2] drm/amd/amdgpu: Add VMID to SRBM debugfs bank selection

Add 5 bits to the offset for SRBM selection to handle VMIDs. Also update the select_me_pipe_q() callback to also select VMID. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 9 + drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 4 ++--

[PATCH] Fix VM handling for VMID 0 w.r.t. SYSTEM_APERTURE

Signed-off-by: Tom St Denis --- src/lib/read_vram.c | 47 + 1 file changed, 43 insertions(+), 4 deletions(-) diff --git a/src/lib/read_vram.c b/src/lib/read_vram.c index 131cec3..812de96 100644 --- a/src/lib/read_vram.c +++ b/src/lib/read_vram.c @@

[PATCH] drm/amd/amdgpu: Indentation and simplification fixes for DF driver

Minor indentation and simplifications for the DF 3.6 driver. No functional changes. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 50 ++-- 1 file changed, 18 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c

Re: [PATCH] drm/amd/amdgpu: cast mem->num_pages to 64-bits when shifting

Christian König wrote: Am 17.06.19 um 21:15 schrieb Kuehling, Felix: Looks good to me. One cosmetic comment inline. With that fixed this patch is Reviewed-by: Felix Kuehling On 2019-06-14 12:51 p.m., StDenis, Tom wrote: On 32-bit hosts mem->num_pages is 32-bits and can overflow when shifted

[PATCH] drm/amd/amdgpu: cast mem->num_pages to 64-bits when shifting

On 32-bit hosts mem->num_pages is 32-bits and can overflow when shifted. Add a cast to avoid this. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH] drm/amd/amdgpu: Bail out of BO node creation if not enough VRAM (v3)

(v2): Return 0 and set mem->mm_node to NULL. (v3): Use atomic64_add_return instead. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c

[PATCH] drm/amd/amdgpu: Bail out of BO node creation if not enough VRAM (v2)

(v2): Return 0 and set mem->mm_node to NULL. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c

Re: [PATCH] drm/amd/amdgpu: Bail out of BO node creation if not enough VRAM

On 2019-06-11 9:34 a.m., Christian König wrote: > Am 10.06.19 um 16:32 schrieb StDenis, Tom: >> Signed-off-by: Tom St Denis >> --- >>   drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 17 - >>   1 file changed, 12 insertions(+), 5 deletions(-) >> &g

[PATCH] drm/amd/amdgpu: Bail out of BO node creation if not enough VRAM

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c index 8aea2f21b202..70b4a5a97ed2 100644

Re: [PATCH] drm/amd/amdgpu: remove vram_page_split kernel option (v3)

On 2019-06-06 7:49 a.m., Christian König wrote: > Am 06.06.19 um 12:50 schrieb StDenis, Tom: >> This option is no longer needed.  The default code paths >> are now the only option. >> >> v2: Add HPAGE support and a default for non contiguous maps >> v3: Misread

Re: [PATCH] drm/amd/amdgpu: remove vram_page_split kernel option (v2)

Ah ya I misread the original default as MiB instead of pages. Tom On 2019-06-06 6:35 a.m., Christian König wrote: > Am 04.06.19 um 19:15 schrieb StDenis, Tom: >> This option is no longer needed.  The default code paths >> are now the only option. >> >> v2: Add

[PATCH] drm/amd/amdgpu: remove vram_page_split kernel option (v3)

This option is no longer needed. The default code paths are now the only option. v2: Add HPAGE support and a default for non contiguous maps v3: Misread 512 pages as MiB ... Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 -

[PATCH] drm/amd/amdgpu: remove vram_page_split kernel option (v2)

This option is no longer needed. The default code paths are now the only option. v2: Add HPAGE support and a default for non contiguous maps Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ---

[PATCH] drm/amd/amdgpu: remove vram_page_split kernel option

This option is no longer needed. The default code paths are now the only option. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8

[PATCH] drm/amd/doc: add rough outline of tracepoint documentation

Signed-off-by: Tom St Denis --- Documentation/gpu/amdgpu.rst | 10 + drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 221 ++ 2 files changed, 231 insertions(+) diff --git a/Documentation/gpu/amdgpu.rst b/Documentation/gpu/amdgpu.rst index 86138798128f..3564765110e5

[PATCH 2/2] drm/amd/doc: Add RAS documentation to guide

Signed-off-by: Tom St Denis --- Documentation/gpu/amdgpu.rst| 11 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/Documentation/gpu/amdgpu.rst b/Documentation/gpu/amdgpu.rst index

[PATCH 1/2] drm/amd/doc: Add XGMI sysfs documentation

Signed-off-by: Tom St Denis --- Documentation/gpu/amdgpu.rst | 9 drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 28 2 files changed, 37 insertions(+) diff --git a/Documentation/gpu/amdgpu.rst b/Documentation/gpu/amdgpu.rst index

[PATCH] drm/amd/amdgpu: Add MEM_LOAD to amdgpu_pm_info debugfs file

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c index 5e2d039e09ad..e0789f0f2670 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +++

Re: [PATCH] drm/amdgpu: add one rlc version into gfxoff blacklist

FWIW when I manually apply this to my drm-next kernel on my raven1 devel box it works fine. Tested-by: Tom St Denis Tom On 2019-03-19 9:31 a.m., Huang Rui wrote: > RLC #53815 ucode has the noise issue on 4k playback while gfxoff enabled. > > Signed-off-by: Huang Rui > --- >

Re: kernel errors with HMM enabled

On 2019-03-14 12:37 p.m., Alex Deucher wrote: > Make sure you have this patch: > https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-5.2-wip=e811b0a799981eaa6fef1809278367471f14ba13 Hi Alex, The tip of our amd-staging-drm-next includes this patch (about 126 down from the tip). Tom

kernel errors with HMM enabled

Hi Philip, With your HMM patches enabled I'm seeing (attached) kernel errors while running piglit. Are these known? I see it all along amd-staging-drm-next until I roll back before your very first HMM patches. Tom log.gz Description: log.gz ___

Re: [PATCH] drm/amdgpu: Add sysfs entries for xgmi hive.

On 2019-03-05 2:16 p.m., Grodzovsky, Andrey wrote: > In each /sys/class/drm/cardX/device/ device you will see the following > > xgmi_device_id /* contains the device id within the hive */ > xgmi_hive_info -> > ../../../../:00:01.1/:02:00.0/:03:00.0/:04:00.0/xgmi_hive_info/ > /*

Re: [PATCH] drm/amdgpu: Add sysfs entries for xgmi hive.

Couple of comments inline. Since I don't have any XGMI gear it would probably help to see what the final directory layout/contents look like so I can update umr to automagically scan all of this. Tom On 2019-03-05 12:47 p.m., Andrey Grodzovsky wrote: > For each device a file xgmi_device_id is

[PATCH] drm/amd/amdgpu: Add ENGINE_CNTL register to vcn10 headers

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h | 2 ++ drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h | 5 + 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h

Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

On 2019-01-31 4:23 a.m., Przemek Socha wrote: > Dnia środa, 30 stycznia 2019 13:42:33 CET piszesz: >> Does the attached patch fix the issue? >> >> Christian. > > I have tested this one also - "drm/amdgpu: partial revert cleanup setting > bulk_movable v2" > >> We still need to set bulk_movable to

Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

On 2019-01-30 7:42 a.m., Koenig, Christian wrote: > Does the attached patch fix the issue? No. Now I get a lockup when I start GNOME and try to bring up a terminal. The patch also didn't apply cleanly on top of drm-next but I was able to just manually add the line. [ 88.018735] general

regression in dcn linked to -msse2

Testing with the new 5.0.0-rc1 amd-staging-drm-next branch results in this commit causing the attached lockup on init with my Raven + Polaris system: 10117450735c7a7c0858095fb46a860e7037cb9a is the first bad commit commit 10117450735c7a7c0858095fb46a860e7037cb9a Author: ndesaulni...@google.com

Re: After Vega 56/64 GPU hang I unable reboot system

Hi Mike, This might be an issue better suited for our llvm team since umr just uses llvm-dev to access the diassembly code. I'll make sure the key folk are aware. Cheers, Tom On 2019-01-10 10:22 a.m., Mikhail Gavrilov wrote: > On Thu, 10 Jan 2019 at 00:36, Mikhail Gavrilov > wrote: >> >>

[PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v3)

v2: Move locks around in other functions so that this function can stand on its own. Also only hold the hive specific lock for add/remove device instead of the driver global lock so you can't add/remove devices in parallel from one hive. v3: add reset_lock Signed-off-by: Tom St Denis ---

Re: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v2)

On 2019-01-07 12:00 p.m., Grodzovsky, Andrey wrote: > > > On 01/07/2019 11:53 AM, StDenis, Tom wrote: >> On 2019-01-07 11:51 a.m., Grodzovsky, Andrey wrote: >>> >>> On 01/07/2019 11:36 AM, StDenis, Tom wrote: >>>> On 2019-01-07 11:33 a.m., Grodzovsk

Re: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v2)

On 2019-01-07 11:51 a.m., Grodzovsky, Andrey wrote: > > > On 01/07/2019 11:36 AM, StDenis, Tom wrote: >> On 2019-01-07 11:33 a.m., Grodzovsky, Andrey wrote: >>> >>> On 01/07/2019 11:16 AM, Liu, Shaoyun wrote: >>>> I think it's reasonable to u

Re: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v2)

m> >> >> -Original Message- >> From: amd-gfx On Behalf Of StDenis, >> Tom >> Sent: Monday, January 7, 2019 10:16 AM >> To: amd-gfx@lists.freedesktop.org >> Cc: StDenis, Tom >> Subject: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v

[PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v2)

v2: Move locks around in other functions so that this function can stand on its own. Also only hold the hive specific lock for add/remove device instead of the driver global lock so you can't add/remove devices in parallel from one hive. Signed-off-by: Tom St Denis ---

Re: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive()

Self NAK this ... calling functions take the same lock We should remove the locks from the callers so this function is thread safe on its own... Tom On 2019-01-07 10:00 a.m., StDenis, Tom wrote: > Signed-off-by: Tom St Denis > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_xg

[PATCH] add missing mutex lock to amdgpu_get_xgmi_hive()

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c index 8a8bc60cb6b4..587a5f73ae8c 100644 ---

Re: After Vega 56/64 GPU hang I unable reboot system

On 2018-12-20 11:07 a.m., Mikhail Gavrilov wrote: > On Thu, 20 Dec 2018 at 19:19, StDenis, Tom wrote: >> >> Ya I was right. With a plain build I can access the files just fine. >> >> >> >> I did manage to get into a weird shell where I couldn't cat >

Re: After Vega 56/64 GPU hang I unable reboot system

On 2018-12-20 9:08 a.m., Tom St Denis wrote: > On 2018-12-20 9:06 a.m., Tom St Denis wrote: >> On 2018-12-20 6:45 a.m., Mikhail Gavrilov wrote: >>> On Thu, 20 Dec 2018 at 16:17, StDenis, Tom wrote: >>>> >>>> Well yup the kernel is not letting you open

Re: After Vega 56/64 GPU hang I unable reboot system

On 2018-12-20 9:06 a.m., Tom St Denis wrote: > On 2018-12-20 6:45 a.m., Mikhail Gavrilov wrote: >> On Thu, 20 Dec 2018 at 16:17, StDenis, Tom wrote: >>> >>> Well yup the kernel is not letting you open the files: >>> >>> >>> As sudo/root

Re: After Vega 56/64 GPU hang I unable reboot system

On 2018-12-20 6:45 a.m., Mikhail Gavrilov wrote: > On Thu, 20 Dec 2018 at 16:17, StDenis, Tom wrote: >> >> Well yup the kernel is not letting you open the files: >> >> >> As sudo/root you should be able to open these files with umr. What >> happens i

Re: After Vega 56/64 GPU hang I unable reboot system

On 2018-12-19 4:21 p.m., Mikhail Gavrilov wrote: > I see that backtrace in my previous message are borked. > I place backtrace in text file for more comfort reading in this message. The backtrace points to the segfault in umr caused when it fails to read the file. We want to know why it can't

Re: After Vega 56/64 GPU hang I unable reboot system

No gfx ring? You can specify a ring name for --waves should be in the docs. It's not on the web docs but in the help text https://cgit.freedesktop.org/amd/umr/tree/src/app/main.c#n643 I'll fix the web docs when I'm in next. Tom On December 19, 2018 3:21:25 PM EST, "Grodzovsky, Andrey"

amdkfd build regression if HSA_AMD is disabled

Hi All, The commit: commit 62f65d3cb34a8300bf1e07fc478e03c3c02634d4 Refs: v4.20-rc3-524-g62f65d3cb34a Author: Felix Kuehling AuthorDate: Mon Nov 19 20:05:54 2018 -0500 Commit: Felix Kuehling CommitDate: Fri Dec 7 17:17:11 2018 -0500 drm/amdgpu: Add KFD VRAM limit checking

build broken on drm-next

Hi, This commit commit e421c656beefa1044f65cf50d7a7455df60cd703 Refs: v4.20-rc3-530-ge421c656beef Author: Tiecheng Zhou AuthorDate: Fri Dec 7 09:11:35 2018 +0800 Commit: Tiecheng Zhou CommitDate: Mon Dec 10 11:14:27 2018 +0800 drm/amdgpu: bypass RLC init under sriov

regression in ttm

This commit causes a regression on my Carrizo running piglit (dmesg attached) commit 5786b66c9e3b7b18f3c24566e70cae450969cb14 Refs: v4.20-rc3-498-g5786b66c9e3b Author: Christian König AuthorDate: Mon Sep 24 13:35:53 2018 +0200 Commit: Christian König CommitDate: Tue Dec 4 10:22:22 2018

Re: regression on RV1

; > Alex > > > *From:* amd-gfx on behalf of > Deucher, Alexander > *Sent:* Wednesday, October 17, 2018 12:15:21 PM > *To:* StDenis, Tom; Koenig, Christian; amd-gfx mailing list > *Cc:* Huang, Ray > *Subject:* Re: regression on RV1 > > IIRC, APUs do not have a pagin

[PATCH] drm/amd/amdgpu: Don't use paging functions on APU

Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 46 -- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c index 33a62d5a4949..b7f6db39d357 100644 ---

regression on RV1

This commit: commit 6cbd074831a423e0d30b386fc056d6c2c3559147 (HEAD, refs/bisect/bad) Author: Christian König Date: Mon Oct 8 14:38:22 2018 +0200 drm/amdgpu: activate paging queue on SDMA v4 Implement all the necessary stuff to get those extra rings working. Signed-off-by:

Re: vcn regression on raven1

, May 1, 2018 21:39 To: StDenis, Tom; Deucher, Alexander Cc: Koenig, Christian; amd-gfx@lists.freedesktop.org Subject: Re: vcn regression on raven1 Hi Tom, Do you mean you cannot find the patch from gerrit/amd-staging-dkms-next either? I do find it. the tip of gerrit/amd-staging-drm-next

Re: vcn regression on raven1

I pull from gerrit. I'm just pointing out that it's not on drm-next upstream either. It may have been missed in a rebase or something. Tom From: Zhang, Jerry Sent: Tuesday, May 1, 2018 21:07 To: StDenis, Tom; Deucher, Alexander Cc: Koenig, Christian

Re: vcn regression on raven1

on the public copy of the tree it's not there https://cgit.freedesktop.org/~agd5f/linux/tree/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c?h=amd-staging-drm-next#n1110 Cheers, Tom From: Zhang, Jerry Sent: Tuesday, May 1, 2018 20:52 To: StDenis, Tom; Deucher

Re: vcn regression on raven1

Hi Jerry, So far as I know this wasn't included on the tip of drm-next. I hit this this morning in my semi-regular pull/build/test cycle. Was this missed in a recent rebase? Tom From: Zhang, Jerry Sent: Tuesday, May 1, 2018 20:43 To: StDenis, Tom

iomem debugfs patches

Hi Christian, I've been running with the last two patches from the ttm changes (that included your iomem patch with my write method addition) for a while now. Through piglit, various GL games, with both normal and restricted VRAM without ill effect. Is there anything else that might be

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

I haven't tried the patch but just like to point out this breaks umr :-) I'll have to craft something on Monday to support this and iova in parallel until the iova kernels are realistically EOL'ed. On the other hand I support this idea since it eliminates the need for an fmem hack. So much

Re: [PATCH 02/30] drm/amd/display: Remove dead enable_plane function definition and call

I tried the latest drm-next as of this morning and still had gfx corruption. I added you to the watchers list for a JIRA ticket I opened about this. Cheers, Tom From: Wentland, Harry Sent: Thursday, December 14, 2017 10:41 To: StDenis, Tom; amd-gfx

Re: remove ttm trace and add iova debugfs (v2)

Should add I was able to read/write system memory mapped by amdgpu with these patches in place on my polaris10 device (with iommu enabled of course). From: amd-gfx on behalf of Tom St Denis

Re: [PATCH 18/19] drm/amdgpu: Disable GFX PG on CZ

setup I can install/run to test it? Or is simply loading a KFD merged/rebased kernel enough to cause the hang (and thus I guess a bisect doesn't make sense). Cheers, Tom From: Kuehling, Felix Sent: Friday, August 11, 2017 20:40 To: StDenis, Tom; amd-gfx

  1   2   >