Re: [PATCH v2] drm/amdgpu: fix multiple memory leaks

2019-09-19 Thread Sven Van Asbroeck
Hi Christian, On Thu, Sep 19, 2019 at 4:05 AM Koenig, Christian wrote: > > > +out4: > > + kfree(i2s_pdata); > > +out3: > > + kfree(adev->acp.acp_res); > > +out2: > > + kfree(adev->acp.acp_cell); > > +out1: > > + kfree(adev->acp.acp_genpd); > > kfree on a NULL pointer is harmless,

Re: [PATCH v2] drm/amdgpu: fix multiple memory leaks

2019-09-18 Thread Sven Van Asbroeck
On Wed, Sep 18, 2019 at 3:09 PM Navid Emamdoost wrote: > > i2s_pdata = kcalloc(3, sizeof(struct i2s_platform_data), GFP_KERNEL); > if (i2s_pdata == NULL) { > - kfree(adev->acp.acp_res); > - kfree(adev->acp.acp_cell); > - return -ENOMEM; >