Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel

Hi Will and Andrey, On 24/07/2019 15:20, Will Deacon wrote: > On Wed, Jul 24, 2019 at 04:16:49PM +0200, Andrey Konovalov wrote: >> On Wed, Jul 24, 2019 at 4:02 PM Will Deacon wrote: >>> On Tue, Jul 23, 2019 at 08:03:29PM +0200, Andrey Konovalov wrote: On Tue, Jul 23, 2019 at 7:59 PM Andrey

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

On 13/06/2019 16:57, Catalin Marinas wrote: > On Thu, Jun 13, 2019 at 04:45:54PM +0100, Vincenzo Frascino wrote: >> On 13/06/2019 16:35, Catalin Marinas wrote: >>> On Thu, Jun 13, 2019 at 12:16:59PM +0100, Dave P Martin wrote: >>>> On Wed, Jun 12, 2019 at 01:43:20PM

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

On 13/06/2019 16:35, Catalin Marinas wrote: > On Thu, Jun 13, 2019 at 12:16:59PM +0100, Dave P Martin wrote: >> On Wed, Jun 12, 2019 at 01:43:20PM +0200, Andrey Konovalov wrote: >>> From: Catalin Marinas >>> >>> It is not desirable to relax the ABI to allow tagged user addresses into >>> the

Re: [PATCH v17 14/15] vfio/type1, arm64: untag user pointers in vaddr_get_pfn

for vma lookups, which can > only by done with untagged pointers. > > Untag user pointers in this function. > > Reviewed-by: Catalin Marinas > Reviewed-by: Kees Cook > Signed-off-by: Andrey Konovalov Reviewed-by: Vincenzo Frascino > --- > drivers/vfio/vfio

Re: [PATCH v17 08/15] userfaultfd, arm64: untag user pointers

for vma lookups, which can > only by done with untagged pointers. > > Untag user pointers in validate_range(). > > Reviewed-by: Catalin Marinas > Reviewed-by: Kees Cook > Signed-off-by: Andrey Konovalov Reviewed-by: Vincenzo Frascino > --- > fs/userfaultfd.c | 22 ++

Re: [PATCH v17 07/15] fs, arm64: untag user pointers in copy_mount_options

before subtracting. > > Reviewed-by: Kees Cook > Reviewed-by: Catalin Marinas > Signed-off-by: Andrey Konovalov Reviewed-by: Vincenzo Frascino > --- > fs/namespace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/namespace.c b/fs/name

Re: [PATCH v17 06/15] mm, arm64: untag user pointers in get_vaddr_frames

for vma lookups, which can > only by done with untagged pointers. Instead of locating and changing > all callers of this function, perform untagging in it. > > Acked-by: Catalin Marinas > Reviewed-by: Kees Cook > Signed-off-by: Andrey Konovalov Reviewed-by: Vincenzo Frascino

Re: [PATCH v17 05/15] mm, arm64: untag user pointers in mm/gup.c

s. > > Reviewed-by: Kees Cook > Reviewed-by: Catalin Marinas > Signed-off-by: Andrey Konovalov Reviewed-by: Vincenzo Frascino > --- > mm/gup.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/mm/gup.c b/mm/gup.c > index ddde097cf9e4..c37df3d455a2 100644 &g

Re: [PATCH v17 04/15] mm, arm64: untag user pointers passed to memory syscalls

ur for the > corresponding vma. > > Reviewed-by: Catalin Marinas > Reviewed-by: Kees Cook > Signed-off-by: Andrey Konovalov Reviewed-by: Vincenzo Frascino > --- > mm/madvise.c | 2 ++ > mm/mempolicy.c | 3 +++ > mm/migrate.c | 2 +- > mm/mincore.c | 2 ++ >

Re: [PATCH v17 03/15] arm64: Introduce prctl() options to control the tagged user addresses ABI

ldren but cleared on execve(). > > The PR_SET_TAGGED_ADDR_CTRL will be expanded in the future to handle > MTE-specific settings like imprecise vs precise exceptions. > > Signed-off-by: Catalin Marinas Reviewed-by: Vincenzo Frascino > --- > arch/arm64/include/asm/processor.h | 6 +++ > arch/a

Re: [PATCH v17 02/15] lib, arm64: untag user pointers in strn*_user

ters to perform > validity checks, but then uses them as is to perform user memory accesses. > > Reviewed-by: Khalid Aziz > Acked-by: Kees Cook > Reviewed-by: Catalin Marinas > Signed-off-by: Andrey Konovalov Reviewed-by: Vincenzo Frascino > --- > lib/strncpy_from_use

Re: [PATCH v17 01/15] arm64: untag user pointers in access_ok and __uaccess_mask_ptr

n __uaccess_mask_ptr, > before performing access validity checks. > > Note, that this patch only temporarily untags the pointers to perform the > checks, but then passes them as is into the kernel internals. > > Reviewed-by: Kees Cook > Reviewed-by: Catalin Marinas > S

Re: [PATCH v16 02/16] arm64: untag user pointers in access_ok and __uaccess_mask_ptr

Hi Catalin, On 12/06/2019 10:32, Catalin Marinas wrote: > Hi Vincenzo, > > On Tue, Jun 11, 2019 at 06:09:10PM +0100, Vincenzo Frascino wrote: >>> diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c >>> index 3767fb21a5b8..69d0be1fc708 100644

Re: [PATCH v16 02/16] arm64: untag user pointers in access_ok and __uaccess_mask_ptr

Hi Catalin, ... > -8< > From 7c624777a4e545522dec1b34e60f0229cb2bd59f Mon Sep 17 00:00:00 2001 > From: Catalin Marinas > Date: Tue, 11 Jun 2019 13:03:38 +0100 > Subject: [PATCH] arm64: Introduce prctl() options to control the tagged user > addresses ABI > > It is not

Re: [PATCH v13 10/20] kernel, arm64: untag user pointers in prctl_set_mm*

Hi Andrey, sorry for the late reply, I came back from holiday and try to catch up with the emails. On 4/29/19 3:23 PM, Andrey Konovalov wrote: > On Fri, Apr 26, 2019 at 4:50 PM Catalin Marinas > wrote: >> >> On Mon, Apr 01, 2019 at 06:44:34PM +0200, Andrey Konovalov wrote: >>> On Fri, Mar 22,