Re: [PATCH v2 2/2] drm/amdpgu: Use VRAM domain in UVD IB test

2021-09-05 Thread Wang, Kevin(Yang)
[AMD Official Use Only] From: dri-devel on behalf of Pan, Xinhui Sent: Monday, September 6, 2021 9:10 AM To: amd-gfx@lists.freedesktop.org ; dri-de...@lists.freedesktop.org Cc: Koenig, Christian ; Deucher, Alexander ; che...@uniontech.com Subject: [PATCH

Re: [PATCH v2 1/2] drm/amd/pm: skip to load smu microcode on sriov for aldebaran

2021-08-12 Thread Wang, Kevin(Yang)
[AMD Official Use Only] From: Lazar, Lijo Sent: Thursday, August 12, 2021 2:27 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Min, Frank ; Zhang, Hawking Subject: Re: [PATCH v2 1/2] drm/amd/pm: skip to load smu microcode

Re: [PATCH v2 1/2] drm/amd/pm: skip to load smu microcode on sriov for aldebaran

2021-08-11 Thread Wang, Kevin(Yang)
[AMD Official Use Only] please ignore this patch, there some errors in here. Best Regards, Kevin From: Wang, Kevin(Yang) Sent: Thursday, August 12, 2021 11:36 AM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Feng, Kenneth ; Min, Frank ; Zhang, Hawking

Re: [PATCH 4/5] drm/amd/pm: change return value in aldebaran_get_power_limit()

2021-08-11 Thread Wang, Kevin(Yang)
[AMD Official Use Only] yes, it is a coding error, I will correct it. thanks. Best Regards, Kevin From: Lazar, Lijo Sent: Wednesday, August 11, 2021 5:45 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Min, Frank ; Zhang, Hawking

Re: [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS

2021-08-02 Thread Wang, Kevin(Yang)
[AMD Official Use Only] From: Lazar, Lijo Sent: Monday, August 2, 2021 3:41 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/pm: correct aldebaran smu feature mapping FEATURE_DATA_CALCULATIONS On 8/2/2021 8:23 AM

Re: [PATCH] drm/amd/pm: Support board calibration on aldebaran

2021-07-15 Thread Wang, Kevin(Yang)
[AMD Official Use Only] From: Lazar, Lijo Sent: Thursday, July 15, 2021 3:47 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Wang, Kevin(Yang) ; Feng, Kenneth ; Quan, Evan Subject: [PATCH] drm/amd/pm: Support board calibration on aldebaran Add

Re: [RFC PATCH v2] drm/amdgpu/ttm: optimize vram access in amdgpu_ttm_access_memory()

2021-07-13 Thread Wang, Kevin(Yang)
[AMD Official Use Only] From: Christian König Sent: Tuesday, July 13, 2021 3:11 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Deucher, Alexander ; Min, Frank ; Koenig, Christian ; Zhang, Hawking Subject: Re: [RFC PATCH v2] drm

Re: [PATCH] drm/amd/pm: drop smu_v13_0_1.c|h files for yellow carp

2021-07-01 Thread Wang, Kevin(Yang)
[AMD Official Use Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: Hou, Xiaomeng (Matthew) Sent: Thursday, July 1, 2021 4:31 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) ; Lazar, Lijo ; Liu, Aaron ; Hou, Xiaomeng (Matthew) Subject

Re: [PATCH] drm/amdgpu: add non-aligned address supported in amdgpu_device_vram_access()

2021-06-29 Thread Wang, Kevin(Yang)
, 2021 11:34 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Zhang, Hawking ; Min, Frank ; Lazar, Lijo Subject: Re: [PATCH] drm/amdgpu: add non-aligned address supported in amdgpu_device_vram_access() Hi Kevin, the primary use

Re: [PATCH] drm/amdgpu: add non-aligned address supported in amdgpu_device_vram_access()

2021-06-28 Thread Wang, Kevin(Yang)
: Christian König Sent: Monday, June 28, 2021 10:10 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH] drm/amdgpu: add non-aligned address supported in amdgpu_device_vram_access() Am 25.06.21 um 05:24 schrieb Kevin Wang: > 1.

Re: [PATCH] drm/amdgpu: add non-aligned address supported in amdgpu_device_vram_access()

2021-06-28 Thread Wang, Kevin(Yang)
[AMD Official Use Only] From: Lazar, Lijo Sent: Friday, June 25, 2021 9:28 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH] drm/amdgpu: add non-aligned address supported

Re: [PATCH 1/1] amdgpu/pm: remove code duplication in show_power_cap calls

2021-06-23 Thread Wang, Kevin(Yang)
[AMD Official Use Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: Powell, Darren Sent: Wednesday, June 23, 2021 10:34 AM To: amd-gfx@lists.freedesktop.org Cc: Powell, Darren Subject: [PATCH 1/1] amdgpu/pm: remove code duplication in show_power_cap

Re: [PATCH 1/1] amdgpu/pm: remove code duplication in show_power_cap calls

2021-06-22 Thread Wang, Kevin(Yang)
[AMD Official Use Only] Please optimize the following code together in new generic function. if (pp_funcs && pp_funcs->get_power_limit){} please check above codes before calling pm_runtime_xxx interfaces to avoid empty operation in pm_runtime cycle. Reviewed-by: Kevin Wang Best Regards,

Re: [PATCH] amdgpu/pm: replaced snprintf usage in amdgpu_pm.c with sysfs_emit

2021-06-16 Thread Wang, Kevin(Yang)
[AMD Official Use Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Darren Powell Sent: Wednesday, June 16, 2021 12:31 PM To: amd-gfx@lists.freedesktop.org Cc: Powell, Darren Subject: [PATCH] amdgpu/pm: replaced snprintf usage in

Re: [PATCH] drm/amd/pm: use attr_update if the attr has it

2021-05-31 Thread Wang, Kevin(Yang)
[AMD Official Use Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Sathishkumar S Sent: Thursday, May 27, 2021 12:23 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Sundararaju, Sathishkumar ; Sharma, Shashank

Re: [PATCH] drm/amdgpu: modify system reference clock source for navi+

2021-05-18 Thread Wang, Kevin(Yang)
[AMD Official Use Only] From: amd-gfx on behalf of Aaron Liu Sent: Tuesday, May 18, 2021 2:26 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Liu, Aaron Subject: [PATCH] drm/amdgpu: modify system reference clock source for navi+

Re: [PATCH v2 2/3] drm/amd/pm: Fix showing incorrect frequencies on aldebaran

2021-05-17 Thread Wang, Kevin(Yang)
and min_clk is the default min clock. Thanks, Lijo From: Wang, Kevin(Yang) Sent: Monday, May 17, 2021 2:32 PM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Chen, Guchun ; Feng, Kenneth Subject: Re: [PATCH v2 2/3] drm/amd/pm: Fix showing incorrect frequencies on aldebaran

Re: [PATCH v2 2/3] drm/amd/pm: Fix showing incorrect frequencies on aldebaran

2021-05-17 Thread Wang, Kevin(Yang)
error, is right? Best Regards, Kevin From: Lazar, Lijo Sent: Monday, May 17, 2021 4:39 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Wang, Kevin(Yang) ; Chen, Guchun ; Feng, Kenneth Subject: [PATCH v2 2/3] drm/amd/pm: Fix showing incorrect frequ

Re: [PATCH v2] drm/amdkfd: disable kfd debugfs node of hang_hws on vf mode

2021-05-13 Thread Wang, Kevin(Yang)
May 14, 2021 12:01 AM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Min, Frank Subject: Re: [PATCH v2] drm/amdkfd: disable kfd debugfs node of hang_hws on vf mode This won't work. the kfd_debugfs directory is system-wide. So you cannot have a per-GPU criteria for cr

Re: [PATCH 2/3] drm/amd/pm: Fix showing incorrect frequencies on aldebaran

2021-05-13 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: Lazar, Lijo Sent: Thursday, May 13, 2021 7:53 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Feng, Kenneth Subject: Re: [PATCH 2/3] drm/amd/pm: Fix showing incorrect

Re: [PATCH 2/3] drm/amd/pm: Fix showing incorrect frequencies on aldebaran

2021-05-13 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: Lazar, Lijo Sent: Thursday, May 13, 2021 5:47 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Feng, Kenneth ; Wang, Kevin(Yang) Subject: [PATCH 2/3] drm/amd/pm: Fix showing incorrect

Re: [PATCH 1/2] drm/scheduler: Change scheduled fence track

2021-04-26 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Roy Sun Sent: Monday, April 26, 2021 2:27 PM To: amd-gfx@lists.freedesktop.org Cc: Sun, Roy ; Nieto, David M Subject: [PATCH 1/2] drm/scheduler: Change scheduled fence track

Re: [PATCH 1/2] drm/scheduler: Change scheduled fence track

2021-04-23 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Roy Sun Sent: Friday, April 23, 2021 6:55 PM To: amd-gfx@lists.freedesktop.org Cc: Sun, Roy ; Nieto, David M Subject: [PATCH 1/2] drm/scheduler: Change scheduled fence track

Re: [PATCH] drm/amdgpu: Ensure dcefclk isn't created on Aldebaran

2021-04-12 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Kent Russell Sent: Tuesday, April 13, 2021 12:01 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amd/pm: Use VBIOS PPTable for aldebaran

2021-04-12 Thread Wang, Kevin(Yang)
[AMD Public Use] Reviewed-by: Kevin Wang Best Regards, Kevin From: Lazar, Lijo Sent: Monday, April 12, 2021 2:06 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Xu, Feifei ; Wang, Kevin(Yang) Subject: [PATCH] drm/amd/pm: Use VBIOS PPTable

Re: [PATCH] drm/amdgpu/swsmu: don't bail early on hw_setup on resume

2021-03-25 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Alex Deucher Sent: Friday, March 26, 2021 12:37 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH]

Re: [PATCH] drm/amd/pm: fix workload mismatch on vega10

2021-03-15 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards. Kevin From: amd-gfx on behalf of Kenneth Feng Sent: Tuesday, March 16, 2021 10:29 AM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/pm:

Re: [PATCH 1/1] drm/amdgpu: wrap kiq ring ops with kiq spinlock

2021-03-15 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Hi Das, It seems more reasonable to put spin lock in ring structure, so that KIQ ring can be treated like other normal ring. and do we have other paths to call kiq ring except for kernel initialization? it seems the kfd and kgd will use kiq

Re: [PATCH] drm/amd/pm: correct the gpu metrics version

2021-03-09 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Evan Quan Sent: Wednesday, March 10, 2021 3:34 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject:

Re: [PATCH] drm/amd/pm: correct the name of one function for vangogh

2021-03-02 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: Du, Xiaojian Sent: Tuesday, March 2, 2021 6:20 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray ; Quan, Evan ; Wang, Kevin(Yang) ; Lazar, Lijo ; Du

Re: [PATCH] drm/amdgpu: fix parameter error of RREG32_PCIE() in amdgpu_regs_pcie

2021-03-02 Thread Wang, Kevin(Yang)
[AMD Public Use] yes, thanks lijo. Best Regards, Kevin From: Lazar, Lijo Sent: Tuesday, March 2, 2021 4:09 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu: fix parameter error of RREG32_PCIE

Re: [PATCH 1/2] drm/amdgpu: refine PSP TA firmware info print in debugfs

2021-03-01 Thread Wang, Kevin(Yang)
[AMD Public Use] From: Zhang, Hawking Sent: Monday, March 1, 2021 5:31 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 1/2] drm/amdgpu: refine PSP TA firmware info print in debugfs [AMD Public Use] + for (i

Re: [PATCH] drm/amdgpu: correct TA RAP firmware information print error

2021-02-28 Thread Wang, Kevin(Yang)
[AMD Public Use] yes, I have the same idea and agree with you. but patch is merged, I will add a new patch to refine it. Best Regards, Kevin From: Zhang, Hawking Sent: Monday, March 1, 2021 1:23 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Li

Re: [PATCH] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool

2021-02-19 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Hi Jiapeng, /* 0 - Fine grained DPM, 1 - Discrete DPM */ - return dpm_desc->SnapToDiscrete == 0 ? true : false; + return !(dpm_desc->SnapToDiscrete == 0); the code logic is wrong, the '!' is not needed. Best Regards,

Re: [PATCH] drm/amd/pm/swsmu: Avoid using structure_size uninitialized in smu_cmn_init_soft_gpu_metrics

2021-02-18 Thread Wang, Kevin(Yang)
thanks, Reviewed-by: Kevin Wang Regards, Kevin > 在 2021年2月19日,06:49,Nathan Chancellor 写道: > > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:764:2: warning: > variable 'structure_size' is used uninitialized whenever switch default > is taken [-Wsometimes-uninitialized] >

Re: [PATCH] drm/amd/pm: make the error log more clear for fine grain tuning function

2021-02-08 Thread Wang, Kevin(Yang)
From: Huang, Ray Sent: Tuesday, February 9, 2021 12:10 PM To: Wang, Kevin(Yang) ; Du, Xiaojian ; amd-gfx@lists.freedesktop.org ; Deucher, Alexander Cc: Quan, Evan ; Lazar, Lijo Subject: RE: [PATCH] drm/amd/pm: make the error log more clear for fine grain tuning function [AMD Official Use

Re: [PATCH] drm/amd/pm: Remove unnecessary conversion to bool

2021-02-07 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] if possible, please correct the same issue in navi10_ppt.c Reviewed-by: Kevin Wang Best Regards, Kevin From: Jiapeng Chong Sent: Sunday, February 7, 2021 4:49 PM To: Deucher, Alexander Cc: Koenig, Christian

Re: [PATCH] drm/amdgpu: optimize list operation in amdgpu_xgmi

2021-02-03 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] thanks Felix, I will continue to optimize related codes in the future. Best Regards, Kevin From: Kuehling, Felix Sent: Wednesday, February 3, 2021 9:53 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org

Re: [PATCH] drm/amd/pm: remove some useless code for vangogh

2021-02-01 Thread Wang, Kevin(Yang)
Cc: Huang, Ray ; Quan, Evan ; Wang, Kevin(Yang) ; Du, Xiaojian Subject: [PATCH] drm/amd/pm: remove some useless code for vangogh This patch is to remove some useless code for vangogh. In the earlier code, vangogh can't finish all the sequence of smu late init. But now vangogh has one stable work

Re: [PATCH] drm/amd/pm: fill in the data member of v2 gpu metrics table for vangogh

2021-02-01 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: Du, Xiaojian Sent: Monday, February 1, 2021 4:33 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray ; Quan, Evan ; Wang, Kevin(Yang) ; Du, Xiaojian

Re: [RFC PATCH 0/3] add ttm trace event support

2021-01-28 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] thanks comments. I will refine these patches, then send out review later. Best Regards, Kevin From: Christian König Sent: Thursday, January 28, 2021 3:46 PM To: Wang, Kevin(Yang) ; dri-de

Re: [PATCH] drm/amd/pm: print the timeout of smc message

2021-01-20 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Huang Rui Sent: Wednesday, January 20, 2021 8:13 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan ; Huang, Ray Subject: [PATCH] drm/amd/pm: print the

Re: [PATCH] drm/amd/pm: make the error log more clear for fine grain tuning function

2021-01-19 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: Du, Xiaojian Sent: Wednesday, January 20, 2021 11:48 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray ; Quan, Evan ; Wang, Kevin(Yang) ; Lazar, Lijo ; Du, Xiaojian ; Du, Xiaojian Subject: [PATCH

Re: [PATCH 2/2] drm/amdgpu: Add secure display TA interface

2021-01-13 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Jinzhou Su Sent: Wednesday, January 13, 2021 11:43 AM To: amd-gfx@lists.freedesktop.org Cc: Su, Jinzhou (Joe) ; Huang, Ray Subject: [PATCH 2/2] drm/amdgpu: Add secure display TA

Re: [PATCH 2/2] drm/amd/pm: modify the fine grain tuning function for vangogh

2021-01-13 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: Du, Xiaojian Sent: Wednesday, January 13, 2021 7:22 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray ; Quan, Evan ; Lazar, Lijo ; Wang, Kevin(Yang) ; Du, Xiaojian Subject: [PATCH 2/2] drm/amd/pm

Re: [PATCH 4/8] amdgpu/pm: Powerplay API for smu , changed 9 pm power functions to use API

2020-12-20 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Darren Powell Sent: Saturday, December 19, 2020 8:48 AM To: amd-gfx@lists.freedesktop.org Cc: Powell, Darren Subject: [PATCH 4/8] amdgpu/pm: Powerplay API for smu , changed 9 pm

Re: [PATCH 3/8] amdgpu/pm: Powerplay API for smu , changed 6 pm hwmon fan functions to use API

2020-12-20 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Darren Powell Sent: Saturday, December 19, 2020 8:48 AM To: amd-gfx@lists.freedesktop.org Cc: Powell, Darren Subject: [PATCH 3/8] amdgpu/pm: Powerplay API for smu , changed 6 pm

Re: [PATCH 1/8] amdgpu/pm: Powerplay API for smu , added get_performance_level

2020-12-20 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Darren Powell Sent: Saturday, December 19, 2020 8:48 AM To: amd-gfx@lists.freedesktop.org Cc: Powell, Darren Subject: [PATCH 1/8] amdgpu/pm: Powerplay API for smu , added

Re: [PATCH V2 1/1] drm/amdgpu: skip load smu and sdma microcode on sriov for SIENNA_CICHLID

2020-12-14 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Stanley.Yang Sent: Monday, December 14, 2020 6:35 PM To: amd-gfx@lists.freedesktop.org ; Jian, Jane Cc: Yang, Stanley Subject:

Re: [PATCH 3/3] drm/amdgpu/pm: inform PMFW rlc status before start/stop rlc for vangogh

2020-12-08 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Xiaomeng Hou Sent: Tuesday, December 8, 2020 7:19 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Hou, Xiaomeng (Matthew) ; Quan, Evan Subject:

Re: [PATCH 2/3] drm/amd/pm: add interface to notify RLC status for vangogh

2020-12-08 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Xiaomeng Hou Sent: Tuesday, December 8, 2020 7:19 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Hou, Xiaomeng (Matthew) ; Quan, Evan Subject:

Re: [PATCH] drm/amdgpu: change trace event parameter name from 'driect' to 'immediate'

2020-12-07 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: Koenig, Christian Sent: Monday, December 7, 2020 4:23 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: change trace event parameter name from 'driect

Re: [PATCH] drm/amd/amdgpu: specify the power strategy for vcn use

2020-11-03 Thread Wang, Kevin(Yang)
comment inline. From: amd-gfx on behalf of Kenneth Feng Sent: Tuesday, November 3, 2020 4:07 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/amdgpu: specify the power strategy for vcn use The power/performance control strategy

Re: [PATCH] drm/amd/swsmu: correct wrong feature bit mapping

2020-11-02 Thread Wang, Kevin(Yang)
sorry, please ignore this patch, the patch has been merged. Best Regards, Kevin From: Wang, Kevin(Yang) Sent: Tuesday, November 3, 2020 1:54 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Wang, Kevin(Yang) Subject: [PATCH] drm/amd/swsmu: correct

Re: [PATCH] drm/amdgpu: add function to program pbb mode for sienna cichlid

2020-10-14 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Likun Gao Sent: Thursday, October 15, 2020 12:03 PM To: amd-gfx@lists.freedesktop.org Cc: Gao, Likun Subject: [PATCH] drm/amdgpu: add function to program pbb mode for sienna

Re: [PATCH] drm/amdgpu/swsmu: init the baco mutex in early_init

2020-10-13 Thread Wang, Kevin(Yang)
Reviewed-by: Kevin Wang > 在 2020年10月13日,20:15,Alex Deucher 写道: > > GPU reset might get called during init time, before > sw_init has been called. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) >

Re: [PATCH] drm/amdgpu: fix the issue that apu has no smu firmware binary

2020-10-13 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Huang Rui Sent: Tuesday, October 13, 2020 7:45 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: [PATCH] drm/amdgpu: fix

Re: [PATCH] drm/amd/powerplay: add one sysfs file -- "pp_od_clk_voltage" to support the feature to modify gfx engine clock(Mhz units) on Raven/Raven2/Picasso APU.

2020-09-28 Thread Wang, Kevin(Yang)
, Kevin(Yang) ; Deucher, Alexander ; Quan, Evan ; Huang, Shimmer ; Du, Xiaojian ; Du, Xiaojian Subject: [PATCH] drm/amd/powerplay: add one sysfs file -- "pp_od_clk_voltage" to support the feature to modify gfx engine clock(Mhz units) on Raven/Raven2/Picasso APU. From: Xiaojian Du From

Re: [PATCH 2/2] drm/amd: Skip not used microcode loading in SRIOV

2020-09-22 Thread Wang, Kevin(Yang)
[AMD Public Use] Embedding these SRIOV check into the underlying functions is in many places, which is not conducive to subsequent code optimization and maintenance. It took a long time to clean up the SMU code before, but now some new checks have been introduced into the SMU code. I think a

Re: [PATCH] drm/amd/pm: fix is_dpm_running() run error on 32bit system

2020-08-24 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Indeed, that's not necessary. thanks. Best Regards, Kevin From: Chen, Jiansong (Simon) Sent: Monday, August 24, 2020 7:59 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander

Re: [PATCH] drm/amd/powerplay: Fix uninitialized warning in arcturus ppt driver

2020-08-12 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Hi Tom, drm/amdgpu: fix uninit-value in arcturus_log_thermal_throttling_event() the fixed patch has been merged into drm-next branch. Best Regards, Kevin From: amd-gfx on behalf of Quan, Evan Sent:

Re: [PATCH] drm/amdgpu/smu: rework i2c adpater registration

2020-08-04 Thread Wang, Kevin(Yang)
Reviewed-By: Kevin Wang Best Regards Kevin > 在 2020年8月5日,上午12:57,Alex Deucher 写道: > > Ping? > > >> On Thu, Jul 30, 2020 at 3:24 PM Alex Deucher wrote: >> >> The i2c init/fini functions just register the i2c adapter. >> There is no need to call them during hw init/fini. They only >> need

Re: [PATCH] drm/amdgpu: skip crit temperature values on APU

2020-07-27 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Huang Rui Sent: Monday, July 27, 2020 4:23 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: [PATCH] drm/amdgpu: skip crit

Re: [PATCH 2/2] drm/amd/swsmu: correct smu lock type on smu_read_sensor()

2020-07-26 Thread Wang, Kevin(Yang)
t Regards, Kevin From: Quan, Evan Sent: Monday, July 27, 2020 12:01 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) ; Feng, Kenneth Subject: RE: [PATCH 2/2] drm/amd/swsmu: correct smu lock type on smu_read_sensor() [AMD Official Use Only - Internal Distributio

Re: [PATCH] drm/amd/powerplay: remove the dpm checking in the boot sequence

2020-07-22 Thread Wang, Kevin(Yang)
Reviewed-by: Kevin Wang > 在 2020年7月22日,下午9:37,Kenneth Feng 写道: > > It's not necessary to retrieve the power features status when the > asic is booted up the first time. This patch can have the features > enablement status still checked in suspend/resume case and removed > from the first boot

Re: [PATCH 2/2] drm/amdgpu: add fw release for sdma v5_0

2020-06-18 Thread Wang, Kevin(Yang)
le) for (i = 0; i < adev->sdma.num_instances; i++) amdgpu_ring_fini(>sdma.instance[i].ring); + sdma_v3_0_free_microcode(adev); return 0; } Best Regards, Kevin From: Sheng, Wenhui Sent: Thursday, June 18, 2020 5:21 PM

Re: [PATCH 2/2] drm/amdgpu: add fw release for sdma v5_0

2020-06-18 Thread Wang, Kevin(Yang)
drm/ | vim - Best Regards, Kevin From: Sheng, Wenhui Sent: Thursday, June 18, 2020 4:31 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 2/2] drm/amdgpu: add fw release for sdma v5_0 [AMD Official Use Only - Internal Distribution On

Re: [PATCH 2/2] drm/amdgpu: add fw release for sdma v5_0

2020-06-18 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Wenhui Sheng Sent: Thursday, June 18, 2020 3:53 PM To: amd-gfx@lists.freedesktop.org Cc: Sheng, Wenhui Subject: [PATCH 2/2] drm/amdgpu: add fw release for sdma v5_0 sdma v5_0

Re: [PATCH 2/2] drm/amd/smu: unify smu ppt callback marcos

2020-06-16 Thread Wang, Kevin(Yang)
to correct it. thanks. Best Regards, Kevin From: Zhang, Hawking Sent: Tuesday, June 16, 2020 6:03 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH 2/2] drm/amd/smu: unify smu ppt callback marcos [AMD Public Use]

Re: [PATCH] drm/amdgpu: remove perf level dpm in one-VF

2020-06-15 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] please add these smu messages into patch commit, after fixed, Reviewed-by: Kevin Wang Best Regards, Kevin From: Sheng, Wenhui Sent: Sunday, June 14, 2020 3:38 PM To: Wang, Kevin(Yang) ; amd-gfx

Re: [PATCH] drm/amdgpu: remove perf level dpm in one-VF

2020-06-12 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] which smu message will break this node work on navi12 asic? Best Regards, Kevin From: amd-gfx on behalf of Wenhui Sheng Sent: Friday, June 12, 2020 5:30 PM To: amd-gfx@lists.freedesktop.org Cc: Sheng,

Re: [PATCH] drm/amd/powerplay: move powerplay table operation out of smu_v11_0.c

2020-06-02 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Acked-by: Kevin Wang Best Regards, Kevin From: Gao, Likun Sent: Tuesday, June 2, 2020 5:08 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth ; Quan, Evan ; Wang, Kevin(Yang) ; Gao, Likun Subject

Re: [PATCH 1/1] drm/amdgpu: remove unused variable

2020-05-26 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Nirmoy Das Sent: Tuesday, May 26, 2020 9:03 PM To: amd-gfx@lists.freedesktop.org Cc: Das, Nirmoy Subject: [PATCH 1/1] drm/amdgpu:

Re: [PATCH] drm/amd/powerplay: check whether SMU IP is enabled before access

2020-05-26 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] size_t smu_sys_get_pp_feature_mask(struct smu_context *smu, char *buf) { - struct amdgpu_device *adev = smu->adev; size_t size = 0; int ret = 0, i = 0; uint32_t feature_mask[2] = { 0 }; @@ -70,8 +69,8 @@ size_t

Re: [PATCH 4/4] drm/amd/powerplay: add check before i2c_add_adapter

2020-05-26 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Wenhui Sheng Sent: Tuesday, May 26, 2020 6:05 PM To: amd-gfx@lists.freedesktop.org Cc: Sheng, Wenhui ; Zhang, Hawking Subject: [PATCH 4/4] drm/amd/powerplay: add check before

Re: [PATCH] drm/amdgpu: fix device attribute node create failed with multi gpu

2020-05-22 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: Alex Deucher Sent: Friday, May 22, 2020 11:16 PM To: Wang, Kevin(Yang) Cc: amd-gfx list ; Deucher, Alexander ; Zhang, Hawking Subject: Re: [PATCH] drm/amdgpu: fix device attribute node create failed

Re: [PATCH] drm/amdgpu: fix sysfs power controls with multi-GPU

2020-05-21 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Hi Alex, the flag of "ATTR_STATE_[UN]SUPPORTED" should be binding to device not device attribute node, when inserting two different video cards, the driver may be need to create different node according device type (vega, navi,...), and when

Re: [PATCH] drm/amd/powerplay: skip i2c eeprom init/fini under sriov mode

2020-05-21 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] please add a detailed description of the reason for this patch, after finshed, the patch is Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Hua Zhang Sent: Friday, May 22, 2020 1:31

Re: [PATCH 1/3] Revert "drm/amdgpu: off by one in amdgpu_device_attr_create_groups() error handling"

2020-05-21 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Series is: Reviewed-by: Kevin Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, May 22, 2020 4:23 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 1/3]

Re: [PATCH v2] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling

2020-05-20 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] thanks. Reviewed-by: Kevin Wang Best Regads, Kevin From: Dan Carpenter Sent: Wednesday, May 20, 2020 9:08 PM To: Deucher, Alexander ; Wang, Kevin(Yang) Cc: Koenig, Christian ; David Airlie ; Daniel Vetter

Re: [PATCH 2/3] drm/amdgpu: optimize amdgpu device attribute code

2020-05-06 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: Zhang, Hawking Sent: Wednesday, May 6, 2020 5:26 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Liu, Monk ; Feng, Kenneth Subject: RE: [PATCH 2/3] drm/amdgpu

Re: [PATCH] drm/amdgpu: cleanup not_vf & pp_not_vf in powerplay

2020-05-06 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] send error, please ignore this patch. Best Regards, Kevin From: Wang, Kevin(Yang) Sent: Wednesday, May 6, 2020 2:20 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Liu, Monk

Re: [PATCH] drm/amdgpu: clean up unused variable about ring lru

2020-04-20 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: Christian König Sent: Monday, April 20, 2020 11:45 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH] drm/amdgpu: clean up

Re: [PATCH] drm/amdgpu/powerplay: using the FCLK DPM table to set the MCLK

2020-04-01 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Yuxian Dai Sent: Wednesday, April 1, 2020 3:14 PM To: amd-gfx@lists.freedesktop.org Cc: Dai, Yuxian (David) ; Dai, Yuxian (David) Subject: [PATCH] drm/amdgpu/powerplay: using

Re: [PATCH] drm/amdgpu/powerplay: using the FCLK DPM table to set the MCLK

2020-04-01 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Yuxian Dai Sent: Wednesday, April 1, 2020 2:02 PM To: amd-gfx@lists.freedesktop.org Cc: Dai, Yuxian (David) ; Dai, Yuxian (David) Subject: [PATCH] drm/amdgpu/powerplay: using

Re: [PATCH] drm/amdgpu: fix hpd bo size calculation error

2020-03-25 Thread Wang, Kevin(Yang)
gards, Kevin From: Koenig, Christian Sent: Wednesday, March 25, 2020 6:28 PM To: Wang, Kevin(Yang) Cc: amd-gfx@lists.freedesktop.org ; Feng, Kenneth ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: fix hpd bo size calculation error Good catch! mem.size is actually the backin

Re: [PATCH] drm/amd/powerplay: sw ctf for arcturus

2020-01-08 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] fine for me. Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Kenneth Feng Sent: Thursday, January 9, 2020 9:53 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan ; Feng, Kenneth

Re: [PATCH] drm/amd/powerplay: unified VRAM address for driver table interaction with SMU V2

2020-01-04 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: amd-gfx on behalf of Evan Quan Sent: Thursday, January 2, 2020 10:39 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Quan, Evan Subject: [PATCH] drm/amd/powerplay: unified VRAM

Re: [PATCH] amd/amdgpu/sriov enable onevf mode for ARCTURUS VF

2019-12-23 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] add @Quan, Evan<mailto:evan.q...@amd.com> to support arcturus asic. comment inline. From: Zhang, Jack (Jian) Sent: Monday, December 23, 2019 4:42 PM To: Feng, Kenneth ; Wang, Kevin(Yang) ; Tao, Yintian

Re: [PATCH 1/2] drm/amdgpu: update the method to get fb_loc of memory training(V2)

2019-12-18 Thread Wang, Kevin(Yang)
, Xiaojie ; Long, Gang ; Wang, Kevin(Yang) ; Yin, Tianci (Rico) Subject: [PATCH 1/2] drm/amdgpu: update the method to get fb_loc of memory training(V2) From: "Tianci.Yin" The method of getting fb_loc changed from parsing VBIOS to taking certain offset from top of VRAM

Re: [PATCH 2/2] drm/amdgpu: remove memory training p2c buffer reservation(V2)

2019-12-18 Thread Wang, Kevin(Yang)
, Hawking ; Xu, Feifei ; Yuan, Xiaojie ; Long, Gang ; Wang, Kevin(Yang) ; Yin, Tianci (Rico) Subject: [PATCH 2/2] drm/amdgpu: remove memory training p2c buffer reservation(V2) From: "Tianci.Yin" IP discovery TMR(occupied the top VRAM with size DISCOVERY_TMR_SIZE) has bee

Re: [PATCH 1/2] drm/amdgpu: update the method to get fb_loc of memory training

2019-12-17 Thread Wang, Kevin(Yang)
; Long, Gang ; Wang, Kevin(Yang) ; Yin, Tianci (Rico) Subject: [PATCH 1/2] drm/amdgpu: update the method to get fb_loc of memory training From: "Tianci.Yin" The method of getting fb_loc changed from parsing VBIOS to taking certain offset from top of VRAM

Re: [PATCH v2 1/5] drm/amdgpu/smu: add metrics table lock

2019-12-17 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] The series patches are Reviewed-by: Kevin Wang From: amd-gfx on behalf of Alex Deucher Sent: Wednesday, December 18, 2019 5:45 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH

Re: [PATCH 1/5] drm/amdgpu/smu: add metrics table lock

2019-12-17 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] the swSMU should be add metrics lock to protect the maintenance data of the metrics table. The series patches are Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Alex Deucher Sent:

Re: [PATCH 1/4] drm/amd/powerplay: implement interface to retrieve gpu temperature for renoir

2019-12-05 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Series are Reviewed-by: Kevin Wang Best Regards, Kevin From: amd-gfx on behalf of Xiaomeng Hou Sent: Thursday, December 5, 2019 7:50 PM To: amd-gfx@lists.freedesktop.org Cc: Hou, Xiaomeng (Matthew)

Re: [PATCH 1/2] drm/amd/powerplay: drop unnecessary API wrapper and return value

2019-12-04 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] this change doesn't make sense, and if you really think the return value is useless. It is more reasonable to accept parameters with return value, not parameter. I think these two patches make the code look worse, unless there's a bug in it.

Re: [PATCH] amd/amdgpu/sriov swSMU disable for sriov

2019-12-02 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Kevin Wang But it's better to optimize the flow of control in is_support_sw_smu() Best Regards, Kevin From: amd-gfx on behalf of Jack Zhang Sent: Monday, December 2, 2019 7:05 PM To:

Re: [PATCH] drm/amdgpu/powerplay: unify smu send message function

2019-12-02 Thread Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only] From: Gao, Likun Sent: Monday, December 2, 2019 6:03 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) ; Feng, Kenneth ; Gao, Likun Subject: [PATCH] drm/amdgpu/powerplay: unify smu send message

Re: [PATCH] drm/amd/powerplay: correct fine grained dpm force level setting

2019-11-14 Thread Wang, Kevin(Yang)
Reviewed-by: Kevin Wang From: amd-gfx on behalf of Evan Quan Sent: Thursday, November 14, 2019 5:07 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH] drm/amd/powerplay: correct fine grained dpm force level setting For fine grained dpm,

[PATCH] drm/amdgpu: fix sysfs interface pcie_replay_count error on navi asic

2019-11-05 Thread Wang, Kevin(Yang)
the asic callback function of get_pcie_replay_count is not implement on navi asic, it will cause null pinter error when read this interface. Signed-off-by: Kevin Wang --- drivers/gpu/drm/amd/amdgpu/nv.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

  1   2   3   >