RE: [PATCH] Remove trailing space

2022-04-28 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Elena Sakhnovitch Sent: Friday, April 29, 2022 07:37 To: amd-gfx@lists.freedesktop.org Cc: Sakhnovitch, Elena (Elen) Subject: [PATCH] Remove trailing space Clea

RE: [PATCH] drm/amdgpu/display: flush the HDP when setting up DMCUB firmware

2022-04-28 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, April 29, 2022 06:13 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/display: flush the HDP when s

RE: [PATCH 5/5] drm/amdgpu/psp: deallocate memory when psp_load_fw failed

2022-04-28 Thread Zhang, Hawking
[AMD Official Use Only - General] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, April 29, 2022 06:13 To: amd-gfx@lists.freedesktop.org Cc: Wong, Alice ; Deucher, Alexander Subject: [PATCH 5/5] drm/amdgpu

RE: [PATCH 2/5] drm/amdgpu/psp: drop load/unload/init_shared_buf wrappers

2022-04-28 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, April 29, 2022 06:12 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/5] drm/amdgpu/psp: drop load/unload/ini

RE: [PATCH] drm/amd/smu: Increace dpm level count only for aldebaran

2022-04-28 Thread Zhang, Hawking
[AMD Official Use Only - General] Hi @Gao, Likun, Can we replace the asic_type check with ip versioning check? Regards, Hawking -Original Message- From: Deucher, Alexander Sent: Friday, April 29, 2022 05:30 To: amd-gfx@lists.freedesktop.org Cc: Gao, Likun ; Zhang, Hawking ; Deucher

RE: [PATCH 3/3] drm/amdgpu/discovery: add GMC 11.0 Support

2022-04-28 Thread Zhang, Hawking
[AMD Official Use Only - General] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, April 29, 2022 02:54 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Gao, Likun Subject: [PATCH 3/3] drm/amdgpu/discovery:

RE: [PATCH 1/3] drm/amdgpu: add RAS poison creation handler (v2)

2022-04-21 Thread Zhang, Hawking
B for pushing the patches - We are always on the way to improve code quality. The series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Friday, April 22, 2022 12:04 To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org; Yang, Stanley ; Lazar, Lijo ;

RE: [PATCH 1/3] drm/amdgpu: add RAS poison creation handler (v2)

2022-04-21 Thread Zhang, Hawking
ughts? Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Wednesday, April 20, 2022 19:30 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley ; Lazar, Lijo ; Ziya, Mohammad zafar ; Chai, Thomas Cc: Zhou1, Tao Subject: [PATCH 1/3] drm/amdgpu: ad

RE: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke support

2022-04-21 Thread Zhang, Hawking
[AMD Official Use Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Candice Li Sent: Wednesday, April 20, 2022 19:14 To: amd-gfx@lists.freedesktop.org Cc: Li, Candice ; Clements, John Subject: [PATCH v2 2/2] drm/amdgpu: Add debug

RE: [PATCH 1/3] drm/amdgpu: implement RAS interrupt handler for poison creation

2022-04-19 Thread Zhang, Hawking
Please also keep the naming style consistent by using "amdgpu_ras" prefix Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Wednesday, April 20, 2022 14:17 To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley ; Ziya, Mohammad zafar ; Ch

RE: [PATCH Review 1/1] drm/amdgpu: add umc query error status function

2022-04-08 Thread Zhang, Hawking
patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Stanley.Yang Sent: Friday, April 8, 2022 16:10 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Zhou1, Tao ; Li, Candice Cc: Yang, Stanley Subject: [PATCH Review 1/1] drm/amdgpu: add umc query error

RE: [PATCH v2] drm/amdgpu: Use flexible array member

2022-04-08 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Friday, April 8, 2022 18:07 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH v2] drm/amdgpu: Use flexible array member Use flexible

RE: [PATCH Review 1/1] drm/amdgpu: print more correctable error info

2022-04-07 Thread Zhang, Hawking
@lists.freedesktop.org; Zhang, Hawking ; Li, Candice Cc: Yang, Stanley Subject: RE: [PATCH Review 1/1] drm/amdgpu: print more correctable error info [AMD Official Use Only] > -Original Message- > From: Stanley.Yang > Sent: Friday, April 8, 2022 10:18 AM > To: amd-gfx@lists.freedeskto

RE: [PATCH 1/1] drm/amdkfd: Fix NULL pointer dereference

2022-04-06 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Felix Kuehling Sent: Thursday, April 7, 2022 05:06 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH 1/1] drm/amdkfd: Fix NULL pointer dereference Check th

RE: [PATCH] drm/amdgpu: expand cg_flags from u32 to u64

2022-03-30 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Evan Quan Sent: Thursday, March 31, 2022 11:33 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; StDenis, Tom ; Quan, Evan Subject: [PATCH] drm/amdgpu: expand cg_

RE: [PATCH] drm/amdgpu: Support AMDGPU RAS debugfs poll interface

2022-03-29 Thread Zhang, Hawking
ai, Thomas ; Zhang, Hawking ; Zhou1, Tao ; Clements, John ; Chai, Thomas Subject: [PATCH] drm/amdgpu: Support AMDGPU RAS debugfs poll interface Some AMDGPU RAS debugfs operations like UE injection can cause gpu reset. Before doing the next debugfs operation, the application should call poll to

RE: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption (v2)

2022-03-21 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Monday, March 21, 2022 17:38 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Kuehling, Felix ; Yang, Stanley ; Chai, Thomas Cc: Zhou1, Tao Subject: [PATCH] drm/amdkfd

RE: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption

2022-03-21 Thread Zhang, Hawking
: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Kuehling, Felix ; Yang, Stanley ; Chai, Thomas Cc: Zhou1, Tao Subject: [PATCH] drm/amdkfd: print unmap queue status for RAS poison consumption Print the status out when it passes, gpu reset message can be observed when unmap queue fails. Signe

RE: [PATCH 4/4] drm/amdkfd: add RAS poison consumption handling for UTCL2 (v2)

2022-03-16 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Wednesday, March 16, 2022 17:26 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Kuehling, Felix ; Yang, Stanley ; Chai, Thomas Cc: Zhou1, Tao Subject: [PATCH 4/4] drm

RE: [PATCH 1/4] drm/amdkfd: refine event_interrupt_poison_consumption

2022-03-16 Thread Zhang, Hawking
[AMD Official Use Only] Hit send too quickly. With below addressed, the patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: Wednesday, March 16, 2022 21:49 To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Kuehling

RE: [PATCH 3/4] drm/amdgpu: add UTCL2 RAS poison query for Aldebaran (v2)

2022-03-16 Thread Zhang, Hawking
[AMD Official Use Only] V2 looks good to me Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Wednesday, March 16, 2022 17:26 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Kuehling, Felix ; Yang, Stanley ; Chai, Thomas Cc: Zhou1, Tao

RE: [PATCH 2/4] drm/amdkfd: replace source_id with client_id for RAS poison consumption

2022-03-16 Thread Zhang, Hawking
- From: Zhou1, Tao Sent: Wednesday, March 16, 2022 17:26 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Kuehling, Felix ; Yang, Stanley ; Chai, Thomas Cc: Zhou1, Tao Subject: [PATCH 2/4] drm/amdkfd: replace source_id with client_id for RAS poison consumption client_id is more accruate

RE: [PATCH 1/4] drm/amdkfd: refine event_interrupt_poison_consumption

2022-03-16 Thread Zhang, Hawking
--Original Message- From: Zhou1, Tao Sent: Wednesday, March 16, 2022 17:26 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Kuehling, Felix ; Yang, Stanley ; Chai, Thomas Cc: Zhou1, Tao Subject: [PATCH 1/4] drm/amdkfd: refine event_interrupt_poison_consumption Combine reading and setting p

RE: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-14 Thread Zhang, Hawking
Never mind Tao. I guess you just want to leverage client_id to differentiate sdma int source from the default, right? Then might consider to explicitly call out the UTCL2_FAULT source. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent: Monday, March

RE: [PATCH 3/3] drm/amdkfd: add RAS poison consumption support for utcl2

2022-03-14 Thread Zhang, Hawking
ing style of ras hw op. Thinking about this more, it's better we add this in gfx ras op, and expose to KFD. Thoughts? Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Monday, March 14, 2022 15:03 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley ; Chai,

RE: [PATCH] drm/amdgpu: Disable baco dummy mode

2022-03-06 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Thursday, March 3, 2022 11:46 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH] drm/amdgpu: Disable baco dummy mode On aldebaran

RE: [PATCH] drm/amdgpu: Refactor mode2 reset logic for v13.0.2

2022-03-06 Thread Zhang, Hawking
[Public] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Thursday, March 3, 2022 11:33 To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu: Refactor mode2 reset logic for

RE: [PATCH] drm/amdkfd: add return value check for queue eviction

2022-02-16 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Wednesday, February 16, 2022 15:25 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley ; Chai, Thomas Cc: Zhou1, Tao Subject: [PATCH] drm/amdkfd: add return

RE: [PATCH Review 1/1] drm/amdgpu: print more error info

2022-02-14 Thread Zhang, Hawking
"); While remove " poison is created " from MCA_STATUS query function. With above fixed, the patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Stanley.Yang Sent: Monday, February 14, 2022 16:14 To: amd-gfx@lists.freedesktop.org; Zhang,

RE: [PATCH] drm/amdgpu: no rlcg legacy read in SRIOV case

2022-02-10 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Chen, Guchun Sent: Friday, February 11, 2022 13:39 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Zhou, Peng Ju ; Koenig, Christian ; Deucher, Alexander ; Skvortsov, Victor Cc: Chen

RE: [PATCH] drm/amdgpu: no rlcg read access in SRIOV case for gfx v9

2022-02-10 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Chen, Guchun Sent: Thursday, February 10, 2022 14:40 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Zhou, Peng Ju ; Koenig, Christian ; Deucher, Alexander Cc: Chen, Guchun Subject

RE: [PATCH] drm/amdgpu: loose check for umc poison mode

2022-02-10 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Thursday, February 10, 2022 16:23 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley ; Chai, Thomas ; Clements, John Cc: Zhou1, Tao Subject: [PATCH] drm

RE: [PATCH] drm/amdgpu: fix gmc init fail in sriov mode

2022-02-09 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Wang, Yang(Kevin) Sent: Wednesday, February 9, 2022 22:30 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Min, Frank ; Wang, Yang(Kevin) Subject: [PATCH] drm/amdgpu: fix gmc init fail

RE: [PATCH Review 1/1] drm/amdgpu: remove unused variable warning

2022-01-19 Thread Zhang, Hawking
2022 19:31 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Ziya, Mohammad zafar ; Clements, John ; Zhou1, Tao Cc: Yang, Stanley Subject: [PATCH Review 1/1] drm/amdgpu: remove unused variable warning Change-Id: Ic2a488ee253a913d806bd33ee9c90e31a71af320 Signed-off-by: Stanley.Yang --- dr

RE: [PATCH] drm/amdgpu: remove unused variable

2022-01-18 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Ziya, Mohammad zafar Sent: Wednesday, January 19, 2022 14:23 To: Zhang, Hawking ; Lazar, Lijo ; Clements, John Cc: amd-gfx@lists.freedesktop.org; Ziya, Mohammad zafar ; kernel test robot

RE: [PATCH 2/3] drm/amdgpu: Move xgmi ras initialization from .late_init to .early_init

2022-01-18 Thread Zhang, Hawking
[AMD Official Use Only] Patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Chai, Thomas Sent: Wednesday, January 19, 2022 10:56 To: amd-gfx@lists.freedesktop.org Cc: Chai, Thomas ; Zhang, Hawking ; Zhou1, Tao ; Clements, John ; Chai, Thomas Subject

RE: [PATCH 1/3] drm/amdgpu: Remove repeated calls

2022-01-18 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Chai, Thomas Sent: Wednesday, January 19, 2022 10:56 To: amd-gfx@lists.freedesktop.org Cc: Chai, Thomas ; Zhang, Hawking ; Zhou1, Tao ; Clements, John ; Chai, Thomas Subject: [PATCH 1/3

RE: [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVERY

2022-01-14 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, January 14, 2022 23:03 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: drop flags check for CHIP_IP_DISCOVE

RE: [PATCH] drm/amd/amdgpu: Add pcie indirect support to amdgpu_mm_wreg_mmio_rlc()

2022-01-09 Thread Zhang, Hawking
[AMD Official Use Only] RE - Actually, for older asics, we shouldn't we be using mmINDEX/mmDATA rather than the pcie indirect registers? Or is that handled already somehow? I remember we checked this with hw team before (might two years ago when make the change in amdgpu_device_rreg/wreg helpe

RE: [PATCH] drm/amd/amdgpu: Add pcie indirect support to amdgpu_mm_wreg_mmio_rlc()

2022-01-07 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tom St Denis Sent: Friday, January 7, 2022 20:08 To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH] drm/amd/amdgpu: Add pcie indirect support to amdgpu_mm

RE: [PATCH V3 12/12] drm/amdgpu: Removed redundant ras code

2021-12-28 Thread Zhang, Hawking
@lists.freedesktop.org Cc: Zhou1, Tao ; Zhang, Hawking ; Clements, John ; Chai, Thomas ; Chai, Thomas Subject: [PATCH V3 12/12] drm/amdgpu: Removed redundant ras code Removed redundant ras code. Signed-off-by: yipechai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 82 ++--- 1

RE: [PATCH] drm/amdkfd: enable sdma ecc interrupt event can be handled by event_interrupt_wq_v9

2021-12-28 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of yipechai Sent: Wednesday, December 29, 2021 10:39 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Zhang, Hawking ; Clements, John ; Chai, Thomas ; Chai, Thomas

RE: [PATCH] drm/amdgpu: add support for IP discovery gc_info table v2

2021-12-16 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, December 16, 2021 11:18 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu: add support for IP discovery gc_i

RE: [PATCH 3/4] drm/amdkfd: add reset queue function for RAS poison

2021-12-16 Thread Zhang, Hawking
: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Thursday, December 16, 2021 19:36 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley ; Chai, Thomas ; Kuehling, Felix Cc: Zhou1, Tao Subject: [PATCH 3/4] drm/amdkfd: add reset queue function for

RE: [PATCH] drm/amd/pm: Fix xgmi link control on aldebaran

2021-12-15 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Wednesday, December 15, 2021 23:50 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Yang, Stanley Subject: [PATCH] drm/amd/pm: Fix xgmi link control on aldebaran Fix the

RE: [PATCH 3/3] drm/amdkfd: reset queue which consumes RAS poison

2021-12-13 Thread Zhang, Hawking
ktop.org; Zhang, Hawking ; Yang, Stanley ; thomas.c...@amd.com; Kuehling, Felix Cc: Zhou1, Tao Subject: [PATCH 3/3] drm/amdkfd: reset queue which consumes RAS poison CP supports unmap queue with reset mode which only destroys specific queue without affecting others. Replacing whole gpu reset wi

RE: [PATCH] drm/amdgpu: Remove the redundant code of psp bootloader functions

2021-12-08 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Feel free to talk with Likun to get a sienna_cichlid board for the testing. Regards, Hawking -Original Message- From: Chai, Thomas Sent: Wednesday, December 8, 2021 18:43 To: amd-gfx@lists.freedesktop.org Cc: Chai, Thomas ; Zhang

RE: [PATCH] drm/amdgpu: enable RAS poison flag when GPU is connected to CPU

2021-12-07 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Wednesday, December 8, 2021 14:20 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Ziya, Mohammad zafar Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: enable RAS poison

RE: [PATCH Review 1/1] drm/amdgpu: skip umc ras error count harvest

2021-12-06 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Stanley.Yang Sent: Tuesday, December 7, 2021 14:40 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Zhou1, Tao ; Li, Candice ; Chai, Thomas Cc: Yang, Stanley Subject

RE: [PATCH 4/4] drm/amdgpu: read and authenticate ip discovery binary

2021-12-06 Thread Zhang, Hawking
[AMD Official Use Only] Please ignore this one (patch #4). Will send out a new one based on latest code. Regards, Hawking -Original Message- From: Zhang, Hawking Sent: Saturday, December 4, 2021 18:21 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH 4/4] drm

RE: [PATCH Review 1/1] drm/amdgpu: only skip get ecc info for aldebaran

2021-12-02 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Stanley.Yang Sent: Friday, December 3, 2021 13:30 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Zhou1, Tao ; Li, Candice ; Chai, Thomas Cc: Yang, Stanley Subject

RE: [PATCH Review 1/2] drm/amdgpu: skip query ecc info in gpu recovery

2021-12-02 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Stanley.Yang Sent: Thursday, December 2, 2021 16:02 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Zhou1, Tao ; Li, Candice ; Chai, Thomas Cc: Yang, Stanley Subject

RE: [PATCH] drm/amdgpu: Don't halt RLC on GFX suspend

2021-11-29 Thread Zhang, Hawking
[AMD Official Use Only] Good catch. Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Monday, November 29, 2021 16:12 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Yang, Stanley ; Clements, John ; Zhou1, Tao Subject

RE: [PATCH Review 1/1] drm/amdgpu: adjust ip block add sequence on aldebaran

2021-11-28 Thread Zhang, Hawking
org; Zhang, Hawking ; Clements, John ; Zhou1, Tao Cc: Yang, Stanley Subject: [PATCH Review 1/1] drm/amdgpu: adjust ip block add sequence on aldebaran Reason: { [ 578.019986] amdgpu :23:00.0: amdgpu: GPU reset begin! [ 583.245566] amdgpu :23:00.0: amdgpu: Failed to disable

RE: [PATCH Review 1/1] drm/amdgpu: adjust ip block suspend sequence on aldebaran to fix disable smu feature failure

2021-11-28 Thread Zhang, Hawking
feature failure on aldebaran" Regards, Hawking -Original Message- From: Stanley.Yang Sent: Monday, November 29, 2021 13:56 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Zhou1, Tao Cc: Yang, Stanley Subject: [PATCH Review 1/1] drm/amdgpu: adjust ip block

RE: [PATCH Review 1/1] drm/amdgpu: fix disable ras feature failed when unload drvier v2

2021-11-26 Thread Zhang, Hawking
[AMD Official Use Only] Thanks! Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Stanley.Yang Sent: Friday, November 26, 2021 21:26 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Zhou1, Tao ; Li, Candice ; Chai, Thomas Cc: Yang, Stanley

RE: [PATCH Review 1/1] drm/amdgpu: fix disable ras feature failed when unload drvier

2021-11-26 Thread Zhang, Hawking
[AMD Official Use Only] I suspect it is still needed, especially when amdgpu_ras_fini is used to deal with ras initialization failure in psp_ras_initialize. Regards, Hawking -Original Message- From: Yang, Stanley Sent: Friday, November 26, 2021 21:08 To: Zhang, Hawking ; amd-gfx

RE: [PATCH Review 1/1] drm/amdgpu: fix disable ras feature failed when unload drvier

2021-11-26 Thread Zhang, Hawking
con->features) - amdgpu_ras_disable_all_features(adev, 1); - cancel_delayed_work_sync(&con->ras_counte_delay_work); Regards, Hawking -Original Message- From: Stanley.Yang Sent: Friday, November 26, 2021 17:48 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements,

RE: [PATCH] drm/amdgpu: Skip ASPM programming on aldebaran

2021-11-24 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Wednesday, November 24, 2021 19:35 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Pawar, Ashish ; Deucher, Alexander Subject: [PATCH] drm/amdgpu: Skip ASPM

RE: 回复: [PATCH Review 3/4] drm/amdgpu: add message smu to get ecc_table v2

2021-11-18 Thread Zhang, Hawking
[AMD Official Use Only] Series looks good to me. Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Thursday, November 18, 2021 22:41 To: Yang, Stanley ; amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Quan, Evan ; Wang, Yang

RE: [PATCH] drm/amdgpu: support new mode-1 reset interface

2021-11-15 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Tuesday, November 16, 2021 15:24 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Yang, Stanley ; Quan, Evan Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu: correct xgmi ras error count reset

2021-11-04 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Thursday, November 4, 2021 17:01 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Yang, Stanley Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: correct xgmi

RE: [PATCH] drm/amdgpu: use correct register mask to extract field

2021-10-29 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Wang, Yang(Kevin) Sent: Friday, October 29, 2021 15:17 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Min, Frank ; Lazar, Lijo ; Oak Zeng ; Zhang, Hawking Subject: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu: remove GPRs init for ALDEBARAN in gpu reset (v3)

2021-10-26 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Tuesday, October 26, 2021 19:19 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: remove GPRs init for ALDEBARAN in gpu reset (v3

RE: [PATCH] drm/amdgpu: remove GPRs init for ALDEBARAN in gpu reset (v2)

2021-10-26 Thread Zhang, Hawking
[AMD Official Use Only] S3/S4 needs re-run the shader. So let's just skip mode-1 reset. Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Tuesday, October 26, 2021 18:33 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: r

RE: [PATCH] drm/amdgpu: remove GPRs init for ALDEBARAN

2021-10-26 Thread Zhang, Hawking
[AMD Official Use Only] The change breaks initialization as well. shall we check in_gpu_reset to exclude reset case? Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Tuesday, October 26, 2021 17:27 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking Cc: Zhou1, Tao Subject

RE: [PATCH] drm/amdgpu: skip GPRs init for some CU settings on ALDEBARAN

2021-10-25 Thread Zhang, Hawking
[AMD Official Use Only] Please add inline comment to remind us remove this workaround later. Other than the patch is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Monday, October 25, 2021 16:56 To: amd-gfx@lists.freedesktop.org; Zhang

RE: [PATCH 2/2] drm/amdgpu: output warning for unsupported ras error inject (v2)

2021-10-18 Thread Zhang, Hawking
[AMD Official Use Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Monday, October 18, 2021 18:50 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Yang, Stanley Cc: Zhou1, Tao Subject: [PATCH 2/2] drm/amdgpu

RE: [PATCH] drm/amdgpu: output warning for unsupported ras error inject

2021-10-15 Thread Zhang, Hawking
[AMD Official Use Only] Would it better create a function to interpret the RAS TA error? I expect more error status is available soon? Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Friday, October 15, 2021 17:11 To: amd-gfx@lists.freedesktop.org; Clements, John ; Zhang

RE: [PATCH] drm/amdgpu: load PSP RL in resume path

2021-10-15 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Friday, October 15, 2021 15:28 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Yang, Stanley Cc: Zhou1, Tao Subject: [PATCH] drm

RE: [PATCH] V2: drm/amdgpu: resolve RAS query bug

2021-09-29 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking From: Clements, John Sent: Wednesday, September 29, 2021 15:03 To: Clements, John ; amd-gfx@lists.freedesktop.org; Zhang, Hawking Subject: RE: [PATCH] V2: drm/amdgpu: resolve RAS query bug [AMD Official Use Only] Updated patch with simpler

RE: [PATCH] drm/amdgpu: resolve RAS query bug

2021-09-29 Thread Zhang, Hawking
Thanks John! Let's try to use amdgpu_ras_query_error_status for that purpose Regards, Hawking From: Clements, John Sent: Wednesday, September 29, 2021 14:07 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking Subject: [PATCH] drm/amdgpu: resolve RAS query bug [AMD Official Use Only] Submi

RE: [PATCH] amd/amdkfd: add ras page retirement handling for sq/sdma (v3)

2021-09-28 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Tuesday, September 28, 2021 15:08 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Joshi, Mukul ; Kuehling, Felix ; Yang, Stanley Cc: Zhou1, Tao Subject: [PATCH] amd

RE: [PATCH] drm/amdgpu: add poison mode query for DF (v2)

2021-09-25 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Sunday, September 26, 2021 10:38 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH] drm/amdgpu: add poison mode query for DF (v2) Add ras poi

RE: [PATCH] drm/amd/pm: Update intermediate power state for SI

2021-09-23 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Thursday, September 23, 2021 12:30 To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Hawking ; Wang, Yang(Kevin) ; Feng, Kenneth ; Quan, Evan Subject

RE: [PATCH] drm/amdgpu: Consolidate RAS cmd warning messages

2021-09-23 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking From: Clements, John Sent: Thursday, September 23, 2021 16:30 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking Subject: [PATCH] drm/amdgpu: Consolidate RAS cmd warning messages [AMD Official Use Only] Submitting patch to

RE: [PATCH 2/3] drm/amdgpu: set poison supported flag for RAS (v2)

2021-09-22 Thread Zhang, Hawking
[AMD Official Use Only] Might be better call the function is_poison_mode_supported. Other than that the series is Reviewed-by: Hawking Zhang -Original Message- From: Zhou1, Tao Sent: Wednesday, September 22, 2021 18:33 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements

RE: [PATCH 3/3] drm/amdgpu: skip umc ras irq handling in poison mode (v2)

2021-09-22 Thread Zhang, Hawking
2, 2021 18:33 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Yang, Stanley Cc: Zhou1, Tao Subject: [PATCH 3/3] drm/amdgpu: skip umc ras irq handling in poison mode (v2) In ras poison mode, umc uncorrectable error will be ignored until the corrupted data consumed by another ras module

RE: [PATCH 3/3] drm/amdgpu: skip umc ras irq handling in poison mode

2021-09-18 Thread Zhang, Hawking
user poison creation event (i.e. leveraging umc error address look up and convert function to get the physical address, explicitly highlight this in kernel message) thoughts? Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Saturday, September 18, 2021 16:08 To: amd-g

RE: [PATCH 1/3] drm/amdgpu: add poison mode query for UMC

2021-09-18 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Saturday, September 18, 2021 16:08 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Clements, John ; Yang, Stanley Cc: Zhou1, Tao Subject: [PATCH 1/3] drm/amdgpu: add

RE: [PATCH 2/3] drm/amdgpu: set poison mode for RAS

2021-09-18 Thread Zhang, Hawking
hese flags are set in enable_feature command per IP block if needed. Instead of global setting at firmware/TA initialization phase, thoughts? Regards, Hawking -Original Message- From: Zhou1, Tao Sent: Saturday, September 18, 2021 16:08 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ;

RE: Subject: [PATCH 1/1] drm/amdgpu: Update RAS trigger error block support

2021-09-09 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking From: Clements, John Sent: Thursday, September 9, 2021 15:59 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Candice Subject: Subject: [PATCH 1/1] drm/amdgpu: Update RAS trigger error block support [AMD Official

RE: [PATCH] drm/amdgpu: Update RAS status print

2021-09-09 Thread Zhang, Hawking
gfx@lists.freedesktop.org; Zhang, Hawking ; Li, Candice Subject: [PATCH] drm/amdgpu: Update RAS status print [AMD Official Use Only] Submitting patch to remove parser for RAS status response codes and just print RAS status value on non-zero value

RE: [PATCH] drm/amdgpu: refactor function to init no-psp fw

2021-09-09 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Gao, Likun Sent: Thursday, September 9, 2021 15:15 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Gao, Likun Subject: [PATCH] drm/amdgpu: refactor function to init no-psp fw From

RE: [PATCH] drm/amdgpu: Clear RAS interrupt status on aldebaran

2021-08-26 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking From: Clements, John Sent: Thursday, August 26, 2021 14:55 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking Subject: [PATCH] drm/amdgpu: Clear RAS interrupt status on aldebaran [AMD Official Use Only] Submittng patch to

RE: [PATCH] amd/amdkfd: add ras page retirement handling for sq/sdma interrupt

2021-08-24 Thread Zhang, Hawking
[AMD Official Use Only] How about we add a new member in ras context (amdgpu_ras) to indicate the poison consumption handling mode/approach? In such way, we can initialize that member per ASIC. Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Zhang, Hawking Sent

RE: [PATCH] amd/amdkfd: add ras page retirement handling for sq/sdma interrupt

2021-08-24 Thread Zhang, Hawking
- From: Zhou1, Tao Sent: Tuesday, August 24, 2021 16:43 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; Yang, Stanley ; Clements, John ; Kuehling, Felix Cc: Zhou1, Tao Subject: [PATCH] amd/amdkfd: add ras page retirement handling for sq/sdma interrupt In ras poison mode, page retirement will

RE: [PATCH] drm/amdgpu: Update RAS XGMI Error Query

2021-08-23 Thread Zhang, Hawking
; Zhang, Hawking Subject: [PATCH] drm/amdgpu: Update RAS XGMI Error Query [AMD Official Use Only] Submitting patch to resolve RAS XGMI error query issue Thank you, John Clements

RE: [PATCH 2/2] drm/amd/pm: change the workload type for some cards

2021-08-13 Thread Zhang, Hawking
[AMD Official Use Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Kenneth Feng Sent: Friday, August 13, 2021 16:48 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Feng, Kenneth Subject: [PATCH 2/2] drm/amd/pm: change the workload type for

RE: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS

2021-08-04 Thread Zhang, Hawking
[Public] The patch is Reviewed-by: Hawking Zhang Regards, Hawking From: Clements, John Sent: Wednesday, August 4, 2021 17:14 To: Clements, John ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: RE: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS [AMD Official Use Only

RE: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS

2021-08-04 Thread Zhang, Hawking
, August 4, 2021 16:48 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: set RAS EEPROM address from VBIOS [AMD Official Use Only] Submitting patch to get RAS EEPROM I2C address from VBIOS FW info table. Thank you, John Clements

RE: [PATCH] drm/amdgpu: adjust fence driver enable sequence

2021-07-28 Thread Zhang, Hawking
- From: Gao, Likun Sent: Wednesday, July 28, 2021 12:08 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Gao, Likun Subject: [PATCH] drm/amdgpu: adjust fence driver enable sequence From: Likun Gao Fence driver was enabled per ring when sw init on per IP block before. Change to enable all

RE: [PATCH] drm/amdgpu: update golden setting for sienna_cichlid

2021-07-15 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Gao, Likun Sent: Thursday, July 15, 2021 12:11 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Chen, Guchun ; Gao, Likun Subject: [PATCH] drm/amdgpu: update golden setting for

Recall: [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset

2021-07-13 Thread Zhang, Hawking
Zhang, Hawking would like to recall the message, "[PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset". ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset

2021-07-13 Thread Zhang, Hawking
[AMD Official Use Only] Yeah, seems like switching the smtp server helps. Someone sents notes to brahma_sw_dev. Regards, Hawking From: Christian König Sent: Tuesday, July 13, 2021 19:03 To: Zhang, Hawking ; Clements, John ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu

RE: [PATCH] drm/amdgpu: Resolve bug in UMC 6.7 UMC error offset

2021-07-13 Thread Zhang, Hawking
[AMD Official Use Only] Let's submit the quick fix first and then work out better naming styles to fix confusing The patch is Reviewed-by: Hawking Zhang Regards, Hawking From: Clements, John Sent: Tuesday, July 13, 2021 17:37 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Su

RE: [PATCH] drm/amdgpu: add non-aligned address supported in amdgpu_device_vram_access()

2021-06-28 Thread Zhang, Hawking
[AMD Official Use Only] Add @Min, Frank for the review. Regards, Hawking From: amd-gfx On Behalf Of Wang, Kevin(Yang) Sent: Monday, June 28, 2021 10:44 To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH] dr

RE: [PATCH Review 1/1] drm/amdgpu: force enable vega20 gaming sku gfx ras

2021-06-16 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Let's just say add vega20 to ras quirk list. Regards, Hawking -Original Message- From: Stanley.Yang Sent: Wednesday, June 16, 2021 20:31 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking Cc: Yang, Stanley Subject: [PATCH Revie

RE: [PATCH Review 1/1] drm/amdgpu: fix bad address translation for sienna_cichlid

2021-06-16 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Stanley.Yang Sent: Wednesday, June 16, 2021 21:23 To: amd-gfx@lists.freedesktop.org; Zhang, Hawking Cc: Yang, Stanley Subject: [PATCH Review 1/1] drm/amdgpu: fix bad address translation for

RE: [PATCH] drm/amdgpu: enable support error injection broadcast to all instances

2021-06-11 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Dennis Li Sent: Friday, June 11, 2021 15:16 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Kuehling, Felix ; Zhang, Hawking ; Koenig, Christian Cc: Li, Dennis Subject: [PATCH] drm

<    1   2   3   4   5   6   7   8   9   10   >