Re: [PATCH 5/6] drm/amdgpu: implement grab dedicated vmid V2

On 04/26/2017 07:10 PM, Chunming Zhou wrote: v2: move sync waiting only when flush needs Change-Id: I64da2701c9fdcf986afb90ba1492a78d5bef1b6c Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 61 ++ 1 file changed,

Re: [PATCH 3/6] drm/amdgpu: reserve/unreserve vmid by vm ioctl v3

On 04/27/2017 10:13 AM, zhoucm1 wrote: On 2017年04月26日 20:26, Christian König wrote: Am 26.04.2017 um 13:10 schrieb Chunming Zhou: add reserve/unreserve vmid funtions. v3: only reserve vmid from gfxhub Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou

Re: [PATCH 3/6] drm/amdgpu: reserve/unreserve vmid by vm ioctl v3

On 04/26/2017 08:26 PM, Christian König wrote: Am 26.04.2017 um 13:10 schrieb Chunming Zhou: add reserve/unreserve vmid funtions. v3: only reserve vmid from gfxhub Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou ---

Re: [PATCH 3/6] drm/amdgpu: reserve vmid by vm ioctl

On 04/26/2017 04:51 PM, Christian König wrote: Am 26.04.2017 um 09:09 schrieb Zhang, Jerry (Junwei): On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou <david1.z...@amd.com> --- drivers/gpu/drm/amd/

Re: [PATCH 3/6] drm/amdgpu: reserve vmid by vm ioctl

On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: I5f80dc39dc9d44660a96a2b710b0dbb4d3b9039d Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 56 ++ 1 file changed, 56 insertions(+) diff --git

Re: [PATCH 2/6] drm/amdgpu: add dedicated vmid field in vm struct

On 04/24/2017 01:57 PM, Chunming Zhou wrote: Change-Id: Id728e20366c8a1ae90d4e901dc80e136e2a613bb Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 17 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 2 ++ 2 files changed, 18

Re: [PATCH 4/6] drm/amdgpu: add limitation for dedicated vm number v2

On 04/24/2017 01:57 PM, Chunming Zhou wrote: v2: move #define to amdgpu_vm.h Change-Id: Ie5958cf6dbdc1c8278e61d9158483472d6f5c6e3 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +

Re: [PATCH] drm/amdgpu: extend vm flags to 64-bit in tracepoint

On 04/24/2017 04:56 PM, Christian König wrote: Am 24.04.2017 um 10:55 schrieb Christian König: Am 24.04.2017 um 08:43 schrieb Junwei Zhang: Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 18 +- 1 file changed, 9

Re: [PATCH v2] drm/amdgpu: PRT support for gfx9 (v2)

On 04/19/2017 07:40 PM, Christian König wrote: Am 19.04.2017 um 10:10 schrieb Zhang, Jerry (Junwei): On 04/19/2017 03:28 PM, Christian König wrote: Am 19.04.2017 um 03:53 schrieb Junwei Zhang: v2: unify PRT bit for all ASICs Signed-off-by: Junwei Zhang <jerry.zh...@amd.com> Acked-by:

Re: [PATCH] drm/amdgpu: fix amdgpu_vm_clear_freed

On 04/20/2017 01:49 PM, Zhang, Jerry (Junwei) wrote: On 04/19/2017 10:07 PM, Christian König wrote: From: Christian König <christian.koe...@amd.com> Use amdgpu_vm_bo_update_mapping() instead of amdgpu_vm_bo_split_mapping() here. We don't want any flags set in the cleared areas and spl

Re: [PATCH] drm/amdgpu: fix amdgpu_vm_clear_freed

On 04/19/2017 10:07 PM, Christian König wrote: From: Christian König Use amdgpu_vm_bo_update_mapping() instead of amdgpu_vm_bo_split_mapping() here. We don't want any flags set in the cleared areas and splitting should be unnecessary. Yeah, the mappings in the

Re: [PATCH v2] drm/amdgpu: PRT support for gfx9 (v2)

On 04/19/2017 03:28 PM, Christian König wrote: Am 19.04.2017 um 03:53 schrieb Junwei Zhang: v2: unify PRT bit for all ASICs Signed-off-by: Junwei Zhang Acked-by: David Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 +

Re: [PATCH 3/3] drm/amdgpu: move gtt usage statistic to gtt mgr

On 04/19/2017 11:50 AM, Chunming Zhou wrote: Change-Id: Ifea42c8ae2206143d7e22b35eea537ba9e928fe8 Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 13 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 6 -- 2 files changed,

Re: [PATCH] drm/amdgpu: PRT support for gfx9

On 04/18/2017 07:25 PM, Nicolai Hähnle wrote: On 18.04.2017 05:13, Zhang, Jerry (Junwei) wrote: On 04/18/2017 10:47 AM, zhoucm1 wrote: On 2017年04月18日 09:51, Zhang, Jerry (Junwei) wrote: Anyone could help to review it? On 04/17/2017 05:04 PM, Junwei Zhang wrote: Signed-off-by: Junwei

Re: [PATCH] drm/amdgpu: PRT support for gfx9

On 04/18/2017 10:47 AM, zhoucm1 wrote: On 2017年04月18日 09:51, Zhang, Jerry (Junwei) wrote: Anyone could help to review it? On 04/17/2017 05:04 PM, Junwei Zhang wrote: Signed-off-by: Junwei Zhang <jerry.zh...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 + drivers/g

Re: [PATCH] drm/amdgpu: PRT support for gfx9

Anyone could help to review it? On 04/17/2017 05:04 PM, Junwei Zhang wrote: Signed-off-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 + drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 1 + drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- 3 files changed,

Re: [PATCH] drm/amdgpu: fix "fix 64bit division"

On 04/07/2017 04:44 PM, Christian König wrote: From: Christian König The offset must be 64bit and add back the accidential dropped line. Signed-off-by: Christian König Reviewed-by: Junwei Zhang ---

Re: [PATCH] drm/amdgpu:fix psp ip block patch

On 04/06/2017 03:31 PM, Monk Liu wrote: should use kernel parm to judge instead of adev member, which hasn't been set at that time Change-Id: I58c83a8615cd4a54440c9de038e45bb70802cc2c Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +- 1 file changed, 1

Re: [PATCH] drm/amdgpu: fix compile warning

On 04/07/2017 03:56 AM, Alex Xie wrote: warning: comparison of distinct pointer types lacks a cast Thanks for your patch. I have fixed it. Please check in our branch. Jerry Change-Id: I317eddd1bd430c98a3c50ec170f592f944081a6e Signed-off-by: Alex Xie ---

Re: [PATCH] drm/amdgpu: set vm size and block size by individual gmc by default

Thanks you all for the comments Updated the v2, please help review On 04/05/2017 09:39 PM, Christian König wrote: Am 05.04.2017 um 15:32 schrieb Alex Deucher: On Wed, Apr 5, 2017 at 5:01 AM, Christian König wrote: Am 05.04.2017 um 08:43 schrieb Junwei Zhang: By

Re: [PATCH] drm/amdgpu: fix vm size and block size for VMPT (v3)

On 04/05/2017 10:27 AM, Alex Deucher wrote: On Tue, Apr 4, 2017 at 10:11 PM, Zhang, Jerry (Junwei) <jerry.zh...@amd.com> wrote: On 04/04/2017 03:34 AM, Deucher, Alexander wrote: -Original Message- From: Junwei Zhang [mailto:jerry.zh...@amd.com] Sent: Friday, March 31, 2017 10

Re: [PATCH 1/8] drm/amdgpu: fix VMHUB order to match the hardware

On 04/04/2017 03:23 AM, Alex Deucher wrote: On Mon, Apr 3, 2017 at 8:39 AM, Christian König wrote: From: Christian König Match our defines with what the hw uses. Signed-off-by: Christian König Patches 1-4, 6-7:

Re: [PATCH] drm/amdgpu: fix vm size and block size for VMPT (v3)

On 04/04/2017 03:34 AM, Deucher, Alexander wrote: -Original Message- From: Junwei Zhang [mailto:jerry.zh...@amd.com] Sent: Friday, March 31, 2017 10:44 PM To: Deucher, Alexander; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; Zhang, Jerry Subject: [PATCH] drm/amdgpu: fix vm size

Re: [PATCH] drm/amdgpu/soc15: Fix static checker warnings

On 04/04/2017 07:02 AM, Harry Wentland wrote: Reviewed-by: Harry Wentland Reviewed-by: Junwei Zhang On 2017-04-03 04:58 PM, Alex Deucher wrote: vega10 is the only soc15 asic at the moment so these warnings are invalid, but add a default case

Re: [PATCH 1/2 v2] drm/amdgpu: fix vm size and block size for Vega10 VMPT

On 03/31/2017 12:05 PM, Deucher, Alexander wrote: -Original Message- From: Junwei Zhang [mailto:jerry.zh...@amd.com] Sent: Thursday, March 30, 2017 10:52 PM To: Deucher, Alexander; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; Zhang, Jerry Subject: [PATCH 1/2 v2] drm/amdgpu: fix

Re: [PATCH 2/2] drm/amdgpu: set vm size as 256TB for Vega10

On 03/29/2017 10:27 PM, Christian König wrote: Am 29.03.2017 um 16:17 schrieb Alex Deucher: On Wed, Mar 29, 2017 at 4:47 AM, Christian König wrote: Am 29.03.2017 um 10:08 schrieb Junwei Zhang: Signed-off-by: Junwei Zhang ---

Re: [PATCH v2] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma (v2)

On 03/29/2017 11:24 PM, Deucher, Alexander wrote: -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Junwei Zhang Sent: Wednesday, March 29, 2017 3:19 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry Subject: [PATCH v2] drm/amdgpu: fix vm

Re: [PATCH] drm/amdgpu: Fix multi-level page table bugs for large BOs v3

On 03/30/2017 02:07 AM, Felix Kuehling wrote: On 17-03-29 01:40 PM, Christian König wrote: Am 29.03.2017 um 19:22 schrieb Felix Kuehling: Fix the start/end address calculation for address ranges that span multiple page directories in amdgpu_vm_alloc_levels. Add error messages if page tables

Re: [PATCH] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma v4

On 03/28/2017 06:06 PM, Christian König wrote: Am 28.03.2017 um 10:55 schrieb Junwei Zhang: Signed-off-by: Junwei Zhang Good catch, patch is Reviewed-by: Christian König . It doesn't matter for older versions because they don't have flags in

Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs

On 03/29/2017 02:52 PM, Christian König wrote: Am 29.03.2017 um 07:58 schrieb Zhang, Jerry (Junwei): Hi Felix, Thanks for your illustration with patience. I got your meaning then, and thanks to fix that. > I think you're right, there are some extra high bits in saddr and eaddr, but > th

Re: [PATCH 0/3] Fixes for multi-level page tables

On 03/29/2017 02:00 PM, Zhang, Jerry (Junwei) wrote: On 03/29/2017 09:00 AM, Felix Kuehling wrote: I worked on these fixes on amd-kfd-staging with a merge of the recent multi- level page table changes. With these changes KFDTest passes on Vega10, including some tests that tend to stress VM

Re: [PATCH 2/3] drm/amdgpu: Fix Vega10 VM initialization

On 03/29/2017 02:47 PM, Christian König wrote: Am 29.03.2017 um 03:48 schrieb Felix Kuehling: On 17-03-28 09:39 PM, Zhang, Jerry (Junwei) wrote: On 03/29/2017 09:00 AM, Felix Kuehling wrote: adev->family is not initialized yet when amdgpu_get_block_size is called. Use adev->asic_type i

Re: [PATCH 0/3] Fixes for multi-level page tables

On 03/29/2017 09:00 AM, Felix Kuehling wrote: I worked on these fixes on amd-kfd-staging with a merge of the recent multi- level page table changes. With these changes KFDTest passes on Vega10, including some tests that tend to stress VM memory management. They applied cleanly to current

Re: [PATCH 2/3] drm/amdgpu: Fix Vega10 VM initialization

On 03/29/2017 09:48 AM, Felix Kuehling wrote: On 17-03-28 09:39 PM, Zhang, Jerry (Junwei) wrote: On 03/29/2017 09:00 AM, Felix Kuehling wrote: adev->family is not initialized yet when amdgpu_get_block_size is called. Use adev->asic_type instead. Minimum VM size is 512GB, not

Re: [PATCH 3/3] drm/amdgpu: Fix multi-level page table bugs for large BOs

On 03/29/2017 09:00 AM, Felix Kuehling wrote: Fix the start/end address calculation for address ranges that span multiple page directories in amdgpu_vm_alloc_levels. Add WARN_ONs if page tables aren't found. Otherwise the page table update would just fail silently. Signed-off-by: Felix

Re: [PATCH] drm/amd/amdgpu: fix Tonga S3 resume hang on rhel6.8

On 03/28/2017 05:27 PM, Jim Qu wrote: 1. security firmware loading has moved to sw init, so this code is useless. 2. it seems that driver could not call request_firmware on kernel 2.6, when S3 resume. for request firmware depends on userspace, at this time, userspace is freeze.

Re: [PATCH] drm/amdgpu: Fix 32bit x86 compilation warning

On 03/29/2017 02:37 AM, Alex Xie wrote: drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c:187:2: warning: right shift count >= width of type [enabled by default] drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c:173:2: warning: right shift count >= width of type [enabled by default]

Re: [PATCH] drm/amdgpu: Improve Vega10 VM fault handling

Vega10 VM fault handling On 17-03-27 09:23 PM, Zhang, Jerry (Junwei) wrote: > > > On 03/28/2017 06:25 AM, Felix Kuehling wrote: >> Register AMDGPU_IH_CLIENTID_UTCL2 as a source of VM faults. Clean >> up the VM fault message format and use rate-limiting similar to >> ot

Re: [PATCH] drm/amdgpu: one pde of 4 levels at least 512GB

On 03/28/2017 11:46 AM, Chunming Zhou wrote: Change-Id: I9d764e6e6cf214e64bd79435a8bbb4063260dc11 Signed-off-by: Chunming Zhou Reviewed-by: Junwei Zhang For the minimum size, PD is 0 --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 8 1 file

Re: [PATCH 00/15] *** Multiple level VMPT enablement ***

On 03/28/2017 12:05 AM, Deucher, Alexander wrote: -Original Message- From: Koenig, Christian Sent: Monday, March 27, 2017 5:37 AM To: Zhou, David(ChunMing); amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: Re: [PATCH 00/15] *** Multiple level VMPT enablement *** Hi David,

Re: [PATCH 05/15] drm/amdgpu: handle multi level PD size calculation

On 03/27/2017 01:53 PM, Chunming Zhou wrote: From: Christian König Allows us to get the size for all levels as well. Change-Id: Iaf2f9b2bf19c3623018a2215f8cf01a61bdbe8ea Signed-off-by: Christian König Reviewed-by: Alex Deucher

Re: [PATCH libdrm] amdgpu: stop reading CC_RB_BACKEND_DISABLE on Vega10

On 03/27/2017 09:44 PM, Christian König wrote: From: Christian König Follow up to 'drm: don't access deprecated register on Vega10'. The same information is available in enabled_rb_pipes_mask and reading that register can cause GRBM bus problems. Signed-off-by:

Re: [PATCH] drm/amdgpu: Improve Vega10 VM fault handling

On 03/28/2017 06:25 AM, Felix Kuehling wrote: Register AMDGPU_IH_CLIENTID_UTCL2 as a source of VM faults. Clean up the VM fault message format and use rate-limiting similar to other ASICs. Signed-off-by: Felix Kuehling May be better to split it into 2 patches

Re: [PATCH 09/13] drm/amdgpu:fix gmc_v9 vm fault process for SRIOV

On 03/27/2017 02:39 PM, Christian König wrote: Am 27.03.2017 um 03:51 schrieb Zhang, Jerry (Junwei): On 03/24/2017 06:38 PM, Monk Liu wrote: for SRIOV we cannot use access register when in IRQ routine with regular KIQ method Change-Id: Ifae3164cf12311b851ae131f58175f6ec3174f82 Signed-off

Re: [PATCH 09/13] drm/amdgpu:fix gmc_v9 vm fault process for SRIOV

On 03/24/2017 06:38 PM, Monk Liu wrote: for SRIOV we cannot use access register when in IRQ routine with regular KIQ method Change-Id: Ifae3164cf12311b851ae131f58175f6ec3174f82 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 24

Re: Question about page table updates at BO destroy

On 03/23/2017 09:07 PM, Nicolai Hähnle wrote: Hi Jerry, On 23.03.2017 03:26, Zhang, Jerry (Junwei) wrote: On 03/22/2017 11:06 PM, Nicolai Hähnle wrote: Hi all, there's a bit of a puzzle where I'm wondering whether there's a subtle bug in the amdgpu kernel module. Basically, the concern

Re: [PATCH v2 2/2] drm/amdgpu: clear freed mappings immediately when BO may be freed

On 03/24/2017 11:42 AM, Zhang, Jerry (Junwei) wrote: On 03/24/2017 03:27 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle <nicolai.haeh...@amd.com> Also, add the fence of the clear operations to the BO to ensure that the underlying memory can only be re-used after all PTEs pointing to i

Re: [PATCH v2 2/2] drm/amdgpu: clear freed mappings immediately when BO may be freed

On 03/24/2017 03:27 AM, Nicolai Hähnle wrote: From: Nicolai Hähnle Also, add the fence of the clear operations to the BO to ensure that the underlying memory can only be re-used after all PTEs pointing to it have been cleared. This avoids the following sequence of

Re: [PATCH v2 1/2] drm/amdgpu: add optional fence out-parameter to amdgpu_vm_clear_freed

On 03/24/2017 10:30 AM, zhoucm1 wrote: On 2017年03月24日 03:27, Nicolai Hähnle wrote: From: Nicolai Hähnle We will add the fence to freed buffer objects in a later commit, to ensure that the underlying memory can only be re-used after all references in page tables have

Re: [PATCH 046/100] drm/amdgpu: Add GMC 9.0 support

Hi Alex, I remember we had a patch to remove the FB location programming in gmc/vmhub. I saw it's not in gmc v9 in this patch, but pre-gmcv9 still program FB register. Is that any missing for sync here? Or it's only supported for gmc v9 now. Jerry On 03/21/2017 04:29 AM, Alex Deucher wrote:

Re: Question about page table updates at BO destroy

On 03/22/2017 11:06 PM, Nicolai Hähnle wrote: Hi all, there's a bit of a puzzle where I'm wondering whether there's a subtle bug in the amdgpu kernel module. Basically, the concern is that a buggy user space driver might trigger a sequence like this: 1. Submit a CS that accesses some BO

Re: [PATCH 1/2] amdgpu: add new VA operations CLEAR and REPLACE

On 03/21/2017 09:30 PM, Nicolai Hähnle wrote: This should use the proper procedure for updating amdgpu_drm.h, as explained in include/drm/README. I can take care of this as soon as all the kernel patches for PRT are in a tree that doesn't rebase (i.e. agd5f/drm-next-4.12 or airlied/drm-next).

<    1   2   3   4