RE: [PATCH] drm/amd/amdgpu: fix the inst passed to amdgpu_virt_rlcg_reg_rw

2024-05-22 Thread Zhao, Victor
to be fixed. Thanks, Victor -Original Message- From: Lazar, Lijo Sent: Wednesday, May 22, 2024 2:14 PM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amd/amdgpu: fix the inst passed to amdgpu_virt_rlcg_reg_rw [AMD Official Use Only - AMD Internal Distribution

RE: [PATCH] drm/amd/amdgpu: fix the inst passed to amdgpu_virt_rlcg_reg_rw

2024-05-21 Thread Zhao, Victor
[AMD Official Use Only - AMD Internal Distribution Only] Hi @Lazar, Lijo, Can you help review this? Thanks, Victor -Original Message- From: Victor Zhao Sent: Tuesday, May 21, 2024 12:08 AM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Zhao, Victor Subject: [PATCH] drm/amd

RE: [PATCH] drm/amd/amdgpu: fix the inst passed to reg read write under sriov

2024-05-20 Thread Zhao, Victor
20, 2024 8:02 PM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: fix the inst passed to reg read write under sriov On 5/20/2024 4:44 PM, Victor Zhao wrote: > the inst passed to reg read/write should be physical instance. > Fix the miss matche

RE: [PATCH] drm/amd/pm: Disallow managing power profiles on SRIOV for gc11.0.3

2023-09-27 Thread Zhao, Victor
[AMD Official Use Only - General] Ping on this patch. Please help review. Thanks, Victor -Original Message- From: Victor Zhao Sent: Tuesday, September 26, 2023 11:09 AM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Victor Subject: [PATCH] drm/amd/pm: Disallow managing power profiles

RE: [PATCH] drm/amdgpu: fix for suspend/resume sequence under sriov

2022-11-02 Thread Zhao, Victor
[AMD Official Use Only - General] Hi Alex, This is a patch fixing the sriov suspend/resume sequence. Please help review. Thanks, Victor -Original Message- From: Victor Zhao Sent: Thursday, November 3, 2022 12:06 PM To: amd-gfx@lists.freedesktop.org; Deucher, Alexander Cc: Zhao

RE: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow

2022-09-20 Thread Zhao, Victor
for now? Please help review this part. Thanks, Victor -Original Message- From: Grodzovsky, Andrey Sent: Monday, September 19, 2022 11:04 PM To: Zhao, Victor ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Cc: Deng, Emily Subject: Re: [PATCH 1/2] drm/amdgpu: fix deadlock caused

RE: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow

2022-09-16 Thread Zhao, Victor
? Or is it on VCE only? Thanks, Victor -Original Message- From: Grodzovsky, Andrey Sent: Friday, September 16, 2022 9:50 PM To: Koenig, Christian ; Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deng, Emily Subject: Re: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow On 2022-09-16 01

RE: [PATCH 2/2] drm/amdgpu: move enable irq later to avoid race with ih resume

2022-09-15 Thread Zhao, Victor
[AMD Official Use Only - General] Hi Lijo, Yes, this is what I observed in sienna cichlid. Thanks, Victor -Original Message- From: Lazar, Lijo Sent: Thursday, September 15, 2022 4:00 PM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deng, Emily ; Grodzovsky, Andrey

RE: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow

2022-09-15 Thread Zhao, Victor
situation. Another fix could be skip submitting jobs which already signaled during resubmit stage, which may look cleaner. Please help give some advice. Thanks, Victor -Original Message- From: Koenig, Christian Sent: Thursday, September 15, 2022 2:32 PM To: Zhao, Victor ; amd-gfx

RE: [PATCH 2/2] drm/amdgpu: move enable irq later to avoid race with ih resume

2022-09-15 Thread Zhao, Victor
Thanks, Victor -Original Message- From: Lazar, Lijo Sent: Thursday, September 15, 2022 1:58 PM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deng, Emily ; Grodzovsky, Andrey Subject: Re: [PATCH 2/2] drm/amdgpu: move enable irq later to avoid race with ih resume On 9/14

RE: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow

2022-09-14 Thread Zhao, Victor
:10 PM To: amd-gfx@lists.freedesktop.org Cc: Deng, Emily ; Grodzovsky, Andrey ; Zhao, Victor Subject: [PATCH 1/2] drm/amdgpu: fix deadlock caused by overflow [background] For a gpu recovery caused by a hang on one ring (e.g. compute), jobs from another ring (e.g. gfx) may continue signaling

RE: [PATCH v2 6/6] drm/amdgpu: reduce reset time

2022-07-29 Thread Zhao, Victor
[AMD Official Use Only - General] Hi Lijo, Can you be more specific why other gpus can be affected? I don’t have a xgmi system on my side. I thought reset_domain is per device. Thanks, Victor -Original Message- From: Lazar, Lijo Sent: Friday, July 29, 2022 2:11 PM To: Zhao

RE: [PATCH v2 1/6] drm/amdgpu: add mode2 reset for sienna_cichlid

2022-07-29 Thread Zhao, Victor
[AMD Official Use Only - General] Thanks for catching. Thanks, Victor -Original Message- From: Quan, Evan Sent: Friday, July 29, 2022 2:06 PM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deng, Emily ; Zhao, Victor ; Grodzovsky, Andrey Subject: RE: [PATCH v2 1/6] drm

RE: [PATCH 5/5] drm/amdgpu: reduce reset time

2022-07-27 Thread Zhao, Victor
timeout reported on gfx/comp ring. And this will require some logic to map the relationship for ring and ip blocks. This way does not look good as well. Thanks, Victor -Original Message- From: Grodzovsky, Andrey Sent: Wednesday, July 27, 2022 12:57 AM To: Zhao, Victor ; amd-gfx

RE: [PATCH 1/5] drm/amdgpu: add mode2 reset for sienna_cichlid

2022-07-26 Thread Zhao, Victor
[AMD Official Use Only - General] Will do. Thanks, Victor -Original Message- From: Grodzovsky, Andrey Sent: Tuesday, July 26, 2022 5:06 AM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Deng, Emily ; Koenig, Christian Subject: Re: [PATCH 1/5] drm/amdgpu

RE: [PATCH 4/5] drm/amdgpu: revert context to stop engine before mode2 reset

2022-07-26 Thread Zhao, Victor
Message- From: Grodzovsky, Andrey Sent: Tuesday, July 26, 2022 5:20 AM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Deng, Emily ; Koenig, Christian Subject: Re: [PATCH 4/5] drm/amdgpu: revert context to stop engine before mode2 reset On 2022-07-22 03:34, Victor

RE: [PATCH 5/5] drm/amdgpu: reduce reset time

2022-07-26 Thread Zhao, Victor
[AMD Official Use Only - General] Hi Andrey, Reply inline. Thanks, Victor -Original Message- From: Grodzovsky, Andrey Sent: Tuesday, July 26, 2022 5:18 AM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Deng, Emily ; Koenig, Christian Subject: Re

RE: [PATCH 2/5] drm/amdgpu: add debugfs amdgpu_reset_level

2022-07-25 Thread Zhao, Victor
if more appropriate. Thanks, Victor -Original Message- From: Koenig, Christian Sent: Friday, July 22, 2022 4:20 PM To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Cc: Deng, Emily ; Deucher, Alexander Subject: Re: [PATCH 2/5] drm/amdgpu: add debugfs amdgpu_reset_level Well NAK

RE: [PATCH v2] drm/amdgpu: Extend full access wait time in guest

2021-08-08 Thread Zhao, Victor
[AMD Official Use Only] Reviewed-by: Victor Zhao -Original Message- From: Peng Ju Zhou Sent: Monday, August 9, 2021 1:31 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Victor ; Zhou, Peng Ju Subject: [PATCH v2] drm/amdgpu: Extend full access wait time in guest From: Victor Zhao