Re: [PATCH 2/2] drm/amd/display: make function tables const

Add Michel, seems Michel found a similar issue. Please see the kern.log. Best Regards Rex From: amd-gfx on behalf of Harry Wentland Sent: Friday, July 6, 2018 9:32 PM To: Christian König; amd-gfx@lists.freedesktop.org Cc: Lipski, Mikita Subject: Re:

Re: [PATCH] drm/amd/powerplay: initialize uvd/vce powergate status v3

Do we need to maintain the uvd/vce pg state in pp? uvd/vce have maintained the pg state by themselves. pp only provide an interface for uvd/vce/gfx/mmhub to power up/down the ip through smu if smu supported, concurrently enable/disable uvd/vce/mmhub dpm feature. Best Regards Rex

Re: [PATCH] drm/amdgpu/pm: fix display count in non-DC path

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 29, 2018 2:38 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pm: fix display count in non-DC path new_active_crtcs

Re: [PATCH] drm/amdgpu/pp: add missing byte swapping in process_pptables_v1_0.c

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 29, 2018 2:38 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pp: add missing byte swapping in

Re: [PATCH] drm/amdgpu/pp: fix endian swapping in atomctrl_get_voltage_range

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 29, 2018 2:38 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pp: fix endian swapping in atomctrl_get_voltage_range

Re: [PATCH] drm/amdgpu/pp: fix copy paste typo in smu7_init_dpm_defaults

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 29, 2018 2:38 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pp: fix copy paste typo in smu7_init_dpm_defaults

Re: [PATCH] drm/amdgpu/pp: fix copy paste typo in smu7_get_pp_table_entry_callback_func_v1

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 29, 2018 2:38 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pp: fix copy paste typo in

Re: [PATCH 1/2] drm/amdgpu: Add module parameter stutter_mode

i36> From: amd-gfx on behalf of Michel Dänzer Sent: Tuesday, June 26, 2018 6:38:14 PM To: Zhu, Rex Cc: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amdgpu: Add module parameter stutter_mode On 2018-06-26 12:23 PM, rex zhu wrote: >

Re: [PATCH 2/5] drm/amd/pp: Fix wrong clock-unit exported to Display

on raven in linux. Best Regards Rex From: Alex Deucher Sent: Wednesday, June 20, 2018 11:47 AM To: Wentland, Harry Cc: amd-gfx list; Wu, Hersen; Lipski, Mikita; Laktyushkin, Dmytro; Zhu, Rex Subject: Re: [PATCH 2/5] drm/amd/pp: Fix wrong clock-unit exported

Re: [PATCH 10/13] drm/amd/powerplay: apply clocks adjust rules on power state change

Hi Evan, did we need to check the following flags on vega12?will driver set those flags when user select the umd_pstate? PHM_PlatformCaps_UMDPState/PHM_PlatformCaps_PState. Best Regards Rex ?? Outlook for Android From: amd-gfx on

Re: [PATCH] drm/amd/pp: Fix uninitialized variable

Applied. Thanks. Best Regards Rex From: rajan.v...@gmail.com Sent: Monday, June 18, 2018 3:31 PM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); Zhu, Rex; StDenis, Tom Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org

Re: [PATCH 4/7] drm/amd/pp: Add gfx pg support in smu through set_powergating_by_smu

C, 0); Move this change to patch3. From: amd-gfx on behalf of Rex Zhu Sent: Wednesday, June 13, 2018 7:18 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 4/7] drm/amd/pp: Add gfx pg support in smu through set_powergating_by_smu gfx ip bl

Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006

_ From: jv...@scarletmail.rutgers.edu on behalf of Jan Vesely Sent: Wednesday, June 13, 2018 9:30 PM To: Koenig, Christian Cc: Zhu, Rex; amd-gfx list Subject: Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006 Hi, can you please improve the commit message? seeing "Revert $HAS

Re: [PATCH] drm/amd/powerplay: Set higher SCLK frequency than dpm7 in OD

Acked-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Kenneth Feng Sent: Tuesday, June 12, 2018 10:54 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amd/powerplay: Set higher SCLK frequency than dpm7 in OD Fix the issue

Re: [PATCH] drm/amd/powerplay: fix wrong clock adjust sequence

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Evan Quan Sent: Wednesday, June 6, 2018 1:54 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan; Zhu, Rex Subject: [PATCH] drm/amd/powerplay: fix wrong clock adjust sequence The clocks

Re: [PATCH 2/2] drm/amdgpu: Make gfx_off control by GFX ip

ock first. Currently, it is not a big deal, because SMU don't support CG/PG on all legacy asics. Best Regards Rex From: Huang Rui Sent: Wednesday, June 6, 2018 10:33 AM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu: Make gfx

Re: [PATCH] drm/amdgpu/pp: switch the default dpm implementation for CI

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, June 1, 2018 1:48 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/pp: switch the default dpm implementation for CI Switch

Re: [PATCH] drm/amdgpu/display: check if ppfuncs exists before using it

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Wednesday, May 30, 2018 10:37 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/display: check if ppfuncs exists before using it Fixes

Re: [PATCH] drm/amdgpu/powerplay: actually return the power with the new query

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Alex Deucher <alexdeuc...@gmail.com> Sent: Sunday, April 22, 2018 3:11 AM To: amd-gfx@lists.freedesktop.org Cc:

RE: [PATCH 4/6] drm/amdgpu/pm: document pp_dpm_sclk pp_dpm_mclk pp_dpm_pcie

Hi Alex, > There will be a '*' next to the level that is currently active. We need to add a level for deep sleep state. Otherwise, On Vega/Rv, when gpu in deepsleep, we can't set "*" for the current level. Best Regards Rex -Original Message- From: amd-gfx

Re: [PATCH] drm/amdgpu/powerplay: rename smu7_upload_mc_firmware

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, April 12, 2018 7:11 AM To: amd-gfx@lists.freedesktop.org Cc:

Re: [PATCH] drm/amdgpu/powerplay: fix smu7_get_memory_type for fiji

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, April 12, 2018 6:59 AM To: amd-gfx@lists.freedesktop.org Cc:

Re: [PATCH] drm/amd/powerplay: get real current gfxclk frequency instead of dpm level value

You can add descriptions like: fix bug read wrong engine clock when in deep sleep. Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Evan Quan <evan.q...@amd.com

Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

with this patch, there should be no difference between AGT and sysfs. Best Regards Rex From: Huang, JinHuiEric Sent: Thursday, April 5, 2018 12:00 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

Re: [PATCH 2/3] drm/amd/pp: Refine get_gpu_power for VI

y 10 ms instand of 20 ms. so the result will more similar to > the output of PPSMC_MSG_GetCurrPkgPwr. > 5. remove max power/vddc/vddci output to keep consistent with vega. > 6. for vddc/vddci power, we can calculate the average value per > [10ms, 4s] in other interface if

Re: [PATCH] drm/amd/pp: Clean register first to avoid read original value

; On 03/30/2018 03:33 AM, Rex Zhu wrote: >> Signed-off-by: Rex Zhu <rex@amd.com> >> --- >> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 13 + >> 1 file changed, 13 insertions(+) >> >> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/

RE: [PATCH] drm/amd/powerply: fix power reading on Fiji

md/powerply: fix power reading on Fiji Power value is wrong reported by customer. It is a regression by commit a7c7bc4c0c47eaac77b8fa92f0672032df7f4254 Author: Rex Zhu <rex@amd.com><mailto:rex@amd.com> Date: Mon Mar 27 15:32:59 2017 +0800 drm/amd/powerplay: reduce samp

Re: [PATCH][next] drm/amd/pp: Fix spelling mistake: "suppported" -> "supported"

Applied and thanks. Best Regards Rex From: Colin King <colin.k...@canonical.com> Sent: Tuesday, March 27, 2018 4:32 PM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Zhu, Rex; Quan, Evan; amd-gfx@lists.freedesktop.org;

RE: [PATCH v2] drm/amdgpu: Parse module param amdgpu_dpm in check_arguments

Sorry, Please ignore this patch. Setting dpm_enabled when check_arguments didn't make sense. We will set dpm_enabled to true when smu hw init successfully. Best Regards Rex -Original Message- From: Quan, Evan Sent: Monday, March 26, 2018 4:36 PM To: Zhu, Rex; amd-gfx

RE: [PATCH 2/6] drm/amd/pp: Add hwmgr_sw_init/fini functioins

Good. Thanks Best Regards Rex -Original Message- From: Huang Rui [mailto:ray.hu...@amd.com] Sent: Friday, March 23, 2018 9:49 AM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/6] drm/amd/pp: Add hwmgr_sw_init/fini functioins On Thu, Mar 22, 2018 at 07:40:14PM

Re: [PATCH] drm/amd/pp: use mlck_table.count for array loop index limit

Thanks. Will apply the patch to drm-next. Best Regards Rex From: Joe Perches <j...@perches.com> Sent: Thursday, March 22, 2018 3:02 AM To: Colin King; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Zhu, Rex; amd-gfx@lists.freedesktop.org;

Re: [PATCH 2/6] drm/amd/pp: Add hwmgr_sw_init/fini functioins

Thanks Alex. I should be more careful when reorder patches . Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, March 22, 2018 9:13 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 2/6] drm/amd/pp: Add hwmgr_sw_ini

Re: [PATCH 3/6] drm/amd/pp: Lock powerplay when reset pp table

Please see inline. Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, March 22, 2018 9:17 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 3/6] drm/amd/pp: Lock powerplay when reset pp table On Thu, Mar 22, 2018 at 7:40 AM, R

RE: [PATCH] drm/amdgpu: Fix NULL ptr on driver unload due to init failure.

kfree(adev->irq.client[i].sources); +adev->irq.client[i].sources = NULL; Set adev->irq.client[i].sources to NULL in amdgpu_irq_fini also can fix NULL ptr in amdgpu_irq_disable_all.. But I didn't check why amdgpu_device_fini was called twice. This patch looks good. Best Regards Rex

Re: [PATCH 5/6] drm/amd/pp: Delete get_xclk function in powerplay

Yes， Thanks for pointing out this error. that is used for testing the ref clk value on vega10. Best Regards Rex From: Quan, Evan Sent: Friday, March 16, 2018 7:24:47 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: RE: [PATCH 5/6

RE: [PATCH v2 1/2] drm/amdgpu: Improve documentation of bo_ptr in amdgpu_bo_create_kernel

, Alexander; amd-gfx@lists.freedesktop.org; ckoenig.leichtzumer...@gmail.com; Zhu, Rex Subject: Re: [PATCH v2 1/2] drm/amdgpu: Improve documentation of bo_ptr in amdgpu_bo_create_kernel That explains the merge conflict that surprised me :) Thanks, Andrey On 03/15/2018 12:18 PM, Deucher

Re: [PATCH 2/2] drm/amd/powerplay: Fix KASAN user after free on driver unload.

Apply this patch with Christian's suggestions. Thanks. Best Regards Rex From: Christian König <ckoenig.leichtzumer...@gmail.com> Sent: Thursday, March 15, 2018 2:21 AM To: Grodzovsky, Andrey; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex; Koenig, Chr

Re: [PATCH][next] drm/amd/pp: remove redundant pointer internal_buf

Apply it and thanks. Best Regards Rex From: Colin King <colin.k...@canonical.com> Sent: Tuesday, March 13, 2018 9:22 PM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Zhu, Rex; amd-gfx@lists.freedesktop.org;

Re: [PATCH] drm/amdgpu/powerplay/vega10: fix memory leak in error path

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Quan, Evan <evan.q...@amd.com> Sent: Wednesday, March 14, 2018 11:20 AM To: Alex Deucher; amd-gfx@lists.freedeskt

Re: [PATCH 2/4] drm/amdgpu: Plus NULL function pointer check

Sure. Thanks. Best Regards Rex From: Christian König <ckoenig.leichtzumer...@gmail.com> Sent: Monday, March 12, 2018 8:54 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/4] drm/amdgpu: Plus NULL function pointer check Am 12.03.2018

Re: [PATCH 4/5] drm/amdgpu/soc15: always load the psp module

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Saturday, March 10, 2018 4:25 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject:

Re: [PATCH 5/5] drm/amdgpu: move getting pcie info to common code

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Saturday, March 10, 2018 4:25 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject:

Re: [PATCH 3/5] drm/amdgpu: use adev->firmware to determine whether to load the PSP module

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Saturday, March 10, 2018 4:25 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject:

Re: [PATCH 1/5] drm/amdgpu/psp: add a few more fw load type checks

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Saturday, March 10, 2018 4:25 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject:

Re: [PATCH 2/5] drm/amdgpu: move firmware loading type setup to common code

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Saturday, March 10, 2018 4:25 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject:

Re: [PATCH 2/2] drm/amdgpu/soc15: always load the psp IP module

all gpu. Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Saturday, March 10, 2018 1:02 AM To: Koenig, Christian Cc: Zhu, Rex; amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: Re: [PATCH 2/2] drm/amdgpu/soc15: always load the psp IP module On Fri,

Re: [PATCH 1/8] drm/amd/pp: Refine code for smu7 in powerplay

From: Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, March 8, 2018 1:12 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 1/8] drm/amd/pp: Refine code for smu7 in powerplay On Wed, Mar 7, 2018 at 5:46 AM, Rex Zhu <rex@amd.com> wrote: > 1. Add avfs_s

Re: [PATCH 2/2] drm/amdgpu/soc15: always load the psp IP module

Use of all freedesktop.org lists is subject to our Code of ... From 29b7717b97fff81f0dcd80b4bda24cea3d6903bb Mon Sep 17 00:00:00 2001 From: Rex Zhu <rex@amd.com> Date: Fri, 9 Mar 2018 12:34:05 +0800 Subject: [PATCH] drm/amdgpu: Remove additional firmware loading type check in

RE: [PATCH 4/8] drm/amd/pp: Clean up the code for RV in powerplay

h functions. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Thursday, March 08, 2018 1:23 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 4/8] drm/amd/pp: Clean up the code for RV in powerplay On Wed, Mar 7, 2018 at 5:46 AM, Rex Zhu <

RE: [PATCH 1/4] drm/amd/pp: Replace files name rv_* with smu10_*

mail.com] Sent: Wednesday, March 07, 2018 12:42 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 1/4] drm/amd/pp: Replace files name rv_* with smu10_* On Tue, Mar 6, 2018 at 5:10 AM, Rex Zhu <rex@amd.com> wrote: > Powerplay is for the hw ip smu, for RV, smu10 is used, so us

Re: [PATCH 2/2] drm/amdgpu: fix KV harvesting

Acked-by: Rex Zhu for the series. Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Tuesday, March 6, 2018 2:30 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher,

Re: [PATCH] drm/amd/pp: fix "Delete the wrapper layer of smu_allocate/free_memory"

Reviewed-by: Rex Zhu<re...@amd.com> Best Regards Rex From: Christian König <ckoenig.leichtzumer...@gmail.com> Sent: Tuesday, March 6, 2018 9:58 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amd/pp: fix "Delete

Re: [PATCH 2/3] drm/amd/pp: Delete the wrap layer of smu_allocate/free_memory

will remove repeated assignment to mc_addr in verion 2. Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Rex Zhu <rex@amd.com> Sent: Monday, March 5, 2018 6:43 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu,

Re: [PATCH] drm/amdgpu: used cached pcie gen info for SI (v2)

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Thursday, March 1, 2018 10:04 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander;

RE: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs

, Felix Sent: Wednesday, February 28, 2018 2:55 AM To: Alex Deucher; Huang, JinHuiEric Cc: Zhu, Rex; Russell, Kent; amd-gfx list Subject: Re: [PATCH] drm/amd/pp: Revert gfx/compute profile switch sysfs On 2018-02-27 11:27 AM, Alex Deucher wrote: > On Tue, Feb 27, 2018 at 11:22 AM, Eric Hu

Re: [PATCH 4/4] drm/amd/pp: Disable power containment on Fiji with compute workload

From: Rex Zhu <rex@amd.com> Sent: Friday, February 23, 2018 5:52 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 4/4] drm/amd/pp: Disable power containment on Fiji with compute workload disable power containment on Fiji in order to get better c

Re: [PATCH] drm/amd/powerplay: fix power over limit on Fiji

Good. I will follow in new power profile implementation. Best Regards Rex From: amd-gfx on behalf of Felix Kuehling Sent: Wednesday, February 28, 2018 5:01 AM To: amd-gfx@lists.freedesktop.org

Re: [PATCH] drm/amdgpu/powerplay/smu7: use proper dep table for mclk

Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Tuesday, February 27, 2018 2:37:05 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher,

RE: [PATCH 01/10] drm/amdgpu: bump version for new power profile sysfs

- From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] Sent: Sunday, February 25, 2018 9:19 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 01/10] drm/amdgpu: bump version for new power profile sysfs Am 24.02.2018 um 14:55 schrieb Rex Zhu: > Add new power profile sy

Re: [PATCH] drm/amd/pp: Cleaning up vega10_enable_dpm_tasks function

ards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Friday, February 23, 2018 1:01 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH] drm/amd/pp: Cleaning up vega10_enable_dpm_tasks function On Thu, Feb 22, 2018 at 11:21 PM, Rex Zhu <rex@amd.com&

Re: [PATCH 10/10] drm/amd/pp: Enable auto automan feature on Polaris

Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Eric Huang <jinhuieric.hu...@amd.com> Sent: Friday, February 9, 2018 12:47 AM To: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 10/10] drm/amd/pp: Enable auto automan feature on Polaris On 2018-

Re: [PATCH 10/10] drm/amd/pp: Enable auto automan feature on Polaris

From: Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, February 8, 2018 11:28 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 10/10] drm/amd/pp: Enable auto automan feature on Polaris On Thu, Feb 8, 2018 at 10:14 AM, Zhu, Rex <rex@amd.com> wro

Re: [PATCH] drm/amd/pp: Expose new interface to DC to ctrl auto wattman

e when Freesync disable/enable. Best Regards Rex From: Wentland, Harry Sent: Thursday, February 8, 2018 11:28 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Cc: Koo, Anthony; Cyr, Aric Subject: Re: [PATCH] drm/amd/pp: Expose new interface to DC to ctrl auto w

Re: [PATCH 10/10] drm/amd/pp: Enable auto automan feature on Polaris

uary 8, 2018 11:02:21 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 10/10] drm/amd/pp: Enable auto automan feature on Polaris On Thu, Feb 8, 2018 at 4:14 AM, Rex Zhu <rex@amd.com> wrote: > Change-Id: I69b24ce65ddb361a89e5ac9b197ae6df9b60a9e5 > Signed-off-by: Rex Zhu <re

Re: [PATCH] drm/amd/pp: Expose new interface to DC to ctrl auto wattman

when autowattman enabled，we will update uphyst/downhyst/min-sclk/mclk activity value to smu based on the workload. Best Regards Rex From: Wentland, Harry Sent: Thursday, February 8, 2018 10:22:16 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re

RE: MCLK defaults high on second card

Hi Tom, The attached patch should be able to fix this issue. Best Regards Rex -Original Message- From: StDenis, Tom Sent: Friday, February 02, 2018 2:58 AM To: Deucher, Alexander; amd-gfx mailing list Cc: Zhu, Rex; Lazare, Jordan; Wentland, Harry Subject: Re: MCLK defaults high

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

Hi Alex, It's Ok, I got it. Thanks. Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Tuesday, January 30, 2018 6:26 AM To: Zhu, Rex Cc: Kuehling, Felix; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manua

Re: [PATCH 2/2] drm/amdgpu/pm: get/set dgpu power cap via hwmon API

>Isn't the power limit only multiplied by 256 on smu7? Yes，I will fix it and convert the output to mw. Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Tuesday, January 30, 2018 4:00 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

we just unfore the clock range in the auto state. Anyway, I will drop this patch. Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Tuesday, January 30, 2018 2:02 AM To: Zhu, Rex Cc: Kuehling, Felix; amd-gfx@lists.freedesktop.org Subjec

RE: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

ve one less command need to input if they want to use pp_dpm_sclk/mclk/pcie. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Saturday, January 27, 2018 7:51 AM To: Zhu, Rex Cc: Kuehling, Felix; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

ing, Felix Sent: Saturday, January 27, 2018 3:32 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level On 2018-01-26 02:20 PM, Zhu, Rex wrote: > > >1. You're breaking the semantics of the existi

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

driver still can set min sclk/mclk. Best Regards Rex From: Kuehling, Felix Sent: Saturday, January 27, 2018 12:49 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level Hi Rex

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

t: Friday, January 26, 2018 8:26 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level On 2018-01-25 07:07 PM, Zhu, Rex wrote: > I also think about this problem. > just think user should unforced clk level

Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level

From: Kuehling, Felix Sent: Friday, January 26, 2018 12:55:19 AM To: amd-gfx@lists.freedesktop.org; Zhu, Rex Subject: Re: [PATCH 1/2] drm/amd/pp: Remove manual mode for power_dpm_force_performance_level This patch breaks unforcing of clocks, which is currently done

Re: [PATCH 1/4] drm/amd/pp: Add new smu callback function

m settings > > Change-Id: Idc0362c219d84564693ca90adf9299e56cfeb6a4 > Signed-off-by: Rex Zhu <rex@amd.com> > --- > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 + > drivers/gpu/drm/amd/powerplay/inc/smumgr.h| 1 + > drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c | 8 &

RE: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

oblem maybe we should not name new sysfs as "power_profile_mode ". It is easy to add min sclk/mclk in the new sysfs, I just think it repeated with other sysfs. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Thursd

RE: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

. Thanks. Best Regards Rex -Original Message- From: Kuehling, Felix Sent: Thursday, January 25, 2018 12:16 PM To: Zhu, Rex; Huang, JinHuiEric; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7 On 2018-01-24 09:28 PM, Zhu, Rex wro

Re: [PATCH 6/6] drm/amdgpu/pm: rework the hwmon visibility settings

Series is Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, January 25, 2018 7:55 AM To: amd-gfx@lists.freedeskt

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

tools. Best Regards Rex From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Felix Kuehling <felix.kuehl...@amd.com> Sent: Thursday, January 25, 2018 7:12 AM To: Zhu, Rex; Huang, JinHuiEric; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Impl

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

. Best Regards Rex From: Kuehling, Felix Sent: Thursday, January 25, 2018 5:41:43 AM To: Zhu, Rex; Huang, JinHuiEric; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7 Hi Rex, As I understand it (the way

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

Yes. Best Regards Rex From: Huang, JinHuiEric Sent: Thursday, January 25, 2018 4:47:23 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7 Hi Rex, So you intend to separate previous one

Re: [PATCH 4/4] drm/amd/pp: Implement set_power_profile_mode on smu7

> "5 * * * * * * * *" mean "CUSTOM enable_sclk SCLK_UP_HYST > SCLK_DOWN_HYST SCLK_ACTIVE_LEVEL enable_mclk MCLK_UP_HYST > MCLK_DOWN_HYST MCLK_ACTIVE_LEVEL" > > Change-Id: Ic6d6f37363bc81ab17051285f6ace847edf725de > Signed-off-by: Rex Zhu <rex@amd.com> > --

Re: [PATCH 5/5] drm/amd/pp: Implement get_power_profile_mode on smu7

* 10 16 31 so add current_mode to notify user current parameters. Best Regards Rex From: Deucher, Alexander Sent: Tuesday, January 23, 2018 11:15 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subjec

RE: [PATCH] drm/amdgpu/powerplay/vega10: fix compute profile name

Thanks, Alex. Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Saturday, January 20, 2018 1:14 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander S

RE: [amd-staging-drm-next]: amdgpu: [powerplay] pp_get_power_profile_mode was not implemented.

Yes, I just implemented this callback function on Vega10. Best Regards Rex -Original Message- From: Dieter Nützel [mailto:die...@nuetzel-hh.de] Sent: Friday, January 19, 2018 4:23 PM To: Zhu, Rex Cc: amd-devel Subject: [amd-staging-drm-next]: amdgpu: [powerplay

RE: [PATCH] drm/amd/powerplay: Fix smu_table_entry.handle type

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex From: Deucher, Alexander Sent: Thursday, January 18, 2018 7:11 AM To: Grodzovsky, Andrey; amd-gfx@lists.freedesktop.org Cc: Lipski, Mikita; Zhu, Rex Subject: Re: [PATCH] drm/amd/powerplay: Fix smu_table_entry.handle type Reviewed-by

RE: [PATCH 1/2] drm/amdgpu: add custom power policy support in sysfs

Sure. We should add the PP_SMC_POWER_PROFILE_AUTO in PP_SMC_POWER_PROFILE. And will be implemented as auto wattman feature. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Tuesday, January 16, 2018 11:59 PM To: Zhu, Rex Cc: amd-gfx list Subject

RE: [PATCH 2/3] drm/amd/pp: Add stable Pstate clk display when print_clock_levels

Ok, I will drop this patch. and please review the new attached patch expose stable pstate clock by ioctl. Best Regards Rex -Original Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Wednesday, January 17, 2018 12:03 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 2

RE: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature

-Original Message- From: Grazvydas Ignotas [mailto:nota...@gmail.com] Sent: Wednesday, January 17, 2018 1:53 AM To: Zhu, Rex Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature On Tue, Jan 16, 2018 at 2:02 PM, Rex Zhu <

RE: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature

2 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 1/8] drm/amd/pp: Add a new pp feature mask bit for OD feature On Tue, Jan 16, 2018 at 7:02 AM, Rex Zhu <rex@amd.com> wrote: > when this bit was set on module load, > driver will allow the user over/under gpu clock and

Re: [PATCH 1/2] drm/amdgpu: add custom power policy support in sysfs

Yes, this new interface is more common, I just save the input and send to hw backend. Smu7 and Vega can share this interface. Best Regards Rex From: Alex Deucher <alexdeuc...@gmail.com> Sent: Thursday, January 11, 2018 4:18:11 AM To: Zhu, Rex Cc: amd-gf

Re: [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display support in debugfs

Ok. Thanks. I will query twice.one for pstate sclk and one for mclk. Best Regards Rex From: Deucher, Alexander Sent: Friday, January 5, 2018 11:44:00 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display

RE: [PATCH v2] drm/amd/pp: Implement get_max_high_clocks for CI/VI

l Message- From: Alex Deucher [mailto:alexdeuc...@gmail.com] Sent: Thursday, January 04, 2018 2:58 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH v2] drm/amd/pp: Implement get_max_high_clocks for CI/VI On Thu, Jan 4, 2018 at 1:01 AM, Rex Zhu <rex@amd.com> wrote: > v2: add

RE: [PATCH 3/3] drm/amd/pp: Refine pp_dpm_set_pp_table logic

Sorry, please ignore this patch as the new logic is wrong. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Tuesday, January 02, 2018 3:54 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 3/3

RE: [PATCH] drm/amdgpu: fix rmmod KCQ disable failed error

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: Wang Hongcheng [mailto:annie.w...@amd.com] Sent: Friday, November 17, 2017 2:24 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex; Wang, Annie Subject: [PATCH] drm/amdgpu: fix rmmod KCQ disable failed

RE: [PATCH] drm/amd/powerplay: fix memory leak of hardcoded pptable

Reviewed-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Eric Huang Sent: Wednesday, November 01, 2017 5:40 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, JinHuiEric Subject: [PATCH] d

RE: [PATCH 2/2] drm/amdgpu: allow GTT overcommit during bind

Patch is Tested-by: Rex Zhu <rex@amd.com> Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Tuesday, October 17, 2017 4:28 PM To: Zhou, David(ChunMing); amd-gfx@lists.freedesktop.org Subje

Re: Regression: Crash/freeze when resuming from suspend or locked screen

Hi Martin, Can you try to reproduce this issue with amdgpu.dc=0 when modprobe amdgpu Best Regards Rex From: amd-gfx on behalf of Deucher, Alexander Sent: Tuesday, October 10, 2017 10:41:29 PM

Re: tonga mclk regression

Thanks Tom. The attached patch can fix this bug. Best Regards Rex From: StDenis, Tom Sent: Thursday, October 5, 2017 9:42 PM To: amd-gfx mailing list Cc: Zhu, Rex; Deucher, Alexander Subject: tonga mclk regression I've bisected it to this commit [root

RE: some more powerplay/pwr virus size reduction patches

Hi Alex, We can use Polaris's PwrVirusTable on Fiji. So can remove fiji_pwrvirus.h Best Regards Rex -Original Message- From: Deucher, Alexander Sent: Friday, September 29, 2017 11:13 AM To: 'Dave Airlie'; amd-gfx mailing list; Alex Deucher; Zhu, Rex Subject: RE: some more powerplay

<    1   2   3   >