Re: [PATCH v2 27/86] drm/meson: Run DRM default client setup

2024-08-21 Thread Neil Armstrong
s the default if no format has been given, leave it out entirely. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Kevin Hilman Cc: Jerome Brunet Cc: Martin Blumenstingl --- drivers/gpu/drm/meson/meson_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gp

Re: [PATCH 31/86] drm/panel/ili9341: Run DRM default client setup

2024-08-19 Thread Neil Armstrong
On 16/08/2024 14:22, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica

Re: [PATCH 31/86] drm/panel/ili9341: Run DRM default client setup

2024-08-19 Thread Neil Armstrong
On 16/08/2024 14:22, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica

Re: [PATCH v3 2/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-05-22 Thread Neil Armstrong
select DRM_DISPLAY_HELPER help Say Y here if you want to enable support for LG sw43408 panel. The panel has a 1080x2160@60Hz resolution and uses 24 bit RGB per Reviewed-by: Neil Armstrong

Re: [PATCH v3 3/3] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-05-22 Thread Neil Armstrong
On 22/05/2024 08:25, Dmitry Baryshkov wrote: Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being declared. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200739.hbwzvohr-...@intel.com/ Reviewed-by: Neil Armstrong Fixes: 069a6c0e

Re: [PATCH] MAINTAINERS: drm/ci: add entries for xfail files

2023-10-02 Thread neil . armstrong
-foundation.org S:Maintained T:git git://anongit.freedesktop.org/drm/drm-misc +F: drivers/gpu/drm/ci/xfails/virtio* F:drivers/gpu/drm/virtio/ F:include/uapi/linux/virtio_gpu.h Reviewed-by: Neil Armstrong

Re: [PATCH 2/4] drm/bridge-connector: handle subconnector types

2023-08-02 Thread Neil Armstrong
On 29/07/2023 02:49, Dmitry Baryshkov wrote: If the created connector type supports subconnector type property, create and attach corresponding it. The default subtype value is 0, which maps to the DRM_MODE_SUBCONNECTOR_Unknown type. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bri

Re: [PATCH 1/2] drm/amdgpu: Fix no-procfs build

2023-05-26 Thread Neil Armstrong
/drm-misc/commit/?id=1a56fcf08ae463a4564d111356091b2bdb6c7bce [2/2] drm/amdgpu: Remove duplicate fdinfo fields (no commit info) -- Neil

Re: [PATCH 2/2] drm/amdgpu: Remove duplicate fdinfo fields

2023-05-26 Thread Neil Armstrong
32_t bus, dev, fn, domain; | ^~~ drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c:64:18: error: variable ‘bus’ set but not used [-Werror=unused-but-set-variable] 64 | uint32_t bus, dev, fn, domain; after applying patch 2, can you fix it ? Seems you can keep the drm-pdev print line I applied patch 1 Thanks, Neil

Re: (subset) [PATCH v4 0/9] drm: fdinfo memory stats

2023-05-24 Thread Neil Armstrong
On 24/05/2023 18:10, Neil Armstrong wrote: Hi, On Mon, 15 May 2023 07:30:07 -0700, Rob Clark wrote: Similar motivation to other similar recent attempt[1]. But with an attempt to have some shared code for this. As well as documentation. It is probably a bit UMA-centric, I guess devices with

Re: [PATCH v5 0/7] drm: fdinfo memory stats

2023-05-24 Thread Neil Armstrong
e [6/7] drm/msm: Add memory stats to fdinfo https://cgit.freedesktop.org/drm/drm-misc/commit/?id=3e9757f5ddb98238226ad68a1609aa313de35adb [7/7] drm/doc: Relax fdinfo string constraints https://cgit.freedesktop.org/drm/drm-misc/commit/?id=90d63a150b85fd1debb9c01237fb78faee02746a -- Neil

Re: (subset) [PATCH v4 0/9] drm: fdinfo memory stats

2023-05-24 Thread Neil Armstrong
tring constraints https://cgit.freedesktop.org/drm/drm-misc/commit/?id=90d63a150b85fd1debb9c01237fb78faee02746a -- Neil

Re: Radeon Driver Crash

2023-05-22 Thread Neil Sikka
I also crossposted here upon request: https://gitlab.freedesktop.org/drm/amd/-/issues/2571 On Fri, May 19, 2023 at 6:36 PM Neil Sikka wrote: > > Hello, I just filed a bug for the Radeon driver crashing: > https://bugzilla.kernel.org/show_bug.cgi?id=217464 > > It looks simi

Radeon Driver Crash

2023-05-20 Thread Neil Sikka
Hello, I just filed a bug for the Radeon driver crashing: https://bugzilla.kernel.org/show_bug.cgi?id=217464 It looks similar to this bug (https://bugzilla.kernel.org/show_bug.cgi?id=198669) because they are both locking up the GPU and the page fault address is at the same page offset of 0xffc, wh

Re: [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate

2021-11-03 Thread Neil Armstrong
Karlman > Cc: Jonathan Hunter > Cc: Joonas Lahtinen > Cc: Kevin Hilman > Cc: Laurent Pinchart > Cc: linux-amlo...@lists.infradead.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-te...@vger.kernel.org > Cc: Martin Blumenstingl > Cc: Neil Armstrong >

Re: [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Neil Armstrong
; > Signed-off-by: Thomas Zimmermann > --- ... > drivers/gpu/drm/meson/meson_drv.c | 2 +- Acked-by: Neil Armstrong ... > > diff --git a/drivers/gpu/drm/meson/meson_drv.c > b/drivers/gpu/drm/meson/meson_drv.c > index a7388bf7c838..3d0ccc7eef1b

Re: [PATCH 2/2] drm/edid: Add alternate clock for SMPTE 4K

2019-11-12 Thread Neil Armstrong
tion Shouldn't it be only bypassed when the sink is HDMI2 ? Neil > > Signed-off-by: Wayne Lin > --- > drivers/gpu/drm/drm_edid.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index fcd7ae2

Re: [PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output

2019-11-01 Thread Neil Mayhew
On 2019-11-01 9:13 a.m., Harry Wentland wrote: > On 2019-10-30 2:58 p.m., n...@neil.mayhew.name wrote: >> From: Neil Mayhew > This requires your Signed-off-by. See [1]. > > With that fixed your change looks good and is > Reviewed-by: Harry Wentland > > You can simp

[PATCH] drm/amdgpu: Show resolution correctly in mode validation debug output

2019-10-30 Thread neil
From: Neil Mayhew --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index a52f0b13a2c8..f802c784e6f6 100644 --- a

Re: 21:9 monitor resolution incorrect since 4.14 kernel

2019-10-30 Thread Neil Mayhew
I enabled kms debugging with drm.debug=4 on the kernel command line. This enabled me to see that the relevant modes are being rejected with error 11 which is DC_EXCEED_DONGLE_CAP. Sure enough, I see that there's a dongle detected that's rated at 165MHz and my preferred modes are all above that. Ho

21:9 monitor resolution incorrect since 4.14 kernel

2019-10-29 Thread Neil Mayhew
ut not with X11 2. When the system boots up the resolution is square and the image is squished horizontally with many columns dropped, both during the boot process and at the gdm login screen. It's not until after I log with X11 that the resolution is set correctly. 3. The output of xrandr --pr

Re: [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API

2019-08-19 Thread Neil Armstrong
Hi Dariusz, Hans, I can apply the dw-hdmi patches if necessary. Neil On 19/08/2019 11:38, Hans Verkuil wrote: > Hi all, > > The patches in this series can be applied independently from each other. > > If you maintain one of these drivers and you want to merge it for v5.4 &

Re: [PATCH 02/13] drm/radeon: Eliminate possible use of an uninitialized variable

2019-08-01 Thread Neil Armstrong
rted only once for each function it appears in Caused by commit bed7a2182de6 ("drm/radeon: Provide ddc symlink in connector sysfs directory") I have used the drm-misc tree from next-20190731 for today. == Neil On 31/07/2019 18:58, Andrzej Pietrasie

Re: [PATCH] Revert "drm/radeon: Provide ddc symlink in connector sysfs directory"

2019-08-01 Thread Neil Armstrong
On 01/08/2019 14:01, Daniel Vetter wrote: > On Thu, Aug 1, 2019 at 1:53 PM Neil Armstrong wrote: >> >> This reverts commit bed7a2182de6833f5d0f990a656bffb1c6000c70. >> >> It causes the following build error: >> ../drm/radeon/radeon_connectors.c: In func

[PATCH] Revert "drm/radeon: Provide ddc symlink in connector sysfs directory"

2019-08-01 Thread Neil Armstrong
s function) ddc = &radeon_connector->ddc_bus->adapter; ^~~ Suggested-by: Daniel Vetter Signed-off-by: Neil Armstrong --- drivers/gpu/drm/radeon/radeon_connectors.c | 142 ++--- 1 file changed, 36 insertions(+), 106 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_c

Re: Review required [Was: Associate ddc adapters with connectors]

2019-07-31 Thread Neil Armstrong
Hi Andrzej, On 31/07/2019 16:22, Neil Armstrong wrote: > On 31/07/2019 15:10, Andrzej Pietrasiewicz wrote: >> W dniu 31.07.2019 o 12:40, Sam Ravnborg pisze: >>> Hi Neil. >>> >>> On Wed, Jul 31, 2019 at 10:00:14AM +0200, Neil Armstrong wrote: >>>

Re: Review required [Was: Associate ddc adapters with connectors]

2019-07-31 Thread Neil Armstrong
On 31/07/2019 15:10, Andrzej Pietrasiewicz wrote: > W dniu 31.07.2019 o 12:40, Sam Ravnborg pisze: >> Hi Neil. >> >> On Wed, Jul 31, 2019 at 10:00:14AM +0200, Neil Armstrong wrote: >>> Hi Sam, >>> >>> On 26/07/2019 20:55, Sam Ravnborg wrote: >

Re: Review required [Was: Associate ddc adapters with connectors]

2019-07-31 Thread Neil Armstrong
t back. I can apply all core and maintainer-acked patches for now : 1, 2, 7, 10, 11, 16, 17, 18, 19, 20, 21, 22, 23 and Andrzej can resend not applied patches with Yours and Emil's Reviewed-by, so we can wait a few more days to apply them. Neil > > Sam > >> Hi Andez

Re: [PATCH v4 19/23] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-07-31 Thread Neil Armstrong
Hi, On 30/07/2019 19:30, Sam Ravnborg wrote: > Hi Neil. > >>> Signed-off-by: Andrzej Pietrasiewicz >>> --- >>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 40 +++ >>> 1 file changed, 20 insertions(+), 20 deletions(-) >>>

Re: [PATCH v6 21/24] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

2019-07-30 Thread Neil Armstrong
ctor_type); > + ret = drm_connector_init_with_ddc(bridge->dev, &dvi->connector, > + &tfp410_con_funcs, > + dvi->connector_type, > + dvi->ddc); > if (ret) { >

Re: [PATCH v6 19/24] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-07-30 Thread Neil Armstrong
> if (ret) { > DRM_ERROR("Failed to initialize connector\n"); > return ret; > Reviewed-by: Neil Armstrong ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH v4 20/23] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

2019-07-30 Thread Neil Armstrong
return ret; > @@ -382,8 +381,8 @@ static int tfp410_fini(struct device *dev) > > drm_bridge_remove(&dvi->bridge); > > - if (dvi->ddc) > - i2c_put_adapter(dvi->ddc); > + if (dvi->connector.ddc) > + i2c_put_adapter(dvi->connector.ddc); > if (dvi->hpd) > gpiod_put(dvi->hpd); > > Reviewed-by: Neil Armstrong ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH v4 19/23] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-07-30 Thread Neil Armstrong
>adap); > - hdmi->ddc = NULL; > + hdmi->connector.ddc = NULL; > } > > if (hdmi->cec_notifier) > @@ -2788,7 +2788,7 @@ __dw_hdmi_probe(struct platform_device *pdev, > err_isfr: > clk_disable_unprepare(hdmi->isfr_clk); >

Re: [PATCH v4 18/23] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-07-30 Thread Neil Armstrong
->ddc); > + return PTR_ERR(vga->connector.ddc); > } > } > > @@ -216,8 +215,8 @@ static int dumb_vga_remove(struct platform_device *pdev) > > drm_bridge_remove(&vga->bridge); > > - if (!IS_ERR(vga->ddc)) > - i2c_put_adapter(vga->ddc); > + if (!IS_ERR(vga->connector.ddc)) > + i2c_put_adapter(vga->connector.ddc); > > return 0; > } > Reviewed-by: Neil Armstrong ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Neil Armstrong
drivers/gpu/drm/mediatek/mtk_dpi.c| 2 +- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c| 2 +- > drivers/gpu/drm/mediatek/mtk_drm_fb.c | 2 +- > drivers/gpu/drm/mediatek/mtk_dsi.c| 2 +- > d

Re: [PATCH 7/7] drm: Split out drm_probe_helper.h

2018-12-10 Thread Neil Armstrong
S) BE LIABLE FOR ANY CLAIM, DAMAGES OR > + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +#ifndef __DRM_PROBE_HELPER_H__ > +#define __DRM_PROBE_HELPER_H__ > + > +#include > + > +struct drm_connector; > +struct drm_device; > +struct drm_modeset_acquire_ctx; > + > +int drm_helper_probe_single_connector_modes(struct drm_connector > + *connector, uint32_t maxX, > + uint32_t maxY); > +int drm_helper_probe_detect(struct drm_connector *connector, > + struct drm_modeset_acquire_ctx *ctx, > + bool force); > +void drm_kms_helper_poll_init(struct drm_device *dev); > +void drm_kms_helper_poll_fini(struct drm_device *dev); > +bool drm_helper_hpd_irq_event(struct drm_device *dev); > +void drm_kms_helper_hotplug_event(struct drm_device *dev); > + > +void drm_kms_helper_poll_disable(struct drm_device *dev); > +void drm_kms_helper_poll_enable(struct drm_device *dev); > +bool drm_kms_helper_is_poll_worker(void); > + > +#endif > Acked-by: Neil Armstrong ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx