[PATCH] drm/amdgpu: Fix a null pointer access when the smc_rreg pointer is NULL

2023-10-23 Thread qu . huang
91] FS: 7f5e0755b740() GS:99479d30() knlGS: [4005007.800895] CS: 0010 DS: ES: CR0: 80050033 [4005007.800898] CR2: ffd6 CR3: 0003253fc000 CR4: 003506e0 Signed-off-by: Qu Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_deb

Re: [PATCH] drm/amdkfd: Fix an illegal memory access

2023-02-22 Thread Qu Huang
On 2023/2/22 3:17, Christophe JAILLET wrote: > Le 21/02/2023 à 17:26, Felix Kuehling a écrit : >> >> On 2023-02-21 06:35, qu.huang-fxuvxftifdnyg1zeobx...@public.gmane.org wrote: >>> From: Qu Huang >>> >>> In the kfd_wait_on_events() function, the k

[PATCH v2] drm/amdkfd: Fix an illegal memory access

2023-02-22 Thread qu . huang
, removing the initialization of activated; * '(event_waiters) &&' in the 'for' loop has also been removed. Signed-off-by: Qu Huang --- drivers/gpu/drm/amd/amdkfd/kfd_events.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_eve

[PATCH] drm/amdkfd: Fix an illegal memory access

2023-02-21 Thread qu . huang
From: Qu Huang In the kfd_wait_on_events() function, the kfd_event_waiter structure is allocated by alloc_event_waiters(), but the event field of the waiter structure is not initialized; When copy_from_user() fails in the kfd_wait_on_events() function, it will enter exception handling to release

Re: [PATCH] drm/amdgpu: Fix a potential sdma invalid access

2021-04-06 Thread Qu Huang
Hi Christian, On 2021/4/3 16:49, Christian König wrote: Hi Qu, Am 03.04.21 um 07:08 schrieb Qu Huang: Hi Christian, On 2021/4/3 0:25, Christian König wrote: Hi Qu, Am 02.04.21 um 05:18 schrieb Qu Huang: Before dma_resv_lock(bo->base.resv, NULL) in amdgpu_bo_release_notify(), the

Re: [PATCH] drm/amdgpu: Fix a potential sdma invalid access

2021-04-03 Thread Qu Huang
Hi Christian, On 2021/4/3 0:25, Christian König wrote: Hi Qu, Am 02.04.21 um 05:18 schrieb Qu Huang: Before dma_resv_lock(bo->base.resv, NULL) in amdgpu_bo_release_notify(), the bo->base.resv lock may be held by ttm_mem_evict_first(), That can't happen since when bo_release_notify is

Re: [PATCH] drm/amdgpu: Fix a potential sdma invalid access

2021-04-03 Thread Qu Huang
Hi Christian, On 2021/4/3 0:25, Christian König wrote: Hi Qu, Am 02.04.21 um 05:18 schrieb Qu Huang: Before dma_resv_lock(bo->base.resv, NULL) in amdgpu_bo_release_notify(), the bo->base.resv lock may be held by ttm_mem_evict_first(), That can't happen since when bo_release_notify is

[PATCH] drm/amdgpu: Fix a potential sdma invalid access

2021-04-01 Thread Qu Huang
will get an invalid address in amdgpu_fill_buffer(), resulting in a VMFAULT or memory corruption. To avoid it, we have to hold bo->base.resv lock first, and check whether the mem.mem_type is TTM_PL_VRAM. Signed-off-by: Qu Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 8 ++-- 1 fil

Re: [PATCH] drm/amdkfd: dqm fence memory corruption

2021-03-26 Thread Qu Huang
On 2021/1/28 5:50, Felix Kuehling wrote: Am 2021-01-27 um 7:33 a.m. schrieb Qu Huang: Amdgpu driver uses 4-byte data type as DQM fence memory, and transmits GPU address of fence memory to microcode through query status PM4 message. However, query status PM4 message definition and microcode

[PATCH] drm/amdkfd: Fix cat debugfs hang_hws file causes system crash bug

2021-03-22 Thread Qu Huang
ull) [ 1272.884564] RSP [ 1272.884566] CR2: 0000 Signed-off-by: Qu Huang --- drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c b/drivers/gpu/drm/amd/amdkfd/kfd_debugfs.c index

[PATCH v2] drm/amdkfd: dqm fence memory corruption

2021-01-29 Thread Qu Huang
of memory, but microcode does write 8 bytes of memory, so there is a memory corruption. Changes since v1: * Change dqm->fence_addr as a u64 pointer to fix this issue, also fix up query_status and amdkfd_fence_wait_timeout function uses 64 bit fence value to make them consistent. Signed-off-by:

[PATCH] drm/amdkfd: dqm fence memory corruption

2021-01-27 Thread Qu Huang
of memory, but microcode does write 8 bytes of memory, so there is a memory corruption. Signed-off-by: Qu Huang --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers