Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-22 Thread Alex Deucher
On Fri, Oct 22, 2021 at 11:02 AM Simon Ser wrote: > > On Friday, October 22nd, 2021 at 15:58, Alex Deucher > wrote: > > > > Agreed that this patch is good but we'll need to also revert the > > > is_chromeos w/a. > > > > I've reverted that and applied this one. Thanks! > > Ah, didn't realize I

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-22 Thread Simon Ser
On Friday, October 22nd, 2021 at 15:58, Alex Deucher wrote: > > Agreed that this patch is good but we'll need to also revert the > > is_chromeos w/a. > > I've reverted that and applied this one. Thanks! Ah, didn't realize I needed to revert that one too. Thank you!

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-22 Thread Alex Deucher
On Thu, Oct 21, 2021 at 2:19 PM Harry Wentland wrote: > > > > On 2021-10-21 13:55, Rodrigo Siqueira Jordao wrote: > > Hi Simon, > > > > I tested this patch and it lgtm. I also agree to revert it. > > > > Btw, did you send the revert patch for "amd/display: only require overlay > > plane to cover

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-21 Thread Harry Wentland
On 2021-10-21 13:55, Rodrigo Siqueira Jordao wrote: > Hi Simon, > > I tested this patch and it lgtm. I also agree to revert it. > > Btw, did you send the revert patch for "amd/display: only require overlay > plane to cover whole CRTC on ChromeOS"? I think we need to revert it as well. >

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-21 Thread Rodrigo Siqueira Jordao
Hi Simon, I tested this patch and it lgtm. I also agree to revert it. Btw, did you send the revert patch for "amd/display: only require overlay plane to cover whole CRTC on ChromeOS"? I think we need to revert it as well. Sean, Mark For ChromeOS, we should ignore this patch. Do we need to

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-21 Thread Simon Ser
On Thursday, October 14th, 2021 at 17:35, Simon Ser wrote: > This reverts commits ddab8bd788f5 ("drm/amd/display: Fix two cursor > duplication > when using overlay") and e7d9560aeae5 ("Revert "drm/amd/display: Fix overlay > validation by considering cursors""). > > tl;dr ChromeOS uses the

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-21 Thread Paul Menzel
Dear Simon, Am 21.10.21 um 18:08 schrieb Simon Ser: On Tuesday, October 19th, 2021 at 10:25, Paul Menzel wrote: Am 19.10.21 um 10:10 schrieb Simon Ser: On Tuesday, October 19th, 2021 at 01:21, Paul Menzel wrote: Am 19.10.21 um 01:06 schrieb Simon Ser: On Tuesday, October 19th, 2021 at

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-21 Thread Simon Ser
Hi again, On Tuesday, October 19th, 2021 at 10:25, Paul Menzel wrote: > Dear Simon, > > > Am 19.10.21 um 10:10 schrieb Simon Ser: > > On Tuesday, October 19th, 2021 at 01:21, Paul Menzel > > wrote: > > > >> Am 19.10.21 um 01:06 schrieb Simon Ser: > >>> On Tuesday, October 19th, 2021 at

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-19 Thread Paul Menzel
Dear Simon, Am 19.10.21 um 10:10 schrieb Simon Ser: On Tuesday, October 19th, 2021 at 01:21, Paul Menzel wrote: Am 19.10.21 um 01:06 schrieb Simon Ser: On Tuesday, October 19th, 2021 at 01:03, Paul Menzel wrote: Excuse my ignorance. Reading the commit message, there was a Linux kernel

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-19 Thread Simon Ser
On Tuesday, October 19th, 2021 at 01:21, Paul Menzel wrote: > Am 19.10.21 um 01:06 schrieb Simon Ser: > > On Tuesday, October 19th, 2021 at 01:03, Paul Menzel wrote: > > > >> Excuse my ignorance. Reading the commit message, there was a Linux > >> kernel change, that broke Chrome OS userspace,

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-18 Thread Paul Menzel
Dear Simon, Am 19.10.21 um 01:06 schrieb Simon Ser: On Tuesday, October 19th, 2021 at 01:03, Paul Menzel wrote: Excuse my ignorance. Reading the commit message, there was a Linux kernel change, that broke Chrome OS userspace, right? If so, and we do not know if there is other userspace using

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-18 Thread Simon Ser
On Tuesday, October 19th, 2021 at 01:03, Paul Menzel wrote: > Excuse my ignorance. Reading the commit message, there was a Linux > kernel change, that broke Chrome OS userspace, right? If so, and we do > not know if there is other userspace using the API incorrectly, > shouldn’t the patch

Re: [PATCH] amd/display: remove ChromeOS workaround

2021-10-18 Thread Paul Menzel
Dear Simon, Am 14.10.21 um 17:35 schrieb Simon Ser: This reverts commits ddab8bd788f5 ("drm/amd/display: Fix two cursor duplication when using overlay") and e7d9560aeae5 ("Revert "drm/amd/display: Fix overlay validation by considering cursors""). tl;dr ChromeOS uses the atomic interface for

[PATCH] amd/display: remove ChromeOS workaround

2021-10-14 Thread Simon Ser
This reverts commits ddab8bd788f5 ("drm/amd/display: Fix two cursor duplication when using overlay") and e7d9560aeae5 ("Revert "drm/amd/display: Fix overlay validation by considering cursors""). tl;dr ChromeOS uses the atomic interface for everything except the cursor. This is incorrect and