Re: [PATCH] amdgpu: Set cik/si_support to 1 by default if radeon isn't built

2017-07-02 Thread Michel Dänzer
On 30/06/17 11:41 PM, axie wrote: > Hi Michel, > > MODULE_PARM_DESC is "used to document arguments that the module can > take. It takes two parameters: a variable name and a free form string > describing that variable" > > I think we should avoid changing document when config change. > > How

Re: [PATCH] amdgpu: Set cik/si_support to 1 by default if radeon isn't built

2017-06-30 Thread axie
Hi Michel, MODULE_PARM_DESC is "used to document arguments that the module can take. It takes two parameters: a variable name and a free form string describing that variable" I think we should avoid changing document when config change. How about changing it to something like the following

[PATCH] amdgpu: Set cik/si_support to 1 by default if radeon isn't built

2017-06-30 Thread Michel Dänzer
From: Michel Dänzer It was required to explicitly set these parameters to 1, even if the radeon driver isn't built at all, which is not intuitive. Reported-by: Shawn Starr Signed-off-by: Michel Dänzer ---