Re: [PATCH] amdgpu: fix GEM obj leak in amdgpu_display_user_framebuffer_create

2021-04-28 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Apr 21, 2021 at 6:29 AM Christian König wrote: > > Am 21.04.21 um 11:16 schrieb Simon Ser: > > This error code-path is missing a drm_gem_object_put call. Other > > error code-paths are fine. > > Good catch. For some extra points you could change the error handling

Re: [PATCH] amdgpu: fix GEM obj leak in amdgpu_display_user_framebuffer_create

2021-04-21 Thread Christian König
Am 21.04.21 um 11:16 schrieb Simon Ser: This error code-path is missing a drm_gem_object_put call. Other error code-paths are fine. Good catch. For some extra points you could change the error handling into using goto error instead of hand wiring it. Either way patch is Reviewed-by: Christia

[PATCH] amdgpu: fix GEM obj leak in amdgpu_display_user_framebuffer_create

2021-04-21 Thread Simon Ser
This error code-path is missing a drm_gem_object_put call. Other error code-paths are fine. Signed-off-by: Simon Ser Fixes: 1769152ac64b ("drm/amdgpu: Fail fb creation from imported dma-bufs. (v2)") Cc: Alex Deucher Cc: Harry Wentland Cc: Nicholas Kazlauskas Cc: Bas Nieuwenhuizen --- driver