Re: [PATCH] drm/amd/display: Add DC feature flag to disable audio

2021-01-27 Thread Christian König
Am 27.01.21 um 13:23 schrieb Ernst Sjöstrand: Just some additional thoughts... The amdgpu driver already supports this as I mentioned, however only for the non-DC codepath. "Set HDMI/DPAudio. Only affects non-DC display handling. The default is -1 (Enabled), set 0 to disabled it." I've

Re: [PATCH] drm/amd/display: Add DC feature flag to disable audio

2021-01-27 Thread Ernst Sjöstrand
Just some additional thoughts... The amdgpu driver already supports this as I mentioned, however only for the non-DC codepath. "Set HDMI/DPAudio. Only affects non-DC display handling. The default is -1 (Enabled), set 0 to disabled it." Linux doesn't have a good infrastructure to disable sound

Re: [PATCH] drm/amd/display: Add DC feature flag to disable audio

2021-01-27 Thread Christian König
Am 26.01.21 um 17:15 schrieb Harry Wentland: On 2021-01-26 9:51 a.m., Ernst Sjöstrand wrote: No problems with amdgpu, but when my headphone port is glitching I often end up with some HDMI audio output selected instead. Wouldn't this be better fixed in the audio management service, like

Re: [PATCH] drm/amd/display: Add DC feature flag to disable audio

2021-01-26 Thread Harry Wentland
On 2021-01-26 9:51 a.m., Ernst Sjöstrand wrote: No problems with amdgpu, but when my headphone port is glitching I often end up with some HDMI audio output selected instead. Wouldn't this be better fixed in the audio management service, like PulseAudio? It sounds like it's not remembering

Re: [PATCH] drm/amd/display: Add DC feature flag to disable audio

2021-01-26 Thread Ernst Sjöstrand
No problems with amdgpu, but when my headphone port is glitching I often end up with some HDMI audio output selected instead. It also cleans up the clutter in the audio selection list. //E Den tis 26 jan. 2021 kl 15:34 skrev Alex Deucher : > On Tue, Jan 26, 2021 at 9:32 AM Ernst Sjöstrand

Re: [PATCH] drm/amd/display: Add DC feature flag to disable audio

2021-01-26 Thread Alex Deucher
On Tue, Jan 26, 2021 at 9:32 AM Ernst Sjöstrand wrote: > > With the pre-DC path you could set audio=0 to disable audio. > This adds a similar feature for the DC path with > amdgpu.dcfeaturemask=0x10. > > Signed-off-by: Ernst Sjöstrand Is there a reason you want this? I.e., is audio causing

[PATCH] drm/amd/display: Add DC feature flag to disable audio

2021-01-26 Thread Ernst Sjöstrand
With the pre-DC path you could set audio=0 to disable audio. This adds a similar feature for the DC path with amdgpu.dcfeaturemask=0x10. Signed-off-by: Ernst Sjöstrand --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++ drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 7 ---