Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2)

2019-05-30 Thread Alex Deucher
On Thu, May 30, 2019 at 10:48 AM Samantha McVey wrote: > > Alex, > > > > Are any of these non-booting systems laptops? If all the laptops don't have > this issue, is there a way we can detect we are on mobile and load the DMCU? > Seeing as ABM and PSR are both practically only used on mobile,

Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2)

2019-05-30 Thread Samantha McVey
Alex, Are any of these non-booting systems laptops? If all the laptops don't have this issue, is there a way we can detect we are on mobile and load the DMCU? Seeing as ABM and PSR are both practically only used on mobile, maybe we can check for that. This way we only enable it on systems

Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2)

2019-05-24 Thread Alex Deucher
On Fri, May 24, 2019 at 12:32 PM Mike Lothian wrote: > > I realise you don't want to enable this as it's breaking some people's > systems, but could we add a new boot parameter to force it for working > systems? Or check against a black list maybe? We could probably add a whitelist. I'm not

Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2)

2019-05-24 Thread Mike Lothian
I realise you don't want to enable this as it's breaking some people's systems, but could we add a new boot parameter to force it for working systems? Or check against a black list maybe? On Fri, 24 May 2019 at 17:20, Alex Deucher wrote: > > On Fri, May 24, 2019 at 12:09 PM Mike Lothian wrote:

Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2)

2019-05-24 Thread Alex Deucher
On Fri, May 24, 2019 at 12:09 PM Mike Lothian wrote: > > Hi > > Curious to know what this means for folk that have newer Raven1 boards > that didn't have issues loading the firmware You won't get ABM I think. ABM is the automatic backlight management. Alex > > Cheers > > Mike > > On Fri, 24

Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2)

2019-05-24 Thread Mike Lothian
Hi Curious to know what this means for folk that have newer Raven1 boards that didn't have issues loading the firmware Cheers Mike On Fri, 24 May 2019 at 16:34, Alex Deucher wrote: > > From: Harry Wentland > > [WHY] > Some early Raven boards had a bad SBIOS that doesn't play nicely with >

[PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2)

2019-05-24 Thread Alex Deucher
From: Harry Wentland [WHY] Some early Raven boards had a bad SBIOS that doesn't play nicely with the DMCU FW. We thought the issues were fixed by ignoring errors on DMCU load but that doesn't seem to be the case. We've still seen reports of users unable to boot their systems at all. [HOW]