Re: [PATCH] drm/amd/display: Fix cursor pos and hotspot calcs

2018-12-12 Thread Michel Dänzer
On 2018-12-12 3:58 p.m., Kazlauskas, Nicholas wrote: > On 12/12/18 9:40 AM, Michel Dänzer wrote: >> On 2018-12-12 3:17 p.m., Kazlauskas, Nicholas wrote: >>> On 12/12/18 9:10 AM, Michel Dänzer wrote: On 2018-12-12 3:04 p.m., Nicholas Kazlauskas wrote: > [Why] > The cursor calculations i

Re: [PATCH] drm/amd/display: Fix cursor pos and hotspot calcs

2018-12-12 Thread Kazlauskas, Nicholas
On 12/12/18 10:18 AM, Alex Deucher wrote: > On Wed, Dec 12, 2018 at 9:04 AM Nicholas Kazlauskas > wrote: >> >> [Why] >> The cursor calculations in amdgpu_dm incorrectly assume that the >> cursor hotspot is always (0, 0) and don't respect the hot_x and hot_y >> attributes that can be passed in via

Re: [PATCH] drm/amd/display: Fix cursor pos and hotspot calcs

2018-12-12 Thread Alex Deucher
On Wed, Dec 12, 2018 at 9:04 AM Nicholas Kazlauskas wrote: > > [Why] > The cursor calculations in amdgpu_dm incorrectly assume that the > cursor hotspot is always (0, 0) and don't respect the hot_x and hot_y > attributes that can be passed in via the drm_mode_cursor2_ioctl. > > The DC hotspot para

Re: [PATCH] drm/amd/display: Fix cursor pos and hotspot calcs

2018-12-12 Thread Kazlauskas, Nicholas
On 12/12/18 9:40 AM, Michel Dänzer wrote: > On 2018-12-12 3:17 p.m., Kazlauskas, Nicholas wrote: >> On 12/12/18 9:10 AM, Michel Dänzer wrote: >>> On 2018-12-12 3:04 p.m., Nicholas Kazlauskas wrote: [Why] The cursor calculations in amdgpu_dm incorrectly assume that the cursor hotspot

Re: [PATCH] drm/amd/display: Fix cursor pos and hotspot calcs

2018-12-12 Thread Michel Dänzer
On 2018-12-12 3:17 p.m., Kazlauskas, Nicholas wrote: > On 12/12/18 9:10 AM, Michel Dänzer wrote: >> On 2018-12-12 3:04 p.m., Nicholas Kazlauskas wrote: >>> [Why] >>> The cursor calculations in amdgpu_dm incorrectly assume that the >>> cursor hotspot is always (0, 0) and don't respect the hot_x and

Re: [PATCH] drm/amd/display: Fix cursor pos and hotspot calcs

2018-12-12 Thread Kazlauskas, Nicholas
On 12/12/18 9:10 AM, Michel Dänzer wrote: > On 2018-12-12 3:04 p.m., Nicholas Kazlauskas wrote: >> [Why] >> The cursor calculations in amdgpu_dm incorrectly assume that the >> cursor hotspot is always (0, 0) and don't respect the hot_x and hot_y >> attributes that can be passed in via the drm_mode_

Re: [PATCH] drm/amd/display: Fix cursor pos and hotspot calcs

2018-12-12 Thread Michel Dänzer
On 2018-12-12 3:04 p.m., Nicholas Kazlauskas wrote: > [Why] > The cursor calculations in amdgpu_dm incorrectly assume that the > cursor hotspot is always (0, 0) and don't respect the hot_x and hot_y > attributes that can be passed in via the drm_mode_cursor2_ioctl. > > The DC hotspot parameters ar

[PATCH] drm/amd/display: Fix cursor pos and hotspot calcs

2018-12-12 Thread Nicholas Kazlauskas
[Why] The cursor calculations in amdgpu_dm incorrectly assume that the cursor hotspot is always (0, 0) and don't respect the hot_x and hot_y attributes that can be passed in via the drm_mode_cursor2_ioctl. The DC hotspot parameters are also incorrectly used to offset the cursor when it goes beyond