Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Christian König via amd-gfx
Am 14.02.19 um 20:03 schrieb Grodzovsky, Andrey: On 2/14/19 12:54 PM, Kazlauskas, Nicholas wrote: On 2/14/19 12:47 PM, Grodzovsky, Andrey wrote: On 2/14/19 11:57 AM, Kazlauskas, Nicholas wrote: On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: On 2/14/19 11:07 AM, Michel Dänzer wrote: On

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Grodzovsky, Andrey
On 2/14/19 12:54 PM, Kazlauskas, Nicholas wrote: > On 2/14/19 12:47 PM, Grodzovsky, Andrey wrote: >> On 2/14/19 11:57 AM, Kazlauskas, Nicholas wrote: >>> On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: On 2/14/19 11:07 AM, Michel Dänzer wrote: > On 2019-02-14 4:54 p.m., Kazlauskas,

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Kazlauskas, Nicholas
On 2/14/19 12:47 PM, Grodzovsky, Andrey wrote: > > On 2/14/19 11:57 AM, Kazlauskas, Nicholas wrote: >> On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: >>> On 2/14/19 11:07 AM, Michel Dänzer wrote: On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: > On 2/14/19 10:42 AM, Grodzovsky,

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Grodzovsky, Andrey
On 2/14/19 11:57 AM, Kazlauskas, Nicholas wrote: > On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: >> On 2/14/19 11:07 AM, Michel Dänzer wrote: >>> On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: > On 2/14/19 4:05 AM, Christian König

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Michel Dänzer
On 2019-02-14 5:57 p.m., Kazlauskas, Nicholas wrote: > On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: >> >> On 2/14/19 11:07 AM, Michel Dänzer wrote: >>> On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: > On 2/14/19 4:05 AM, Christian

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Kazlauskas, Nicholas
On 2/14/19 11:47 AM, Grodzovsky, Andrey wrote: > > On 2/14/19 11:07 AM, Michel Dänzer wrote: >> On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: >>> On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: On 2/14/19 4:05 AM, Christian König wrote: > Am 13.02.19 um 19:58 schrieb Andrey

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Grodzovsky, Andrey
On 2/14/19 11:07 AM, Michel Dänzer wrote: > On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: >> On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: >>> On 2/14/19 4:05 AM, Christian König wrote: Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: > When ring hang happens

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Michel Dänzer
On 2019-02-14 4:54 p.m., Kazlauskas, Nicholas wrote: > On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: >> On 2/14/19 4:05 AM, Christian König wrote: >>> Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: When ring hang happens amdgpu_dm_commit_planes during flip is holding the BO reserved

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Grodzovsky, Andrey
On 2/14/19 10:54 AM, Kazlauskas, Nicholas wrote: > On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: >> On 2/14/19 4:05 AM, Christian König wrote: >>> Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: When ring hang happens amdgpu_dm_commit_planes during flip is holding the BO reserved and

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Kazlauskas, Nicholas
On 2/14/19 10:42 AM, Grodzovsky, Andrey wrote: > > On 2/14/19 4:05 AM, Christian König wrote: >> Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: >>> When ring hang happens amdgpu_dm_commit_planes during flip is holding >>> the BO reserved and then stack waiting for fences to signal in >>>

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Grodzovsky, Andrey
On 2/14/19 4:05 AM, Christian König wrote: > Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: >> When ring hang happens amdgpu_dm_commit_planes during flip is holding >> the BO reserved and then stack waiting for fences to signal in >> reservation_object_wait_timeout_rcu (which won't signal

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-14 Thread Christian König via amd-gfx
Am 13.02.19 um 19:58 schrieb Andrey Grodzovsky: When ring hang happens amdgpu_dm_commit_planes during flip is holding the BO reserved and then stack waiting for fences to signal in reservation_object_wait_timeout_rcu (which won't signal because there was a hnag). Then when we try to shutdown

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-13 Thread Kazlauskas, Nicholas
On 2/13/19 2:21 PM, Grodzovsky, Andrey wrote: > > On 2/13/19 2:16 PM, Kazlauskas, Nicholas wrote: >> On 2/13/19 2:10 PM, Grodzovsky, Andrey wrote: >>> On 2/13/19 2:00 PM, Kazlauskas, Nicholas wrote: On 2/13/19 1:58 PM, Andrey Grodzovsky wrote: > When ring hang happens

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-13 Thread Grodzovsky, Andrey
On 2/13/19 2:16 PM, Kazlauskas, Nicholas wrote: > On 2/13/19 2:10 PM, Grodzovsky, Andrey wrote: >> On 2/13/19 2:00 PM, Kazlauskas, Nicholas wrote: >>> On 2/13/19 1:58 PM, Andrey Grodzovsky wrote: When ring hang happens amdgpu_dm_commit_planes during flip is holding the BO reserved and

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-13 Thread Kazlauskas, Nicholas
On 2/13/19 2:10 PM, Grodzovsky, Andrey wrote: > > On 2/13/19 2:00 PM, Kazlauskas, Nicholas wrote: >> On 2/13/19 1:58 PM, Andrey Grodzovsky wrote: >>> When ring hang happens amdgpu_dm_commit_planes during flip is holding >>> the BO reserved and then stack waiting for fences to signal in >>>

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-13 Thread Grodzovsky, Andrey
On 2/13/19 2:00 PM, Kazlauskas, Nicholas wrote: > On 2/13/19 1:58 PM, Andrey Grodzovsky wrote: >> When ring hang happens amdgpu_dm_commit_planes during flip is holding >> the BO reserved and then stack waiting for fences to signal in >> reservation_object_wait_timeout_rcu (which won't signal

Re: [PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-13 Thread Kazlauskas, Nicholas
On 2/13/19 1:58 PM, Andrey Grodzovsky wrote: > When ring hang happens amdgpu_dm_commit_planes during flip is holding > the BO reserved and then stack waiting for fences to signal in > reservation_object_wait_timeout_rcu (which won't signal because there > was a hnag). Then when we try to shutdown

[PATCH] drm/amd/display: Fix deadlock with display during hanged ring recovery.

2019-02-13 Thread Andrey Grodzovsky
When ring hang happens amdgpu_dm_commit_planes during flip is holding the BO reserved and then stack waiting for fences to signal in reservation_object_wait_timeout_rcu (which won't signal because there was a hnag). Then when we try to shutdown display block during reset recovery from