Re: [PATCH] drm/amd/display: Use int for signed error code checks in commit planes

On 5/2/19 9:09 AM, Christian König wrote: > > Am 02.05.19 um 15:08 schrieb Christian König: >> Am 02.05.19 um 15:03 schrieb Nicholas Kazlauskas: >>> [Why] >>> >>> The type of 'r' is uint32_t and the return codes for both: >>> >>> - reservation_object_wait_timeout_rcu >>> - amdgpu_bo_reserve >>>

Re: [PATCH] drm/amd/display: Use int for signed error code checks in commit planes

Am 02.05.19 um 15:08 schrieb Christian König: Am 02.05.19 um 15:03 schrieb Nicholas Kazlauskas: [Why] The type of 'r' is uint32_t and the return codes for both: - reservation_object_wait_timeout_rcu - amdgpu_bo_reserve ...are signed. While it works for the latter since the check is done on

Re: [PATCH] drm/amd/display: Use int for signed error code checks in commit planes

Am 02.05.19 um 15:03 schrieb Nicholas Kazlauskas: [Why] The type of 'r' is uint32_t and the return codes for both: - reservation_object_wait_timeout_rcu - amdgpu_bo_reserve ...are signed. While it works for the latter since the check is done on != 0 it doesn't work for the former since we

[PATCH] drm/amd/display: Use int for signed error code checks in commit planes

[Why] The type of 'r' is uint32_t and the return codes for both: - reservation_object_wait_timeout_rcu - amdgpu_bo_reserve ...are signed. While it works for the latter since the check is done on != 0 it doesn't work for the former since we check <= 0. [How] Make 'r' an int in commit planes so