Re: [PATCH] drm/amd/display: Fix unused variable warning

2022-01-26 Thread Huang Rui
On Thu, Jan 27, 2022 at 11:33:50AM +0800, Huang, Tim wrote: > [Why] > It will build failed with unused variable 'dc' with > '-Werror=unused-variable'enabled when CONFIG_DRM_AMD_DC_DCN > is not defined. > > Signed-off-by: Tim Huang Reviewed-by: Huang Rui > --- >

RE: [PATCH] drm/amd/display: Fix unused variable warning

2022-01-26 Thread Liu, Aaron
gt; Subject: [PATCH] drm/amd/display: Fix unused variable warning > > [Why] > It will build failed with unused variable 'dc' with '-Werror=unused- > variable'enabled when CONFIG_DRM_AMD_DC_DCN is not defined. > > Signed-off-by: Tim Huang > --- > drivers/gpu/drm/amd/display

Re: [PATCH] drm/amd/display: Fix unused variable warning

2022-01-26 Thread Alex Deucher
Reviewed-by: Alex Deucher On Wed, Jan 26, 2022 at 10:34 PM Tim Huang wrote: > > [Why] > It will build failed with unused variable 'dc' with > '-Werror=unused-variable'enabled when CONFIG_DRM_AMD_DC_DCN > is not defined. > > Signed-off-by: Tim Huang > --- >

[PATCH] drm/amd/display: Fix unused variable warning

2022-01-26 Thread Tim Huang
[Why] It will build failed with unused variable 'dc' with '-Werror=unused-variable'enabled when CONFIG_DRM_AMD_DC_DCN is not defined. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH] drm/amd/display: fix unused variable warning

2021-01-25 Thread Harry Wentland
On 2021-01-25 7:48 a.m., Arnd Bergmann wrote: From: Arnd Bergmann After all users of the 'dm' warnings got hidden in an #ifdef, the compiler started warning about it being unused: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: error: unused variable 'dm'

[PATCH] drm/amd/display: fix unused variable warning

2021-01-25 Thread Arnd Bergmann
From: Arnd Bergmann After all users of the 'dm' warnings got hidden in an #ifdef, the compiler started warning about it being unused: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: error: unused variable 'dm' [-Werror,-Wunused-variable] Add another such #ifdef. Fixes:

Re: [PATCH] drm/amd/display: Fix unused variable warning

2021-01-20 Thread Harry Wentland
On 2021-01-20 12:23 p.m., Bhawanpreet Lakha wrote: [Why] The dm struct is only being used if DCN config is defined and this causes a unused variable warning if DCN option is not set. [How] Remove the compile flag so the variable is used (there also seems to be a duplicate guard due to a bad

Re: [PATCH] drm/amd/display: Fix unused variable warning

2021-01-20 Thread Alex Deucher
On Wed, Jan 20, 2021 at 12:23 PM Bhawanpreet Lakha wrote: > > [Why] > The dm struct is only being used if DCN config is defined and this > causes a unused variable warning if DCN option is not set. > > [How] > Remove the compile flag so the variable is used (there also seems to be > a duplicate

[PATCH] drm/amd/display: Fix unused variable warning

2021-01-20 Thread Bhawanpreet Lakha
[Why] The dm struct is only being used if DCN config is defined and this causes a unused variable warning if DCN option is not set. [How] Remove the compile flag so the variable is used (there also seems to be a duplicate guard due to a bad rebase) so remove the outer guard to fix the warning.