Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-21 Thread Lazar, Lijo
On 11/21/2024 7:58 PM, Alex Deucher wrote: > On Wed, Nov 20, 2024 at 11:57 PM Lazar, Lijo wrote: >> >> >> >> On 11/20/2024 11:58 PM, Alex Deucher wrote: >>> smu->workload_mask is IP specific and should not be messed with in >>> the common code. The mask bits vary across SMU versions. >>> >>> Mo

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-21 Thread Alex Deucher
On Wed, Nov 20, 2024 at 11:57 PM Lazar, Lijo wrote: > > > > On 11/20/2024 11:58 PM, Alex Deucher wrote: > > smu->workload_mask is IP specific and should not be messed with in > > the common code. The mask bits vary across SMU versions. > > > > Move all handling of smu->workload_mask in to the back

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-20 Thread Lazar, Lijo
On 11/20/2024 11:58 PM, Alex Deucher wrote: > smu->workload_mask is IP specific and should not be messed with in > the common code. The mask bits vary across SMU versions. > > Move all handling of smu->workload_mask in to the backends and > simplify the code. Store the user's preference in smu

[PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-20 Thread Alex Deucher
smu->workload_mask is IP specific and should not be messed with in the common code. The mask bits vary across SMU versions. Move all handling of smu->workload_mask in to the backends and simplify the code. Store the user's preference in smu->power_profile_mode which will be reflected in sysfs. F

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-20 Thread Alex Deucher
On Wed, Nov 20, 2024 at 9:10 AM Alex Deucher wrote: > > On Wed, Nov 20, 2024 at 4:32 AM Lazar, Lijo wrote: > > > > > > > > On 11/19/2024 11:16 PM, Alex Deucher wrote: > > > smu->workload_mask is IP specific and should not be messed with in > > > the common code. The mask bits vary across SMU vers

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-20 Thread Lazar, Lijo
On 11/20/2024 7:40 PM, Alex Deucher wrote: > On Wed, Nov 20, 2024 at 4:32 AM Lazar, Lijo wrote: >> >> >> >> On 11/19/2024 11:16 PM, Alex Deucher wrote: >>> smu->workload_mask is IP specific and should not be messed with in >>> the common code. The mask bits vary across SMU versions. >>> >>> Mov

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-20 Thread Alex Deucher
On Wed, Nov 20, 2024 at 4:32 AM Lazar, Lijo wrote: > > > > On 11/19/2024 11:16 PM, Alex Deucher wrote: > > smu->workload_mask is IP specific and should not be messed with in > > the common code. The mask bits vary across SMU versions. > > > > Move all handling of smu->workload_mask in to the backe

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-20 Thread Lazar, Lijo
On 11/19/2024 11:16 PM, Alex Deucher wrote: > smu->workload_mask is IP specific and should not be messed with in > the common code. The mask bits vary across SMU versions. > > Move all handling of smu->workload_mask in to the backends and > simplify the code. Store the user's preference in smu

[PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-19 Thread Alex Deucher
smu->workload_mask is IP specific and should not be messed with in the common code. The mask bits vary across SMU versions. Move all handling of smu->workload_mask in to the backends and simplify the code. Store the user's preference in smu->power_profile_mode which will be reflected in sysfs. F

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-15 Thread Alex Deucher
On Fri, Nov 15, 2024 at 7:14 AM Lazar, Lijo wrote: > > > > On 11/15/2024 2:36 AM, Alex Deucher wrote: > > smu->workload_mask is IP specific and should not be messed with in > > the common code. The mask bits vary across SMU versions. > > > > Move all handling of smu->workload_mask in to the backen

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-15 Thread Lazar, Lijo
On 11/15/2024 2:36 AM, Alex Deucher wrote: > smu->workload_mask is IP specific and should not be messed with in > the common code. The mask bits vary across SMU versions. > > Move all handling of smu->workload_mask in to the backends and > simplify the code. Store the user's preference in smu-

RE: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-15 Thread Feng, Kenneth
: [PATCH] drm/amd/pm: fix and simplify workload handling smu->workload_mask is IP specific and should not be messed with in the common code. The mask bits vary across SMU versions. Move all handling of smu->workload_mask in to the backends and simplify the code. Store the user's prefer

[PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-14 Thread Alex Deucher
smu->workload_mask is IP specific and should not be messed with in the common code. The mask bits vary across SMU versions. Move all handling of smu->workload_mask in to the backends and simplify the code. Store the user's preference in smu->power_profile_mode which will be reflected in sysfs. F

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-12 Thread Alex Deucher
enneth > Cc: Deucher, Alexander ; > amd-gfx@lists.freedesktop.org; Lazar, Lijo > Subject: Re: [PATCH] drm/amd/pm: fix and simplify workload handling > > > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links,

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-12 Thread Lazar, Lijo
On 11/12/2024 7:55 PM, Alex Deucher wrote: > On Tue, Nov 12, 2024 at 1:18 AM Lazar, Lijo > wrote: > > > > On 11/9/2024 11:01 AM, Alex Deucher wrote: > > smu->workload_mask is IP specific and should not be messed with in > > the common code. The mask bit

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-12 Thread Alex Deucher
On Tue, Nov 12, 2024 at 1:18 AM Lazar, Lijo wrote: > > > On 11/9/2024 11:01 AM, Alex Deucher wrote: > > smu->workload_mask is IP specific and should not be messed with in > > the common code. The mask bits vary across SMU versions. > > > > Move all handling of smu->workload_mask in to the backend

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-12 Thread Alex Deucher
y, November 9, 2024 1:32 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Feng, Kenneth < > kenneth.f...@amd.com>; Lazar, Lijo > Subject: [PATCH] drm/amd/pm: fix and simplify workload handling > > smu->workload_mask is IP specific and should not be messed with i

Re: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-11 Thread Lazar, Lijo
On 11/9/2024 11:01 AM, Alex Deucher wrote: > smu->workload_mask is IP specific and should not be messed with in > the common code. The mask bits vary across SMU versions. > > Move all handling of smu->workload_mask in to the backends and > simplify the code. Store the user's preference in smu-

RE: [PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-11 Thread Feng, Kenneth
Alexander Sent: Saturday, November 9, 2024 1:32 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Feng, Kenneth ; Lazar, Lijo Subject: [PATCH] drm/amd/pm: fix and simplify workload handling smu->workload_mask is IP specific and should not be messed with in the common code. The mask

[PATCH] drm/amd/pm: fix and simplify workload handling

2024-11-08 Thread Alex Deucher
smu->workload_mask is IP specific and should not be messed with in the common code. The mask bits vary across SMU versions. Move all handling of smu->workload_mask in to the backends and simplify the code. Store the user's preference in smu->power_profile_mode which will be reflected in sysfs. F