Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-07-05 Thread Alex Deucher
On Thu, Jul 4, 2019 at 4:15 PM Yrjan Skrimstad wrote: > > On Sun, Jun 16, 2019 at 04:43:10PM +0200, Yrjan Skrimstad wrote: > > That is an interesting observation to me. I am actually running > > lm-sensors, although only every 15 seconds. I suppose that this might > > be the reason this happens

Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-07-04 Thread Yrjan Skrimstad
On Sun, Jun 16, 2019 at 04:43:10PM +0200, Yrjan Skrimstad wrote: > That is an interesting observation to me. I am actually running > lm-sensors, although only every 15 seconds. I suppose that this might > be the reason this happens to me. Though I don't think this should reasonably cause problems

Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-06-16 Thread Yrjan Skrimstad
On Thu, Jun 13, 2019 at 09:57:24AM -0400, Alex Deucher wrote: > The patch is fine and I can apply it (I don't think there are any > restrictions on sleeping in sysfs), but this code only gets executed > when you actually read the power status from the card (e.g., via sysfs > or debugfs).

Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-06-13 Thread Alex Deucher
On Tue, Jun 4, 2019 at 4:22 PM Yrjan Skrimstad wrote: > > On Thu, May 30, 2019 at 02:08:21AM +0200, Yrjan Skrimstad wrote: > > This driver currently contains a repeated 500ms blocking delay call > > which causes frequent major buffer underruns in PulseAudio. This patch > > fixes this issue by

Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-06-12 Thread Dieter Nützel
CC trimmed Hello Alex and Harry, any comments on this? I'm running my Xeon X3470 (4c/8t) with this under amd-staging-drm-next (as always ;-) ) and see no issues so far. Thanks! Dieter Am 04.06.2019 22:21, schrieb Yrjan Skrimstad: On Thu, May 30, 2019 at 02:08:21AM +0200, Yrjan Skrimstad

Re: [PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-06-04 Thread Yrjan Skrimstad
On Thu, May 30, 2019 at 02:08:21AM +0200, Yrjan Skrimstad wrote: > This driver currently contains a repeated 500ms blocking delay call > which causes frequent major buffer underruns in PulseAudio. This patch > fixes this issue by replacing the blocking delay with a non-blocking > sleep call. I

[PATCH] drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

2019-05-29 Thread Yrjan Skrimstad
This driver currently contains a repeated 500ms blocking delay call which causes frequent major buffer underruns in PulseAudio. This patch fixes this issue by replacing the blocking delay with a non-blocking sleep call. Signed-off-by: Yrjan Skrimstad ---