Re: [PATCH] drm/amdgpu/powerplay: fix sysfs_emit/sysfs_emit_at handling

2021-11-04 Thread Christian König
As discussed previous I don't think this is the right approach. The distinction between sysfs_emit() and sysfs_emit_at() is exactly to avoid that kind of stuff. Instead we should probably add the size parameter to the functions in question and so fix the calling convention. Or even better

RE: [PATCH] drm/amdgpu/powerplay: fix sysfs_emit/sysfs_emit_at handling

2021-11-03 Thread Yu, Lang
, Darren >Subject: [PATCH] drm/amdgpu/powerplay: fix sysfs_emit/sysfs_emit_at handling > >sysfs_emit and sysfs_emit_at requrie a page boundary aligned buf address. Make >them happy! > >v2: fix sysfs_emit -> sysfs_emit_at missed conversions > >Cc: Lang Yu >Cc: Darren P

[PATCH] drm/amdgpu/powerplay: fix sysfs_emit/sysfs_emit_at handling

2021-11-03 Thread Alex Deucher
sysfs_emit and sysfs_emit_at requrie a page boundary aligned buf address. Make them happy! v2: fix sysfs_emit -> sysfs_emit_at missed conversions Cc: Lang Yu Cc: Darren Powell Fixes: 6db0c87a0a8e ("amdgpu/pm: Replace hwmgr smu usage of sprintf with sysfs_emit") Bug: