; amd-gfx list
Subject: RE: [PATCH] drm/amdgpu/sriov/vcn: skip ip revision check case to ip
init for SIENNA_CICHLID
[Public]
It's better to move 'case IP_VERSION(3, 0, 192)' after IP_VERSION(3, 0, 192)?
case IP_VERSION(3, 1, 1):
case IP_VERSION(3, 0, 2):
+ case IP_VERSION(3, 0, 192
; Chen, JingWen
Cc: amd-gfx@lists.freedesktop.org; Jian, Jane
Subject: [PATCH] drm/amdgpu/sriov/vcn: skip ip revision check case to ip init
for SIENNA_CICHLID
[WHY]
for sriov odd# vf will modify vcn0 engine ip revision(due to multimedia
bandwidth feature), which will be mismatched
[WHY]
for sriov odd# vf will modify vcn0 engine ip revision(due to multimedia
bandwidth feature),
which will be mismatched with original vcn0 revision
[HOW]
add new version check for vcn0 disabled revision(3, 0, 192), typically modified
under
sriov mode
Signed-off-by: Jane Jian
Change-Id:
; amd-gfx list
Subject: Re: [PATCH] drm/amdgpu/sriov/vcn: skip ip revision check case to ip
init for SIENNA_CICHLID
On Wed, Nov 24, 2021 at 9:20 AM Jane Jian wrote:
>
> [WHY]
> for sriov odd# vf will modify vcn0 engine ip revision(due to
> multimedia bandwidth fea
))
amdgpu_device_ip_block_add(adev, _v3_0_ip_block);
break;
Regards,
Guchun
-Original Message-
From: Alex Deucher
Sent: Wednesday, November 24, 2021 10:23 PM
To: Jian, Jane
Cc: Deucher, Alexander ; Chen, Guchun
; Chen, JingWen ; amd-gfx list
Subject: Re: [PATCH] drm/amdgpu/sriov/vcn: skip ip
On Wed, Nov 24, 2021 at 9:20 AM Jane Jian wrote:
>
> [WHY]
> for sriov odd# vf will modify vcn0 engine ip revision(due to multimedia
> bandwidth feature),
> which will be mismatched with original vcn0 revision
>
> [HOW]
> add new version check for vcn0 disabled revision(3, 0, 192), typically
>
[WHY]
for sriov odd# vf will modify vcn0 engine ip revision(due to multimedia
bandwidth feature),
which will be mismatched with original vcn0 revision
[HOW]
add new version check for vcn0 disabled revision(3, 0, 192), typically modified
under
sriov mode
Signed-off-by: Jane Jian
Change-Id:
On Wed, Nov 24, 2021 at 4:54 AM Jane Jian wrote:
>
> [WHY]
> for sriov odd# vf will modify vcn0 engine ip revision(due to multimedia
> bandwidth feature),
> which will be mismatched with original vcn0 revision
>
> [HOW]
> add new version check for vcn0 disabled revision
>
> Signed-off-by: Jane
[WHY]
for sriov odd# vf will modify vcn0 engine ip revision(due to multimedia
bandwidth feature),
which will be mismatched with original vcn0 revision
[HOW]
add new version check for vcn0 disabled revision
Signed-off-by: Jane Jian
Change-Id: I1ace32acbf3a13c0baac958508da1324ec387a58
---
gwen.ch...@amd.com>>
Cc: Jian, Jane mailto:jane.j...@amd.com>>
Subject: [PATCH] drm/amdgpu/sriov/vcn: skip ip revision check case to ip init
for SIENNA_CICHLID
[WHY]
for sriov odd# vf will modify vcn0 engine ip revision(due to multimedia
bandwidth feature),
which will be mismatched with or
@lists.freedesktop.org; Chen, Guchun
; Chen, JingWen
Subject: Re: [PATCH] drm/amdgpu/sriov/vcn: skip ip revision check case to ip
init for SIENNA_CICHLID
[Public]
Can we just add a check for the new IP version in that case? This looks really
hacky.
Alex
From
, Jane
Subject: [PATCH] drm/amdgpu/sriov/vcn: skip ip revision check case to ip init
for SIENNA_CICHLID
[WHY]
for sriov odd# vf will modify vcn0 engine ip revision(due to multimedia
bandwidth feature),
which will be mismatched with original vcn0 revision
[HOW]
skip ip revision match case
[WHY]
for sriov odd# vf will modify vcn0 engine ip revision(due to multimedia
bandwidth feature),
which will be mismatched with original vcn0 revision
[HOW]
skip ip revision match case and continue use asic type to check
Signed-off-by: Jane Jian
Change-Id:
[WHY]
for sriov odd# vf will modify vcn0 engine ip revision(due to multimedia
bandwidth feature),
which will be mismatched with original vcn0 revision
[HOW]
skip ip revision match case and continue use asic type to check
Signed-off-by: Jane Jian
Change-Id:
14 matches
Mail list logo
