Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-24 Thread Felix Kuehling
On 2018-08-24 03:09 PM, Christian König wrote: > Am 24.08.2018 um 20:59 schrieb Felix Kuehling: >> On 2018-08-24 03:32 AM, Christian König wrote: >>> The roundup to a power of two here is not 100% correct, but I don't >>> think it will hurt us much. >>> >>> For now the patch is Reviewed-by: Christi

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-24 Thread Christian König
Am 24.08.2018 um 20:59 schrieb Felix Kuehling: On 2018-08-24 03:32 AM, Christian König wrote: The roundup to a power of two here is not 100% correct, but I don't think it will hurt us much. For now the patch is Reviewed-by: Christian König . Thanks. Do you mind elaborating on what's not 100% c

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-24 Thread Felix Kuehling
On 2018-08-24 03:32 AM, Christian König wrote: > The roundup to a power of two here is not 100% correct, but I don't > think it will hurt us much. > > For now the patch is Reviewed-by: Christian König > . Thanks. Do you mind elaborating on what's not 100% correct here? Maybe do the min(..., max_s

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-24 Thread Christian König
Am 24.08.2018 um 00:37 schrieb Felix Kuehling: Set the VM size based on system memory size between the ASIC-specific limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their default VM size of 256TB (48 bit). Only older GPUs will adjust VM size depending on system memory size. This m

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-23 Thread Huang Rui
On Thu, Aug 23, 2018 at 06:37:10PM -0400, Felix Kuehling wrote: > Set the VM size based on system memory size between the ASIC-specific > limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their > default VM size of 256TB (48 bit). Only older GPUs will adjust VM size > depending on syst

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-23 Thread Zhang, Jerry (Junwei)
On 08/24/2018 06:37 AM, Felix Kuehling wrote: Set the VM size based on system memory size between the ASIC-specific limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their default VM size of 256TB (48 bit). Only older GPUs will adjust VM size depending on system memory size. This ma

[PATCH] drm/amdgpu: Adjust the VM size based on system memory size v2

2018-08-23 Thread Felix Kuehling
Set the VM size based on system memory size between the ASIC-specific limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their default VM size of 256TB (48 bit). Only older GPUs will adjust VM size depending on system memory size. This makes more VM space available for ROCm application

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size

2018-08-22 Thread Christian König
Am 22.08.2018 um 19:40 schrieb Felix Kuehling: On 2018-08-22 02:55 AM, Christian König wrote: Am 21.08.2018 um 23:45 schrieb Felix Kuehling: [snip] +    } else { +    struct sysinfo si; +    unsigned int phys_ram_gb; + +    /* Optimal VM size depends on the amount of physical +   

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size

2018-08-22 Thread Felix Kuehling
On 2018-08-22 02:55 AM, Christian König wrote: > Am 21.08.2018 um 23:45 schrieb Felix Kuehling: [snip] >> +    } else { >>> +    struct sysinfo si; >>> +    unsigned int phys_ram_gb; >>> + >>> +    /* Optimal VM size depends on the amount of physical >>> + * RAM available. Under

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size

2018-08-21 Thread Christian König
Am 21.08.2018 um 23:45 schrieb Felix Kuehling: This patch is meant for amd-staging-drm-next. It's part of my effort to reduce differences between kfd-staging and upstream and eventually replace all our memory manager hacks with upstream solutions. This commit should only affect GFXv8 and older.

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size

2018-08-21 Thread Zhang, Jerry (Junwei)
On 08/22/2018 05:25 AM, Felix Kuehling wrote: Set the VM size based on system memory size between the ASIC-specific limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their default VM size of 256TB (48 bit). Only older GPUs will adjust VM size depending on system memory size. This ma

Re: [PATCH] drm/amdgpu: Adjust the VM size based on system memory size

2018-08-21 Thread Felix Kuehling
This patch is meant for amd-staging-drm-next. It's part of my effort to reduce differences between kfd-staging and upstream and eventually replace all our memory manager hacks with upstream solutions. This commit should only affect GFXv8 and older. It should not have any negative impact, except bi

[PATCH] drm/amdgpu: Adjust the VM size based on system memory size

2018-08-21 Thread Felix Kuehling
Set the VM size based on system memory size between the ASIC-specific limits given by min_vm_size and max_bits. GFXv9 GPUs will keep their default VM size of 256TB (48 bit). Only older GPUs will adjust VM size depending on system memory size. This makes more VM space available for ROCm application