t;; Deng, Emily
mailto:emily.d...@amd.com>>; Alex Deucher
mailto:alexdeuc...@gmail.com>>; Nieto,
David M mailto:david.ni...@amd.com>>
*Subject:* Re: [PATCH] drm/amdgpu: Align serial size in
drm_amdgpu_info_vbios
Yeah, but umr is making strong use of sys
l) <
> jiawei...@amd.com>; amd-gfx list ; Deng,
> Emily ; Alex Deucher ; Nieto,
> David M
> *Subject:* Re: [PATCH] drm/amdgpu: Align serial size in
> drm_amdgpu_info_vbios
>
> Yeah, but umr is making strong use of sysfs as well.
>
> The only justification of this int
-gfx list ; Deng, Emily ;
Alex Deucher ; Nieto, David M
Subject: Re: [PATCH] drm/amdgpu: Align serial size in drm_amdgpu_info_vbios
Yeah, but umr is making strong use of sysfs as well.
The only justification of this interface would be if we want to use it in Mesa.
And I agree with Marek
Cook ; Gu, JiaWei (Will)
; amd-gfx list ;
Deng, Emily ; Alex Deucher
; Nieto, David M
*Subject:* Re: [PATCH] drm/amdgpu: Align serial size in
drm_amdgpu_info_vbios
Mesa doesn't use sysfs.
Note that this is a uapi, meaning that once it's in the kernel, it
can't be changed like that.
What's
list ; Deng, Emily ;
Alex Deucher ; Nieto, David M
Subject: Re: [PATCH] drm/amdgpu: Align serial size in drm_amdgpu_info_vbios
Mesa doesn't use sysfs.
Note that this is a uapi, meaning that once it's in the kernel, it can't be
changed like that.
What's the use case for this new interface? Isn't
mation it needs. It makes little sense from a
> programming perspective to add an incomplete interface in my opinion
>
>
> ------------------
>
> *From:* Gu, JiaWei (Will)
> *Sent:* Monday, May 10, 2021 12:13:07 AM
> *To:* Nieto, David M
> *Cc:* Alex Deucher
quot;Gu, JiaWei (Will)"
*Cc: *Alex Deucher , "Deng, Emily"
, Kees Cook , amd-gfx list
*Subject: *Re: [PATCH] drm/amdgpu: Align serial size in
drm_amdgpu_info_vbios
Well we could add both as sysfs file(s).
Question here is rather what is the primary use case of this and if
the
10:52 AM
To: Gu, JiaWei (Will) ; Christian König
Cc: Alex Deucher ; Deng, Emily ;
Kees Cook ; amd-gfx list
Subject: Re: [PATCH] drm/amdgpu: Align serial size in drm_amdgpu_info_vbios
[AMD Official Use Only - Internal Distribution Only]
I agree that the serial number should be on number form
From: Gu, JiaWei (Will)
Sent: Monday, May 10, 2021 7:23 PM
To: Nieto, David M ; Christian König
Cc: Alex Deucher ; Deng, Emily ;
Kees Cook ; amd-gfx list
Subject: RE: [PATCH] drm/amdgpu: Align serial size in drm_amdgpu_info_vbios
[AMD Official Use Only - Internal Distribution Only
Gu, JiaWei (Will)
Cc: Alex Deucher ; Deng, Emily ;
Kees Cook ; amd-gfx list
Subject: Re: [PATCH] drm/amdgpu: Align serial size in drm_amdgpu_info_vbios
One of the primary usecases is to add this information to the renderer string,
I am not sure if there are other cases of UMD drivers accessing
ok , amd-gfx list
Subject: Re: [PATCH] drm/amdgpu: Align serial size in drm_amdgpu_info_vbios
Well we could add both as sysfs file(s).
Question here is rather what is the primary use case of this and if the
application has the necessary access permissions to the sysfs files?
Regards,
Christian.
Am 1
, 2021 12:13:07 AM
*To:* Nieto, David M
*Cc:* Alex Deucher ; amd-gfx list
; Kees Cook ;
Deng, Emily
*Subject:* RE: [PATCH] drm/amdgpu: Align serial size in
drm_amdgpu_info_vbios
[AMD Official Use Only - Internal Distribution Only]
Hi David,
What I meant is to ONLY delete the serial[16] from
, 2021 12:13:07 AM
To: Nieto, David M
Cc: Alex Deucher ; amd-gfx list
; Kees Cook ; Deng, Emily
Subject: RE: [PATCH] drm/amdgpu: Align serial size in drm_amdgpu_info_vbios
[AMD Official Use Only - Internal Distribution Only]
Hi David,
What I meant is to ONLY delete the serial[16] from
"%s\n", adev->serial);
}
Thanks,
Jiawei
-Original Message-
From: Nieto, David M
Sent: Monday, May 10, 2021 2:53 PM
To: Gu, JiaWei (Will)
Cc: Alex Deucher ; amd-gfx list
; Kees Cook ; Deng, Emily
Subject: Re: [PATCH] drm/amdgpu: Align serial size in drm_amdgpu_info_vbios
> From: Alex Deucher
> Sent: Sunday, May 9, 2021 11:59 PM
> To: Gu, JiaWei (Will)
> Cc: amd-gfx list ; Kees Cook
>
> Subject: Re: [PATCH] drm/amdgpu: Align serial size in drm_amdgpu_info_vbios
>
>> On Sat, May 8, 2021 at 2:48 AM Jiawei Gu wrote:
>>
>&
-Original Message-
From: Alex Deucher
Sent: Sunday, May 9, 2021 11:59 PM
To: Gu, JiaWei (Will)
Cc: amd-gfx list ; Kees Cook
Subject: Re: [PATCH] drm/amdgpu: Align serial size in drm_amdgpu_info_vbios
On Sat, May 8, 2021 at 2:48 AM Jiawei Gu wrote:
>
> 20 should be serial char si
On Sat, May 8, 2021 at 2:48 AM Jiawei Gu wrote:
>
> 20 should be serial char size now instead of 16.
>
> Signed-off-by: Jiawei Gu
Please make sure this keeps proper 64 bit alignment in the structure.
Alex
> ---
> include/uapi/drm/amdgpu_drm.h | 2 +-
> 1 file changed, 1 insertion(+), 1
20 should be serial char size now instead of 16.
Signed-off-by: Jiawei Gu
---
include/uapi/drm/amdgpu_drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
index 2b487a8d2727..1c20721f90da 100644
---
18 matches
Mail list logo
