Re: [PATCH] drm/amdgpu: Each PSP need to get latest topology info on XGMI configuration

2018-11-09 Thread Liu, Shaoyun
For now we depends on the  TA(firmware)  to decided whether the memory will be shared or not . They always been  set to enabled within same hive . Regards shaoyun.liu On 2018-11-09 12:53 p.m., Grodzovsky, Andrey wrote: > Reviewed-by: Andrey Grodzovsky > > Question - shouldn't we also set

Re: [PATCH] drm/amdgpu: Each PSP need to get latest topology info on XGMI configuration

2018-11-09 Thread Grodzovsky, Andrey
Reviewed-by: Andrey Grodzovsky Question - shouldn't we also set psp_xgmi_node_info.is_sharing_enabled to 1 to enable FB sharing ? Andrey On 11/08/2018 11:14 AM, Liu, Shaoyun wrote: > From: shaoyunl > > Driver need to call each psp instance to get topology info before set topology > >

Re: [PATCH] drm/amdgpu: Each PSP need to get latest topology info on XGMI configuration

2018-11-08 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking Sent from my iPhone > On Nov 9, 2018, at 00:17, Liu, Shaoyun wrote: > > From: shaoyunl > > Driver need to call each psp instance to get topology info before set topology > > Change-Id: I20d914a0c678686db3f1f99edf250f3656ec9fc1 > Signed-off-by:

[PATCH] drm/amdgpu: Each PSP need to get latest topology info on XGMI configuration

2018-11-08 Thread Liu, Shaoyun
From: shaoyunl Driver need to call each psp instance to get topology info before set topology Change-Id: I20d914a0c678686db3f1f99edf250f3656ec9fc1 Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-)